201963 2019-09-18 19:20:32 -0700 [LFC] Remove redundant Layout::Box::ElementTypes 2019-09-19 08:36:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1572193 0 zalan 2019-09-18 19:20:32 -0700 ssia 1572202 1 379096 zalan 2019-09-18 19:32:34 -0700 Created attachment 379096 Patch 1572365 2 379096 commit-queue 2019-09-19 08:35:36 -0700 Comment on attachment 379096 Patch Clearing flags on attachment: 379096 Committed r250091: <https://trac.webkit.org/changeset/250091> 1572366 3 commit-queue 2019-09-19 08:35:38 -0700 All reviewed patches have been landed. Closing bug. 1572367 4 webkit-bug-importer 2019-09-19 08:36:16 -0700 <rdar://problem/55520482> 379096 2019-09-18 19:32:34 -0700 2019-09-19 08:35:36 -0700 Patch bug-201963-20190918193229.patch text/plain 6938 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMwNjAyYmZlM2ViMWJi NDcwMWZkOTA2MjU3NjljNDI4ZTU2MDBkNy4uMWVlMWYyNjA5OTQ1MWRkYTY2NzBmMTlkZGNhZGY3 ODVlYzM0MTBiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA5LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gUmVtb3ZlIHJlZHVu ZGFudCBMYXlvdXQ6OkJveDo6RWxlbWVudFR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE5NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSB0eXBlcyBjYW4gYmUgc29sdmVkIHRocm91Z2gg UmVuZGVyU3R5bGUuCisKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCb3g6OmlzUGFkZGluZ0FwcGxpY2FibGUgY29u c3QpOgorICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpCb3g6OmlzVGFibGVIZWFkZXIgY29uc3QpOgorICAgICAgICAoV2Vi Q29yZTo6TGF5b3V0OjpCb3g6OmlzVGFibGVCb2R5IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6 OkxheW91dDo6Qm94Ojppc1RhYmxlRm9vdGVyIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6Qm94Ojppc1RhYmxlUm93IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 Qm94Ojppc1RhYmxlQ29sdW1uR3JvdXAgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 OjpCb3g6OmlzVGFibGVDb2x1bW4gY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpC b3g6OmlzVGFibGVDZWxsIGNvbnN0KToKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlv dXRUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRyZWVCdWlsZGVy OjpjcmVhdGVMYXlvdXRCb3gpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsYXlvdXRVc2luZ0Zvcm1hdHRpbmdDb250ZXh0KToK KwogMjAxOS0wOS0xOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtMRkNdIEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeS9NYXJnaW5Db2xsYXBzZS9RdWlyayBj bGFzc2VzIHNob3VsZCBub3QgbmVlZCB0byBhY2Nlc3Mgbm9uLWNvbnN0IERpc3BsYXk6OkJveApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAKaW5kZXgg N2ViYzRhYzNkNjUxMGRiMGFjYTM4YjQ0NjVkNDVjZjMyZDE4NDIzMy4uNGQyYmM5N2E0ODFjOTQz M2M0NWRhYjNmMjJiYzAzNzRkMTE5ZGY4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv bGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwCkBAIC0zNzMsMTMgKzM3MywxMiBAQCBib29sIEJveDo6 aXNQYWRkaW5nQXBwbGljYWJsZSgpIGNvbnN0CiAgICAgaWYgKGlzQW5vbnltb3VzKCkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKIAotICAgIGF1dG8gZWxlbWVudFR5cGUgPSBtX2VsZW1lbnRBdHRy aWJ1dGVzLnZhbHVlKCkuZWxlbWVudFR5cGU7Ci0gICAgcmV0dXJuIGVsZW1lbnRUeXBlICE9IEVs ZW1lbnRUeXBlOjpUYWJsZUhlYWRlckdyb3VwCi0gICAgICAgICYmIGVsZW1lbnRUeXBlICE9IEVs ZW1lbnRUeXBlOjpUYWJsZUJvZHlHcm91cAotICAgICAgICAmJiBlbGVtZW50VHlwZSAhPSBFbGVt ZW50VHlwZTo6VGFibGVGb290ZXJHcm91cAotICAgICAgICAmJiBlbGVtZW50VHlwZSAhPSBFbGVt ZW50VHlwZTo6VGFibGVSb3cKLSAgICAgICAgJiYgZWxlbWVudFR5cGUgIT0gRWxlbWVudFR5cGU6 OlRhYmxlQ29sdW1uR3JvdXAKLSAgICAgICAgJiYgZWxlbWVudFR5cGUgIT0gRWxlbWVudFR5cGU6 OlRhYmxlQ29sdW1uOworICAgIHJldHVybiAhaXNUYWJsZUhlYWRlcigpCisgICAgICAgICYmICFp c1RhYmxlQm9keSgpCisgICAgICAgICYmICFpc1RhYmxlRm9vdGVyKCkKKyAgICAgICAgJiYgIWlz VGFibGVSb3coKQorICAgICAgICAmJiAhaXNUYWJsZUNvbHVtbkdyb3VwKCkKKyAgICAgICAgJiYg IWlzVGFibGVDb2x1bW4oKTsKIH0KIAogdm9pZCBCb3g6OnNldFRleHRDb250ZW50KFN0cmluZyB0 ZXh0Q29udGVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVl L0xheW91dEJveC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94 LmgKaW5kZXggNTgwNTIyMTdlYWQzMjdkNjA0NGM0YTRhNDQ2NjY1NmE2Mjc3ZmZjZC4uNTM5YmNl NWQyNjY2M2EyNTE3NTA0ZDYyMTk0YTM1ODc1NTgyMTQxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmgKQEAgLTQ3LDEyICs0Nyw2IEBAIHB1YmxpYzoK ICAgICAgICAgQm9keSwKICAgICAgICAgVGFibGVXcmFwcGVyQm94LCAvLyBUaGUgdGFibGUgZ2Vu ZXJhdGVzIGEgcHJpbmNpcGFsIGJsb2NrIGNvbnRhaW5lciBib3ggY2FsbGVkIHRoZSB0YWJsZSB3 cmFwcGVyIGJveCB0aGF0IGNvbnRhaW5zIHRoZSB0YWJsZSBib3ggYW5kIGFueSBjYXB0aW9uIGJv eGVzLgogICAgICAgICBUYWJsZUJveCwgLy8gVGhlIHRhYmxlIGJveCBpcyBhIGJsb2NrLWxldmVs IGJveCB0aGF0IGNvbnRhaW5zIHRoZSB0YWJsZSdzIGludGVybmFsIHRhYmxlIGJveGVzLgotICAg ICAgICBUYWJsZUNvbHVtbiwKLSAgICAgICAgVGFibGVSb3csCi0gICAgICAgIFRhYmxlQ29sdW1u R3JvdXAsCi0gICAgICAgIFRhYmxlSGVhZGVyR3JvdXAsCi0gICAgICAgIFRhYmxlQm9keUdyb3Vw LAotICAgICAgICBUYWJsZUZvb3Rlckdyb3VwLAogICAgICAgICBJbWFnZSwKICAgICAgICAgSUZy YW1lLAogICAgICAgICBIYXJkTGluZUJyZWFrLApAQCAtMTE2LDExICsxMTAsMTMgQEAgcHVibGlj OgogICAgIGJvb2wgaXNUYWJsZVdyYXBwZXJCb3goKSBjb25zdCB7IHJldHVybiBtX2VsZW1lbnRB dHRyaWJ1dGVzICYmIG1fZWxlbWVudEF0dHJpYnV0ZXMudmFsdWUoKS5lbGVtZW50VHlwZSA9PSBF bGVtZW50VHlwZTo6VGFibGVXcmFwcGVyQm94OyB9CiAgICAgYm9vbCBpc1RhYmxlQm94KCkgY29u c3QgeyByZXR1cm4gbV9lbGVtZW50QXR0cmlidXRlcyAmJiBtX2VsZW1lbnRBdHRyaWJ1dGVzLnZh bHVlKCkuZWxlbWVudFR5cGUgPT0gRWxlbWVudFR5cGU6OlRhYmxlQm94OyB9CiAgICAgYm9vbCBp c1RhYmxlQ2FwdGlvbigpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCkuZGlzcGxheSgpID09IERpc3Bs YXlUeXBlOjpUYWJsZUNhcHRpb247IH0KLSAgICBib29sIGlzVGFibGVIZWFkZXIoKSBjb25zdCB7 IHJldHVybiBtX2VsZW1lbnRBdHRyaWJ1dGVzICYmIG1fZWxlbWVudEF0dHJpYnV0ZXMudmFsdWUo KS5lbGVtZW50VHlwZSA9PSBFbGVtZW50VHlwZTo6VGFibGVIZWFkZXJHcm91cDsgfQotICAgIGJv b2wgaXNUYWJsZUJvZHkoKSBjb25zdCB7IHJldHVybiBtX2VsZW1lbnRBdHRyaWJ1dGVzICYmIG1f ZWxlbWVudEF0dHJpYnV0ZXMudmFsdWUoKS5lbGVtZW50VHlwZSA9PSBFbGVtZW50VHlwZTo6VGFi bGVCb2R5R3JvdXA7IH0KLSAgICBib29sIGlzVGFibGVGb290ZXIoKSBjb25zdCB7IHJldHVybiBt X2VsZW1lbnRBdHRyaWJ1dGVzICYmIG1fZWxlbWVudEF0dHJpYnV0ZXMudmFsdWUoKS5lbGVtZW50 VHlwZSA9PSBFbGVtZW50VHlwZTo6VGFibGVGb290ZXJHcm91cDsgfQotICAgIGJvb2wgaXNUYWJs ZVJvdygpIGNvbnN0IHsgcmV0dXJuIG1fZWxlbWVudEF0dHJpYnV0ZXMgJiYgbV9lbGVtZW50QXR0 cmlidXRlcy52YWx1ZSgpLmVsZW1lbnRUeXBlID09IEVsZW1lbnRUeXBlOjpUYWJsZVJvdzsgfQot ICAgIGJvb2wgaXNUYWJsZUNlbGwoKSBjb25zdCB7IHJldHVybiBzdHlsZSgpLmRpc3BsYXkoKSA9 PSBEaXNwbGF5VHlwZTo6VGFibGVDZWxsOzsgfQorICAgIGJvb2wgaXNUYWJsZUhlYWRlcigpIGNv bnN0IHsgcmV0dXJuIHN0eWxlKCkuZGlzcGxheSgpID09IERpc3BsYXlUeXBlOjpUYWJsZUhlYWRl ckdyb3VwOyB9CisgICAgYm9vbCBpc1RhYmxlQm9keSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCku ZGlzcGxheSgpID09IERpc3BsYXlUeXBlOjpUYWJsZVJvd0dyb3VwOyB9CisgICAgYm9vbCBpc1Rh YmxlRm9vdGVyKCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5kaXNwbGF5KCkgPT0gRGlzcGxheVR5 cGU6OlRhYmxlRm9vdGVyR3JvdXA7IH0KKyAgICBib29sIGlzVGFibGVSb3coKSBjb25zdCB7IHJl dHVybiBzdHlsZSgpLmRpc3BsYXkoKSA9PSBEaXNwbGF5VHlwZTo6VGFibGVSb3c7IH0KKyAgICBi b29sIGlzVGFibGVDb2x1bW5Hcm91cCgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCkuZGlzcGxheSgp ID09IERpc3BsYXlUeXBlOjpUYWJsZUNvbHVtbkdyb3VwOyB9CisgICAgYm9vbCBpc1RhYmxlQ29s dW1uKCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5kaXNwbGF5KCkgPT0gRGlzcGxheVR5cGU6OlRh YmxlQ29sdW1uOyB9CisgICAgYm9vbCBpc1RhYmxlQ2VsbCgpIGNvbnN0IHsgcmV0dXJuIHN0eWxl KCkuZGlzcGxheSgpID09IERpc3BsYXlUeXBlOjpUYWJsZUNlbGw7IH0KICAgICBib29sIGlzUmVw bGFjZWQoKSBjb25zdCB7IHJldHVybiBpc0ltYWdlKCkgfHwgaXNJRnJhbWUoKTsgfQogICAgIGJv b2wgaXNJRnJhbWUoKSBjb25zdCB7IHJldHVybiBtX2VsZW1lbnRBdHRyaWJ1dGVzICYmIG1fZWxl bWVudEF0dHJpYnV0ZXMudmFsdWUoKS5lbGVtZW50VHlwZSA9PSBFbGVtZW50VHlwZTo6SUZyYW1l OyB9CiAgICAgYm9vbCBpc0ltYWdlKCkgY29uc3QgeyByZXR1cm4gbV9lbGVtZW50QXR0cmlidXRl cyAmJiBtX2VsZW1lbnRBdHRyaWJ1dGVzLnZhbHVlKCkuZWxlbWVudFR5cGUgPT0gRWxlbWVudFR5 cGU6OkltYWdlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJl ZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJl ZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKaW5kZXggNDA2ZThmYzgwNTQ0YmZhNjcyZjFiMTIzNzdk ODgxMDkyNDc0MmM4ZC4uZDNhMzliZWU4MjY5OWYyZjU1Yzk3YThhMDE1MDhmMThhZmFjOTA2MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1 aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRy ZWVCdWlsZGVyLmNwcApAQCAtMTAwLDE4ICsxMDAsNiBAQCBzdGQ6OnVuaXF1ZV9wdHI8Qm94PiBU cmVlQnVpbGRlcjo6Y3JlYXRlTGF5b3V0Qm94KGNvbnN0IFJlbmRlckVsZW1lbnQmIHBhcmVudFJl bgogICAgICAgICBpZiAoYXV0byogZWxlbWVudCA9IHJlbmRlcmVyLmVsZW1lbnQoKSkgewogICAg ICAgICAgICAgaWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpib2R5VGFnKSkKICAg ICAgICAgICAgICAgICByZXR1cm4gQm94OjpFbGVtZW50QXR0cmlidXRlcyB7IEJveDo6RWxlbWVu dFR5cGU6OkJvZHkgfTsKLSAgICAgICAgICAgIGlmIChlbGVtZW50LT5oYXNUYWdOYW1lKEhUTUxO YW1lczo6Y29sVGFnKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gQm94OjpFbGVtZW50QXR0cmli dXRlcyB7IEJveDo6RWxlbWVudFR5cGU6OlRhYmxlQ29sdW1uIH07Ci0gICAgICAgICAgICBpZiAo ZWxlbWVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnRyVGFnKSkKLSAgICAgICAgICAgICAgICBy ZXR1cm4gQm94OjpFbGVtZW50QXR0cmlidXRlcyB7IEJveDo6RWxlbWVudFR5cGU6OlRhYmxlUm93 IH07Ci0gICAgICAgICAgICBpZiAoZWxlbWVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OmNvbGdy b3VwVGFnKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gQm94OjpFbGVtZW50QXR0cmlidXRlcyB7 IEJveDo6RWxlbWVudFR5cGU6OlRhYmxlQ29sdW1uR3JvdXAgfTsKLSAgICAgICAgICAgIGlmIChl bGVtZW50LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6dGhlYWRUYWcpKQotICAgICAgICAgICAgICAg IHJldHVybiBCb3g6OkVsZW1lbnRBdHRyaWJ1dGVzIHsgQm94OjpFbGVtZW50VHlwZTo6VGFibGVI ZWFkZXJHcm91cCB9OwotICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5h bWVzOjp0Ym9keVRhZykpCi0gICAgICAgICAgICAgICAgcmV0dXJuIEJveDo6RWxlbWVudEF0dHJp YnV0ZXMgeyBCb3g6OkVsZW1lbnRUeXBlOjpUYWJsZUJvZHlHcm91cCB9OwotICAgICAgICAgICAg aWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjp0Zm9vdFRhZykpCi0gICAgICAgICAg ICAgICAgcmV0dXJuIEJveDo6RWxlbWVudEF0dHJpYnV0ZXMgeyBCb3g6OkVsZW1lbnRUeXBlOjpU YWJsZUZvb3Rlckdyb3VwIH07CiAgICAgICAgICAgICBpZiAoZWxlbWVudC0+aGFzVGFnTmFtZShI VE1MTmFtZXM6OmltZ1RhZykpCiAgICAgICAgICAgICAgICAgcmV0dXJuIEJveDo6RWxlbWVudEF0 dHJpYnV0ZXMgeyBCb3g6OkVsZW1lbnRUeXBlOjpJbWFnZSB9OwogICAgICAgICAgICAgaWYgKGVs ZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjppZnJhbWVUYWcpKQo=