201948 2019-09-18 15:04:51 -0700 Web Inspector: console assertion when pressing up/down in empty console log view 2019-09-18 18:46:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1572113 0 joepeck 2019-09-18 15:04:51 -0700 console assertion when pressing up/down in empty console log view Steps to Reproduce: 1. Open Web Inspector 2. js> 123 3. Select the "123" output view 4. Clear the console (⌘K) 5. Press Up or Down => Assert in inspector² Notes: Simple fix, but maybe we should beep. 1572167 1 379088 joepeck 2019-09-18 17:17:02 -0700 Created attachment 379088 [PATCH] Proposed Fix 1572171 2 379088 hi 2019-09-18 17:25:22 -0700 Comment on attachment 379088 [PATCH] Proposed Fix rs=me Can you actually write somewhere what the assertion message/location actually was? I'm guessing it's the `console.assert(message)` inside `WI.LogContentView.prototype._updateMessagesSelection`? 1572173 3 joepeck 2019-09-18 17:34:32 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 379088 [details] > [PATCH] Proposed Fix > > rs=me > > Can you actually write somewhere what the assertion message/location > actually was? I'm guessing it's the `console.assert(message)` inside > `WI.LogContentView.prototype._updateMessagesSelection`? Yep that was it. I'll add that to the ChangeLog. 1572184 4 joepeck 2019-09-18 18:45:56 -0700 https://trac.webkit.org/r250076 1572185 5 webkit-bug-importer 2019-09-18 18:46:19 -0700 <rdar://problem/55502716> 379088 2019-09-18 17:17:02 -0700 2019-09-18 18:45:52 -0700 [PATCH] Proposed Fix assert-1.patch text/plain 3027 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM5Zjg3MmM5NTk5Li4xYWJjZGRlZWJkMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDktMTggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBjb25zb2xlIGFzc2VydGlvbiB3aGVuIHByZXNzaW5nIHVwL2Rvd24gaW4gZW1wdHkgY29uc29s ZSBsb2cgdmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAxOTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0ku TG9nQ29udGVudFZpZXcucHJvdG90eXBlLl91cEFycm93V2FzUHJlc3NlZCk6CisgICAgICAgIChX SS5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUuX2Rvd25BcnJvd1dhc1ByZXNzZWQpOgorICAgICAg ICBFbnN1cmUgdGhhdCBhIG1lc3NhZ2UgZXhpc3RzIGJlZm9yZSBjYWxsaW5nIGBfdXBkYXRlTWVz c2FnZXNTZWxlY3Rpb25gLgorICAgICAgICBBbmQgb25seSBwcmV2ZW50RGVmYXVsdCB3aGVuIHNl bGVjdGluZyBhIG1lc3NhZ2UsIHdoaWNoIGFsbG93cyB1cworICAgICAgICB0byBmYWxsIGJhY2sg dG8gYSBzeXN0ZW0gYmVlcCBpZiB0aGlzIGtleSBldmVudCBkb2VzIG5vdGhpbmcuCisKIDIwMTkt MDktMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBIVE1MIEZvcm1hdHRlciAtIGJldHRlciBoYW5kbGluZyBmb3IgSFRNTCBz cGVjaWZpYyB0YWcgY2FzZXMgKDxwPi88bGk+KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcwppbmRleCAw N2NkNWFiOWZkYS4uZTM5NjFkNjAzYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCkBAIC05ODUs MTQgKzk4NSwxNiBAQCBXSS5Mb2dDb250ZW50VmlldyA9IGNsYXNzIExvZ0NvbnRlbnRWaWV3IGV4 dGVuZHMgV0kuQ29udGVudFZpZXcKIAogICAgICAgICB2YXIgbGFzdE1lc3NhZ2UgPSB0aGlzLl9z ZWxlY3RlZE1lc3NhZ2VzLmxhc3RWYWx1ZTsKICAgICAgICAgdmFyIHByZXZpb3VzTWVzc2FnZSA9 IHRoaXMuX3ByZXZpb3VzTWVzc2FnZShsYXN0TWVzc2FnZSk7Ci0gICAgICAgIGlmIChwcmV2aW91 c01lc3NhZ2UpCisgICAgICAgIGlmIChwcmV2aW91c01lc3NhZ2UpIHsKICAgICAgICAgICAgIHRo aXMuX3VwZGF0ZU1lc3NhZ2VzU2VsZWN0aW9uKHByZXZpb3VzTWVzc2FnZSwgZmFsc2UsIGV2ZW50 LnNoaWZ0S2V5LCB0cnVlKTsKLSAgICAgICAgZWxzZSBpZiAoIWV2ZW50LnNoaWZ0S2V5KSB7Cisg ICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICB9IGVsc2UgaWYgKCFl dmVudC5zaGlmdEtleSkgewogICAgICAgICAgICAgdGhpcy5fY2xlYXJNZXNzYWdlc1NlbGVjdGlv bigpOwotICAgICAgICAgICAgdGhpcy5fdXBkYXRlTWVzc2FnZXNTZWxlY3Rpb24obWVzc2FnZXNb MF0sIGZhbHNlLCBmYWxzZSwgdHJ1ZSk7CisgICAgICAgICAgICBpZiAobWVzc2FnZXMubGVuZ3Ro KSB7CisgICAgICAgICAgICAgICAgdGhpcy5fdXBkYXRlTWVzc2FnZXNTZWxlY3Rpb24obWVzc2Fn ZXNbMF0sIGZhbHNlLCBmYWxzZSwgdHJ1ZSk7CisgICAgICAgICAgICAgICAgZXZlbnQucHJldmVu dERlZmF1bHQoKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQotCi0gICAgICAgIGV2ZW50LnBy ZXZlbnREZWZhdWx0KCk7CiAgICAgfQogCiAgICAgX2Rvd25BcnJvd1dhc1ByZXNzZWQoZXZlbnQp CkBAIC0xMDA3LDE0ICsxMDA5LDE2IEBAIFdJLkxvZ0NvbnRlbnRWaWV3ID0gY2xhc3MgTG9nQ29u dGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgICAgIHZhciBsYXN0TWVzc2Fn ZSA9IHRoaXMuX3NlbGVjdGVkTWVzc2FnZXMubGFzdFZhbHVlOwogICAgICAgICB2YXIgbmV4dE1l c3NhZ2UgPSB0aGlzLl9uZXh0TWVzc2FnZShsYXN0TWVzc2FnZSk7Ci0gICAgICAgIGlmIChuZXh0 TWVzc2FnZSkKKyAgICAgICAgaWYgKG5leHRNZXNzYWdlKSB7CiAgICAgICAgICAgICB0aGlzLl91 cGRhdGVNZXNzYWdlc1NlbGVjdGlvbihuZXh0TWVzc2FnZSwgZmFsc2UsIGV2ZW50LnNoaWZ0S2V5 LCB0cnVlKTsKLSAgICAgICAgZWxzZSBpZiAoIWV2ZW50LnNoaWZ0S2V5KSB7CisgICAgICAgICAg ICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICB9IGVsc2UgaWYgKCFldmVudC5zaGlm dEtleSkgewogICAgICAgICAgICAgdGhpcy5fY2xlYXJNZXNzYWdlc1NlbGVjdGlvbigpOwotICAg ICAgICAgICAgdGhpcy5fdXBkYXRlTWVzc2FnZXNTZWxlY3Rpb24obWVzc2FnZXMubGFzdFZhbHVl LCBmYWxzZSwgZmFsc2UsIHRydWUpOworICAgICAgICAgICAgaWYgKG1lc3NhZ2VzLmxlbmd0aCkg eworICAgICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZU1lc3NhZ2VzU2VsZWN0aW9uKG1lc3NhZ2Vz Lmxhc3RWYWx1ZSwgZmFsc2UsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBldmVudC5w cmV2ZW50RGVmYXVsdCgpOworICAgICAgICAgICAgfQogICAgICAgICB9Ci0KLSAgICAgICAgZXZl bnQucHJldmVudERlZmF1bHQoKTsKICAgICB9CiAKICAgICBfbGVmdEFycm93V2FzUHJlc3NlZChl dmVudCkK