201947 2019-09-18 15:02:46 -0700 Stop calling WTF::initializeMainThread() in JSGlobalContextCreate*() 2019-09-18 16:23:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201083 InRadar P2 Normal --- 200507 1 cdumez cdumez ews-watchlist ggaren keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1572106 0 cdumez 2019-09-18 15:02:46 -0700 Stop calling WTF::initializeMainThread() in JSGlobalContextCreate*(). I started doing so in <https://trac.webkit.org/changeset/248533> but it is causing crashes for apps using this JS API on background threads. It is also no longer necessary as of <https://trac.webkit.org/changeset/249064>. 1572109 1 cdumez 2019-09-18 15:03:04 -0700 <rdar://problem/55453612> 1572112 2 379077 cdumez 2019-09-18 15:04:47 -0700 Created attachment 379077 Patch 1572118 3 379077 mark.lam 2019-09-18 15:08:30 -0700 Comment on attachment 379077 Patch r=me if bots are green. 1572131 4 379077 cdumez 2019-09-18 15:56:23 -0700 Comment on attachment 379077 Patch Clearing flags on attachment: 379077 Committed r250062: <https://trac.webkit.org/changeset/250062> 1572132 5 cdumez 2019-09-18 15:56:26 -0700 All reviewed patches have been landed. Closing bug. 1572143 6 cdumez 2019-09-18 16:23:41 -0700 FYI, I am looking into writing an API test for this, to avoid this happening again in the future. 379077 2019-09-18 15:04:47 -0700 2019-09-18 15:56:23 -0700 Patch bug-201947-20190918150446.patch text/plain 2201 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MWNjYTNlNTg2OWMyNjZlM2U5ZWUwZjliNzE5MmYwYjc2YjZmOTlmLi40ODM1NzVjZjMxYjk5YTU5 YjVjNjVlNTY2YmY1MWVkOTFkMzY4NmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wOS0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIFN0b3AgY2FsbGluZyBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCkgaW4gSlNH bG9iYWxDb250ZXh0Q3JlYXRlKigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDE5NDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1NDUzNjEyPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgY2Fs bGluZyBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCkgaW4gSlNHbG9iYWxDb250ZXh0Q3JlYXRl KigpLiBJIHN0YXJ0ZWQgZG9pbmcgc28gaW4gPGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5n ZXNldC8yNDg1MzM+CisgICAgICAgIGJ1dCBpdCBpcyBjYXVzaW5nIGNyYXNoZXMgZm9yIGFwcHMg dXNpbmcgdGhpcyBKUyBBUEkgb24gYmFja2dyb3VuZCB0aHJlYWRzLiBJdCBpcyBhbHNvIG5vIGxv bmdlciBuZWNlc3NhcnkgYXMgb2YKKyAgICAgICAgPGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8yNDkwNjQ+LgorCisgICAgICAgICogQVBJL0pTQ29udGV4dFJlZi5jcHA6CisgICAg ICAgIChKU0NvbnRleHRHcm91cENyZWF0ZSk6CisgICAgICAgIChKU0dsb2JhbENvbnRleHRDcmVh dGUpOgorICAgICAgICAoSlNHbG9iYWxDb250ZXh0Q3JlYXRlSW5Hcm91cCk6CisKIDIwMTktMDkt MTggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTAwMDIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL0pTQ29udGV4dFJlZi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTQ29udGV4dFJlZi5jcHAKaW5kZXggYzM3ZjEyNzZmYzQ5NzgxMzY2NzVlNmFiZGE5MTU0OTYz MTVlZTk3NC4uZGU3NTU1NDdhYjA3OTkyNTA2NTI0ZGZjZjYwOWZmZTUwMTc5ZWIwNyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmNwcApAQCAtNjgsNyArNjgsNiBA QCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBKU0NvbnRleHRHcm91cFJlZiBKU0NvbnRleHRHcm91 cENyZWF0ZSgpCiB7Ci0gICAgV1RGOjppbml0aWFsaXplTWFpblRocmVhZCgpOwogICAgIGluaXRp YWxpemVUaHJlYWRpbmcoKTsKICAgICByZXR1cm4gdG9SZWYoJlZNOjpjcmVhdGVDb250ZXh0R3Jv dXAoKS5sZWFrUmVmKCkpOwogfQpAQCAtMTE5LDcgKzExOCw2IEBAIHZvaWQgSlNDb250ZXh0R3Jv dXBDbGVhckV4ZWN1dGlvblRpbWVMaW1pdChKU0NvbnRleHRHcm91cFJlZiBncm91cCkKIAogSlNH bG9iYWxDb250ZXh0UmVmIEpTR2xvYmFsQ29udGV4dENyZWF0ZShKU0NsYXNzUmVmIGdsb2JhbE9i amVjdENsYXNzKQogewotICAgIFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWQoKTsKICAgICBpbml0 aWFsaXplVGhyZWFkaW5nKCk7CiAKICNpZiBPUyhEQVJXSU4pCkBAIC0xMzUsNyArMTMzLDYgQEAg SlNHbG9iYWxDb250ZXh0UmVmIEpTR2xvYmFsQ29udGV4dENyZWF0ZShKU0NsYXNzUmVmIGdsb2Jh bE9iamVjdENsYXNzKQogCiBKU0dsb2JhbENvbnRleHRSZWYgSlNHbG9iYWxDb250ZXh0Q3JlYXRl SW5Hcm91cChKU0NvbnRleHRHcm91cFJlZiBncm91cCwgSlNDbGFzc1JlZiBnbG9iYWxPYmplY3RD bGFzcykKIHsKLSAgICBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCk7CiAgICAgaW5pdGlhbGl6 ZVRocmVhZGluZygpOwogCiAgICAgUmVmPFZNPiB2bSA9IGdyb3VwID8gUmVmPFZNPigqdG9KUyhn cm91cCkpIDogVk06OmNyZWF0ZUNvbnRleHRHcm91cCgpOwo=