201942 2019-09-18 13:40:35 -0700 Eagerly create and add the m_layerHostingView to WKWebView 2019-09-18 17:07:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1572057 0 timothy 2019-09-18 13:40:35 -0700 Some apps will add subviews to WKWebView, and by the time we add our m_layerHostingView view we might be adding it behind a view that should have been added behind our layer hosting view subview. This recently affected the Spark email app, due to some changes in order of loading delegate calls and when compositing is enabled. From what I can tell we are hitting this now because we sped up loading since Mojave. We are at the mercy of TiledCoreAnimationDrawingArea’s layer flush runloop observer which, which checks for m_needsSendEnterAcceleratedCompositingMode, before waiting a runloop cycle before triggering the message to the UI process to add the WKFlippedView for m_layerHostingView. The didFinishNavigation delegate call, which adds Spark's subview, seems to be happening reliably sooner than it did in Mojave. WebKit always adds the WKFlippedView behind all subviews, so if Spark's subview is added early, then WKFlippedView will be behind Spark's opaque subview. <rdar://problem/55312523> 1572058 1 379068 timothy 2019-09-18 13:47:05 -0700 Created attachment 379068 Patch 1572165 2 379068 commit-queue 2019-09-18 17:07:38 -0700 Comment on attachment 379068 Patch Clearing flags on attachment: 379068 Committed r250069: <https://trac.webkit.org/changeset/250069> 1572166 3 commit-queue 2019-09-18 17:07:40 -0700 All reviewed patches have been landed. Closing bug. 379068 2019-09-18 13:47:05 -0700 2019-09-18 17:07:38 -0700 Patch bug-201942-20190918134705.patch text/plain 4212 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlYjU3NWY5NDE4OTU5MGEw NmY1OWQ0YmE1YWM0MDNlMmM0ZWY3YmQuLmU2MTM3ZmU3MWVhMzdkMDMyZmYyM2E1M2M0NTQ3NDdm YjRlM2IzYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDktMTggIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEVhZ2VybHkgY3JlYXRlIGFu ZCBhZGQgdGhlIG1fbGF5ZXJIb3N0aW5nVmlldyB0byBXS1dlYlZpZXcuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE5NDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIGFwcHMgd2lsbCBhZGQgc3Vi dmlld3MgdG8gV0tXZWJWaWV3LCBhbmQgYnkgdGhlIHRpbWUgd2UgYWRkIG91ciBtX2xheWVySG9z dGluZ1ZpZXcgdmlldyB3ZSBtaWdodCBiZQorICAgICAgICBhZGRpbmcgaXQgYmVoaW5kIGEgdmll dyB0aGF0IHNob3VsZCBoYXZlIGJlZW4gYWRkZWQgYmVoaW5kIG91ciBsYXllciBob3N0aW5nIHZp ZXcgc3Vidmlldy4gVGhpcyBhZmZlY3RlZAorICAgICAgICB0aGUgU3BhcmsgZW1haWwgYXBwLCBk dWUgdG8gY2hhbmdlcyBpbiBvcmRlciBvZiBsb2FkaW5nIGRlbGVnYXRlIGNhbGxzIGFuZCB3aGVu IGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQuCisgICAgICAgIEluc3RlYWQgb2YgZGVsYXllZCBjcmVh dGlvbiBvZiBtX2xheWVySG9zdGluZ1ZpZXcsIGFsd2F5cyBjcmVhdGUgaXQgYW5kIGFkZCBpdCB0 byB0byB0aGUgV0tXZWJWaWV3LgorICAgICAgICBUaGlzIGVuc3VyZXMgcHJvcGVyIG9yZGVyaW5n IG9mIHN1YnZpZXdzIHdoZW4gY2xpZW50cyBhZGQgYSB2aWV3IGJlaGluZCBhbGwgZXhpc3Rpbmcg c3Vidmlld3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpXZWJWaWV3SW1wbCk6IENyZWF0ZSBhbmQgYWRk IG1fbGF5ZXJIb3N0aW5nVmlldyBoZXJlLgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6 c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ1Jvb3RMYXllcik6IFJlbW92ZSBjcmVhdGlvbiBhbmQg cmVtb3ZhbCBvZiBtX2xheWVySG9zdGluZ1ZpZXcuCisgICAgICAgIEp1c3Qgc2V0IHRoZSBzdWJs YXllcnMgb2YgbV9sYXllckhvc3RpbmdWaWV3J3MgbGF5ZXIgaGVyZS4KKwogMjAxOS0wOS0xNyAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYk1ETlNSZWdpc3Rl ciBubyBsb25nZXIgbmVlZHMgdG8gYmUgcHJvdmlkZWQgc2Vzc2lvbklEcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQppbmRleCAzNWFjNGRmNmU1ZWRkMDc0 N2E3M2RiZTViY2FjM2I2YTU5MzIzMmVlLi42NDJmMTY2NzUyZTZjOTgzNTQ2MDAwZmMwNDZlYWNk NTQ3MDFlNWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJW aWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w bC5tbQpAQCAtMTMzMiw2ICsxMzMyLDIyIEBAIFdlYlZpZXdJbXBsOjpXZWJWaWV3SW1wbChOU1Zp ZXcgPFdlYlZpZXdJbXBsRGVsZWdhdGU+ICp2aWV3LCBXS1dlYlZpZXcgKm91dGVyV2ViCiAKICAg ICBbdmlldyBhZGRUcmFja2luZ0FyZWE6bV9wcmltYXJ5VHJhY2tpbmdBcmVhLmdldCgpXTsKIAor ICAgIC8vIENyZWF0ZSBhbiBOU1ZpZXcgdGhhdCB3aWxsIGhvc3Qgb3VyIGxheWVyIHRyZWUuCisg ICAgbV9sYXllckhvc3RpbmdWaWV3ID0gYWRvcHROUyhbW1dLRmxpcHBlZFZpZXcgYWxsb2NdIGlu aXRXaXRoRnJhbWU6W21fdmlldyBib3VuZHNdXSk7CisgICAgW21fbGF5ZXJIb3N0aW5nVmlldyBz ZXRBdXRvcmVzaXppbmdNYXNrOk5TVmlld1dpZHRoU2l6YWJsZSB8IE5TVmlld0hlaWdodFNpemFi bGVdOworCisgICAgW3ZpZXcgYWRkU3VidmlldzptX2xheWVySG9zdGluZ1ZpZXcuZ2V0KCkgcG9z aXRpb25lZDpOU1dpbmRvd0JlbG93IHJlbGF0aXZlVG86bmlsXTsKKworICAgIC8vIENyZWF0ZSBh IHJvb3QgbGF5ZXIgdGhhdCB3aWxsIGJhY2sgdGhlIE5TVmlldy4KKyAgICBSZXRhaW5QdHI8Q0FM YXllcj4gbGF5ZXIgPSBhZG9wdE5TKFtbQ0FMYXllciBhbGxvY10gaW5pdF0pOworICAgIFtsYXll ciBzZXREZWxlZ2F0ZTpbV2ViQWN0aW9uRGlzYWJsaW5nQ0FMYXllckRlbGVnYXRlIHNoYXJlZF1d OworI2lmbmRlZiBOREVCVUcKKyAgICBbbGF5ZXIgc2V0TmFtZTpAIkhvc3Rpbmcgcm9vdCBsYXll ciJdOworI2VuZGlmCisKKyAgICBbbV9sYXllckhvc3RpbmdWaWV3IHNldExheWVyOmxheWVyLmdl dCgpXTsKKyAgICBbbV9sYXllckhvc3RpbmdWaWV3IHNldFdhbnRzTGF5ZXI6WUVTXTsKKwogICAg IG1fcGFnZS0+c2V0SW50cmluc2ljRGV2aWNlU2NhbGVGYWN0b3IoaW50cmluc2ljRGV2aWNlU2Nh bGVGYWN0b3IoKSk7CiAKICAgICBpZiAoQ2xhc3MgZ2VzdHVyZUNsYXNzID0gTlNDbGFzc0Zyb21T dHJpbmcoQCJOU0ltbWVkaWF0ZUFjdGlvbkdlc3R1cmVSZWNvZ25pemVyIikpIHsKQEAgLTM3NDYs MzMgKzM3NjIsNyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5n Um9vdExheWVyKENBTGF5ZXIgKnJvb3RMYXllcikKICAgICBbQ0FUcmFuc2FjdGlvbiBiZWdpbl07 CiAgICAgW0NBVHJhbnNhY3Rpb24gc2V0RGlzYWJsZUFjdGlvbnM6WUVTXTsKIAotICAgIGlmIChy b290TGF5ZXIpIHsKLSAgICAgICAgaWYgKCFtX2xheWVySG9zdGluZ1ZpZXcpIHsKLSAgICAgICAg ICAgIC8vIENyZWF0ZSBhbiBOU1ZpZXcgdGhhdCB3aWxsIGhvc3Qgb3VyIGxheWVyIHRyZWUuCi0g ICAgICAgICAgICBtX2xheWVySG9zdGluZ1ZpZXcgPSBhZG9wdE5TKFtbV0tGbGlwcGVkVmlldyBh bGxvY10gaW5pdFdpdGhGcmFtZTpbbV92aWV3IGJvdW5kc11dKTsKLSAgICAgICAgICAgIFttX2xh eWVySG9zdGluZ1ZpZXcgc2V0QXV0b3Jlc2l6aW5nTWFzazpOU1ZpZXdXaWR0aFNpemFibGUgfCBO U1ZpZXdIZWlnaHRTaXphYmxlXTsKLQotICAgICAgICAgICAgW21fdmlldyBhZGRTdWJ2aWV3Om1f bGF5ZXJIb3N0aW5nVmlldy5nZXQoKSBwb3NpdGlvbmVkOk5TV2luZG93QmVsb3cgcmVsYXRpdmVU bzpuaWxdOwotCi0gICAgICAgICAgICAvLyBDcmVhdGUgYSByb290IGxheWVyIHRoYXQgd2lsbCBi YWNrIHRoZSBOU1ZpZXcuCi0gICAgICAgICAgICBSZXRhaW5QdHI8Q0FMYXllcj4gbGF5ZXIgPSBh ZG9wdE5TKFtbQ0FMYXllciBhbGxvY10gaW5pdF0pOwotICAgICAgICAgICAgW2xheWVyIHNldERl bGVnYXRlOltXZWJBY3Rpb25EaXNhYmxpbmdDQUxheWVyRGVsZWdhdGUgc2hhcmVkXV07Ci0jaWZu ZGVmIE5ERUJVRwotICAgICAgICAgICAgW2xheWVyIHNldE5hbWU6QCJIb3N0aW5nIHJvb3QgbGF5 ZXIiXTsKLSNlbmRpZgotCi0gICAgICAgICAgICBbbV9sYXllckhvc3RpbmdWaWV3IHNldExheWVy OmxheWVyLmdldCgpXTsKLSAgICAgICAgICAgIFttX2xheWVySG9zdGluZ1ZpZXcgc2V0V2FudHNM YXllcjpZRVNdOwotICAgICAgICB9Ci0KLSAgICAgICAgW21fbGF5ZXJIb3N0aW5nVmlldyBsYXll cl0uc3VibGF5ZXJzID0gW05TQXJyYXkgYXJyYXlXaXRoT2JqZWN0OnJvb3RMYXllcl07Ci0gICAg fSBlbHNlIGlmIChtX2xheWVySG9zdGluZ1ZpZXcpIHsKLSAgICAgICAgW21fbGF5ZXJIb3N0aW5n VmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKLSAgICAgICAgW21fbGF5ZXJIb3N0aW5nVmlldyBz ZXRMYXllcjpuaWxdOwotICAgICAgICBbbV9sYXllckhvc3RpbmdWaWV3IHNldFdhbnRzTGF5ZXI6 Tk9dOwotCi0gICAgICAgIG1fbGF5ZXJIb3N0aW5nVmlldyA9IG51bGxwdHI7Ci0gICAgfQorICAg IFttX2xheWVySG9zdGluZ1ZpZXcgbGF5ZXJdLnN1YmxheWVycyA9IHJvb3RMYXllciA/IEBbIHJv b3RMYXllciBdIDogbmlsOwogCiAgICAgW0NBVHJhbnNhY3Rpb24gY29tbWl0XTsKIH0K