201937 2019-09-18 12:29:49 -0700 [EWS] layout-test results shouldn't be hosted on ews server 2020-07-11 08:04:48 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap lingho webkit-bug-importer oldest_to_newest 1572021 0 aakash_jain 2019-09-18 12:29:49 -0700 We shouldn't host layout-test results on the ews-build.webkit.org server. Since EWS runs untrusted code, someone might try to exploit XSS vulnerability through these as they are hosted on a webkit.org server. Potential solution is to host them on S3. 1572025 1 aakash_jain 2019-09-18 12:32:07 -0700 <rdar://problem/55303798> 1670433 2 403962 aakash_jain 2020-07-10 07:02:00 -0700 Created attachment 403962 Patch 1670467 3 403972 aakash_jain 2020-07-10 09:15:00 -0700 Created attachment 403972 Patch 1670474 4 aakash_jain 2020-07-10 09:42:09 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/34/builds/1265 (notice the updated 'view layout test results' and 'download layout test results' urls) 1670482 5 403972 ap 2020-07-10 10:14:17 -0700 Comment on attachment 403972 Patch rs=me 1670483 6 aakash_jain 2020-07-10 10:21:16 -0700 Committed r264229: <https://trac.webkit.org/changeset/264229> 1670740 7 aakash_jain 2020-07-11 08:04:48 -0700 Restarted EWS server to pick up this change yesterday. Working fine, e.g.: https://ews-build.webkit.org/#/builders/10/builds/30476 403962 2020-07-10 07:02:00 -0700 2020-07-10 09:14:56 -0700 Patch bug-201937-20200710100159.patch text/plain 1712 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDIxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA3LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBsYXlvdXQtdGVzdCByZXN1bHRzIHNob3VsZG4ndCBiZSBob3N0 ZWQgb24gZXdzIHNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAxOTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChFeHRyYWN0VGVzdFJlc3VsdHMucmVzdWx0RGlyZWN0b3J5VVJMKToKKwogMjAyMC0wNy0xMCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gTWluaUJyb3dzZXI6IHRpdGxlIG9mIGJhY2stZm9yd2FyZCBtZW51IGl0ZW1zIG5lZWRzIHRv IGJlIHRydW5jYXRlZCB3aGVuIGl0J3MgdG9vIGxhcmdlCkluZGV4OiBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNjQyMTcpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTM3 LDYgKzM3LDcgQEAgaW1wb3J0IG9zCiAKIEJVR19TRVJWRVJfVVJMID0gJ2h0dHBzOi8vYnVncy53 ZWJraXQub3JnLycKIFMzVVJMID0gJ2h0dHBzOi8vczMtdXMtd2VzdC0yLmFtYXpvbmF3cy5jb20v JworUzNfUkVTVUxUU19VUkwgPSAnaHR0cHM6Ly9ld3MtYnVpbGQuczMtdXMtd2VzdC0yLmFtYXpv bmF3cy5jb20vJwogRVdTX0JVSUxEX1VSTCA9ICdodHRwczovL2V3cy1idWlsZC53ZWJraXQub3Jn LycKIEVXU19VUkwgPSAnaHR0cHM6Ly9ld3Mud2Via2l0Lm9yZy8nCiBXaXRoUHJvcGVydGllcyA9 IHByb3BlcnRpZXMuV2l0aFByb3BlcnRpZXMKQEAgLTI0MTgsNyArMjQxOSw4IEBAIGNsYXNzIEV4 dHJhY3RUZXN0UmVzdWx0cyhtYXN0ZXIuTWFzdGVyU2gKICAgICAgICAgbWFzdGVyLk1hc3RlclNo ZWxsQ29tbWFuZC5fX2luaXRfXyhzZWxmLCBjb21tYW5kPXNlbGYuY29tbWFuZCwgbG9nRW52aXJv bj1GYWxzZSkKIAogICAgIGRlZiByZXN1bHREaXJlY3RvcnlVUkwoc2VsZik6Ci0gICAgICAgIHJl dHVybiBzZWxmLnJlc3VsdERpcmVjdG9yeS5yZXBsYWNlKCdwdWJsaWNfaHRtbC8nLCAnLycpICsg Jy8nCisgICAgICAgIHBhdGggPSBzZWxmLnJlc3VsdERpcmVjdG9yeS5yZXBsYWNlKCdwdWJsaWNf aHRtbC9yZXN1bHRzLycsICcnKSArICcvJworICAgICAgICByZXR1cm4gJ3t9e30nLmZvcm1hdChT M19SRVNVTFRTX1VSTCwgcGF0aCkKIAogICAgIGRlZiByZXN1bHRzRG93bmxvYWRVUkwoc2VsZik6 CiAgICAgICAgIHJldHVybiBzZWxmLnppcEZpbGUucmVwbGFjZSgncHVibGljX2h0bWwvJywgJy8n KQo= 403972 2020-07-10 09:15:00 -0700 2020-07-10 10:14:17 -0700 Patch bug-201937-20200710121457.patch text/plain 3875 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDIyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA3LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBsYXlvdXQtdGVzdCByZXN1bHRzIHNob3VsZG4ndCBiZSBob3N0 ZWQgb24gZXdzIHNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAxOTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChFeHRyYWN0VGVzdFJlc3VsdHMucmVzdWx0RGlyZWN0b3J5VVJMKToKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisKIDIwMjAtMDctMTAg IFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR1N0cmVhbWVyXVtFTUVdW09wZW5DRE1dIEltcGxlbWVudCBPcGVuQ0RNIHN1cHBvcnQKSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9u IDI2NDIyMikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQko d29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsNyBAQCBpbXBvcnQgb3MKIAogQlVHX1NFUlZFUl9V UkwgPSAnaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvJwogUzNVUkwgPSAnaHR0cHM6Ly9zMy11cy13 ZXN0LTIuYW1hem9uYXdzLmNvbS8nCitTM19SRVNVTFRTX1VSTCA9ICdodHRwczovL2V3cy1idWls ZC5zMy11cy13ZXN0LTIuYW1hem9uYXdzLmNvbS8nCiBFV1NfQlVJTERfVVJMID0gJ2h0dHBzOi8v ZXdzLWJ1aWxkLndlYmtpdC5vcmcvJwogRVdTX1VSTCA9ICdodHRwczovL2V3cy53ZWJraXQub3Jn LycKIFdpdGhQcm9wZXJ0aWVzID0gcHJvcGVydGllcy5XaXRoUHJvcGVydGllcwpAQCAtMjQxOCwx MCArMjQxOSwxMiBAQCBjbGFzcyBFeHRyYWN0VGVzdFJlc3VsdHMobWFzdGVyLk1hc3RlclNoCiAg ICAgICAgIG1hc3Rlci5NYXN0ZXJTaGVsbENvbW1hbmQuX19pbml0X18oc2VsZiwgY29tbWFuZD1z ZWxmLmNvbW1hbmQsIGxvZ0Vudmlyb249RmFsc2UpCiAKICAgICBkZWYgcmVzdWx0RGlyZWN0b3J5 VVJMKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5yZXN1bHREaXJlY3RvcnkucmVwbGFjZSgn cHVibGljX2h0bWwvJywgJy8nKSArICcvJworICAgICAgICBwYXRoID0gc2VsZi5yZXN1bHREaXJl Y3RvcnkucmVwbGFjZSgncHVibGljX2h0bWwvcmVzdWx0cy8nLCAnJykgKyAnLycKKyAgICAgICAg cmV0dXJuICd7fXt9Jy5mb3JtYXQoUzNfUkVTVUxUU19VUkwsIHBhdGgpCiAKICAgICBkZWYgcmVz dWx0c0Rvd25sb2FkVVJMKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi56aXBGaWxlLnJlcGxh Y2UoJ3B1YmxpY19odG1sLycsICcvJykKKyAgICAgICAgcGF0aCA9IHNlbGYuemlwRmlsZS5yZXBs YWNlKCdwdWJsaWNfaHRtbC9yZXN1bHRzLycsICcnKQorICAgICAgICByZXR1cm4gJ3t9e30nLmZv cm1hdChTM19SRVNVTFRTX1VSTCwgcGF0aCkKIAogICAgIGRlZiBnZXRMYXN0QnVpbGRTdGVwQnlO YW1lKHNlbGYsIG5hbWUpOgogICAgICAgICBmb3Igc3RlcCBpbiByZXZlcnNlZChzZWxmLmJ1aWxk LmV4ZWN1dGVkU3RlcHMpOgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjY0MjIyKQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv cHkpCkBAIC0zMDU3LDcgKzMwNTcsNyBAQCBjbGFzcyBUZXN0RXh0cmFjdFRlc3RSZXN1bHRzKEJ1 aWxkU3RlcE1pCiAgICAgICAgICAgICArIDAsCiAgICAgICAgICkKICAgICAgICAgc2VsZi5leHBl Y3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J0V4dHJhY3RlZCB0ZXN0IHJl c3VsdHMnKQotICAgICAgICBzZWxmLmV4cGVjdEFkZGVkVVJMcyhbY2FsbCgndmlldyBsYXlvdXQg dGVzdCByZXN1bHRzJywgJy9yZXN1bHRzL3Rlc3QvcjI0NjhfYWIxYTI4YjRmZWVlMGQ0Mjk3M2M3 YzA1MzM1YjM1YmNhOTI3ZTk3NCAoMSkvcmVzdWx0cy5odG1sJyldKQorICAgICAgICBzZWxmLmV4 cGVjdEFkZGVkVVJMcyhbY2FsbCgndmlldyBsYXlvdXQgdGVzdCByZXN1bHRzJywgJ2h0dHBzOi8v ZXdzLWJ1aWxkLnMzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tL21hY09TLVNpZXJyYS1SZWxlYXNl LVdLMi1UZXN0cy1FV1MvcjI0NjgtMTIvcmVzdWx0cy5odG1sJyldKQogICAgICAgICByZXR1cm4g c2VsZi5ydW5TdGVwKCkKIAogICAgIGRlZiB0ZXN0X3N1Y2Nlc3Nfd2l0aF9pZGVudGlmaWVyKHNl bGYpOgpAQCAtMzA3NSw3ICszMDc1LDcgQEAgY2xhc3MgVGVzdEV4dHJhY3RUZXN0UmVzdWx0cyhC dWlsZFN0ZXBNaQogICAgICAgICAgICAgKyAwLAogICAgICAgICApCiAgICAgICAgIHNlbGYuZXhw ZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdFeHRyYWN0ZWQgdGVzdCBy ZXN1bHRzJykKLSAgICAgICAgc2VsZi5leHBlY3RBZGRlZFVSTHMoW2NhbGwoJ3ZpZXcgbGF5b3V0 IHRlc3QgcmVzdWx0cycsICcvcmVzdWx0cy90ZXN0L3IyNDY4X2FiMWEyOGI0ZmVlZTBkNDI5NzNj N2MwNTMzNWIzNWJjYTkyN2U5NzQgKDEpL3Jlc3VsdHMuaHRtbCcpXSkKKyAgICAgICAgc2VsZi5l eHBlY3RBZGRlZFVSTHMoW2NhbGwoJ3ZpZXcgbGF5b3V0IHRlc3QgcmVzdWx0cycsICdodHRwczov L2V3cy1idWlsZC5zMy11cy13ZXN0LTIuYW1hem9uYXdzLmNvbS9pT1MtMTItU2ltdWxhdG9yLVdL Mi1UZXN0cy1FV1MvcjEyMzQtMTIvcmVzdWx0cy5odG1sJyldKQogICAgICAgICByZXR1cm4gc2Vs Zi5ydW5TdGVwKCkKIAogICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6CkBAIC0zMDkzLDcgKzMw OTMsNyBAQCBjbGFzcyBUZXN0RXh0cmFjdFRlc3RSZXN1bHRzKEJ1aWxkU3RlcE1pCiAgICAgICAg ICAgICArIDIsCiAgICAgICAgICkKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1G QUlMVVJFLCBzdGF0ZV9zdHJpbmc9J2ZhaWxlZCAoMikgKGZhaWx1cmUpJykKLSAgICAgICAgc2Vs Zi5leHBlY3RBZGRlZFVSTHMoW2NhbGwoJ3ZpZXcgbGF5b3V0IHRlc3QgcmVzdWx0cycsICcvcmVz dWx0cy90ZXN0L3IyNDY4X2FiMWEyOGI0ZmVlZTBkNDI5NzNjN2MwNTMzNWIzNWJjYTkyN2U5NzQg KDEpL3Jlc3VsdHMuaHRtbCcpXSkKKyAgICAgICAgc2VsZi5leHBlY3RBZGRlZFVSTHMoW2NhbGwo J3ZpZXcgbGF5b3V0IHRlc3QgcmVzdWx0cycsICdodHRwczovL2V3cy1idWlsZC5zMy11cy13ZXN0 LTIuYW1hem9uYXdzLmNvbS9tYWNPUy1TaWVycmEtUmVsZWFzZS1XSzItVGVzdHMtRVdTL3IxMjM0 LTEyL3Jlc3VsdHMuaHRtbCcpXSkKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAo=