20191 2008-07-27 22:02:00 -0700 [Qt] Hitting enter/return doesn't create new list items as in other WebKit ports. 2008-08-05 06:42:32 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED http://rtef.info/demo.htm or http://tinymce.moxiecode.com/example_full.php?example=true Qt P2 Normal --- 1 elbunce vestbo oldest_to_newest 87105 0 elbunce 2008-07-27 22:02:00 -0700 This problem still exists in SVN r35406. Creating either an ordered or unordered list in (TinyMCE, RTEF, or otherwise) doesn't work as expected using the Qt build of WebKit. In Safari and using the Mac OS X native build, Enter/Return result in a new list item being created, however it inserts a line break. This is caused by the VK_RETURN handling in Qt WebKit calling the InsertLineBreak instead of InsertNewline command. 87106 1 22516 elbunce 2008-07-27 22:03:04 -0700 Created attachment 22516 Patch to change VK_RETURN handling from InsertLineBreak to InsertNewline 87153 2 vestbo 2008-07-28 07:30:13 -0700 This should probably be handled in QWebPage::editorActionForKeyEvent(), but might require changes in Qt. I'm looking into it. We also need to make sure we exec InsertLineBreak when the shift modifier is pressed (ctrl on mac). 87164 3 elbunce 2008-07-28 09:54:40 -0700 I agree about the Shift / CTRL modifier. Also that long-term a lot of EditorClientQt::handleKeyboardEvent() should be refactored, and that comparison/dispatch using QKeySequence would be a better way to go. However, I'm not sure wholesale moving it to use QWebPage::editorActionForKeyEvent() is the correct solution either, unless you wish to expose most / all of the necessary commands as QWebPage::WebActions. 87167 4 22523 elbunce 2008-07-28 10:22:56 -0700 Created attachment 22523 Improved patch handles Shift + Return properly. 87245 5 elbunce 2008-07-28 22:38:48 -0700 Looking at the sequences in question, making them QPage::WebActions might not be a bad idea. I'd still probably separate the edit vs. 'nav' action lookups. 87256 6 vestbo 2008-07-29 04:48:17 -0700 Preliminary patch (requires a > 1. August Qt snapshot): http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=fb313a86b2565637593c8b5b497c28b9ae763b1a 87262 7 vestbo 2008-07-29 06:17:08 -0700 Updated patch. This one should build against Qt 4.4 too (by using the approach of patch 22523). Thanks for contributing! http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=7d2f6e54672ca4d0c3fd4541ad59e4f32db981cc 87358 8 elbunce 2008-07-29 21:55:12 -0700 Heh, the one correction I'd make is that my name is Erik with a k at the end. ;-) 87862 9 vestbo 2008-08-05 06:42:32 -0700 Landed in r35558, with a k at the end :) Thanks! 22516 2008-07-27 22:03:04 -0700 2008-07-28 10:22:56 -0700 Patch to change VK_RETURN handling from InsertLineBreak to InsertNewline insertnewline.patch.txt text/plain 1349 elbunce SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzU0MDYpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDctMjcgIEVyaWsgQnVuY2UgIDxzZXQgRU1BSUxf QUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKwkKKwlDaGFuZ2UgVktfUkVUVVJOIGhhbmRsaW5nIGZyb20gSW5zZXJ0TGlu ZUJyZWFrIHRvIEluc2VydE5ld2xpbmUgdG8gbWFrZSBjb25zaXN0ZW50IHdpdGggb3RoZXIgcGxh dGZvcm1zLiBBbmQgZml4IGJyb2tlbiBVbm9yZGVyZWQvT3JkZXJlZCBMaXN0IGhhbmRsaW5nLgor CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RWRpdG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgorCiAyMDA4LTA3 LTI3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFF0 IGJ1aWxkIGZhaWx1cmUuCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xp ZW50UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRRdC5jcHAJKHJldmlzaW9uIDM1NDA2KQorKysgV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L0VkaXRvckNsaWVudFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQzLDcgKzM0Myw3IEBAIHZv aWQgRWRpdG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQKICAgICBpZiAoc3RhcnQtPmlz Q29udGVudEVkaXRhYmxlKCkpIHsKICAgICAgICAgc3dpdGNoIChrZXZlbnQtPndpbmRvd3NWaXJ0 dWFsS2V5Q29kZSgpKSB7CiAgICAgICAgICAgICBjYXNlIFZLX1JFVFVSTjoKLSAgICAgICAgICAg ICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIkluc2VydExpbmVCcmVhayIpLmV4ZWN1dGUo KTsKKyAgICAgICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIkluc2VydE5ld2xp bmUiKS5leGVjdXRlKCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNl IFZLX0JBQ0s6CiAgICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5kZWxldGVXaXRoRGly ZWN0aW9uKFNlbGVjdGlvbkNvbnRyb2xsZXI6OkJBQ0tXQVJELAo= 22523 2008-07-28 10:22:56 -0700 2008-07-28 10:22:56 -0700 Improved patch handles Shift + Return properly. insertnewline.patch.txt text/plain 1471 elbunce SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzU0MDYpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDctMjcgIEVyaWsgQnVuY2UgIDxzZXQgRU1BSUxf QUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKwkKKwlDaGFuZ2UgVktfUkVUVVJOIGhhbmRsaW5nIGZyb20gSW5zZXJ0TGlu ZUJyZWFrIHRvIEluc2VydE5ld2xpbmUgdG8gbWFrZSBjb25zaXN0ZW50IHdpdGggb3RoZXIgcGxh dGZvcm1zLiBBbmQgZml4IGJyb2tlbiBVbm9yZGVyZWQvT3JkZXJlZCBMaXN0IGhhbmRsaW5nLgor CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RWRpdG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgorCiAyMDA4LTA3 LTI3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFF0 IGJ1aWxkIGZhaWx1cmUuCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xp ZW50UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRRdC5jcHAJKHJldmlzaW9uIDM1NDA2KQorKysgV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L0VkaXRvckNsaWVudFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQzLDcgKzM0Myw5IEBAIHZv aWQgRWRpdG9yQ2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQKICAgICBpZiAoc3RhcnQtPmlz Q29udGVudEVkaXRhYmxlKCkpIHsKICAgICAgICAgc3dpdGNoIChrZXZlbnQtPndpbmRvd3NWaXJ0 dWFsS2V5Q29kZSgpKSB7CiAgICAgICAgICAgICBjYXNlIFZLX1JFVFVSTjoKLSAgICAgICAgICAg ICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIkluc2VydExpbmVCcmVhayIpLmV4ZWN1dGUo KTsKKyAgICAgICAgICAgICAgICBpZiAoa2V2ZW50LT5zaGlmdEtleSgpKQorICAgICAgICAgICAg ICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIkluc2VydExpbmVCcmVhayIpLmV4ZWN1 dGUoKTsKKyAgICAgICAgICAgICAgICBlbHNlIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiSW5z ZXJ0TmV3bGluZSIpLmV4ZWN1dGUoKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ICAgIGNhc2UgVktfQkFDSzoKICAgICAgICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmRlbGV0 ZVdpdGhEaXJlY3Rpb24oU2VsZWN0aW9uQ29udHJvbGxlcjo6QkFDS1dBUkQsCg==