201902 2019-09-17 21:37:16 -0700 REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing 2019-10-15 11:08:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad achristensen achristensen benjamin cdumez cmarcelo dbates ews-watchlist jiewen_tan rniwa webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1571811 0 ryanhaddad 2019-09-17 21:37:16 -0700 The following test is failing on iOS simulator bots running iOS 13: TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments /Volumes/Data/slave/ios-simulator-13-release/build/Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:117 Expected equality of these values: 'a' Which is: 'a' (97, 0x61) static_cast<char*>(arrayBuffer->data())[position] Which is: '\0' https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/2/steps/run-api-tests/logs/stdio 1571812 1 webkit-bug-importer 2019-09-17 21:37:29 -0700 <rdar://problem/55466168> 1572502 2 ryanhaddad 2019-09-19 15:20:40 -0700 Disabled the test for iOS in https://trac.webkit.org/changeset/250105 1572904 3 achristensen 2019-09-20 14:44:48 -0700 Interesting. The test passes for me locally. Maybe it's misinterpreting the Vector constructor somehow. 1579287 4 380797 achristensen 2019-10-11 15:57:29 -0700 Created attachment 380797 Patch 1579346 5 380797 achristensen 2019-10-11 18:57:21 -0700 Comment on attachment 380797 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380797&action=review > Source/WTF/wtf/Vector.h:-208 > - if (!__builtin_constant_p(dstEnd - dst) || (!(dstEnd - dst))) This line should have been ... || (!!(dstEnd - dst))) That was causing this to not call memset only in optimized builds when the size was nonzero. Since I think it's not needed let's just remove it and let the compiler optimize out any memset with 0 size. 1579751 6 achristensen 2019-10-14 12:54:58 -0700 Ping review? 1579766 7 achristensen 2019-10-14 13:25:56 -0700 http://trac.webkit.org/r251089 1580179 8 jiewen_tan 2019-10-15 11:08:04 -0700 *** Bug 201620 has been marked as a duplicate of this bug. *** 380797 2019-10-11 15:57:29 -0700 2019-10-14 13:06:46 -0700 Patch bug-201902-20191011155729.patch text/plain 4562 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTEwMjQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTExICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPUyAxMz9d IFRlc3RXZWJLaXRBUEkuU2hhcmVkQnVmZmVyVGVzdC50cnlDcmVhdGVBcnJheUJ1ZmZlckxhcmdl U2VnbWVudHMgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAxOTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvVmVjdG9yLmg6CisgICAgICAgIFRoZSBjb2RlIGludHJvZHVjZWQg aW4gcjEwODE1MyB0byB3b3JrYXJvdW5kIGEgd2FybmluZyB3aGVuIGJ1aWxkaW5nIENocm9tZSB3 YXMgY2F1c2luZyB1cyB0byB1c2UgdW5pbml0aWFsaXplZCBtZW1vcnkKKyAgICAgICAgd2hlbiB3 ZSBjcmVhdGUgYSBWZWN0b3Igd2l0aCB0aGUgc2l6ZV90L3tzaWduZWQsdW5zaWduZWR9Y2hhciBj b25zdHJ1Y3RvciB3aXRoIGEgY29uc3RleHByIHNpemVfdC4KKyAgICAgICAgVGhpcyB3YXMgdGhl IGNhdXNlIG9mIGJ1ZyAyMDE5MDIgYW5kIGJ1ZyAyMDE2MjAgd2hpY2ggb25seSBtYW5pZmVzdGVk IHRoZW1zZWx2ZXMgaW4gcmVsZWFzZSBidWlsZHMgd2l0aCBzb21lIGNvbXBpbGVycy4KKwogMjAx OS0xMC0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIE9ubHkgdXNlIENGTmV0d29yayBTUEkgZm9yIG1ldHJpY3Mgd2hlcmUgbmVlZGVkCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0 Zi9WZWN0b3IuaAkocmV2aXNpb24gMjUxMDI3KQorKysgU291cmNlL1dURi93dGYvVmVjdG9yLmgJ KHdvcmtpbmcgY29weSkKQEAgLTIwNCwxMCArMjA0LDcgQEAgc3RydWN0IFZlY3RvckZpbGxlcjx0 cnVlLCBUPgogICAgIHN0YXRpYyB2b2lkIHVuaW5pdGlhbGl6ZWRGaWxsKFQqIGRzdCwgVCogZHN0 RW5kLCBjb25zdCBUJiB2YWwpIAogICAgIHsKICAgICAgICAgc3RhdGljX2Fzc2VydChzaXplb2Yo VCkgPT0gMSwgIlNpemUgb2YgdHlwZSBUIHNob3VsZCBiZSBlcXVhbCB0byBvbmUhIik7Ci0jaWYg Q09NUElMRVIoR0NDX0NPTVBBVElCTEUpICYmIGRlZmluZWQoX0ZPUlRJRllfU09VUkNFKQotICAg ICAgICBpZiAoIV9fYnVpbHRpbl9jb25zdGFudF9wKGRzdEVuZCAtIGRzdCkgfHwgKCEoZHN0RW5k IC0gZHN0KSkpCi0jZW5kaWYKLSAgICAgICAgICAgIG1lbXNldChkc3QsIHZhbCwgZHN0RW5kIC0g ZHN0KTsKKyAgICAgICAgbWVtc2V0KGRzdCwgdmFsLCBkc3RFbmQgLSBkc3QpOwogICAgIH0KIH07 CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTAyNykKKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTEwLTExICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVT U0lPTjogW2lPUyAxMz9dIFRlc3RXZWJLaXRBUEkuU2hhcmVkQnVmZmVyVGVzdC50cnlDcmVhdGVB cnJheUJ1ZmZlckxhcmdlU2VnbWVudHMgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxOTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1dGhuL2ZpZG8vVTJmUmVz cG9uc2VDb252ZXJ0ZXIuY3BwOgorICAgICAgICAoZmlkbzo6V2ViQ29yZTo6Y3JlYXRlQXR0ZXN0 ZWRDcmVkZW50aWFsRGF0YUZyb21VMmZSZWdpc3RlclJlc3BvbnNlKToKKwogMjAxOS0xMC0xMSAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE9u bHkgdXNlIENGTmV0d29yayBTUEkgZm9yIG1ldHJpY3Mgd2hlcmUgbmVlZGVkCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL2ZpZG8vVTJmUmVzcG9uc2VDb252ZXJ0ZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vZmlkby9VMmZS ZXNwb25zZUNvbnZlcnRlci5jcHAJKHJldmlzaW9uIDI1MTAyNCkKKysrIFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXV0aG4vZmlkby9VMmZSZXNwb25zZUNvbnZlcnRlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTk4LDkgKzk4LDcgQEAgc3RhdGljIFZlY3Rvcjx1aW50OF90PiBjcmVhdGVBdHRl c3RlZENyZQogICAgIGlmIChjcmVkZW50aWFsSWQuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4g eyB9OwogCi0gICAgVmVjdG9yPHVpbnQ4X3Q+IGFhZ3VpZChhYWd1aWRMZW5ndGgpOwotICAgIG1l bXNldChhYWd1aWQuZGF0YSgpLCAwLCBhYWd1aWRMZW5ndGgpOwotICAgIHJldHVybiBidWlsZEF0 dGVzdGVkQ3JlZGVudGlhbERhdGEoYWFndWlkLCBjcmVkZW50aWFsSWQsIHB1YmxpY0tleSk7Cisg ICAgcmV0dXJuIGJ1aWxkQXR0ZXN0ZWRDcmVkZW50aWFsRGF0YShWZWN0b3I8dWludDhfdD4oYWFn dWlkTGVuZ3RoLCAwKSwgY3JlZGVudGlhbElkLCBwdWJsaWNLZXkpOwogfQogCiBzdGF0aWMgc2l6 ZV90IHBhcnNlWDUwOUxlbmd0aChjb25zdCBWZWN0b3I8dWludDhfdD4mIHUyZkRhdGEsIHNpemVf dCBvZmZzZXQpCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTEwMjcpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0xMC0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT046IFtpT1MgMTM/XSBUZXN0 V2ViS2l0QVBJLlNoYXJlZEJ1ZmZlclRlc3QudHJ5Q3JlYXRlQXJyYXlCdWZmZXJMYXJnZVNlZ21l bnRzIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMTkwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1NoYXJlZEJ1ZmZlci5jcHA6Cisg ICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDE5LTEwLTExICBBYWthc2ggSmFp biAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgYnVpbGQud2Via2l0 Lm9yZyBiYXNlZGlyCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvU2hh cmVkQnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YkNvcmUvU2hhcmVkQnVmZmVyLmNwcAkocmV2aXNpb24gMjUxMDI0KQorKysgVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJDb3JlL1NoYXJlZEJ1ZmZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwMSw3ICsxMDEsNiBAQCBURVNUX0YoU2hhcmVkQnVmZmVyVGVzdCwgdHJ5Q3JlYXRlQXJyYXlC CiAgICAgRVhQRUNUX0VRKDAsIG1lbWNtcChleHBlY3RlZENvbmNhdGVuYXRpb24sIGFycmF5QnVm ZmVyLT5kYXRhKCksIHN0cmxlbihleHBlY3RlZENvbmNhdGVuYXRpb24pKSk7CiB9CiAKLSNpZiAh UExBVEZPUk0oSU9TKSAvLyBGSVhNRTogd2Via2l0Lm9yZy9iLzIwMTkwMiBSRUdSRVNTSU9OOiBb aU9TIDEzP10gVGVzdFdlYktpdEFQSS5TaGFyZWRCdWZmZXJUZXN0LnRyeUNyZWF0ZUFycmF5QnVm ZmVyTGFyZ2VTZWdtZW50cyBpcyBmYWlsaW5nCiBURVNUX0YoU2hhcmVkQnVmZmVyVGVzdCwgdHJ5 Q3JlYXRlQXJyYXlCdWZmZXJMYXJnZVNlZ21lbnRzKQogewogICAgIFZlY3RvcjxjaGFyPiB2ZWN0 b3IwKDB4NDAwMCwgJ2EnKTsKQEAgLTEyNyw3ICsxMjYsNiBAQCBURVNUX0YoU2hhcmVkQnVmZmVy VGVzdCwgdHJ5Q3JlYXRlQXJyYXlCCiAgICAgICAgICsrcG9zaXRpb247CiAgICAgfQogfQotI2Vu ZGlmIC8vICFQTEFURk9STShJT1MpCiAKIFRFU1RfRihTaGFyZWRCdWZmZXJUZXN0LCBjb3B5KQog ewo=