201895 2019-09-17 20:44:39 -0700 [cairo] Incorrect targetRect in BackingStoreBackendCairoImpl::scroll 2019-09-18 00:58:22 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=59655 https://bugs.webkit.org/show_bug.cgi?id=83309 InRadar P2 Normal --- 1 fujii fujii cgarcia magomez mrobinson webkit-bug-importer zan oldest_to_newest 1571792 0 fujii 2019-09-17 20:44:39 -0700 [cairo] Incorrect targetRect in BackingStoreBackendCairoImpl::scroll In BackingStoreBackendCairoImpl::scroll, targetRect is calculated wrongly by shifting maxX and manxY. > IntRect targetRect = scrollRect; > targetRect.move(scrollOffset); > targetRect.shiftMaxXEdgeTo(targetRect.maxX() - scrollOffset.width()); > targetRect.shiftMaxYEdgeTo(targetRect.maxY() - scrollOffset.height()); This code came from Bug 59655. On the other hand, Bug 83309 fixed BackingStoreBackendCairoX11::scroll. > IntRect targetRect = scrollRect; > targetRect.move(scrollOffset); > targetRect.intersect(scrollRect); 1571796 1 379017 fujii 2019-09-17 20:54:23 -0700 Created attachment 379017 Patch 1571846 2 379017 fujii 2019-09-18 00:57:17 -0700 Comment on attachment 379017 Patch Clearing flags on attachment: 379017 Committed r250027: <https://trac.webkit.org/changeset/250027> 1571847 3 fujii 2019-09-18 00:57:21 -0700 All reviewed patches have been landed. Closing bug. 1571848 4 webkit-bug-importer 2019-09-18 00:58:22 -0700 <rdar://problem/55469927> 379017 2019-09-17 20:54:23 -0700 2019-09-18 00:57:17 -0700 Patch bug-201895-20190918125422.patch text/plain 1943 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwMDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDEwODc3NzgyNzgwOWRl M2MyMjYxNTMzNGFkMjYxZTA2OGIwNTYxNC4uOTNlODFjYmQwMTAyNGJiOWMxOTJmZTRiMDYzYTQ1 NzVhY2JkZTZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTE3ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtjYWlyb10g SW5jb3JyZWN0IHRhcmdldFJlY3QgaW4gQmFja2luZ1N0b3JlQmFja2VuZENhaXJvSW1wbDo6c2Ny b2xsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE4 OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBC YWNraW5nU3RvcmVCYWNrZW5kQ2Fpcm9JbXBsOjpzY3JvbGwsIHRhcmdldFJlY3QgaXMgY2FsY3Vs YXRlZAorICAgICAgICB3cm9uZ2x5IGJ5IHNoaWZ0aW5nIG1heFggYW5kIG1heFkuIEJ1ZyA1OTY1 NSBmaXhlZCB0aGUgaXNzdWUgYnkKKyAgICAgICAgcmVtb3ZpbmcgdGhlIHNoaWZ0aW5nLCBidXQg b25seSBmb3IgQmFja2luZ1N0b3JlQmFja2VuZENhaXJvWDExOjpzY3JvbGwuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9CYWNraW5nU3RvcmVCYWNrZW5kQ2Fpcm9JbXBsLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkJhY2tpbmdTdG9yZUJhY2tlbmRDYWlyb0ltcGw6OnNjcm9sbCk6IFRha2UgaW50 ZXJzZWN0aW9uIG9mIHRhcmdldFJlY3QgYW5kIHNjcm9sbFJlY3QuCisKIDIwMTktMDktMTcgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZl cnQgY2hhbmdlIHRoYXQgQWxleCBtaXN0YWtlbmx5IGNvbW1pdHRlZCBhdCB0aGUgc2FtZSB0aW1l IGFzIHIyNTAwMDYgYW5kIGJyb2tlIHRoZSBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0JhY2tpbmdTdG9yZUJhY2tlbmRDYWlyb0ltcGwu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQmFja2luZ1N0b3Jl QmFja2VuZENhaXJvSW1wbC5jcHAKaW5kZXggMWNlYzQwZjUwY2E3NmY3NTRlY2ViZDIxNDJjYWFm Y2JiOWE5OWI2MC4uMTI1NmFjN2VlMTNiNzdjN2VmZjMwNGU2N2Q2YTU5NGRlZmU2ZDFjNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQmFja2luZ1N0 b3JlQmFja2VuZENhaXJvSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vQmFja2luZ1N0b3JlQmFja2VuZENhaXJvSW1wbC5jcHAKQEAgLTU0LDggKzU0 LDcgQEAgdm9pZCBCYWNraW5nU3RvcmVCYWNrZW5kQ2Fpcm9JbXBsOjpzY3JvbGwoY29uc3QgSW50 UmVjdCYgc2Nyb2xsUmVjdCwgY29uc3QgSW50U2kKIHsKICAgICBJbnRSZWN0IHRhcmdldFJlY3Qg PSBzY3JvbGxSZWN0OwogICAgIHRhcmdldFJlY3QubW92ZShzY3JvbGxPZmZzZXQpOwotICAgIHRh cmdldFJlY3Quc2hpZnRNYXhYRWRnZVRvKHRhcmdldFJlY3QubWF4WCgpIC0gc2Nyb2xsT2Zmc2V0 LndpZHRoKCkpOwotICAgIHRhcmdldFJlY3Quc2hpZnRNYXhZRWRnZVRvKHRhcmdldFJlY3QubWF4 WSgpIC0gc2Nyb2xsT2Zmc2V0LmhlaWdodCgpKTsKKyAgICB0YXJnZXRSZWN0LmludGVyc2VjdChz Y3JvbGxSZWN0KTsKICAgICBpZiAodGFyZ2V0UmVjdC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVy bjsKIAo=