201878 2019-09-17 12:06:21 -0700 WebSWServerConnection does not need to store a sessionID 2019-09-17 13:53:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1571613 0 cdumez 2019-09-17 12:06:21 -0700 WebSWServerConnection does not need to store a sessionID, it can simply get it from its SWServer. 1571614 1 378977 cdumez 2019-09-17 12:07:26 -0700 Created attachment 378977 Patch 1571655 2 378977 ggaren 2019-09-17 13:28:05 -0700 Comment on attachment 378977 Patch r=me 1571666 3 378977 cdumez 2019-09-17 13:49:04 -0700 Comment on attachment 378977 Patch Clearing flags on attachment: 378977 Committed r249979: <https://trac.webkit.org/changeset/249979> 1571667 4 cdumez 2019-09-17 13:49:06 -0700 All reviewed patches have been landed. Closing bug. 1571672 5 webkit-bug-importer 2019-09-17 13:53:17 -0700 <rdar://problem/55452320> 378977 2019-09-17 12:07:26 -0700 2019-09-17 13:49:04 -0700 Patch bug-201878-20190917120726.patch text/plain 7121 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjOTJlYTc1NDQ4NzI0ZTc1 ZjBhMWYwZDFmZDA0YWM3ZGNhYjE3YWIuLjRkMDIwMzY1MWUxZjliYTYwNmEzOTFlODU4NGI0ZGQz YjFlYTI4OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDktMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJTV1NlcnZlckNvbm5lY3Rpb24g ZG9lcyBub3QgbmVlZCB0byBzdG9yZSBhIHNlc3Npb25JRAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxODc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViU1dTZXJ2ZXJDb25uZWN0aW9uIGRvZXMgbm90 IG5lZWQgdG8gc3RvcmUgYSBzZXNzaW9uSUQsIGl0IGNhbiBzaW1wbHkgZ2V0IGl0IGZyb20gaXRz IFNXU2VydmVyLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25U b1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2Vzczo6ZXN0YWJsaXNoU1dTZXJ2ZXJDb25uZWN0aW9uKToKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlNXU2VydmVyQ29ubmVjdGlvbjo6V2ViU1dTZXJ2ZXJDb25uZWN0aW9uKToK KyAgICAgICAgKFdlYktpdDo6V2ViU1dTZXJ2ZXJDb25uZWN0aW9uOjpzdGFydEZldGNoKToKKyAg ICAgICAgKFdlYktpdDo6V2ViU1dTZXJ2ZXJDb25uZWN0aW9uOjpzZXNzaW9uSUQgY29uc3QpOgor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25uZWN0 aW9uLmg6CisKIDIwMTktMDktMTcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWJNRE5TUmVnaXN0ZXIgbm8gbG9uZ2VyIG5lZWRzIHRvIGJlIHByb3ZpZGVkIHNl c3Npb25JRHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29y a0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKaW5kZXggMThiNjRmMTZiZWZkYzk3 YmJlOGMxMTE3ZDVjN2M0NDczZGNhNjk3YS4uMTg2MjViNjNhYjZiMmQ0N2M5NzI1ZmZkZjY3ZjZj YzVhMTdlZDM1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKQEAgLTg2Miw3ICs4NjIs NyBAQCB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjp1bnJlZ2lzdGVyU1dDb25u ZWN0aW9uKCkKIHZvaWQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmVzdGFibGlzaFNX U2VydmVyQ29ubmVjdGlvbigpCiB7CiAgICAgYXV0byYgc2VydmVyID0gbV9uZXR3b3JrUHJvY2Vz cy0+c3dTZXJ2ZXJGb3JTZXNzaW9uKG1fc2Vzc2lvbklEKTsKLSAgICBhdXRvIGNvbm5lY3Rpb24g PSBtYWtlVW5pcXVlPFdlYlNXU2VydmVyQ29ubmVjdGlvbj4obV9uZXR3b3JrUHJvY2Vzcywgc2Vy dmVyLCBtX2Nvbm5lY3Rpb24uZ2V0KCksIG1fd2ViUHJvY2Vzc0lkZW50aWZpZXIsIG1fc2Vzc2lv bklEKTsKKyAgICBhdXRvIGNvbm5lY3Rpb24gPSBtYWtlVW5pcXVlPFdlYlNXU2VydmVyQ29ubmVj dGlvbj4obV9uZXR3b3JrUHJvY2Vzcywgc2VydmVyLCBtX2Nvbm5lY3Rpb24uZ2V0KCksIG1fd2Vi UHJvY2Vzc0lkZW50aWZpZXIpOwogCiAgICAgQVNTRVJUKCFtX3N3Q29ubmVjdGlvbik7CiAgICAg bV9zd0Nvbm5lY3Rpb24gPSBtYWtlV2Vha1B0cigqY29ubmVjdGlvbik7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25u ZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9X ZWJTV1NlcnZlckNvbm5lY3Rpb24uY3BwCmluZGV4IDg0ZGQ3ZjM0YWE3MTgxN2NkZjc1Yjc1OTgy OTIzOTk4ODk2YWRiMDUuLjU3MmQyNzFmYjVjYjVmN2RmMGIyZjQ2MjNmOTc0ZThjMmQ0ZmFmMzEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9X ZWJTV1NlcnZlckNvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlckNvbm5lY3Rpb24uY3BwCkBAIC01OCwxMiArNTgs MTEgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiB1c2luZyBuYW1lc3BhY2UgUEFMOwogdXNpbmcgbmFt ZXNwYWNlIFdlYkNvcmU7CiAKLSNkZWZpbmUgU1dTRVJWRVJDT05ORUNUSU9OX1JFTEVBU0VfTE9H X0lGX0FMTE9XRUQoZm10LCAuLi4pIFJFTEVBU0VfTE9HX0lGKG1fc2Vzc2lvbklELmlzQWx3YXlz T25Mb2dnaW5nQWxsb3dlZCgpLCBTZXJ2aWNlV29ya2VyLCAiJXAgLSBXZWJTV1NlcnZlckNvbm5l Y3Rpb246OiIgZm10LCB0aGlzLCAjI19fVkFfQVJHU19fKQotI2RlZmluZSBTV1NFUlZFUkNPTk5F Q1RJT05fUkVMRUFTRV9MT0dfRVJST1JfSUZfQUxMT1dFRChmbXQsIC4uLikgUkVMRUFTRV9MT0df RVJST1JfSUYobV9zZXNzaW9uSUQuaXNBbHdheXNPbkxvZ2dpbmdBbGxvd2VkKCksIFNlcnZpY2VX b3JrZXIsICIlcCAtIFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6IiBmbXQsIHRoaXMsICMjX19WQV9B UkdTX18pCisjZGVmaW5lIFNXU0VSVkVSQ09OTkVDVElPTl9SRUxFQVNFX0xPR19JRl9BTExPV0VE KGZtdCwgLi4uKSBSRUxFQVNFX0xPR19JRihzZXNzaW9uSUQoKS5pc0Fsd2F5c09uTG9nZ2luZ0Fs bG93ZWQoKSwgU2VydmljZVdvcmtlciwgIiVwIC0gV2ViU1dTZXJ2ZXJDb25uZWN0aW9uOjoiIGZt dCwgdGhpcywgIyNfX1ZBX0FSR1NfXykKKyNkZWZpbmUgU1dTRVJWRVJDT05ORUNUSU9OX1JFTEVB U0VfTE9HX0VSUk9SX0lGX0FMTE9XRUQoZm10LCAuLi4pIFJFTEVBU0VfTE9HX0VSUk9SX0lGKHNl c3Npb25JRCgpLmlzQWx3YXlzT25Mb2dnaW5nQWxsb3dlZCgpLCBTZXJ2aWNlV29ya2VyLCAiJXAg LSBXZWJTV1NlcnZlckNvbm5lY3Rpb246OiIgZm10LCB0aGlzLCAjI19fVkFfQVJHU19fKQogCi1X ZWJTV1NlcnZlckNvbm5lY3Rpb246OldlYlNXU2VydmVyQ29ubmVjdGlvbihOZXR3b3JrUHJvY2Vz cyYgbmV0d29ya1Byb2Nlc3MsIFNXU2VydmVyJiBzZXJ2ZXIsIElQQzo6Q29ubmVjdGlvbiYgY29u bmVjdGlvbiwgUHJvY2Vzc0lkZW50aWZpZXIgcHJvY2Vzc0lkZW50aWZpZXIsIFNlc3Npb25JRCBz ZXNzaW9uSUQpCitXZWJTV1NlcnZlckNvbm5lY3Rpb246OldlYlNXU2VydmVyQ29ubmVjdGlvbihO ZXR3b3JrUHJvY2VzcyYgbmV0d29ya1Byb2Nlc3MsIFNXU2VydmVyJiBzZXJ2ZXIsIElQQzo6Q29u bmVjdGlvbiYgY29ubmVjdGlvbiwgUHJvY2Vzc0lkZW50aWZpZXIgcHJvY2Vzc0lkZW50aWZpZXIp CiAgICAgOiBTV1NlcnZlcjo6Q29ubmVjdGlvbihzZXJ2ZXIsIHByb2Nlc3NJZGVudGlmaWVyKQot ICAgICwgbV9zZXNzaW9uSUQoc2Vzc2lvbklEKQogICAgICwgbV9jb250ZW50Q29ubmVjdGlvbihj b25uZWN0aW9uKQogICAgICwgbV9uZXR3b3JrUHJvY2VzcyhuZXR3b3JrUHJvY2VzcykKIHsKQEAg LTE4OSw3ICsxODgsNyBAQCB2b2lkIFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6c3RhcnRGZXRjaChT ZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRlbnRpZmllciBzZXJ2aQogCiAgICAgICAgICAgICBp ZiAoY29udGV4dENvbm5lY3Rpb24pIHsKICAgICAgICAgICAgICAgICBTV1NFUlZFUkNPTk5FQ1RJ T05fUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgic3RhcnRGZXRjaDogU3RhcnRpbmcgZmV0Y2ggJXMg dmlhIHNlcnZpY2Ugd29ya2VyICVzIiwgZmV0Y2hJZGVudGlmaWVyLmxvZ2dpbmdTdHJpbmcoKS51 dGY4KCkuZGF0YSgpLCBzZXJ2aWNlV29ya2VySWRlbnRpZmllci5sb2dnaW5nU3RyaW5nKCkudXRm OCgpLmRhdGEoKSk7Ci0gICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8V2ViU1dTZXJ2ZXJUb0Nv bnRleHRDb25uZWN0aW9uJj4oKmNvbnRleHRDb25uZWN0aW9uKS5zdGFydEZldGNoKG1fc2Vzc2lv bklELCBtX2NvbnRlbnRDb25uZWN0aW9uLmdldCgpLCB0aGlzLT5pZGVudGlmaWVyKCksIGZldGNo SWRlbnRpZmllciwgc2VydmljZVdvcmtlcklkZW50aWZpZXIsIHJlcXVlc3QsIG9wdGlvbnMsIGZv cm1EYXRhLCByZWZlcnJlcik7CisgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8V2ViU1dTZXJ2 ZXJUb0NvbnRleHRDb25uZWN0aW9uJj4oKmNvbnRleHRDb25uZWN0aW9uKS5zdGFydEZldGNoKHNl c3Npb25JRCgpLCBtX2NvbnRlbnRDb25uZWN0aW9uLmdldCgpLCB0aGlzLT5pZGVudGlmaWVyKCks IGZldGNoSWRlbnRpZmllciwgc2VydmljZVdvcmtlcklkZW50aWZpZXIsIHJlcXVlc3QsIG9wdGlv bnMsIGZvcm1EYXRhLCByZWZlcnJlcik7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAg ICAgICAgIFNXU0VSVkVSQ09OTkVDVElPTl9SRUxFQVNFX0xPR19FUlJPUl9JRl9BTExPV0VEKCJz dGFydEZldGNoOiBmZXRjaElkZW50aWZpZXI6ICVzIERpZE5vdEhhbmRsZSBiZWNhdXNlIGZhaWxl ZCB0byBydW4gc2VydmljZSB3b3JrZXIiLCBmZXRjaElkZW50aWZpZXIubG9nZ2luZ1N0cmluZygp LnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICAgICAgICAgIG1fY29udGVudENvbm5lY3Rpb24tPnNl bmQoTWVzc2FnZXM6OlNlcnZpY2VXb3JrZXJDbGllbnRGZXRjaDo6RGlkTm90SGFuZGxlIHsgfSwg ZmV0Y2hJZGVudGlmaWVyKTsKQEAgLTM1Nyw2ICszNTYsMTEgQEAgdm9pZCBXZWJTV1NlcnZlckNv bm5lY3Rpb246OnN5bmNUZXJtaW5hdGVXb3JrZXJGcm9tQ2xpZW50KFdlYkNvcmU6OlNlcnZpY2VX b3JrZXIKICAgICBzeW5jVGVybWluYXRlV29ya2VyKFdURk1vdmUoaWRlbnRpZmllcikpOwogICAg IGNvbXBsZXRpb25IYW5kbGVyKCk7CiB9CisKK1BBTDo6U2Vzc2lvbklEIFdlYlNXU2VydmVyQ29u bmVjdGlvbjo6c2Vzc2lvbklEKCkgY29uc3QKK3sKKyAgICByZXR1cm4gc2VydmVyKCkuc2Vzc2lv bklEKCk7Cit9CiAgICAgCiB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiB2b2lkIFdlYlNXU2VydmVyQ29u bmVjdGlvbjo6c2VuZFRvQ29udGV4dFByb2Nlc3MoV2ViQ29yZTo6U1dTZXJ2ZXJUb0NvbnRleHRD b25uZWN0aW9uJiBjb25uZWN0aW9uLCBVJiYgbWVzc2FnZSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlckNvbm5lY3Rp b24uaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1Nl cnZlckNvbm5lY3Rpb24uaAppbmRleCAxMGU0NDJlOTI1NTBjZTEzN2EyODlkMTllNGVlZTQwNDJh ZmIxMDI2Li44Y2Q0OTVjMWM5MGM3MTdkODNkZGY3YjNmMTNmNjUxZGJlYTZmZDI4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2 ZXJDb25uZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNl V29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5oCkBAIC01NCw3ICs1NCw3IEBAIGNsYXNzIE5l dHdvcmtQcm9jZXNzOwogCiBjbGFzcyBXZWJTV1NlcnZlckNvbm5lY3Rpb24gOiBwdWJsaWMgV2Vi Q29yZTo6U1dTZXJ2ZXI6OkNvbm5lY3Rpb24sIHB1YmxpYyBJUEM6Ok1lc3NhZ2VTZW5kZXIsIHB1 YmxpYyBJUEM6Ok1lc3NhZ2VSZWNlaXZlciB7CiBwdWJsaWM6Ci0gICAgV2ViU1dTZXJ2ZXJDb25u ZWN0aW9uKE5ldHdvcmtQcm9jZXNzJiwgV2ViQ29yZTo6U1dTZXJ2ZXImLCBJUEM6OkNvbm5lY3Rp b24mLCBXZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllciwgUEFMOjpTZXNzaW9uSUQpOworICAgIFdl YlNXU2VydmVyQ29ubmVjdGlvbihOZXR3b3JrUHJvY2VzcyYsIFdlYkNvcmU6OlNXU2VydmVyJiwg SVBDOjpDb25uZWN0aW9uJiwgV2ViQ29yZTo6UHJvY2Vzc0lkZW50aWZpZXIpOwogICAgIFdlYlNX U2VydmVyQ29ubmVjdGlvbihjb25zdCBXZWJTV1NlcnZlckNvbm5lY3Rpb24mKSA9IGRlbGV0ZTsK ICAgICB+V2ViU1dTZXJ2ZXJDb25uZWN0aW9uKCkgZmluYWw7CiAKQEAgLTYyLDggKzYyLDggQEAg cHVibGljOgogCiAgICAgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24mLCBJ UEM6OkRlY29kZXImKSBmaW5hbDsKICAgICB2b2lkIGRpZFJlY2VpdmVTeW5jTWVzc2FnZShJUEM6 OkNvbm5lY3Rpb24mLCBJUEM6OkRlY29kZXImLCBzdGQ6OnVuaXF1ZV9wdHI8SVBDOjpFbmNvZGVy PiYpOwotCi0gICAgUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklEKCkgY29uc3QgeyByZXR1cm4gbV9z ZXNzaW9uSUQ7IH0KKyAgICAKKyAgICBQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQoKSBjb25zdDsK IAogcHJpdmF0ZToKICAgICAvLyBJbXBsZW1lbnQgU1dTZXJ2ZXI6OkNvbm5lY3Rpb24gKE1lc3Nh Z2VzIHRvIHRoZSBjbGllbnQgV2ViUHJvY2VzcykKQEAgLTEwOSw3ICsxMDksNiBAQCBwcml2YXRl OgogICAgIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IHN0YXRpYyB2b2lkIHNlbmRUb0NvbnRl eHRQcm9jZXNzKFdlYkNvcmU6OlNXU2VydmVyVG9Db250ZXh0Q29ubmVjdGlvbiYsIFUmJiBtZXNz YWdlKTsKIAotICAgIFBBTDo6U2Vzc2lvbklEIG1fc2Vzc2lvbklEOwogICAgIFJlZjxJUEM6OkNv bm5lY3Rpb24+IG1fY29udGVudENvbm5lY3Rpb247CiAgICAgUmVmPE5ldHdvcmtQcm9jZXNzPiBt X25ldHdvcmtQcm9jZXNzOwogICAgIEhhc2hNYXA8V2ViQ29yZTo6U2VydmljZVdvcmtlckNsaWVu dElkZW50aWZpZXIsIFdlYkNvcmU6OkNsaWVudE9yaWdpbj4gbV9jbGllbnRPcmlnaW5zOwo=