201870 2019-09-17 06:02:04 -0700 [GStreamer] isAVC1CodecSupported is crashing several media source tests due to avc1.4d4001 codec type 2019-09-23 03:31:32 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply calvaris cgarcia commit-queue ews-watchlist gustavo menard pnormand vjaquez oldest_to_newest 1571511 0 cturner 2019-09-17 06:02:04 -0700 GStreamerRegistryScanner::isAVC1CodecSupported is a little sloppy not checking NULL returns from the gst_codec_utils* family which is causing the crashes. But there's a deeper problem, the NULL return is for when the h264 codec utility thinks there's an erroneous input. Particularly, it doesn't like the level_idc in the SPS for avc1.4D4001. There's nothing wrong with that according to the spec, so there's two bugs, 1. Fix the sloppy NULL checking in WebKit 2. Fix GStreamer to correctly parse the level_idc 1571528 1 378962 cturner 2019-09-17 07:30:05 -0700 Created attachment 378962 Patch 1571530 2 cturner 2019-09-17 07:30:57 -0700 I am mistaken about point 2. In fact, the web tests are doing some weird encoding level idc's with multiplying by 10. The GStreamer function is expecting the correct things, so we have to special case here for test conformance. 1571865 3 378962 calvaris 2019-09-18 02:44:13 -0700 Comment on attachment 378962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378962&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:322 > + char levelAsStringFallback[2] = { '\0', '\0' }; This is a bit too tricky so I would recommend adding a with this bug number to enable a very quick access to the info. 1572181 4 pnormand 2019-09-18 18:16:55 -0700 Instead of a bug link I would suggest an explanation similar to the one present in the ChangeLog (or copy/paste :)) because when ChangeLogs roll-over, keeping track of the code change reasoning becomes harder. 1573248 5 379359 cturner 2019-09-23 00:48:51 -0700 Created attachment 379359 Patch for landing 1573249 6 379359 commit-queue 2019-09-23 00:51:04 -0700 Comment on attachment 379359 Patch for landing Rejecting attachment 379359 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 379359, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13059974 1573261 7 379361 cturner 2019-09-23 02:45:08 -0700 Created attachment 379361 Patch for landing 1573269 8 379361 commit-queue 2019-09-23 03:31:30 -0700 Comment on attachment 379361 Patch for landing Clearing flags on attachment: 379361 Committed r250227: <https://trac.webkit.org/changeset/250227> 1573270 9 commit-queue 2019-09-23 03:31:32 -0700 All reviewed patches have been landed. Closing bug. 378962 2019-09-17 07:30:05 -0700 2019-09-23 00:48:47 -0700 Patch bug-201870-20190917153004.patch text/plain 3252 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjE4NDU2MmYzZTAw NDQ1NGJjMGM4ZDEyMTNlMDE3N2EzOWUwMS4uNjExYTIxYzhjMmI0YzdiMmUxNmFmY2RhM2UzZTJm ZGQ1NDBiNzE2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDE5LTA5LTE3ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBp c0FWQzFDb2RlY1N1cHBvcnRlZCBpcyBjcmFzaGluZyBzZXZlcmFsIG1lZGlhIHNvdXJjZSB0ZXN0 cyBkdWUgdG8gYXZjMS40ZDQwMDEgY29kZWMgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxODcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEdTdHJlYW1lciBjb2RlYy11dGlscyBwYWNrYWdl IGV4cGVjdHMgYWxsIGxldmVsX2lkYydzIHRvIGJlCisgICAgICAgIG11bHRpcGxlcyBvZiAxMCBm cm9tIHRoZSBzcGVjIGlkYywgaS5lLiwgMS4xIC0+IDExLCAzLjEgLT4gMzEsIDEKKyAgICAgICAg LT4gMTAsIGV0Yy4KKworICAgICAgICBJbiB0aGUgV1BUIHRlc3RzLCB0aGVyZSBpcyBzb21lIGNv bmZ1c2lvbiBvZiB0aGlzICoxMCBtdWx0aXBsaWVyLAorICAgICAgICBhbmQgdGhlIGxldmVsX2lk YyBpcyBnaXZlbiBpbiBzZXZlcmFsIHBsYWNlcyBhcyBzaW1wbHkgIjEiLiBUaGlzCisgICAgICAg IGNhdXNlcyB0aGUgZ2V0X2xldmVsIGNvZGVjIGhlbHBlciB0byByZXR1cm4gTlVMTCwgd2hpY2gg dGhlCisgICAgICAgIHJlZ2lzdHJ5IHNjYW5uZXIgd2FzIG5vdCBoYW5kbGluZyBwcm9wZXJseSwg YW5kIGNyYXNoaW5nIG9uLgorCisgICAgICAgIEZpeCB0aGlzIGJ5IHNwZWNpYWwgY2FzaW5nICJ3 ZWIgbGV2ZWwgaWRjJ3MiIHRoYXQgdmlvbGF0ZSB0aGUgKjEwCisgICAgICAgIHJ1bGUgaW4gaXNB VkMxQ29kZWNTdXBwb3J0ZWQuCisKKyAgICAgICAgVGhlcmUgaXMgcHJpb3IgYXJ0IGFsb25nIHRo ZXNlIGxpbmVzIGluIEdlY2tvOgorICAgICAgICBodHRwczovL3NlYXJjaGZveC5vcmcvbW96aWxs YS1jZW50cmFsL3NvdXJjZS9kb20vbWVkaWEvVmlkZW9VdGlscy5jcHAjNDUzCisgICAgICAgIEkg YXNzdW1lIENocm9tZS9JRS9ldGMgbXVzdCBkbyBzb21ldGhpbmcgc2ltaWxhci4gVGhlIGZpeCBk b2VzIG5vdAorICAgICAgICBiZWxvbmcgaW4gR1N0cmVhbWVyIHNpbmNlIHRoZXNlIGFyZSBhY3R1 YWxseSBpbnZhbGlkIGlucHV0cyB0byB0aGUKKyAgICAgICAgZ2V0X2xldmVsIGZ1bmN0aW9uLgor CisgICAgICAgIFRlc3RlZCBieSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlh LXNvdXJjZQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1l clJlZ2lzdHJ5U2Nhbm5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJSZWdpc3Ry eVNjYW5uZXI6OmlzQVZDMUNvZGVjU3VwcG9ydGVkIGNvbnN0KToKKyAgICAgICAgU3BlY2lhbCBj YXNlIGxldmVscyAxLi41LCBldmVuIHRob3VnaCB0aGVzZSAqc2hvdWxkKiBiZQorICAgICAgICBy ZXByZXNlbnRlZCBhcyAxMCB0aHJvdWdoIDUwIHJlc3BlY3RpdmVseSwgdGhleSBhcmUgbm90IGlu CisgICAgICAgIHdlYi1sYW5kLiBUaGUgdHdvLWJ5dGUgbG9jYWwgc3RvcmFnZSB0cmljayB3YXMg Y29udHJpYnV0ZWQgdG8gbWUKKyAgICAgICAgYnkgQWRyaWFuIFBlcmV6IGRlIENhc3Ryby4KKwog MjAxOS0wOS0xNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM RkNdW0JGQ10gQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmluRmxvd05vblJlcGxh Y2VkSGVpZ2h0QW5kTWFyZ2luIHNob3VsZCBub3QgcmVhZCBjb250YWluaW5nIGJsb2NrJ3Mgd2lk dGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9HU3RyZWFtZXJSZWdpc3RyeVNjYW5uZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHAKaW5kZXggODQ4 NzBjY2M5OWFkMjMzMTU2MTZhNjE1OTFhZjg0NTIxMjU2NWIzZi4uMWViYWNmMjE5MGRiNmNmNTNh Yzc0NTY1MDg5NGRmZTdjMzQ1MzJjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lz dHJ5U2Nhbm5lci5jcHAKQEAgLTMxOCw2ICszMTgsMTggQEAgYm9vbCBHU3RyZWFtZXJSZWdpc3Ry eVNjYW5uZXI6OmlzQVZDMUNvZGVjU3VwcG9ydGVkKGNvbnN0IFN0cmluZyYgY29kZWMsIGJvb2wg c2gKIAogICAgIGNvbnN0IGNoYXIqIHByb2ZpbGUgPSBnc3RfY29kZWNfdXRpbHNfaDI2NF9nZXRf cHJvZmlsZShzcHMsIDMpOwogICAgIGNvbnN0IGNoYXIqIGxldmVsID0gZ3N0X2NvZGVjX3V0aWxz X2gyNjRfZ2V0X2xldmVsKHNwcywgMyk7CisKKyAgICBjaGFyIGxldmVsQXNTdHJpbmdGYWxsYmFj a1syXSA9IHsgJ1wwJywgJ1wwJyB9OworICAgIGlmICghbGV2ZWwgJiYgc3BzWzJdID4gMCAmJiBz cHNbMl0gPD0gNSkgeworICAgICAgICBsZXZlbEFzU3RyaW5nRmFsbGJhY2tbMF0gPSBzdGF0aWNf Y2FzdDxjaGFyPignMCcgKyBzcHNbMl0pOworICAgICAgICBsZXZlbCA9IGxldmVsQXNTdHJpbmdG YWxsYmFjazsKKyAgICB9CisKKyAgICBpZiAoIXByb2ZpbGUgfHwgIWxldmVsKSB7CisgICAgICAg IEdTVF9FUlJPUigiSC4yNjQgcHJvZmlsZSAvIGxldmVsIHdhcyBub3QgcmVjb2duaXNlZCBpbiBj b2RlYyAlcyIsIGNvZGVjLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgfQorCiAgICAgR1NUX0RFQlVHKCJDb2RlYyAlcyB0cmFuc2xhdGVzIHRvIEguMjY0IHByb2Zp bGUgJXMgYW5kIGxldmVsICVzIiwgY29kZWMudXRmOCgpLmRhdGEoKSwgcHJvZmlsZSwgbGV2ZWwp OwogCiAgICAgYXV0byBjaGVja0gyNjRDYXBzID0gWyZdKGNvbnN0IGNoYXIqIGNhcHNTdHJpbmcp IHsK 379359 2019-09-23 00:48:51 -0700 2019-09-23 02:45:04 -0700 Patch for landing bug-201870-20190923084850.patch text/plain 3434 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjE4NDU2MmYzZTAw NDQ1NGJjMGM4ZDEyMTNlMDE3N2EzOWUwMS4uNjExYTIxYzhjMmI0YzdiMmUxNmFmY2RhM2UzZTJm ZGQ1NDBiNzE2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDE5LTA5LTE3ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBp c0FWQzFDb2RlY1N1cHBvcnRlZCBpcyBjcmFzaGluZyBzZXZlcmFsIG1lZGlhIHNvdXJjZSB0ZXN0 cyBkdWUgdG8gYXZjMS40ZDQwMDEgY29kZWMgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxODcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEdTdHJlYW1lciBjb2RlYy11dGlscyBwYWNrYWdl IGV4cGVjdHMgYWxsIGxldmVsX2lkYydzIHRvIGJlCisgICAgICAgIG11bHRpcGxlcyBvZiAxMCBm cm9tIHRoZSBzcGVjIGlkYywgaS5lLiwgMS4xIC0+IDExLCAzLjEgLT4gMzEsIDEKKyAgICAgICAg LT4gMTAsIGV0Yy4KKworICAgICAgICBJbiB0aGUgV1BUIHRlc3RzLCB0aGVyZSBpcyBzb21lIGNv bmZ1c2lvbiBvZiB0aGlzICoxMCBtdWx0aXBsaWVyLAorICAgICAgICBhbmQgdGhlIGxldmVsX2lk YyBpcyBnaXZlbiBpbiBzZXZlcmFsIHBsYWNlcyBhcyBzaW1wbHkgIjEiLiBUaGlzCisgICAgICAg IGNhdXNlcyB0aGUgZ2V0X2xldmVsIGNvZGVjIGhlbHBlciB0byByZXR1cm4gTlVMTCwgd2hpY2gg dGhlCisgICAgICAgIHJlZ2lzdHJ5IHNjYW5uZXIgd2FzIG5vdCBoYW5kbGluZyBwcm9wZXJseSwg YW5kIGNyYXNoaW5nIG9uLgorCisgICAgICAgIEZpeCB0aGlzIGJ5IHNwZWNpYWwgY2FzaW5nICJ3 ZWIgbGV2ZWwgaWRjJ3MiIHRoYXQgdmlvbGF0ZSB0aGUgKjEwCisgICAgICAgIHJ1bGUgaW4gaXNB VkMxQ29kZWNTdXBwb3J0ZWQuCisKKyAgICAgICAgVGhlcmUgaXMgcHJpb3IgYXJ0IGFsb25nIHRo ZXNlIGxpbmVzIGluIEdlY2tvOgorICAgICAgICBodHRwczovL3NlYXJjaGZveC5vcmcvbW96aWxs YS1jZW50cmFsL3NvdXJjZS9kb20vbWVkaWEvVmlkZW9VdGlscy5jcHAjNDUzCisgICAgICAgIEkg YXNzdW1lIENocm9tZS9JRS9ldGMgbXVzdCBkbyBzb21ldGhpbmcgc2ltaWxhci4gVGhlIGZpeCBk b2VzIG5vdAorICAgICAgICBiZWxvbmcgaW4gR1N0cmVhbWVyIHNpbmNlIHRoZXNlIGFyZSBhY3R1 YWxseSBpbnZhbGlkIGlucHV0cyB0byB0aGUKKyAgICAgICAgZ2V0X2xldmVsIGZ1bmN0aW9uLgor CisgICAgICAgIFRlc3RlZCBieSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlh LXNvdXJjZQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1l clJlZ2lzdHJ5U2Nhbm5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJSZWdpc3Ry eVNjYW5uZXI6OmlzQVZDMUNvZGVjU3VwcG9ydGVkIGNvbnN0KToKKyAgICAgICAgU3BlY2lhbCBj YXNlIGxldmVscyAxLi41LCBldmVuIHRob3VnaCB0aGVzZSAqc2hvdWxkKiBiZQorICAgICAgICBy ZXByZXNlbnRlZCBhcyAxMCB0aHJvdWdoIDUwIHJlc3BlY3RpdmVseSwgdGhleSBhcmUgbm90IGlu CisgICAgICAgIHdlYi1sYW5kLiBUaGUgdHdvLWJ5dGUgbG9jYWwgc3RvcmFnZSB0cmljayB3YXMg Y29udHJpYnV0ZWQgdG8gbWUKKyAgICAgICAgYnkgQWRyaWFuIFBlcmV6IGRlIENhc3Ryby4KKwog MjAxOS0wOS0xNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM RkNdW0JGQ10gQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmluRmxvd05vblJlcGxh Y2VkSGVpZ2h0QW5kTWFyZ2luIHNob3VsZCBub3QgcmVhZCBjb250YWluaW5nIGJsb2NrJ3Mgd2lk dGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9HU3RyZWFtZXJSZWdpc3RyeVNjYW5uZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHAKaW5kZXggODQ4 NzBjY2M5OWFkMjMzMTU2MTZhNjE1OTFhZjg0NTIxMjU2NWIzZi4uMWFmY2ZmMGQ4MWM0MWU5NTYx MjAzODY3YjFhZTEwZjcxOTM1YTJkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lz dHJ5U2Nhbm5lci5jcHAKQEAgLTMxOCw2ICszMTgsMjEgQEAgYm9vbCBHU3RyZWFtZXJSZWdpc3Ry eVNjYW5uZXI6OmlzQVZDMUNvZGVjU3VwcG9ydGVkKGNvbnN0IFN0cmluZyYgY29kZWMsIGJvb2wg c2gKIAogICAgIGNvbnN0IGNoYXIqIHByb2ZpbGUgPSBnc3RfY29kZWNfdXRpbHNfaDI2NF9nZXRf cHJvZmlsZShzcHMsIDMpOwogICAgIGNvbnN0IGNoYXIqIGxldmVsID0gZ3N0X2NvZGVjX3V0aWxz X2gyNjRfZ2V0X2xldmVsKHNwcywgMyk7CisKKyAgICAvLyBUbyBhdm9pZCBnb2luZyB0aHJvdWdo IGEgY2xhc3MgaGllcmFyY2h5IGZvciBzdWNoIGEgc2ltcGxlCisgICAgLy8gc3RyaW5nIGNvbnZl cnNpb24sIHdlIHVzZSBhIGxpdHRsZSB0cmljayBoZXJlOiBTZWUKKyAgICAvLyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxODcwLgorICAgIGNoYXIgbGV2ZWxBc1N0 cmluZ0ZhbGxiYWNrWzJdID0geyAnXDAnLCAnXDAnIH07CisgICAgaWYgKCFsZXZlbCAmJiBzcHNb Ml0gPiAwICYmIHNwc1syXSA8PSA1KSB7CisgICAgICAgIGxldmVsQXNTdHJpbmdGYWxsYmFja1sw XSA9IHN0YXRpY19jYXN0PGNoYXI+KCcwJyArIHNwc1syXSk7CisgICAgICAgIGxldmVsID0gbGV2 ZWxBc1N0cmluZ0ZhbGxiYWNrOworICAgIH0KKworICAgIGlmICghcHJvZmlsZSB8fCAhbGV2ZWwp IHsKKyAgICAgICAgR1NUX0VSUk9SKCJILjI2NCBwcm9maWxlIC8gbGV2ZWwgd2FzIG5vdCByZWNv Z25pc2VkIGluIGNvZGVjICVzIiwgY29kZWMudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICB9CisKICAgICBHU1RfREVCVUcoIkNvZGVjICVzIHRyYW5zbGF0ZXMgdG8g SC4yNjQgcHJvZmlsZSAlcyBhbmQgbGV2ZWwgJXMiLCBjb2RlYy51dGY4KCkuZGF0YSgpLCBwcm9m aWxlLCBsZXZlbCk7CiAKICAgICBhdXRvIGNoZWNrSDI2NENhcHMgPSBbJl0oY29uc3QgY2hhciog Y2Fwc1N0cmluZykgewo= 379361 2019-09-23 02:45:08 -0700 2019-09-23 03:31:30 -0700 Patch for landing bug-201870-20190923104507.patch text/plain 3443 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjE4NDU2MmYzZTAw NDQ1NGJjMGM4ZDEyMTNlMDE3N2EzOWUwMS4uNTY3YmRjMWIxOWFjOTNkMWVhMzZmYzU5Mzk1NWU5 MDAyMzM1MDVlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDE5LTA5LTE3ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBp c0FWQzFDb2RlY1N1cHBvcnRlZCBpcyBjcmFzaGluZyBzZXZlcmFsIG1lZGlhIHNvdXJjZSB0ZXN0 cyBkdWUgdG8gYXZjMS40ZDQwMDEgY29kZWMgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxODcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWGFi aWVyIFJvZHJpZ3Vlei1DYWx2YXIuCisKKyAgICAgICAgVGhlIEdTdHJlYW1lciBjb2RlYy11dGls cyBwYWNrYWdlIGV4cGVjdHMgYWxsIGxldmVsX2lkYydzIHRvIGJlCisgICAgICAgIG11bHRpcGxl cyBvZiAxMCBmcm9tIHRoZSBzcGVjIGlkYywgaS5lLiwgMS4xIC0+IDExLCAzLjEgLT4gMzEsIDEK KyAgICAgICAgLT4gMTAsIGV0Yy4KKworICAgICAgICBJbiB0aGUgV1BUIHRlc3RzLCB0aGVyZSBp cyBzb21lIGNvbmZ1c2lvbiBvZiB0aGlzICoxMCBtdWx0aXBsaWVyLAorICAgICAgICBhbmQgdGhl IGxldmVsX2lkYyBpcyBnaXZlbiBpbiBzZXZlcmFsIHBsYWNlcyBhcyBzaW1wbHkgIjEiLiBUaGlz CisgICAgICAgIGNhdXNlcyB0aGUgZ2V0X2xldmVsIGNvZGVjIGhlbHBlciB0byByZXR1cm4gTlVM TCwgd2hpY2ggdGhlCisgICAgICAgIHJlZ2lzdHJ5IHNjYW5uZXIgd2FzIG5vdCBoYW5kbGluZyBw cm9wZXJseSwgYW5kIGNyYXNoaW5nIG9uLgorCisgICAgICAgIEZpeCB0aGlzIGJ5IHNwZWNpYWwg Y2FzaW5nICJ3ZWIgbGV2ZWwgaWRjJ3MiIHRoYXQgdmlvbGF0ZSB0aGUgKjEwCisgICAgICAgIHJ1 bGUgaW4gaXNBVkMxQ29kZWNTdXBwb3J0ZWQuCisKKyAgICAgICAgVGhlcmUgaXMgcHJpb3IgYXJ0 IGFsb25nIHRoZXNlIGxpbmVzIGluIEdlY2tvOgorICAgICAgICBodHRwczovL3NlYXJjaGZveC5v cmcvbW96aWxsYS1jZW50cmFsL3NvdXJjZS9kb20vbWVkaWEvVmlkZW9VdGlscy5jcHAjNDUzCisg ICAgICAgIEkgYXNzdW1lIENocm9tZS9JRS9ldGMgbXVzdCBkbyBzb21ldGhpbmcgc2ltaWxhci4g VGhlIGZpeCBkb2VzIG5vdAorICAgICAgICBiZWxvbmcgaW4gR1N0cmVhbWVyIHNpbmNlIHRoZXNl IGFyZSBhY3R1YWxseSBpbnZhbGlkIGlucHV0cyB0byB0aGUKKyAgICAgICAgZ2V0X2xldmVsIGZ1 bmN0aW9uLgorCisgICAgICAgIFRlc3RlZCBieSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL21lZGlhLXNvdXJjZQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFt ZXJSZWdpc3RyeVNjYW5uZXI6OmlzQVZDMUNvZGVjU3VwcG9ydGVkIGNvbnN0KToKKyAgICAgICAg U3BlY2lhbCBjYXNlIGxldmVscyAxLi41LCBldmVuIHRob3VnaCB0aGVzZSAqc2hvdWxkKiBiZQor ICAgICAgICByZXByZXNlbnRlZCBhcyAxMCB0aHJvdWdoIDUwIHJlc3BlY3RpdmVseSwgdGhleSBh cmUgbm90IGluCisgICAgICAgIHdlYi1sYW5kLiBUaGUgdHdvLWJ5dGUgbG9jYWwgc3RvcmFnZSB0 cmljayB3YXMgY29udHJpYnV0ZWQgdG8gbWUKKyAgICAgICAgYnkgQWRyaWFuIFBlcmV6IGRlIENh c3Ryby4KKwogMjAxOS0wOS0xNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtMRkNdW0JGQ10gQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmluRmxv d05vblJlcGxhY2VkSGVpZ2h0QW5kTWFyZ2luIHNob3VsZCBub3QgcmVhZCBjb250YWluaW5nIGJs b2NrJ3Mgd2lkdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9HU3RyZWFtZXJSZWdpc3RyeVNjYW5uZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHAK aW5kZXggODQ4NzBjY2M5OWFkMjMzMTU2MTZhNjE1OTFhZjg0NTIxMjU2NWIzZi4uMWFmY2ZmMGQ4 MWM0MWU5NTYxMjAzODY3YjFhZTEwZjcxOTM1YTJkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclJlZ2lzdHJ5U2Nhbm5lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJl YW1lclJlZ2lzdHJ5U2Nhbm5lci5jcHAKQEAgLTMxOCw2ICszMTgsMjEgQEAgYm9vbCBHU3RyZWFt ZXJSZWdpc3RyeVNjYW5uZXI6OmlzQVZDMUNvZGVjU3VwcG9ydGVkKGNvbnN0IFN0cmluZyYgY29k ZWMsIGJvb2wgc2gKIAogICAgIGNvbnN0IGNoYXIqIHByb2ZpbGUgPSBnc3RfY29kZWNfdXRpbHNf aDI2NF9nZXRfcHJvZmlsZShzcHMsIDMpOwogICAgIGNvbnN0IGNoYXIqIGxldmVsID0gZ3N0X2Nv ZGVjX3V0aWxzX2gyNjRfZ2V0X2xldmVsKHNwcywgMyk7CisKKyAgICAvLyBUbyBhdm9pZCBnb2lu ZyB0aHJvdWdoIGEgY2xhc3MgaGllcmFyY2h5IGZvciBzdWNoIGEgc2ltcGxlCisgICAgLy8gc3Ry aW5nIGNvbnZlcnNpb24sIHdlIHVzZSBhIGxpdHRsZSB0cmljayBoZXJlOiBTZWUKKyAgICAvLyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxODcwLgorICAgIGNoYXIg bGV2ZWxBc1N0cmluZ0ZhbGxiYWNrWzJdID0geyAnXDAnLCAnXDAnIH07CisgICAgaWYgKCFsZXZl bCAmJiBzcHNbMl0gPiAwICYmIHNwc1syXSA8PSA1KSB7CisgICAgICAgIGxldmVsQXNTdHJpbmdG YWxsYmFja1swXSA9IHN0YXRpY19jYXN0PGNoYXI+KCcwJyArIHNwc1syXSk7CisgICAgICAgIGxl dmVsID0gbGV2ZWxBc1N0cmluZ0ZhbGxiYWNrOworICAgIH0KKworICAgIGlmICghcHJvZmlsZSB8 fCAhbGV2ZWwpIHsKKyAgICAgICAgR1NUX0VSUk9SKCJILjI2NCBwcm9maWxlIC8gbGV2ZWwgd2Fz IG5vdCByZWNvZ25pc2VkIGluIGNvZGVjICVzIiwgY29kZWMudXRmOCgpLmRhdGEoKSk7CisgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKICAgICBHU1RfREVCVUcoIkNvZGVjICVzIHRyYW5z bGF0ZXMgdG8gSC4yNjQgcHJvZmlsZSAlcyBhbmQgbGV2ZWwgJXMiLCBjb2RlYy51dGY4KCkuZGF0 YSgpLCBwcm9maWxlLCBsZXZlbCk7CiAKICAgICBhdXRvIGNoZWNrSDI2NENhcHMgPSBbJl0oY29u c3QgY2hhciogY2Fwc1N0cmluZykgewo=