201818 2019-09-16 06:19:05 -0700 check-webkit-style: Fix warning message for std::make_unique<typename[]> 2019-09-16 10:44:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200878 https://bugs.webkit.org/show_bug.cgi?id=201804 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin ews-watchlist glenn ross.kirsling webkit-bug-importer ysuzuki oldest_to_newest 1571075 0 ddkilzer 2019-09-16 06:19:05 -0700 Fix warning message for std::make_unique<_typename_[]> in check-webkit-style. When writing the patch for Bug 201804, it was not clear from check-webkit-style output that I hand to switch from std::make_unique<uint32_t[]>(size) to WTF::makeUniqueArray<uint32_t>(size). 1571076 1 webkit-bug-importer 2019-09-16 06:19:22 -0700 <rdar://problem/55397921> 1571077 2 378857 ddkilzer 2019-09-16 06:36:10 -0700 Created attachment 378857 Patch v1 1571125 3 ddkilzer 2019-09-16 09:32:31 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Created attachment 378857 [details] > Patch v1 This patch can't possibly affect ios-wk2 tests. Looks like that failure was caused by a flaky test. 1571172 4 378857 commit-queue 2019-09-16 10:44:55 -0700 Comment on attachment 378857 Patch v1 Clearing flags on attachment: 378857 Committed r249906: <https://trac.webkit.org/changeset/249906> 1571173 5 commit-queue 2019-09-16 10:44:56 -0700 All reviewed patches have been landed. Closing bug. 378857 2019-09-16 06:36:10 -0700 2019-09-16 10:44:55 -0700 Patch v1 bug-201818-20190916063744.patch text/plain 4583 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjQ2N2JjNzg4NzNjZjhiNzgxNWJjZDljNjVlM2JkYTc1 NGU5ZGIzYi4uNWVlNjQwNGE3ODZiMTRhZDBiNzE5OGU5YWU4OTllMWJjYTMzNmMyMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTA5LTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBGaXggd2FybmluZyBtZXNzYWdlIGZvciBzdGQ6Om1h a2VfdW5pcXVlPHR5cGVuYW1lW10+CisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMDE4 MTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3d0 Zl9tYWtlX3VuaXF1ZSk6IEVtaXQgZGlmZmVyZW50IGVycm9yIG1lc3NhZ2Ugd2hlbiB1c2luZwor ICAgICAgICBzdGQ6Om1ha2VfdW5pcXVlPD4oKSB0byBjcmVhdGUgYW4gYXJyYXkuICBQZXJzb25h bGl6ZSB0aGUgZXJyb3IKKyAgICAgICAgbWVzc2FnZSBieSBpbmNsdWRpbmcgdGhlIG9yaWdpbmFs IHR5cGUgbmFtZSwgd2hpY2ggYWxzbworICAgICAgICBkZW1vbnN0cmF0ZXMgdGhhdCBXVEY6Om1h a2VVbmlxdWVBcnJheTw+KCkgZG9lcyBub3QgbmVlZCBzcXVhcmUKKyAgICAgICAgYnJhY2tldHMg Zm9yIGl0cyB0eXBlbmFtZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X3d0Zl9t YWtlX3VuaXF1ZSk6IEFkZCB0ZXN0LgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rfd3Rm X21ha2VfdW5pcXVlX2FycmF5KTogRGl0dG8uCisKIDIwMTktMDktMTUgIERhdmlkIEtpbHplciAg PGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggbGVha3MgaW4gRHVtcFJlbmRlclRy ZWUgYW5kIFdlYktpdFRlc3RSdW5uZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKaW5kZXggMWM0MzkxNjAxMzliMTViMjE2NzlhMGIxMWNlMmI1ZWVmN2Zm Yzc1Yy4uNTkxODYwZmQyODc0ODVhNjQyNWZhYzI1NTBhODQwMGFmNjY2YmQxYiAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTI0MTEsMTEgKzI0 MTEsMTggQEAgZGVmIGNoZWNrX3d0Zl9tYWtlX3VuaXF1ZShjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKIAogICAgIGxpbmUgPSBjbGVhbl9saW5lcy5lbGlkZWRb bGluZV9udW1iZXJdICAjIEdldCByaWQgb2YgY29tbWVudHMgYW5kIHN0cmluZ3MuCiAKLSAgICB1 c2luZ19zdGRfbWFrZV91bmlxdWUgPSBzZWFyY2gocidcYnN0ZDo6bWFrZV91bmlxdWVccypcPCcs IGxpbmUpCi0gICAgaWYgbm90IHVzaW5nX3N0ZF9tYWtlX3VuaXF1ZToKKyAgICB1c2luZ19zdGRf bWFrZV91bmlxdWVfc2VhcmNoID0gc2VhcmNoKHInXGJzdGQ6Om1ha2VfdW5pcXVlXHMqPChbXihd KyknLCBsaW5lKQorICAgIGlmIG5vdCB1c2luZ19zdGRfbWFrZV91bmlxdWVfc2VhcmNoOgogICAg ICAgICByZXR1cm4KIAotICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS93dGZfbWFrZV91 bmlxdWUnLCA0LCAiVXNlICdXVEY6Om1ha2VVbmlxdWU8PicgaW5zdGVhZCBvZiAnc3RkOjptYWtl X3VuaXF1ZTw+Jy4iKQorICAgIHR5cGVuYW1lID0gdXNpbmdfc3RkX21ha2VfdW5pcXVlX3NlYXJj aC5ncm91cCgxKS5zdHJpcCgpWzotMV0uc3RyaXAoKQorICAgIGlmIHR5cGVuYW1lLmVuZHN3aXRo KCdbXScpOgorICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3J1bnRpbWUvd3RmX21ha2VfdW5p cXVlJywgNCwKKyAgICAgICAgICAgICAgIlVzZSAnV1RGOjptYWtlVW5pcXVlQXJyYXk8e25ld190 eXBlbmFtZX0+JyBpbnN0ZWFkIG9mICdzdGQ6Om1ha2VfdW5pcXVlPHtvcmlnaW5hbF90eXBlbmFt ZX0+Jy4iLmZvcm1hdCgKKyAgICAgICAgICAgICAgICAgIG5ld190eXBlbmFtZT10eXBlbmFtZVs6 LTJdLCBvcmlnaW5hbF90eXBlbmFtZT10eXBlbmFtZSkpCisgICAgZWxzZToKKyAgICAgICAgZXJy b3IobGluZV9udW1iZXIsICdydW50aW1lL3d0Zl9tYWtlX3VuaXF1ZScsIDQsCisgICAgICAgICAg ICAgICJVc2UgJ1dURjo6bWFrZVVuaXF1ZTx7dHlwZW5hbWV9PicgaW5zdGVhZCBvZiAnc3RkOjpt YWtlX3VuaXF1ZTx7dHlwZW5hbWV9PicuIi5mb3JtYXQodHlwZW5hbWU9dHlwZW5hbWUpKQogCiAK IGRlZiBjaGVja19jdHlwZV9mdW5jdGlvbnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxl X3N0YXRlLCBlcnJvcik6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDczMTc5YWI3NDM0OGU1NTA2MWQ1ZDVjNDQ2 MTU0ZmRmNWZjYjVhNTUuLmU5NzBkNjUwZDQzYjhiN2RhMWUxZTVkMWI5M2I4N2Y3ZjE3MWM2OGMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5CkBAIC01MjE3LDYgKzUyMTcsNDIgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0 KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJyAgW3J1bnRpbWUvbWF4X21pbl9tYWNy b3NdIFs0XScsCiAgICAgICAgICAgICAnZm9vLmgnKQogCisgICAgZGVmIHRlc3Rfd3RmX21ha2Vf dW5pcXVlKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgICdz dGQ6OnVuaXF1ZV9wdHI8Rm9vPiBmb28gPSBXVEY6Om1ha2VVbmlxdWU8Rm9vPigpOycsCisgICAg ICAgICAgICAgJycsCisgICAgICAgICAgICAgJ2Zvby5jcHAnKQorCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoCisgICAgICAgICAgICAnc3RkOjp1bmlxdWVfcHRyPEZvbz4gZm9vID0gc3RkOjpt YWtlX3VuaXF1ZTxGb28+KCk7JywKKyAgICAgICAgICAgICJVc2UgJ1dURjo6bWFrZVVuaXF1ZTxG b28+JyBpbnN0ZWFkIG9mICdzdGQ6Om1ha2VfdW5pcXVlPEZvbz4nLiIKKyAgICAgICAgICAgICIg IFtydW50aW1lL3d0Zl9tYWtlX3VuaXF1ZV0gWzRdIiwKKyAgICAgICAgICAgICdmb28uY3BwJykK KworICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ3N0ZDo6dW5pcXVlX3B0 cjxGb28+IGZvbyA9IHN0ZDo6bWFrZV91bmlxdWU8Rm9vPigpOycsCisgICAgICAgICAgICAiVXNl ICdXVEY6Om1ha2VVbmlxdWU8Rm9vPicgaW5zdGVhZCBvZiAnc3RkOjptYWtlX3VuaXF1ZTxGb28+ Jy4iCisgICAgICAgICAgICAiICBbcnVudGltZS93dGZfbWFrZV91bmlxdWVdIFs0XSIsCisgICAg ICAgICAgICAnZm9vLm1tJykKKworICAgIGRlZiB0ZXN0X3d0Zl9tYWtlX3VuaXF1ZV9hcnJheShz ZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICAnV1RGOjpVbmlx dWVBcnJheTx1aW50MzJfdD4gYXJyYXkgPSBXVEY6Om1ha2VVbmlxdWVBcnJheTx1aW50MzJfdD4o MTApOycsCisgICAgICAgICAgICAgJycsCisgICAgICAgICAgICAgJ2Zvby5jcHAnKQorCisgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnc3RkOjp1bmlxdWVfcHRyPHVpbnQz Ml90W10+IGFycmF5ID0gc3RkOjptYWtlX3VuaXF1ZTx1aW50MzJfdFtdPigxMCk7JywKKyAgICAg ICAgICAgICJVc2UgJ1dURjo6bWFrZVVuaXF1ZUFycmF5PHVpbnQzMl90PicgaW5zdGVhZCBvZiAn c3RkOjptYWtlX3VuaXF1ZTx1aW50MzJfdFtdPicuIgorICAgICAgICAgICAgIiAgW3J1bnRpbWUv d3RmX21ha2VfdW5pcXVlXSBbNF0iLAorICAgICAgICAgICAgJ2Zvby5jcHAnKQorCisgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnc3RkOjp1bmlxdWVfcHRyPHVpbnQzMl90 W10+IGFycmF5ID0gc3RkOjptYWtlX3VuaXF1ZTx1aW50MzJfdFtdPigxMCk7JywKKyAgICAgICAg ICAgICJVc2UgJ1dURjo6bWFrZVVuaXF1ZUFycmF5PHVpbnQzMl90PicgaW5zdGVhZCBvZiAnc3Rk OjptYWtlX3VuaXF1ZTx1aW50MzJfdFtdPicuIgorICAgICAgICAgICAgIiAgW3J1bnRpbWUvd3Rm X21ha2VfdW5pcXVlXSBbNF0iLAorICAgICAgICAgICAgJ2Zvby5tbScpCisKICAgICBkZWYgdGVz dF93dGZfbW92ZShzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKICAgICAgICAgICAg ICAnQSBhID0gV1RGTW92ZShiKTsnLAo=