201812 2019-09-15 21:58:22 -0700 REGRESSION (r243113): Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate 2019-09-16 09:41:54 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195636 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue thorton timothy webkit-bug-importer oldest_to_newest 1571005 0 ddkilzer 2019-09-15 21:58:22 -0700 Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate. The _WKAttributedStringNavigationDelegate class is missing a -dealloc method under MRR. Regressed with: Bug 195636: Add new NSAttributedString API for converting HTML. <https://bugs.webkit.org/show_bug.cgi?id=195636> <https://trac.webkit.org/changeset/243113/webkit> 1571006 1 webkit-bug-importer 2019-09-15 21:58:39 -0700 <rdar://problem/55387394> 1571007 2 378838 ddkilzer 2019-09-15 22:02:06 -0700 Created attachment 378838 Patch v1 1571111 3 378838 timothy 2019-09-16 09:04:30 -0700 Comment on attachment 378838 Patch v1 Thanks! 1571133 4 378838 commit-queue 2019-09-16 09:41:53 -0700 Comment on attachment 378838 Patch v1 Clearing flags on attachment: 378838 Committed r249902: <https://trac.webkit.org/changeset/249902> 1571134 5 commit-queue 2019-09-16 09:41:54 -0700 All reviewed patches have been landed. Closing bug. 378838 2019-09-15 22:02:06 -0700 2019-09-16 09:41:53 -0700 Patch v1 bug-201812-20190915220337.patch text/plain 1877 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcwNWQ4NTUyZDIzMjJkODEx ZWFmZDBhNDVkZDVmYmU0Y2E4ZmI2MTcuLmU5NzdmMTdhN2M2NzhhNWI1NTE2YmM3ODVmMDI4MWYx Nzg5ZTQ5MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDktMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjQzMTEz KTogTGVhayBvZiBtdWx0aXBsZSBpbnN0YW5jZSB2YXJpYWJsZSBibG9ja3Mgd2hlbiBkZWFsbG9j YXRpbmcgX1dLQXR0cmlidXRlZFN0cmluZ05hdmlnYXRpb25EZWxlZ2F0ZQorICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMjAxODEyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9OU0F0dHJpYnV0ZWRTdHJp bmcubW06CisgICAgICAgICgtW19XS0F0dHJpYnV0ZWRTdHJpbmdOYXZpZ2F0aW9uRGVsZWdhdGUg ZGVhbGxvY10pOiBBZGQgbWV0aG9kCisgICAgICAgIHRvIHJlbGVhc2UgaW5zdGFuY2UgdmFyaWFi bGUgYmxvY2tzIHRvIGZpeCBwb3RlbnRpYWwgbGVha3MuCisKIDIwMTktMDktMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjQ4NTky KTogTGVhayBvZiBDRkRpY3Rpb25hcnlSZWYgaW4gV2ViS2l0OjpOZXR3b3JrUlRDUHJvdmlkZXI6 OnByb3h5SW5mb0Zyb21TZXNzaW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9OU0F0dHJpYnV0ZWRTdHJpbmcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvTlNBdHRyaWJ1dGVkU3RyaW5nLm1tCmluZGV4IDc4ZjVhM2EwYmE5NmZk YzljYzhlZTYwZGRkMTMwZmRlMWE5Y2JkMmEuLmQ1OGVjODFmYzljZmRkNDM0ZjMxMzIwYjJkM2M4 MDZmZDkxNzNlMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9OU0F0dHJpYnV0ZWRTdHJpbmcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL05TQXR0cmlidXRlZFN0cmluZy5tbQpAQCAtNjMsNiArNjMsMjIgQEAgQGVuZAogCiBA aW1wbGVtZW50YXRpb24gX1dLQXR0cmlidXRlZFN0cmluZ05hdmlnYXRpb25EZWxlZ2F0ZQogCist ICh2b2lkKWRlYWxsb2MKK3sKKyAgICBbX3dlYkNvbnRlbnRQcm9jZXNzRGlkVGVybWluYXRlIHJl bGVhc2VdOworICAgIF93ZWJDb250ZW50UHJvY2Vzc0RpZFRlcm1pbmF0ZSA9IG5pbDsKKyAgICBb X2RlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24gcmVsZWFzZV07CisgICAgX2RlY2lkZVBv bGljeUZvck5hdmlnYXRpb25BY3Rpb24gPSBuaWw7CisgICAgW19kaWRGYWlsUHJvdmlzaW9uYWxO YXZpZ2F0aW9uIHJlbGVhc2VdOworICAgIF9kaWRGYWlsUHJvdmlzaW9uYWxOYXZpZ2F0aW9uID0g bmlsOworICAgIFtfZGlkRmFpbE5hdmlnYXRpb24gcmVsZWFzZV07CisgICAgX2RpZEZhaWxOYXZp Z2F0aW9uID0gbmlsOworICAgIFtfZGlkRmluaXNoTmF2aWdhdGlvbiByZWxlYXNlXTsKKyAgICBf ZGlkRmluaXNoTmF2aWdhdGlvbiA9IG5pbDsKKworICAgIFtzdXBlciBkZWFsbG9jXTsKK30KKwog LSAodm9pZCl3ZWJWaWV3V2ViQ29udGVudFByb2Nlc3NEaWRUZXJtaW5hdGU6KFdLV2ViVmlldyAq KXdlYlZpZXcKIHsKICAgICBpZiAoX3dlYkNvbnRlbnRQcm9jZXNzRGlkVGVybWluYXRlKQo=