201811 2019-09-15 21:46:19 -0700 REGRESSION (r248592): Leak of CFDictionaryRef in WebKit::NetworkRTCProvider::proxyInfoFromSession() 2019-09-15 22:51:57 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200583 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1571001 0 ddkilzer 2019-09-15 21:46:19 -0700 Leak of CFDictionaryRef in WebKit::NetworkRTCProvider::proxyInfoFromSession(). Caused by: Bug 200583: User Agent and SessionID should be given to NetworkRTCProvider to set up the correct proxy information <https://bugs.webkit.org/show_bug.cgi?id=200583> <https://trac.webkit.org/changeset/248592/webkit> 1571002 1 webkit-bug-importer 2019-09-15 21:48:36 -0700 <rdar://problem/55387262> 1571003 2 webkit-bug-importer 2019-09-15 21:48:38 -0700 <rdar://problem/55387263> 1571004 3 378837 ddkilzer 2019-09-15 21:49:03 -0700 Created attachment 378837 Patch v1 1571025 4 378837 commit-queue 2019-09-15 22:51:56 -0700 Comment on attachment 378837 Patch v1 Clearing flags on attachment: 378837 Committed r249889: <https://trac.webkit.org/changeset/249889> 1571026 5 commit-queue 2019-09-15 22:51:57 -0700 All reviewed patches have been landed. Closing bug. 378837 2019-09-15 21:49:03 -0700 2019-09-15 22:51:56 -0700 Patch v1 bug-201811-20190915215034.patch text/plain 3336 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZlZGI3ZmVkOWRjMTM5ZTYx ZGM1MDIxNTgyMWI5ZGNlZGE2NWM0ZDIuLjcwNWQ4NTUyZDIzMjJkODExZWFmZDBhNDVkZDVmYmU0 Y2E4ZmI2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDktMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjQ4NTky KTogTGVhayBvZiBDRkRpY3Rpb25hcnlSZWYgaW4gV2ViS2l0OjpOZXR3b3JrUlRDUHJvdmlkZXI6 OnByb3h5SW5mb0Zyb21TZXNzaW9uKCkKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIw MTgxMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IE5ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIubW06CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6cHJveHlJbmZvRnJvbVNlc3Npb24pOiBVc2UKKyAg ICAgICAgUmV0YWluUHRyPD4gdG8gZml4IHRoZSBsZWFrLgorCiAyMDE5LTA5LTEzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQXV4aWxpYXJ5 UHJvY2Vzc1Byb3h5OjpzZW5kV2l0aEFzeW5jUmVwbHkgc2hvdWxkIHF1ZXVlIHVwIG1lc3NhZ2Vz IGlmIHNlbnQgd2hpbGUgdGhlIHByb2Nlc3MgaXMgc3RhcnRpbmcgbGlrZSBpdCBkb2VzIG1lc3Nh Z2VzIHdpdGhvdXQgcmVwbGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLm1tCmluZGV4IGY2NTZjYWU5MTMyM2M4 ZTJhOGUyNWQ2NDExNzY1ZGMyNTRkNGMyMDUuLjY0NDRkZTQ1ZDNjOTY0NjVmZGM1YWY0ZTgyYzdl NThkMDY5YzRjNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2Vi cnRjL05ldHdvcmtSVENQcm92aWRlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIubW0KQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNs dWRlIDxXZWJDb3JlL0xpYldlYlJUQ01hY3Jvcy5oPgogI2luY2x1ZGUgPHdlYnJ0Yy9ydGNfYmFz ZS9hc3luY3BhY2tldHNvY2tldC5oPgogI2luY2x1ZGUgPHdlYnJ0Yy9ydGNfYmFzZS9sb2dnaW5n Lmg+CisjaW5jbHVkZSA8d3RmL1JldGFpblB0ci5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApA QCAtNzIsMTkgKzczLDE5IEBAIHJ0Yzo6UHJveHlJbmZvIE5ldHdvcmtSVENQcm92aWRlcjo6cHJv eHlJbmZvRnJvbVNlc3Npb24oY29uc3QgUlRDTmV0d29yazo6U29ja2V0CiB7CiAgICAgLy8gRklY TUU6IFdlIHNob3VsZCBjaGVjayBmb3Iga0NGTmV0d29ya1Byb3hpZXNFeGNlcHRpb25zTGlzdCB0 byBkZWNpZGUgd2hldGhlciB0byB1c2UgcHJveHkgb3Igbm90LgogICAgIC8vIEZJWE1FOiBXZSBz aG91bGQgYWxzbyBnZXQgdXNlcm5hbWUvcGFzc3dvcmQgZm9yIGF1dGhlbnRpY2F0aW9uIGNhc2Vz LgotICAgIGF1dG8gcHJveHlEaWN0aW9uYXJ5ID0gc3RhdGljX2Nhc3Q8TmV0d29ya1Nlc3Npb25D b2NvYSY+KHNlc3Npb24pLnByb3h5Q29uZmlndXJhdGlvbigpOworICAgIFJldGFpblB0cjxDRkRp Y3Rpb25hcnlSZWY+IHByb3h5RGljdGlvbmFyeSA9IHN0YXRpY19jYXN0PE5ldHdvcmtTZXNzaW9u Q29jb2EmPihzZXNzaW9uKS5wcm94eUNvbmZpZ3VyYXRpb24oKTsKICAgICBpZiAoIXByb3h5RGlj dGlvbmFyeSkKLSAgICAgICAgcHJveHlEaWN0aW9uYXJ5ID0gQ0ZOZXR3b3JrQ29weVN5c3RlbVBy b3h5U2V0dGluZ3MoKTsKKyAgICAgICAgcHJveHlEaWN0aW9uYXJ5ID0gYWRvcHRDRihDRk5ldHdv cmtDb3B5U3lzdGVtUHJveHlTZXR0aW5ncygpKTsKICNpZiBQTEFURk9STShNQUMpCi0gICAgaWYg KGlzRW5hYmxlZChwcm94eURpY3Rpb25hcnksIGtDRk5ldHdvcmtQcm94aWVzSFRUUFNFbmFibGUp KQotICAgICAgICByZXR1cm4gY3JlYXRlUlRDUHJveHkocHJveHlEaWN0aW9uYXJ5LCBydGM6OlBS T1hZX0hUVFBTLCBrQ0ZOZXR3b3JrUHJveGllc0hUVFBTUHJveHksIGtDRk5ldHdvcmtQcm94aWVz SFRUUFNQb3J0KTsKKyAgICBpZiAoaXNFbmFibGVkKHByb3h5RGljdGlvbmFyeS5nZXQoKSwga0NG TmV0d29ya1Byb3hpZXNIVFRQU0VuYWJsZSkpCisgICAgICAgIHJldHVybiBjcmVhdGVSVENQcm94 eShwcm94eURpY3Rpb25hcnkuZ2V0KCksIHJ0Yzo6UFJPWFlfSFRUUFMsIGtDRk5ldHdvcmtQcm94 aWVzSFRUUFNQcm94eSwga0NGTmV0d29ya1Byb3hpZXNIVFRQU1BvcnQpOwogCi0gICAgaWYgKGlz RW5hYmxlZChwcm94eURpY3Rpb25hcnksIGtDRk5ldHdvcmtQcm94aWVzU09DS1NFbmFibGUpKQot ICAgICAgICByZXR1cm4gY3JlYXRlUlRDUHJveHkocHJveHlEaWN0aW9uYXJ5LCBydGM6OlBST1hZ X1NPQ0tTNSwga0NGTmV0d29ya1Byb3hpZXNTT0NLU1Byb3h5LCBrQ0ZOZXR3b3JrUHJveGllc1NP Q0tTUG9ydCk7CisgICAgaWYgKGlzRW5hYmxlZChwcm94eURpY3Rpb25hcnkuZ2V0KCksIGtDRk5l dHdvcmtQcm94aWVzU09DS1NFbmFibGUpKQorICAgICAgICByZXR1cm4gY3JlYXRlUlRDUHJveHko cHJveHlEaWN0aW9uYXJ5LmdldCgpLCBydGM6OlBST1hZX1NPQ0tTNSwga0NGTmV0d29ya1Byb3hp ZXNTT0NLU1Byb3h5LCBrQ0ZOZXR3b3JrUHJveGllc1NPQ0tTUG9ydCk7CiAjZW5kaWYKICNpZiBQ TEFURk9STShJT1MpCi0gICAgaWYgKGlzRW5hYmxlZChwcm94eURpY3Rpb25hcnksIGtDRk5ldHdv cmtQcm94aWVzSFRUUEVuYWJsZSkpCi0gICAgICAgIHJldHVybiBjcmVhdGVSVENQcm94eShwcm94 eURpY3Rpb25hcnksIHJ0Yzo6UFJPWFlfSFRUUFMsIGtDRk5ldHdvcmtQcm94aWVzSFRUUFByb3h5 LCBrQ0ZOZXR3b3JrUHJveGllc0hUVFBQb3J0KTsKKyAgICBpZiAoaXNFbmFibGVkKHByb3h5RGlj dGlvbmFyeS5nZXQoKSwga0NGTmV0d29ya1Byb3hpZXNIVFRQRW5hYmxlKSkKKyAgICAgICAgcmV0 dXJuIGNyZWF0ZVJUQ1Byb3h5KHByb3h5RGljdGlvbmFyeS5nZXQoKSwgcnRjOjpQUk9YWV9IVFRQ Uywga0NGTmV0d29ya1Byb3hpZXNIVFRQUHJveHksIGtDRk5ldHdvcmtQcm94aWVzSFRUUFBvcnQp OwogI2VuZGlmCiAgICAgcmV0dXJuIHsgfTsKIH0K