201806 2019-09-15 11:10:54 -0700 REGRESSION (r229419): Missing call to [self init] in -[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:] 2019-09-15 14:43:35 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183291 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue dino pvollan simon.fraser thorton webkit-bug-importer oldest_to_newest 1570954 0 ddkilzer 2019-09-15 11:10:54 -0700 Missing call to [self init] in -[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]. - (id)initWithScrollbar:(Scrollbar*)scrollbar featureToAnimate:(FeatureToAnimate)featureToAnimate animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration { #if !ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) self = [super initWithDuration:duration animationCurve:NSAnimationEaseInOut]; if (!self) return nil; #else // FIXME: Missing call to [self init] here! const NSTimeInterval timeInterval = 0.01; _timer = adoptNS([[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSinceNow:0] interval:timeInterval target:self selector:@selector(setCurrentProgress:) userInfo:nil repeats:YES]); _duration = duration; _timingFunction = CubicBezierTimingFunction::create(CubicBezierTimingFunction::EaseInOut); #endif [...] return self; } <https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm#L317> 1570955 1 webkit-bug-importer 2019-09-15 11:11:05 -0700 <rdar://problem/55380741> 1570956 2 378817 ddkilzer 2019-09-15 11:14:04 -0700 Created attachment 378817 Patch v1 1570957 3 378817 ddkilzer 2019-09-15 11:20:00 -0700 Comment on attachment 378817 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=378817&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:326 > + self = [super init]; > + if (!self) > + return nil; Note that I chose to use plain old -init due to this class inheriting from NSObject: #if !ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) @interface WebScrollbarPartAnimation : NSAnimation #else @interface WebScrollbarPartAnimation : NSObject #endif 1570972 4 378817 commit-queue 2019-09-15 14:43:33 -0700 Comment on attachment 378817 Patch v1 Clearing flags on attachment: 378817 Committed r249887: <https://trac.webkit.org/changeset/249887> 1570973 5 commit-queue 2019-09-15 14:43:35 -0700 All reviewed patches have been landed. Closing bug. 378817 2019-09-15 11:14:04 -0700 2019-09-15 14:43:33 -0700 Patch v1 bug-201806-20190915111530.patch text/plain 1684 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNmYjc4NGM5N2M5NzNl OWIyMDMxMTRlMTMxMjYzMjExNDJiZDc0NS4uOTYxOTA2M2IyZWJkMGUxNWU5YjA5YzIxMGExZDY5 OWI4N2Y3MGZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA5LTE1ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTWlzc2luZyBjYWxsIHRv IFtzZWxmIGluaXRdIGluIC1bV2ViU2Nyb2xsYmFyUGFydEFuaW1hdGlvbiBpbml0V2l0aFNjcm9s bGJhcjpmZWF0dXJlVG9BbmltYXRlOmFuaW1hdGVGcm9tOmFuaW1hdGVUbzpkdXJhdGlvbjpdCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMDE4MDY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0 b3JNYWMubW06CisgICAgICAgICgtW1dlYlNjcm9sbGJhclBhcnRBbmltYXRpb24gaW5pdFdpdGhT Y3JvbGxiYXI6ZmVhdHVyZVRvQW5pbWF0ZTphbmltYXRlRnJvbTphbmltYXRlVG86ZHVyYXRpb246 XSk6CisgICAgICAgIENhbGwgW3NlbGYgaW5pdF0gYW5kIHJldHVybiBlYXJseSBpZiB0aGUgcmVz dWx0IGlzIG5pbC4KKwogMjAxOS0wOS0xMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdIERvIG5vdCBjcmVhdGUgRm9ybWF0dGluZ0NvbnRleHQgdW5sZXNz IHRoZSByb290IGhhcyBjaGlsZCBib3hlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9TY3JvbGxBbmltYXRvck1hYy5tbQppbmRleCA2ODYwZTMzYzNhM2IyMTU2MzA1ZmIzMWFm NDI3ZGM0OTAyMzU4N2FkLi5mMTc4Mjg2YzU2OWU5MzhiNmI0NTI2NWViMzkyNzdhNDNlMzc2NGRk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JN YWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj Lm1tCkBAIC0zMjEsNiArMzIxLDEwIEBAIC0gKGlkKWluaXRXaXRoU2Nyb2xsYmFyOihTY3JvbGxi YXIqKXNjcm9sbGJhciBmZWF0dXJlVG9BbmltYXRlOihGZWF0dXJlVG9BbmltYXRlCiAgICAgaWYg KCFzZWxmKQogICAgICAgICByZXR1cm4gbmlsOwogI2Vsc2UKKyAgICBzZWxmID0gW3N1cGVyIGlu aXRdOworICAgIGlmICghc2VsZikKKyAgICAgICAgcmV0dXJuIG5pbDsKKwogICAgIGNvbnN0IE5T VGltZUludGVydmFsIHRpbWVJbnRlcnZhbCA9IDAuMDE7CiAgICAgX3RpbWVyID0gYWRvcHROUyhb W05TVGltZXIgYWxsb2NdIGluaXRXaXRoRmlyZURhdGU6W05TRGF0ZSBkYXRlV2l0aFRpbWVJbnRl cnZhbFNpbmNlTm93OjBdIGludGVydmFsOnRpbWVJbnRlcnZhbCB0YXJnZXQ6c2VsZiBzZWxlY3Rv cjpAc2VsZWN0b3Ioc2V0Q3VycmVudFByb2dyZXNzOikgdXNlckluZm86bmlsIHJlcGVhdHM6WUVT XSk7CiAgICAgX2R1cmF0aW9uID0gZHVyYXRpb247Cg==