201804 2019-09-15 07:01:56 -0700 [JSC] REGRESSION (r248938): Leak of uint32_t arrays in testFastForwardCopy32() 2019-09-16 13:29:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200181 https://bugs.webkit.org/show_bug.cgi?id=201818 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ews-watchlist justin_michaud keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1570932 0 ddkilzer 2019-09-15 07:01:56 -0700 Leak of uint32_t arrays in testFastForwardCopy32() due to `continue` statements not releasing memory allocated by `new`. void testFastForwardCopy32() { #if CPU(X86_64) for (const bool aligned : { true, false }) { for (const bool overlap : { false, true }) { for (size_t arrsize : { 1, 4, 5, 6, 8, 10, 12, 16, 20, 40, 100, 1000}) { size_t overlapAmount = 5; uint32_t* arr1, *arr2; if (overlap) { arr1 = new uint32_t[arrsize * 2]; arr2 = arr1 + (arrsize - overlapAmount); } else { arr1 = new uint32_t[arrsize]; arr2 = new uint32_t[arrsize]; } if (!aligned && arrsize < 3) continue; // LEAKS! if (overlap && arrsize <= overlapAmount + 3) continue; // LEAKS! [...] if (!overlap) { delete[] arr1; delete[] arr2; } else delete[] arr1; } } } #endif } <https://trac.webkit.org/browser/webkit/trunk/Source/JavaScriptCore/b3/testb3_8.cpp> 1570933 1 ddkilzer 2019-09-15 07:04:51 -0700 Leak introduced by: Bug 200181: Identify memcpy loops in b3 <https://bugs.webkit.org/show_bug.cgi?id=200181> <https://trac.webkit.org/changeset/248938> 1570934 2 378811 ddkilzer 2019-09-15 07:12:35 -0700 Created attachment 378811 Patch v1 1570938 3 378812 ddkilzer 2019-09-15 07:24:24 -0700 Created attachment 378812 Patch v2 1570939 4 ddkilzer 2019-09-15 07:27:31 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 378812 [details] > Patch v2 ERROR: Source/JavaScriptCore/b3/testb3_8.cpp:881: Use 'WTF::makeUnique<>' instead of 'std::make_unique<>'. [runtime/wtf_make_unique] [4] ERROR: Source/JavaScriptCore/b3/testb3_8.cpp:885: Use 'WTF::makeUnique<>' instead of 'std::make_unique<>'. [runtime/wtf_make_unique] [4] ERROR: Source/JavaScriptCore/b3/testb3_8.cpp:886: Use 'WTF::makeUnique<>' instead of 'std::make_unique<>'. [runtime/wtf_make_unique] [4] Total errors found: 3 in 2 files This is a false positive. WTF::makeUnique<> doesn't handle POD types, so std::make_unique<> must still be used. (See build failures of "Patch v1".) 1570953 5 webkit-bug-importer 2019-09-15 10:57:59 -0700 <rdar://problem/55380614> 1571008 6 378812 saam 2019-09-15 22:02:28 -0700 Comment on attachment 378812 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=378812&action=review > Source/JavaScriptCore/b3/testb3_8.cpp:885 > + array1 = std::make_unique<uint32_t[]>(arrsize); Should we be using WTF::makeUnique? 1571020 7 ddkilzer 2019-09-15 22:41:20 -0700 (In reply to Saam Barati from comment #6) > Comment on attachment 378812 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378812&action=review > > > Source/JavaScriptCore/b3/testb3_8.cpp:885 > > + array1 = std::make_unique<uint32_t[]>(arrsize); > > Should we be using WTF::makeUnique? No. It doesn't support POD types. See Comment #4. 1571022 8 378812 ddkilzer 2019-09-15 22:44:20 -0700 Comment on attachment 378812 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=378812&action=review >>> Source/JavaScriptCore/b3/testb3_8.cpp:885 >>> + array1 = std::make_unique<uint32_t[]>(arrsize); >> >> Should we be using WTF::makeUnique? > > No. It doesn't support POD types. See Comment #4. Or is the patch missing a #include of <wtf/UniqueArray.h>? 1571038 9 378812 ysuzuki 2019-09-16 00:56:56 -0700 Comment on attachment 378812 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=378812&action=review >>>> Source/JavaScriptCore/b3/testb3_8.cpp:885 >>>> + array1 = std::make_unique<uint32_t[]>(arrsize); >>> >>> Should we be using WTF::makeUnique? >> >> No. It doesn't support POD types. See Comment #4. > > Or is the patch missing a #include of <wtf/UniqueArray.h>? Use `makeUniqueArray<uint32_t>(arrsize)` instead. 1571069 10 ddkilzer 2019-09-16 05:30:51 -0700 (In reply to Yusuke Suzuki from comment #9) > Comment on attachment 378812 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378812&action=review > > >>>> Source/JavaScriptCore/b3/testb3_8.cpp:885 > >>>> + array1 = std::make_unique<uint32_t[]>(arrsize); > >>> > >>> Should we be using WTF::makeUnique? > >> > >> No. It doesn't support POD types. See Comment #4. > > > > Or is the patch missing a #include of <wtf/UniqueArray.h>? > > Use `makeUniqueArray<uint32_t>(arrsize)` instead. Thanks! Just noticed that. 1571070 11 378856 ddkilzer 2019-09-16 05:31:26 -0700 Created attachment 378856 Patch v3 1571080 12 378858 ddkilzer 2019-09-16 06:42:18 -0700 Created attachment 378858 Patch v4 1571127 13 ddkilzer 2019-09-16 09:36:10 -0700 (In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to David Kilzer (:ddkilzer) from comment #3) > > Created attachment 378812 [details] > > Patch v2 > > ERROR: Source/JavaScriptCore/b3/testb3_8.cpp:881: Use 'WTF::makeUnique<>' > instead of 'std::make_unique<>'. [runtime/wtf_make_unique] [4] > ERROR: Source/JavaScriptCore/b3/testb3_8.cpp:885: Use 'WTF::makeUnique<>' > instead of 'std::make_unique<>'. [runtime/wtf_make_unique] [4] > ERROR: Source/JavaScriptCore/b3/testb3_8.cpp:886: Use 'WTF::makeUnique<>' > instead of 'std::make_unique<>'. [runtime/wtf_make_unique] [4] > Total errors found: 3 in 2 files > > This is a false positive. WTF::makeUnique<> doesn't handle POD types, so > std::make_unique<> must still be used. (See build failures of "Patch v1".) Filed Bug 201818 to fix this error message when using arrays: Bug 201818: check-webkit-style: Fix warning message for std::make_unique<typename[]> <https://bugs.webkit.org/show_bug.cgi?id=201818> 1571242 14 378858 commit-queue 2019-09-16 13:29:49 -0700 Comment on attachment 378858 Patch v4 Clearing flags on attachment: 378858 Committed r249914: <https://trac.webkit.org/changeset/249914> 1571243 15 commit-queue 2019-09-16 13:29:51 -0700 All reviewed patches have been landed. Closing bug. 378811 2019-09-15 07:12:35 -0700 2019-09-15 07:24:22 -0700 Patch v1 bug-201804-20190915071402.patch text/plain 2381 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm N2U5YTkyNjcyNmQzOTUyZWQ5ZmQyM2ZhZjRmYjNkMzNlYTQwYjAyLi5lNmY0ZjUwMTMwNGY3YmJm NTk1ZTVkMmRiYjdlN2M0ODczNTI1NWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wOS0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJFR1JFU1NJT04gKHIyNDg5MzgpOiBMZWFrIG9mIHVpbnQzMl90 IGFycmF5cyBpbiB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMjAxODA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYjMvdGVzdGIzXzguY3BwOgorICAgICAgICAodGVzdEZhc3RGb3J3YXJkQ29w eTMyKTogQWxsb2NhdGUgYXJyYXlzIHVzaW5nCisgICAgICAgIFdURjo6bWFrZVVuaXF1ZTx1aW50 MzJfdFtdPiB0byBmaXggbGVha3MgY2F1c2VkIGJ5IGNvbnRpbnVlCisgICAgICAgIHN0YXRlbWVu dHMuCisKIDIwMTktMDktMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBMZWFrIG9mIE5TTWFwVGFibGUgaW4gLVtKU1ZpcnR1YWxNYWNoaW5lIGFkZE1hbmFn ZWRSZWZlcmVuY2U6d2l0aE93bmVyOl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy90ZXN0YjNfOC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzguY3Bw CmluZGV4IDcyNzkwNjJjZTViYTY4MTc3ODllYWNmMjU0ZGEwNTRkYjVkM2FjNmEuLjQ5NjkzNzZi NmVlYWM5MDEzZTFmMDVkNzc4MTQwMDM3ZDEwZGYxMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9iMy90ZXN0YjNfOC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L3Rlc3RiM184LmNwcApAQCAtODc0LDE0ICs4NzQsMTggQEAgdm9pZCB0ZXN0RmFzdEZvcndhcmRD b3B5MzIoKQogICAgICAgICAgICAgZm9yIChzaXplX3QgYXJyc2l6ZSA6IHsgMSwgNCwgNSwgNiwg OCwgMTAsIDEyLCAxNiwgMjAsIDQwLCAxMDAsIDEwMDB9KSB7CiAgICAgICAgICAgICAgICAgc2l6 ZV90IG92ZXJsYXBBbW91bnQgPSA1OwogCisgICAgICAgICAgICAgICAgc3RkOjp1bmlxdWVfcHRy PHVpbnQzMl90W10+IGFycmF5MSwgYXJyYXkyOwogICAgICAgICAgICAgICAgIHVpbnQzMl90KiBh cnIxLCAqYXJyMjsKIAogICAgICAgICAgICAgICAgIGlmIChvdmVybGFwKSB7Ci0gICAgICAgICAg ICAgICAgICAgIGFycjEgPSBuZXcgdWludDMyX3RbYXJyc2l6ZSAqIDJdOworICAgICAgICAgICAg ICAgICAgICBhcnJheTEgPSBXVEY6Om1ha2VVbmlxdWU8dWludDMyX3RbXT4oYXJyc2l6ZSAqIDIp OworICAgICAgICAgICAgICAgICAgICBhcnIxID0gJmFycmF5MVswXTsKICAgICAgICAgICAgICAg ICAgICAgYXJyMiA9IGFycjEgKyAoYXJyc2l6ZSAtIG92ZXJsYXBBbW91bnQpOwogICAgICAgICAg ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgICAgIGFycjEgPSBuZXcgdWludDMyX3Rb YXJyc2l6ZV07Ci0gICAgICAgICAgICAgICAgICAgIGFycjIgPSBuZXcgdWludDMyX3RbYXJyc2l6 ZV07CisgICAgICAgICAgICAgICAgICAgIGFycmF5MSA9IFdURjo6bWFrZVVuaXF1ZTx1aW50MzJf dFtdPihhcnJzaXplKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyYXkyID0gV1RGOjptYWtlVW5p cXVlPHVpbnQzMl90W10+KGFycnNpemUpOworICAgICAgICAgICAgICAgICAgICBhcnIxID0gJmFy cmF5MVswXTsKKyAgICAgICAgICAgICAgICAgICAgYXJyMiA9ICZhcnJheTJbMF07CiAgICAgICAg ICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgaWYgKCFhbGlnbmVkICYmIGFycnNpemUgPCAz KQpAQCAtOTE1LDEyICs5MTksNiBAQCB2b2lkIHRlc3RGYXN0Rm9yd2FyZENvcHkzMigpCiAgICAg ICAgICAgICAgICAgICAgIC0tYXJyMTsKICAgICAgICAgICAgICAgICAgICAgLS1hcnIyOwogICAg ICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgIGlmICghb3ZlcmxhcCkgewotICAgICAg ICAgICAgICAgICAgICBkZWxldGVbXSBhcnIxOwotICAgICAgICAgICAgICAgICAgICBkZWxldGVb XSBhcnIyOwotICAgICAgICAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgICAgICAgICBkZWxl dGVbXSBhcnIxOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQo= 378812 2019-09-15 07:24:24 -0700 2019-09-16 05:31:24 -0700 Patch v2 bug-201804-20190915072550.patch text/plain 2385 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm N2U5YTkyNjcyNmQzOTUyZWQ5ZmQyM2ZhZjRmYjNkMzNlYTQwYjAyLi5iZjQ3MTk5NDIwMzIyMjE1 ZmEwMGYxMjhjOTgzMDNiZjYwNWZiMGE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wOS0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJFR1JFU1NJT04gKHIyNDg5MzgpOiBMZWFrIG9mIHVpbnQzMl90 IGFycmF5cyBpbiB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMjAxODA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYjMvdGVzdGIzXzguY3BwOgorICAgICAgICAodGVzdEZhc3RGb3J3YXJkQ29w eTMyKTogQWxsb2NhdGUgYXJyYXlzIHVzaW5nCisgICAgICAgIHN0ZDo6bWFrZV91bmlxdWU8dWlu dDMyX3RbXT4gdG8gZml4IGxlYWtzIGNhdXNlZCBieSBjb250aW51ZQorICAgICAgICBzdGF0ZW1l bnRzLgorCiAyMDE5LTA5LTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAK ICAgICAgICAgTGVhayBvZiBOU01hcFRhYmxlIGluIC1bSlNWaXJ0dWFsTWFjaGluZSBhZGRNYW5h Z2VkUmVmZXJlbmNlOndpdGhPd25lcjpdCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvdGVzdGIzXzguY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM184LmNw cAppbmRleCA3Mjc5MDYyY2U1YmE2ODE3Nzg5ZWFjZjI1NGRhMDU0ZGI1ZDNhYzZhLi41Zjc4M2Zm OGM4NjFlZmI0Y2ZiZmMzODhkZjY0N2EzNzE0YmJiNzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYjMvdGVzdGIzXzguY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My90ZXN0YjNfOC5jcHAKQEAgLTg3NCwxNCArODc0LDE4IEBAIHZvaWQgdGVzdEZhc3RGb3J3YXJk Q29weTMyKCkKICAgICAgICAgICAgIGZvciAoc2l6ZV90IGFycnNpemUgOiB7IDEsIDQsIDUsIDYs IDgsIDEwLCAxMiwgMTYsIDIwLCA0MCwgMTAwLCAxMDAwfSkgewogICAgICAgICAgICAgICAgIHNp emVfdCBvdmVybGFwQW1vdW50ID0gNTsKIAorICAgICAgICAgICAgICAgIHN0ZDo6dW5pcXVlX3B0 cjx1aW50MzJfdFtdPiBhcnJheTEsIGFycmF5MjsKICAgICAgICAgICAgICAgICB1aW50MzJfdCog YXJyMSwgKmFycjI7CiAKICAgICAgICAgICAgICAgICBpZiAob3ZlcmxhcCkgewotICAgICAgICAg ICAgICAgICAgICBhcnIxID0gbmV3IHVpbnQzMl90W2FycnNpemUgKiAyXTsKKyAgICAgICAgICAg ICAgICAgICAgYXJyYXkxID0gc3RkOjptYWtlX3VuaXF1ZTx1aW50MzJfdFtdPihhcnJzaXplICog Mik7CisgICAgICAgICAgICAgICAgICAgIGFycjEgPSAmYXJyYXkxWzBdOwogICAgICAgICAgICAg ICAgICAgICBhcnIyID0gYXJyMSArIChhcnJzaXplIC0gb3ZlcmxhcEFtb3VudCk7CiAgICAgICAg ICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgYXJyMSA9IG5ldyB1aW50MzJf dFthcnJzaXplXTsKLSAgICAgICAgICAgICAgICAgICAgYXJyMiA9IG5ldyB1aW50MzJfdFthcnJz aXplXTsKKyAgICAgICAgICAgICAgICAgICAgYXJyYXkxID0gc3RkOjptYWtlX3VuaXF1ZTx1aW50 MzJfdFtdPihhcnJzaXplKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyYXkyID0gc3RkOjptYWtl X3VuaXF1ZTx1aW50MzJfdFtdPihhcnJzaXplKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyMSA9 ICZhcnJheTFbMF07CisgICAgICAgICAgICAgICAgICAgIGFycjIgPSAmYXJyYXkyWzBdOwogICAg ICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAgIGlmICghYWxpZ25lZCAmJiBhcnJzaXpl IDwgMykKQEAgLTkxNSwxMiArOTE5LDYgQEAgdm9pZCB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQog ICAgICAgICAgICAgICAgICAgICAtLWFycjE7CiAgICAgICAgICAgICAgICAgICAgIC0tYXJyMjsK ICAgICAgICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgICAgICBpZiAoIW92ZXJsYXApIHsKLSAg ICAgICAgICAgICAgICAgICAgZGVsZXRlW10gYXJyMTsKLSAgICAgICAgICAgICAgICAgICAgZGVs ZXRlW10gYXJyMjsKLSAgICAgICAgICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICAgICAg ZGVsZXRlW10gYXJyMTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0K 378856 2019-09-16 05:31:26 -0700 2019-09-16 06:42:17 -0700 Patch v3 bug-201804-20190916053259.patch text/plain 2516 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDRkYmQ0YWUxODlmMDYyMGQ2N2I3YzlkZmMyZTg4NDc5ZGExZTQ0Li4xZjdmZmRmMmYwMzAyMjJj Zjk4NTlhMGRiM2RiYjkzZWQ0YTZjOTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wOS0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJFR1JFU1NJT04gKHIyNDg5MzgpOiBMZWFrIG9mIHVpbnQzMl90 IGFycmF5cyBpbiB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMjAxODA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYjMvdGVzdGIzXzguY3BwOgorICAgICAgICAodGVzdEZhc3RGb3J3YXJkQ29w eTMyKTogQWxsb2NhdGUgYXJyYXlzIHVzaW5nCisgICAgICAgIFdURjo6bWFrZVVuaXF1ZUFycmF5 PHVpbnQzMl90PiB0byBmaXggbGVha3MgY2F1c2VkIGJ5IGNvbnRpbnVlCisgICAgICAgIHN0YXRl bWVudHMuCisKIDIwMTktMDktMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBMZWFrIG9mIE5TTWFwVGFibGUgaW4gLVtKU1ZpcnR1YWxNYWNoaW5lIGFkZE1h bmFnZWRSZWZlcmVuY2U6d2l0aE93bmVyOl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9iMy90ZXN0YjNfOC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzgu Y3BwCmluZGV4IDcyNzkwNjJjZTViYTY4MTc3ODllYWNmMjU0ZGEwNTRkYjVkM2FjNmEuLjhlYTNl Yjc1MTU1YTkyM2M5NTQwY2MwMzI3ZDY5OGVjOThmZjhiYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfOC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL3Rlc3RiM184LmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgInRlc3RiMy5oIgogCisjaW5jbHVkZSA8d3RmL1VuaXF1ZUFycmF5Lmg+CisKICNp ZiBFTkFCTEUoQjNfSklUKQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgpAQCAtODc0LDE0ICs4NzYs MTggQEAgdm9pZCB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQogICAgICAgICAgICAgZm9yIChzaXpl X3QgYXJyc2l6ZSA6IHsgMSwgNCwgNSwgNiwgOCwgMTAsIDEyLCAxNiwgMjAsIDQwLCAxMDAsIDEw MDB9KSB7CiAgICAgICAgICAgICAgICAgc2l6ZV90IG92ZXJsYXBBbW91bnQgPSA1OwogCisgICAg ICAgICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPHVpbnQzMl90W10+IGFycmF5MSwgYXJyYXkyOwog ICAgICAgICAgICAgICAgIHVpbnQzMl90KiBhcnIxLCAqYXJyMjsKIAogICAgICAgICAgICAgICAg IGlmIChvdmVybGFwKSB7Ci0gICAgICAgICAgICAgICAgICAgIGFycjEgPSBuZXcgdWludDMyX3Rb YXJyc2l6ZSAqIDJdOworICAgICAgICAgICAgICAgICAgICBhcnJheTEgPSBtYWtlVW5pcXVlQXJy YXk8dWludDMyX3Q+KGFycnNpemUgKiAyKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyMSA9ICZh cnJheTFbMF07CiAgICAgICAgICAgICAgICAgICAgIGFycjIgPSBhcnIxICsgKGFycnNpemUgLSBv dmVybGFwQW1vdW50KTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAg ICAgICBhcnIxID0gbmV3IHVpbnQzMl90W2FycnNpemVdOwotICAgICAgICAgICAgICAgICAgICBh cnIyID0gbmV3IHVpbnQzMl90W2FycnNpemVdOworICAgICAgICAgICAgICAgICAgICBhcnJheTEg PSBtYWtlVW5pcXVlQXJyYXk8dWludDMyX3Q+KGFycnNpemUpOworICAgICAgICAgICAgICAgICAg ICBhcnJheTIgPSBtYWtlVW5pcXVlQXJyYXk8dWludDMyX3Q+KGFycnNpemUpOworICAgICAgICAg ICAgICAgICAgICBhcnIxID0gJmFycmF5MVswXTsKKyAgICAgICAgICAgICAgICAgICAgYXJyMiA9 ICZhcnJheTJbMF07CiAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgaWYgKCFh bGlnbmVkICYmIGFycnNpemUgPCAzKQpAQCAtOTE1LDEyICs5MjEsNiBAQCB2b2lkIHRlc3RGYXN0 Rm9yd2FyZENvcHkzMigpCiAgICAgICAgICAgICAgICAgICAgIC0tYXJyMTsKICAgICAgICAgICAg ICAgICAgICAgLS1hcnIyOwogICAgICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgIGlm ICghb3ZlcmxhcCkgewotICAgICAgICAgICAgICAgICAgICBkZWxldGVbXSBhcnIxOwotICAgICAg ICAgICAgICAgICAgICBkZWxldGVbXSBhcnIyOwotICAgICAgICAgICAgICAgIH0gZWxzZQotICAg ICAgICAgICAgICAgICAgICBkZWxldGVbXSBhcnIxOwogICAgICAgICAgICAgfQogICAgICAgICB9 CiAgICAgfQo= 378858 2019-09-16 06:42:18 -0700 2019-09-16 13:29:49 -0700 Patch v4 bug-201804-20190916064351.patch text/plain 2510 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDRkYmQ0YWUxODlmMDYyMGQ2N2I3YzlkZmMyZTg4NDc5ZGExZTQ0Li4xZjdmZmRmMmYwMzAyMjJj Zjk4NTlhMGRiM2RiYjkzZWQ0YTZjOTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wOS0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJFR1JFU1NJT04gKHIyNDg5MzgpOiBMZWFrIG9mIHVpbnQzMl90 IGFycmF5cyBpbiB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMjAxODA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYjMvdGVzdGIzXzguY3BwOgorICAgICAgICAodGVzdEZhc3RGb3J3YXJkQ29w eTMyKTogQWxsb2NhdGUgYXJyYXlzIHVzaW5nCisgICAgICAgIFdURjo6bWFrZVVuaXF1ZUFycmF5 PHVpbnQzMl90PiB0byBmaXggbGVha3MgY2F1c2VkIGJ5IGNvbnRpbnVlCisgICAgICAgIHN0YXRl bWVudHMuCisKIDIwMTktMDktMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBMZWFrIG9mIE5TTWFwVGFibGUgaW4gLVtKU1ZpcnR1YWxNYWNoaW5lIGFkZE1h bmFnZWRSZWZlcmVuY2U6d2l0aE93bmVyOl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9iMy90ZXN0YjNfOC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzgu Y3BwCmluZGV4IDcyNzkwNjJjZTViYTY4MTc3ODllYWNmMjU0ZGEwNTRkYjVkM2FjNmEuLmU0NjUw YTFkNTQ3ZjVhZTNjZDhlOTVkZDI2ZTA2N2Q3MzBlZTllMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfOC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL3Rlc3RiM184LmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgInRlc3RiMy5oIgogCisjaW5jbHVkZSA8d3RmL1VuaXF1ZUFycmF5Lmg+CisKICNp ZiBFTkFCTEUoQjNfSklUKQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgpAQCAtODc0LDE0ICs4NzYs MTggQEAgdm9pZCB0ZXN0RmFzdEZvcndhcmRDb3B5MzIoKQogICAgICAgICAgICAgZm9yIChzaXpl X3QgYXJyc2l6ZSA6IHsgMSwgNCwgNSwgNiwgOCwgMTAsIDEyLCAxNiwgMjAsIDQwLCAxMDAsIDEw MDB9KSB7CiAgICAgICAgICAgICAgICAgc2l6ZV90IG92ZXJsYXBBbW91bnQgPSA1OwogCisgICAg ICAgICAgICAgICAgVW5pcXVlQXJyYXk8dWludDMyX3Q+IGFycmF5MSwgYXJyYXkyOwogICAgICAg ICAgICAgICAgIHVpbnQzMl90KiBhcnIxLCAqYXJyMjsKIAogICAgICAgICAgICAgICAgIGlmIChv dmVybGFwKSB7Ci0gICAgICAgICAgICAgICAgICAgIGFycjEgPSBuZXcgdWludDMyX3RbYXJyc2l6 ZSAqIDJdOworICAgICAgICAgICAgICAgICAgICBhcnJheTEgPSBtYWtlVW5pcXVlQXJyYXk8dWlu dDMyX3Q+KGFycnNpemUgKiAyKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyMSA9ICZhcnJheTFb MF07CiAgICAgICAgICAgICAgICAgICAgIGFycjIgPSBhcnIxICsgKGFycnNpemUgLSBvdmVybGFw QW1vdW50KTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgICAgICBh cnIxID0gbmV3IHVpbnQzMl90W2FycnNpemVdOwotICAgICAgICAgICAgICAgICAgICBhcnIyID0g bmV3IHVpbnQzMl90W2FycnNpemVdOworICAgICAgICAgICAgICAgICAgICBhcnJheTEgPSBtYWtl VW5pcXVlQXJyYXk8dWludDMyX3Q+KGFycnNpemUpOworICAgICAgICAgICAgICAgICAgICBhcnJh eTIgPSBtYWtlVW5pcXVlQXJyYXk8dWludDMyX3Q+KGFycnNpemUpOworICAgICAgICAgICAgICAg ICAgICBhcnIxID0gJmFycmF5MVswXTsKKyAgICAgICAgICAgICAgICAgICAgYXJyMiA9ICZhcnJh eTJbMF07CiAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgaWYgKCFhbGlnbmVk ICYmIGFycnNpemUgPCAzKQpAQCAtOTE1LDEyICs5MjEsNiBAQCB2b2lkIHRlc3RGYXN0Rm9yd2Fy ZENvcHkzMigpCiAgICAgICAgICAgICAgICAgICAgIC0tYXJyMTsKICAgICAgICAgICAgICAgICAg ICAgLS1hcnIyOwogICAgICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgIGlmICghb3Zl cmxhcCkgewotICAgICAgICAgICAgICAgICAgICBkZWxldGVbXSBhcnIxOwotICAgICAgICAgICAg ICAgICAgICBkZWxldGVbXSBhcnIyOwotICAgICAgICAgICAgICAgIH0gZWxzZQotICAgICAgICAg ICAgICAgICAgICBkZWxldGVbXSBhcnIxOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAg fQo=