201801 2019-09-14 18:32:49 -0700 [Cocoa] Add a WKA extension point 2019-09-18 00:16:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes achristensen commit-queue sam thorton webkit-bug-importer oldest_to_newest 1570911 0 aestes 2019-09-14 18:32:49 -0700 [Cocoa] Add a WKA extension point 1570912 1 378804 aestes 2019-09-14 18:34:31 -0700 Created attachment 378804 Patch 1570913 2 aestes 2019-09-14 18:34:53 -0700 rdar://problem/55372507 1570914 3 webkit-bug-importer 2019-09-14 18:35:13 -0700 <rdar://problem/55372554> 1570916 4 378804 sam 2019-09-14 18:43:24 -0700 Comment on attachment 378804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378804&action=review > Source/WebCore/ChangeLog:3 > + [Cocoa] Add a WKA extension point What is a WKA extension point? Why should we add one? > Source/WebCore/ChangeLog:11 > + * Modules/applepay/ApplePayRequestBase.cpp: > + (WebCore::requiresSupportedNetworks): > + (WebCore::convertAndValidate): How is this being tested? 1571581 5 aestes 2019-09-17 10:12:27 -0700 (In reply to Sam Weinig from comment #4) > Comment on attachment 378804 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378804&action=review > > > Source/WebCore/ChangeLog:3 > > + [Cocoa] Add a WKA extension point > > What is a WKA extension point? Why should we add one? It's a place where WebKitAdditions can extend WebKit. The radar explains why we should add one. > > > Source/WebCore/ChangeLog:11 > > + * Modules/applepay/ApplePayRequestBase.cpp: > > + (WebCore::requiresSupportedNetworks): > > + (WebCore::convertAndValidate): > > How is this being tested? With a layout test, but it can't be included in this patch. It'll be part of a future patch that moves things from WebKitAdditions to open source. 1571588 6 378804 commit-queue 2019-09-17 10:46:10 -0700 Comment on attachment 378804 Patch Clearing flags on attachment: 378804 Committed r249964: <https://trac.webkit.org/changeset/249964> 1571589 7 commit-queue 2019-09-17 10:46:12 -0700 All reviewed patches have been landed. Closing bug. 1571595 8 aestes 2019-09-17 11:12:48 -0700 Rolled out in r249967: <https://trac.webkit.org/changeset/249967> 1571830 9 aestes 2019-09-18 00:16:17 -0700 Committed r250026: <https://trac.webkit.org/changeset/250026> 378804 2019-09-14 18:34:31 -0700 2019-09-18 00:12:12 -0700 Patch bug-201801-20190914183430.patch text/plain 2448 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzJhYzkwYjE5M2NmNzhh OWIyZjBjMDY3YmYwYjgzMTRmZDIyYmQxNy4uYjgxMjE1YzNmZjllZmM5ZDJmMGQwZjQ4MWRhYjNj NzM5MmIzNjhkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA5LTE0ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIEFkZCBhIFdLQSBl eHRlbnNpb24gcG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMTgwMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTUzNzI1MDc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL2FwcGxl cGF5L0FwcGxlUGF5UmVxdWVzdEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVxdWlyZXNT dXBwb3J0ZWROZXR3b3Jrcyk6CisgICAgICAgIChXZWJDb3JlOjpjb252ZXJ0QW5kVmFsaWRhdGUp OgorCiAyMDE5LTA5LTE0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV0aXJlIHg4NiAzMmJpdCBKSVQgc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVJlcXVlc3RCYXNlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlSZXF1ZXN0QmFzZS5jcHAKaW5kZXggNWQ4 MTI3OWY4Mzc4ZThlNDA0NGUxZGM5YWNiODI4MzViNWE1MjM2NS4uMWQ2YmYyZDhmYjM2MDFiNWJh ODg1N2ZiNWEyNjk4MTI3MGQxY2E5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9hcHBsZXBheS9BcHBsZVBheVJlcXVlc3RCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5UmVxdWVzdEJhc2UuY3BwCkBAIC0zNiw2ICszNiw3IEBA CiAjZWxzZQogbmFtZXNwYWNlIFdlYkNvcmUgewogc3RhdGljIHZvaWQgZmluaXNoQ29udmVydGlu ZyhBcHBsZVBheVNlc3Npb25QYXltZW50UmVxdWVzdCYsIEFwcGxlUGF5UmVxdWVzdEJhc2UmKSB7 IH0KK3N0YXRpYyBib29sIHJlcXVpcmVzU3VwcG9ydGVkTmV0d29ya3ModW5zaWduZWQsIGNvbnN0 IEFwcGxlUGF5UmVxdWVzdEJhc2UmKSB7IHJldHVybiB0cnVlOyB9CiB9CiAjZW5kaWYKIApAQCAt NDMsOSArNDQsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBFeGNlcHRpb25PcjxW ZWN0b3I8U3RyaW5nPj4gY29udmVydEFuZFZhbGlkYXRlKERvY3VtZW50JiBkb2N1bWVudCwgdW5z aWduZWQgdmVyc2lvbiwgY29uc3QgVmVjdG9yPFN0cmluZz4mIHN1cHBvcnRlZE5ldHdvcmtzLCBj b25zdCBQYXltZW50Q29vcmRpbmF0b3ImIHBheW1lbnRDb29yZGluYXRvcikKIHsKLSAgICBpZiAo c3VwcG9ydGVkTmV0d29ya3MuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsg VHlwZUVycm9yLCAiQXQgbGVhc3Qgb25lIHN1cHBvcnRlZCBuZXR3b3JrIG11c3QgYmUgcHJvdmlk ZWQuIiB9OwotCiAgICAgVmVjdG9yPFN0cmluZz4gcmVzdWx0OwogICAgIHJlc3VsdC5yZXNlcnZl SW5pdGlhbENhcGFjaXR5KHN1cHBvcnRlZE5ldHdvcmtzLnNpemUoKSk7CiAgICAgZm9yIChhdXRv JiBzdXBwb3J0ZWROZXR3b3JrIDogc3VwcG9ydGVkTmV0d29ya3MpIHsKQEAgLTcyLDYgKzcwLDkg QEAgRXhjZXB0aW9uT3I8QXBwbGVQYXlTZXNzaW9uUGF5bWVudFJlcXVlc3Q+IGNvbnZlcnRBbmRW YWxpZGF0ZShEb2N1bWVudCYgZG9jdW1lbnQKICAgICAgICAgcmV0dXJuIG1lcmNoYW50Q2FwYWJp bGl0aWVzLnJlbGVhc2VFeGNlcHRpb24oKTsKICAgICByZXN1bHQuc2V0TWVyY2hhbnRDYXBhYmls aXRpZXMobWVyY2hhbnRDYXBhYmlsaXRpZXMucmVsZWFzZVJldHVyblZhbHVlKCkpOwogCisgICAg aWYgKHJlcXVpcmVzU3VwcG9ydGVkTmV0d29ya3ModmVyc2lvbiwgcmVxdWVzdCkgJiYgcmVxdWVz dC5zdXBwb3J0ZWROZXR3b3Jrcy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBFeGNlcHRpb24g eyBUeXBlRXJyb3IsICJBdCBsZWFzdCBvbmUgc3VwcG9ydGVkIG5ldHdvcmsgbXVzdCBiZSBwcm92 aWRlZC4iIH07CisKICAgICBhdXRvIHN1cHBvcnRlZE5ldHdvcmtzID0gY29udmVydEFuZFZhbGlk YXRlKGRvY3VtZW50LCB2ZXJzaW9uLCByZXF1ZXN0LnN1cHBvcnRlZE5ldHdvcmtzLCBwYXltZW50 Q29vcmRpbmF0b3IpOwogICAgIGlmIChzdXBwb3J0ZWROZXR3b3Jrcy5oYXNFeGNlcHRpb24oKSkK ICAgICAgICAgcmV0dXJuIHN1cHBvcnRlZE5ldHdvcmtzLnJlbGVhc2VFeGNlcHRpb24oKTsK