201793 2019-09-14 03:40:58 -0700 [GTK][WPE] Check for a Snap sandbox a bit harder 2019-09-14 15:45:37 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 201486 1 aperez aperez bugs-noreply cgarcia commit-queue fpizlo mark.lam mcatanzaro pgriffis svillar oldest_to_newest 1570856 0 aperez 2019-09-14 03:40:58 -0700 In a discussion with Patrick after bug #201486 we agreed that it may be a good thing to check a little bit more thoroughly whether we are running inside a Snap sandbox: instead of looking for a “SNAP” environment variable only, we can check also for the “SNAP_NAME” and “SNAP_REVISION” variables. The rationale is that “SNAP” is kind of a short variable and not completely unlikely to be set by an user without being inside a Snap container. Checking a couple of environment variables should be fine (it is very unlikely that they would be all set accidentally at the same time), and we don't want anyway to make complex checks anyway. 1570857 1 378790 aperez 2019-09-14 03:53:11 -0700 Created attachment 378790 Patch 1570858 2 aperez 2019-09-14 03:54:16 -0700 Added Patrick in CC, as he is our sandboxing expert, in case he wants to comment on this :) 1570901 3 378790 pgriffis 2019-09-14 14:58:47 -0700 Comment on attachment 378790 Patch Looks good. 1570905 4 378790 commit-queue 2019-09-14 15:45:36 -0700 Comment on attachment 378790 Patch Clearing flags on attachment: 378790 Committed r249882: <https://trac.webkit.org/changeset/249882> 1570906 5 commit-queue 2019-09-14 15:45:37 -0700 All reviewed patches have been landed. Closing bug. 378790 2019-09-14 03:53:11 -0700 2019-09-14 15:45:36 -0700 Patch bug-201793-20190914135309.patch text/plain 1642 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ3YmU3ZDgzYTBiYTM3M2U0 YjcyNWNjMTNmYTE0YjIxOThiMmE5NjUuLjRmNjViMTMxMTYzMGNjYjc1MDE4YjQwM2E2OGQyNDRj YzFlYzE2OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDktMTQgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd IENoZWNrIGZvciBhIFNuYXAgc2FuZGJveCBhIGJpdCBoYXJkZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTc5MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIv UHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHA6CisgICAgICAgIChXZWJLaXQ6OmlzSW5zaWRlU25hcCk6 IENoZWNrIHdoZXRoZXIgdGhlIFNOQVBfTkFNRSBhbmQgU05BUF9SRVZJU0lPTgorICAgICAgICBl bnZpcm9ubWVudCB2YXJpYWJsZXMgYXJlIGRlZmluZWQgYXMgd2VsbC4KKwogMjAxOS0wOS0xMSAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUHJvdmlkZSBhIHByb3Rv dHlwZSBmb3IgQVIgUXVpY2tMb29rIHRvIHRyaWdnZXIgcHJvY2Vzc2luZyBpbiB0aGUgb3JpZ2lu YXRpbmcgcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIv Z2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xh dW5jaGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHAKaW5kZXggOGEyZjgxM2Q0MmQwYzE1 M2VkYzIxZGM3N2IyZTU4NjdmOGU1MzJjYS4uZGNmOGMzYzJmZmMzN2YyNjNmNGY3YjM3YjcxZGYx Y2QzODAzZjAyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIv Z2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9MYXVuY2hlci9nbGliL1Byb2Nlc3NMYXVuY2hlckdMaWIuY3BwCkBAIC02Niw3ICs2NiwxMCBA QCBzdGF0aWMgYm9vbCBpc0luc2lkZVNuYXAoKQogICAgIGlmIChyZXQpCiAgICAgICAgIHJldHVy biAqcmV0OwogCi0gICAgcmV0ID0gZ19nZXRlbnYoIlNOQVAiKTsKKyAgICAvLyBUaGUgIlNOQVAi IGVudmlyb25tZW50IHZhcmlhYmxlIGlzIG5vdCB1bmxpa2VseSB0byBiZSBzZXQgZm9yL2J5IHNv bWV0aGluZyBvdGhlcgorICAgIC8vIHRoYW4gU25hcCwgc28gY2hlY2sgYSBjb3VwbGUgb2YgYWRk aXRpb25hbCB2YXJpYWJsZXMgdG8gYXZvaWQgZmFsc2UgcG9zaXRpdmVzLgorICAgIC8vIFNlZTog aHR0cHM6Ly9zbmFwY3JhZnQuaW8vZG9jcy9lbnZpcm9ubWVudC12YXJpYWJsZXMKKyAgICByZXQg PSBnX2dldGVudigiU05BUCIpICYmIGdfZ2V0ZW52KCJTTkFQX05BTUUiKSAmJiBnX2dldGVudigi U05BUF9SRVZJU0lPTiIpOwogICAgIHJldHVybiAqcmV0OwogfQogI2VuZGlmCg==