201781 2019-09-13 16:08:03 -0700 Remove unneeded PLATFORM(*) macros in Platform.h 2019-09-16 11:01:37 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=201777 P2 Normal --- 1 jbedard webkit-unassigned ap krollin mitz thorton oldest_to_newest 1570732 0 jbedard 2019-09-13 16:08:03 -0700 As per discussions in https://bugs.webkit.org/show_bug.cgi?id=201777, there are a number of PLATFORM macros in Platform.h that are made obsolete by the version macros. We should remove them. 1570734 1 jbedard 2019-09-13 16:12:28 -0700 Maybe the problem here is actually that we need to rename the __IPHONE_OS_VERSION_MIN_REQUIRED to something like '__IOS_FAMILY_OS_VERSION_MIN_REQUIRED' 1570736 2 ap 2019-09-13 16:16:50 -0700 > we need to rename the __IPHONE_OS_VERSION_MIN_REQUIRED This one is not ours, it comes from system frameworks. 1570823 3 thorton 2019-09-13 20:42:20 -0700 What we really need is the thing Keith proposed offline to make this all way less complicated. Hopefully he can repeat that here. 1570996 4 krollin 2019-09-15 18:35:09 -0700 I'm doing a lot of work in this area, Jonathan. I'm not exactly sure what this bugzilla covers. Let's meet up and make sure we're not duplicating our efforts. 1570997 5 krollin 2019-09-15 18:39:58 -0700 As for what Tim mentions, see <rdar://problem/50220520>. I want to follow-up on those ideas once we clean up exactly what should be enabled on which platform. 1571089 6 jbedard 2019-09-16 07:36:40 -0700 (In reply to Keith Rollin from comment #4) > I'm doing a lot of work in this area, Jonathan. I'm not exactly sure what > this bugzilla covers. Let's meet up and make sure we're not duplicating our > efforts. I'm not exactly sure what this bug covers either. I was just trying to track some comments that Alexey made in <https://bugs.webkit.org/show_bug.cgi?id=201777>. I'm fine with shelving any work here until you're finished with your patch, it seems like you have a more coherent understanding of what we want. 1571168 7 ap 2019-09-16 10:36:27 -0700 Probably best to close this bug to avoid confusion. My comment was about how it would be most correct to have separate HAVE_ACCESSIBILITY_BUNDLES_PATH and USE_ACCESSIBILITY_BUNDLES_PATH macros. But that gets dangerously close to over-engineering. Another of my comments was about how there are still many suspiciously looking uses of PLATFORM(IOS_FAMILY) with iOS specific version checks. Those may or may mean that the #ifs were meant to enable something on a different set of targets.