201780 2019-09-13 16:07:19 -0700 performJITMemcpy() should do its !Gigacage assertion on exit. 2019-09-13 16:46:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller mitz msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1570731 0 mark.lam 2019-09-13 16:07:19 -0700 <rdar://problem/55354867> 1570733 1 378758 mark.lam 2019-09-13 16:10:18 -0700 Created attachment 378758 proposed patch. 1570735 2 378758 rmorisset 2019-09-13 16:13:19 -0700 Comment on attachment 378758 proposed patch. r=me 1570738 3 mark.lam 2019-09-13 16:19:33 -0700 Thanks for the review. Landed in r249857: <http://trac.webkit.org/r249857>. 1570742 4 mark.lam 2019-09-13 16:26:11 -0700 Keith Rollins found an issue. 1570748 5 378760 mark.lam 2019-09-13 16:36:18 -0700 Created attachment 378760 follow up fix. 1570753 6 378760 rmorisset 2019-09-13 16:42:43 -0700 Comment on attachment 378760 follow up fix. r=me 1570756 7 mark.lam 2019-09-13 16:46:13 -0700 Follow up landed in r249858: <http://trac.webkit.org/r249858>. 378758 2019-09-13 16:10:18 -0700 2019-09-13 16:36:46 -0700 proposed patch. bug-201780.patch text/plain 1713 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ5ODU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE5LTA5LTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBw ZXJmb3JtSklUTWVtY3B5KCkgc2hvdWxkIGRvIGl0cyAhR2lnYWNhZ2UgYXNzZXJ0aW9uIG9uIGV4 aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE3 ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1MzU0ODY3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3Iu aDoKKyAgICAgICAgKEpTQzo6R2lnYWNhZ2VBc3NlcnRTY29wZTo6R2lnYWNhZ2VBc3NlcnRTY29w ZSk6CisgICAgICAgIChKU0M6OkdpZ2FjYWdlQXNzZXJ0U2NvcGU6On5HaWdhY2FnZUFzc2VydFNj b3BlKToKKyAgICAgICAgKEpTQzo6cGVyZm9ybUpJVE1lbWNweSk6CisKIDIwMTktMDktMTMgIFl1 c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBNaWNyby1v cHRpbWl6ZSBZYXJySklUJ3Mgc3Vycm9nYXRlIHBhaXIgaGFuZGxpbmcKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCShyZXZpc2lvbiAy NDk4NTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3Iu aAkod29ya2luZyBjb3B5KQpAQCAtMTE2LDkgKzExNiwxNyBAQCBKU19FWFBPUlRfUFJJVkFURSBi b29sIGlzSklUUEModm9pZCogcGMpCiAKIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgZHVtcEpJVE1l bW9yeShjb25zdCB2b2lkKiwgY29uc3Qgdm9pZCosIHNpemVfdCk7CiAKK3N0cnVjdCBHaWdhY2Fn ZUFzc2VydFNjb3BlIHsKKyAgICBHaWdhY2FnZUFzc2VydFNjb3BlKGNvbnN0IHZvaWQgKnNyYykK KyAgICAgICAgOiBzcmMoc3JjKQorICAgIHsgfQorICAgIH5HaWdhY2FnZUFzc2VydFNjb3BlKCkg eyBSRUxFQVNFX0FTU0VSVCghR2lnYWNhZ2U6OmNvbnRhaW5zKHNyYykpOyB9CisgICAgY29uc3Qg dm9pZCogc3JjOworfTsKKwogc3RhdGljIEFMV0FZU19JTkxJTkUgdm9pZCogcGVyZm9ybUpJVE1l bWNweSh2b2lkICpkc3QsIGNvbnN0IHZvaWQgKnNyYywgc2l6ZV90IG4pCiB7Ci0gICAgUkVMRUFT RV9BU1NFUlQoIUdpZ2FjYWdlOjpjb250YWlucyhzcmMpKTsKKyAgICBHaWdhY2FnZUFzc2VydFNj b3BlIGFzc2VydFNjb3BlKHNyYyk7CiAjaWYgQ1BVKEFSTTY0KQogICAgIHN0YXRpYyBjb25zdGV4 cHIgc2l6ZV90IGluc3RydWN0aW9uU2l6ZSA9IHNpemVvZih1bnNpZ25lZCk7CiAgICAgUkVMRUFT RV9BU1NFUlQocm91bmRVcFRvTXVsdGlwbGVPZjxpbnN0cnVjdGlvblNpemU+KGRzdCkgPT0gZHN0 KTsK 378760 2019-09-13 16:36:18 -0700 2019-09-13 16:42:43 -0700 follow up fix. bug-201780b.patch text/plain 2492 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ5ODU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTA5LTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBw ZXJmb3JtSklUTWVtY3B5KCkgc2hvdWxkIGRvIGl0cyAhR2lnYWNhZ2UgYXNzZXJ0aW9uIG9uIGV4 aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE3 ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1MzU0ODY3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWRvaW5nIHByZXZpb3VzIGZpeC4KKwor ICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OnBlcmZv cm1KSVRNZW1jcHkpOgorICAgICAgICAoSlNDOjpHaWdhY2FnZUFzc2VydFNjb3BlOjpHaWdhY2Fn ZUFzc2VydFNjb3BlKTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6R2lnYWNhZ2VBc3NlcnRTY29w ZTo6fkdpZ2FjYWdlQXNzZXJ0U2NvcGUpOiBEZWxldGVkLgorCiAyMDE5LTA5LTEzICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBwZXJmb3JtSklUTWVtY3B5KCkgc2hv dWxkIGRvIGl0cyAhR2lnYWNhZ2UgYXNzZXJ0aW9uIG9uIGV4aXQuCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAkocmV2aXNpb24gMjQ5 ODU3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJ KHdvcmtpbmcgY29weSkKQEAgLTExNiwxNyArMTE2LDggQEAgSlNfRVhQT1JUX1BSSVZBVEUgYm9v bCBpc0pJVFBDKHZvaWQqIHBjKQogCiBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGR1bXBKSVRNZW1v cnkoY29uc3Qgdm9pZCosIGNvbnN0IHZvaWQqLCBzaXplX3QpOwogCi1zdHJ1Y3QgR2lnYWNhZ2VB c3NlcnRTY29wZSB7Ci0gICAgR2lnYWNhZ2VBc3NlcnRTY29wZShjb25zdCB2b2lkICpzcmMpCi0g ICAgICAgIDogc3JjKHNyYykKLSAgICB7IH0KLSAgICB+R2lnYWNhZ2VBc3NlcnRTY29wZSgpIHsg UkVMRUFTRV9BU1NFUlQoIUdpZ2FjYWdlOjpjb250YWlucyhzcmMpKTsgfQotICAgIGNvbnN0IHZv aWQqIHNyYzsKLX07Ci0KIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQqIHBlcmZvcm1KSVRNZW1j cHkodm9pZCAqZHN0LCBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBuKQogewotICAgIEdpZ2FjYWdl QXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGUoc3JjKTsKICNpZiBDUFUoQVJNNjQpCiAgICAgc3RhdGlj IGNvbnN0ZXhwciBzaXplX3QgaW5zdHJ1Y3Rpb25TaXplID0gc2l6ZW9mKHVuc2lnbmVkKTsKICAg ICBSRUxFQVNFX0FTU0VSVChyb3VuZFVwVG9NdWx0aXBsZU9mPGluc3RydWN0aW9uU2l6ZT4oZHN0 KSA9PSBkc3QpOwpAQCAtMTQ0LDYgKzEzNSw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQq IHBlcmZvcm1KSVRNZW0KICAgICAgICAgewogICAgICAgICAgICAgb3NfdGhyZWFkX3NlbGZfcmVz dHJpY3Rfcnd4X3RvX3J3KCk7CiAgICAgICAgICAgICBtZW1jcHkoZHN0LCBzcmMsIG4pOworICAg ICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIUdpZ2FjYWdlOjpjb250YWlucyhzcmMpKTsKICAgICAg ICAgICAgIG9zX3RocmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90b19yeCgpOwogICAgICAgICAgICAg cmV0dXJuIGRzdDsKICAgICAgICAgfQpAQCAtMTU1LDYgKzE0Nyw3IEBAIHN0YXRpYyBBTFdBWVNf SU5MSU5FIHZvaWQqIHBlcmZvcm1KSVRNZW0KICAgICAgICAgICAgIC8vIG1lbWNweSB0aGF0IHRh a2VzIGFuIG9mZnNldCBpbnRvIHRoZSBKSVQgcmVnaW9uIGFzIGl0cyBkZXN0aW5hdGlvbiAoZmly c3QpIHBhcmFtZXRlci4KICAgICAgICAgICAgIG9mZl90IG9mZnNldCA9IChvZmZfdCkoKHVpbnRw dHJfdClkc3QgLSBzdGFydE9mRml4ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbDx1aW50cHRyX3Q+KCkp OwogICAgICAgICAgICAgcmV0YWdDb2RlUHRyPEpJVFRodW5rUHRyVGFnLCBDRnVuY3Rpb25QdHJU YWc+KGdfanNjQ29uZmlnLmppdFdyaXRlU2VwYXJhdGVIZWFwcykob2Zmc2V0LCBzcmMsIG4pOwor ICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIUdpZ2FjYWdlOjpjb250YWlucyhzcmMpKTsKICAg ICAgICAgICAgIHJldHVybiBkc3Q7CiAgICAgICAgIH0KICNlbmRpZgo=