201777 2019-09-13 15:18:31 -0700 iOS 13: Some SPI targets 13.1 2019-09-13 17:04:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201781 InRadar P2 Normal --- 1 jbedard jbedard ap benjamin cdumez cmarcelo commit-queue dbates ews-watchlist ryanhaddad webkit-bug-importer youennf oldest_to_newest 1570718 0 jbedard 2019-09-13 15:18:31 -0700 There are a number of SPIs which aren't available in the 13.0 SDK, and are instead for 13.1. Our macros should reflect this. 1570721 1 378755 jbedard 2019-09-13 15:31:56 -0700 Created attachment 378755 Patch 1570730 2 378755 ap 2019-09-13 16:04:00 -0700 Comment on attachment 378755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378755&action=review r=me, because the issues are pre-existing. > Source/WTF/wtf/Platform.h:1490 > +#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130100 PLATFORM(IOS_FAMILY) here is weird. The check for __IPHONE_OS_VERSION_MIN_REQUIRED makes it so that the code is only enabled on iOS, so we should change it to PLATFORM(IOS). But maybe this is not intentional? May be worth checking with a domain expert. > Source/WTF/wtf/Platform.h:1544 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130100) Same here, PLATFORM(IOS_FAMILY) is either misleading or incorrect. To bee 100% precise, we would need a HAVE macro that would be accurate on all platforms that have the function, and a USE macro that tells use where we choose to use it. 1570737 3 jbedard 2019-09-13 16:17:25 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 378755 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378755&action=review > > r=me, because the issues are pre-existing. > > > Source/WTF/wtf/Platform.h:1490 > > +#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130100 > > PLATFORM(IOS_FAMILY) here is weird. The check for > __IPHONE_OS_VERSION_MIN_REQUIRED makes it so that the code is only enabled > on iOS, so we should change it to PLATFORM(IOS). > > But maybe this is not intentional? May be worth checking with a domain > expert. > > > Source/WTF/wtf/Platform.h:1544 > > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130100) > > Same here, PLATFORM(IOS_FAMILY) is either misleading or incorrect. > > To bee 100% precise, we would need a HAVE macro that would be accurate on > all platforms that have the function, and a USE macro that tells use where > we choose to use it. I file <https://bugs.webkit.org/show_bug.cgi?id=201781>...I'd like to get those changes right, seems like the addition of the IOS_FAMILY macro has made some things more confusing. 1570739 4 ap 2019-09-13 16:21:37 -0700 > seems like the addition of the IOS_FAMILY macro has made some things more confusing. PLATFORM(IOS_FAMILY) is a new name for PLATFORM(IOS), which was a misnomer. It's less confusing, but it uncovered a lot of incorrect assumptions that people made thinking that PLATFORM(IOS) is only true on iOS. Keith Rollin recently fixed many of those. 1570759 5 378755 commit-queue 2019-09-13 17:00:51 -0700 Comment on attachment 378755 Patch Clearing flags on attachment: 378755 Committed r249859: <https://trac.webkit.org/changeset/249859> 1570760 6 commit-queue 2019-09-13 17:00:53 -0700 All reviewed patches have been landed. Closing bug. 1570761 7 webkit-bug-importer 2019-09-13 17:04:29 -0700 <rdar://problem/55358068> 378755 2019-09-13 15:31:56 -0700 2019-09-13 17:00:51 -0700 Patch bug-201777-20190913153156.patch text/plain 1499 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDk4NTYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA5LTEzICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBpT1MgMTM6IFNvbWUgU1BJIHRhcmdldHMgMTMu MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNzc3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYv UGxhdGZvcm0uaDoKKwogMjAxOS0wOS0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgSGFyZGVuIEpTQyBhZ2FpbnN0IHRoZSBhYnVzZSBvZiBydW50aW1lIG9wdGlv bnMuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDI0OTg1MikKKysrIFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0ODcsNyArMTQ4Nyw3IEBACiAjZGVmaW5l IEhBVkVfQUNDRVNTSUJJTElUWV9TVVBQT1JUIDEKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oSU9T X0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwCisj aWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTMwMDAwICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTMwMTAw CiAjZGVmaW5lIEhBVkVfQUNDRVNTSUJJTElUWV9CVU5ETEVTX1BBVEggMQogI2VuZGlmCiAKQEAg LTE1NDEsNyArMTU0MSw3IEBACiAjZGVmaW5lIEhBVkVfRElTQUxMT1dBQkxFX1VTRVJfSU5TVEFM TEVEX0ZPTlRTIDEKICNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAm JiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDApCisjaWYgKFBMQVRG T1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8 IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSAxMzAwMDAgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMzAxMDAp CiAjZGVmaW5lIEhBVkVfQ1RGT05UQ1JFQVRFRk9SQ0hBUkFDVEVSU1dJVEhMQU5HVUFHRUFORE9Q VElPTiAxCiAjZW5kaWYKIAo=