201774 2019-09-13 14:20:04 -0700 We should never fail to allocate VA for the Gigacage. 2019-09-13 15:07:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1570703 0 mark.lam 2019-09-13 14:20:04 -0700 Unfortunately, this is still not true for OS(LINUX). So, I'll leave the GIGACAGE_ALLOCATION_CAN_FAIL code in place but disable it for everything else. <rdar://problem/55352042> 1570705 1 378753 mark.lam 2019-09-13 14:25:07 -0700 Created attachment 378753 proposed patch. 1570706 2 378753 ysuzuki 2019-09-13 14:26:55 -0700 Comment on attachment 378753 proposed patch. r=me 1570717 3 mark.lam 2019-09-13 15:07:34 -0700 Thanks for the review. Landed in r249856: <http://trac.webkit.org/r249856>. 378753 2019-09-13 14:25:07 -0700 2019-09-13 14:26:55 -0700 proposed patch. bug-201774.patch text/plain 1944 mark.lam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTg1NCkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTEzICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBXZSBzaG91bGQgbmV2ZXIgZmFpbCB0 byBhbGxvY2F0ZSBWQSBmb3IgdGhlIEdpZ2FjYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNzc0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81 NTM1MjA0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVbmZvcnR1bmF0ZWx5LCB0aGlzIGlzIHN0aWxsIG5vdCB0cnVlIGZvciBPUyhMSU5VWCkuICBT bywgSSdsbCBsZWF2ZSB0aGUKKyAgICAgICAgR0lHQUNBR0VfQUxMT0NBVElPTl9DQU5fRkFJTCBj b2RlIGluIHBsYWNlIGJ1dCBkaXNhYmxlIGl0IGZvciBldmVyeXRoaW5nIGVsc2UuCisKKyAgICAg ICAgKiBibWFsbG9jL0dpZ2FjYWdlLmg6CisKIDIwMTktMDktMDkgIE1pY2hhZWwgU2Fib2ZmICA8 bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IHRvIHByZS1yMjQzMTQ0IHNjYXZl bmdpbmcgYmVoYXZpb3IgZm9yIG1hY09TCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dp Z2FjYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9HaWdhY2FnZS5o CShyZXZpc2lvbiAyNDk4NTQpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmgJ KHdvcmtpbmcgY29weSkKQEAgLTcxLDIwICs3MSwxOSBAQCBjb25zdGV4cHIgc2l6ZV90IHByaW1p dGl2ZUdpZ2FjYWdlU2l6ZSA9CiBjb25zdGV4cHIgc2l6ZV90IGpzVmFsdWVHaWdhY2FnZVNpemUg PSAyICogYm1hbGxvYzo6U2l6ZXM6OkdCOwogY29uc3RleHByIHNpemVfdCBtYXhpbXVtQ2FnZVNp emVSZWR1Y3Rpb25Gb3JTbGlkZSA9IGJtYWxsb2M6OlNpemVzOjpHQiAvIDQ7CiBjb25zdGV4cHIg c2l6ZV90IGNvbmZpZ1NpemVUb1Byb3RlY3QgPSAxNiAqIGJtYWxsb2M6OlNpemVzOjprQjsKLSNk ZWZpbmUgR0lHQUNBR0VfQUxMT0NBVElPTl9DQU5fRkFJTCAxCiAjZWxzZQogY29uc3RleHByIHNp emVfdCBwcmltaXRpdmVHaWdhY2FnZVNpemUgPSAzMiAqIGJtYWxsb2M6OlNpemVzOjpHQjsKIGNv bnN0ZXhwciBzaXplX3QganNWYWx1ZUdpZ2FjYWdlU2l6ZSA9IDE2ICogYm1hbGxvYzo6U2l6ZXM6 OkdCOwogY29uc3RleHByIHNpemVfdCBtYXhpbXVtQ2FnZVNpemVSZWR1Y3Rpb25Gb3JTbGlkZSA9 IDQgKiBibWFsbG9jOjpTaXplczo6R0I7CiBjb25zdGV4cHIgc2l6ZV90IGNvbmZpZ1NpemVUb1By b3RlY3QgPSA0ICogYm1hbGxvYzo6U2l6ZXM6OmtCOwotI2RlZmluZSBHSUdBQ0FHRV9BTExPQ0FU SU9OX0NBTl9GQUlMIDAKICNlbmRpZgogCiAvLyBJbiBMaW51eCwgaWYgYHZtLm92ZXJjb21taXRf bWVtb3J5ID0gMmAgaXMgc3BlY2lmaWVkLCBtbWFwIHdpdGggbGFyZ2Ugc2l6ZSBjYW4gZmFpbCBp ZiBpdCBleGNlZWRzIHRoZSBzaXplIG9mIFJBTS4KIC8vIFNvIHdlIHNwZWNpZnkgR0lHQUNBR0Vf QUxMT0NBVElPTl9DQU5fRkFJTCA9IDEuCiAjaWYgQk9TKExJTlVYKQotI3VuZGVmIEdJR0FDQUdF X0FMTE9DQVRJT05fQ0FOX0ZBSUwKICNkZWZpbmUgR0lHQUNBR0VfQUxMT0NBVElPTl9DQU5fRkFJ TCAxCisjZWxzZQorI2RlZmluZSBHSUdBQ0FHRV9BTExPQ0FUSU9OX0NBTl9GQUlMIDAKICNlbmRp ZgogCiAK