201761 2019-09-13 06:56:53 -0700 Add release logging in WebLoaderStrategy to check that a load is going through service worker 2019-09-14 03:12:15 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1570569 0 youennf 2019-09-13 06:56:53 -0700 Add release logging in WebLoaderStrategy to check that a load is going through service worker 1570570 1 378728 youennf 2019-09-13 06:57:49 -0700 Created attachment 378728 Patch 1570583 2 378728 cdumez 2019-09-13 08:25:42 -0700 Comment on attachment 378728 Patch Can we add RELEASE_LOGGING to scheduleLoadFromNetworkProcess() also? Otherwise, we cannot tell that the service worker did not handle the request and that we went to the network. It looks like we only have debug logging at the moment. 1570850 3 378789 youennf 2019-09-14 01:55:17 -0700 Created attachment 378789 Patch for landing 1570851 4 youennf 2019-09-14 01:56:14 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 378728 [details] > Patch > > Can we add RELEASE_LOGGING to scheduleLoadFromNetworkProcess() also? > Otherwise, we cannot tell that the service worker did not handle the request > and that we went to the network. It looks like we only have debug logging at > the moment. I added some logging for that and made the first logging dependent on whether there is a service worker identifier in the options. 1570853 5 378789 commit-queue 2019-09-14 03:11:29 -0700 Comment on attachment 378789 Patch for landing Clearing flags on attachment: 378789 Committed r249872: <https://trac.webkit.org/changeset/249872> 1570854 6 commit-queue 2019-09-14 03:11:31 -0700 All reviewed patches have been landed. Closing bug. 1570855 7 webkit-bug-importer 2019-09-14 03:12:15 -0700 <rdar://problem/55364801> 378728 2019-09-13 06:57:49 -0700 2019-09-14 01:55:14 -0700 Patch bug-201761-20190913155748.patch text/plain 1984 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZjYWFkNGQ4MmEyODVlZDM5 NTc2MTEwZTJlMzQ3ZWUxYTNkMjgwYzIuLmFlN2RkNmNkMjIwYzRmMTk0MTdlOTEyYTI3N2QwMDEx NDFmODM5ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDktMTMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCByZWxlYXNlIGxvZ2dpbmcg aW4gV2ViTG9hZGVyU3RyYXRlZ3kgdG8gY2hlY2sgdGhhdCBhIGxvYWQgaXMgZ29pbmcgdGhyb3Vn aCBzZXJ2aWNlIHdvcmtlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAxNzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJMb2FkZXJTdHJhdGVneTo6c2NoZWR1bGVMb2FkKToKKwogMjAxOS0w OS0xMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUGFydGl0 aW9uIHByb2Nlc3NlcyBydW5uaW5nIHNlcnZpY2Ugd29ya2VycyBieSBzZXNzaW9uIElECmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVn eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVn eS5jcHAKaW5kZXggYjUzOWJlYjY3OTc0ZjRmYTJhYTEwZDdkOTNiZTM2ZWI1ZDg1Njg5ZS4uYjFk NWI4MTJlZTkyY2U4NDY4ZTc2NDIyYjQ1ODVhMjAzY2EyZDkxNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcApAQCAt MjE0LDYgKzIxNCw4IEBAIHZvaWQgV2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlTG9hZChSZXNv dXJjZUxvYWRlciYgcmVzb3VyY2VMb2FkZXIsIENhY2hlZFJlc291CiAgICAgfQogI2VuZGlmCiAK KyAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKHJlc291cmNlTG9hZGVyLCAic2NoZWR1bGVMb2Fk OiBVUkwgd2lsbCBiZSBzY2hlZHVsZWQgdGhyb3VnaCBTZXJ2aWNlV29ya2VyIG9yIE5ldHdvcmsg UHJvY2VzcyAoZnJhbWUgPSAlcCwgcGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQ Ukl1NjQgIiwgcmVzb3VyY2VJRCA9ICUiIFBSSXU2NCAiKSIsIHJlc291cmNlTG9hZGVyLmZyYW1l KCksIHRyYWNraW5nUGFyYW1ldGVycy5wYWdlSUQudG9VSW50NjQoKSwgdHJhY2tpbmdQYXJhbWV0 ZXJzLmZyYW1lSUQudG9VSW50NjQoKSwgaWRlbnRpZmllcik7CisKICNpZiBFTkFCTEUoU0VSVklD RV9XT1JLRVIpCiAgICAgV2ViU2VydmljZVdvcmtlclByb3ZpZGVyOjpzaW5nbGV0b24oKS5oYW5k bGVGZXRjaChyZXNvdXJjZUxvYWRlciwgc2Vzc2lvbklELCBzaG91bGRDbGVhclJlZmVycmVyT25I VFRQU1RvSFRUUFJlZGlyZWN0LCBbdGhpcywgdHJhY2tpbmdQYXJhbWV0ZXJzLCBpZGVudGlmaWVy LCBzZXNzaW9uSUQsIHNob3VsZENsZWFyUmVmZXJyZXJPbkhUVFBTVG9IVFRQUmVkaXJlY3QsIG1h eGltdW1CdWZmZXJpbmdUaW1lID0gbWF4aW11bUJ1ZmZlcmluZ1RpbWUocmVzb3VyY2UpLCByZXNv dXJjZUxvYWRlciA9IG1ha2VSZWYocmVzb3VyY2VMb2FkZXIpXSAoU2VydmljZVdvcmtlckNsaWVu dEZldGNoOjpSZXN1bHQgcmVzdWx0KSBtdXRhYmxlIHsKICAgICAgICAgaWYgKHJlc3VsdCAhPSBT ZXJ2aWNlV29ya2VyQ2xpZW50RmV0Y2g6OlJlc3VsdDo6VW5oYW5kbGVkKSB7Cg== 378789 2019-09-14 01:55:17 -0700 2019-09-14 03:11:29 -0700 Patch for landing bug-201761-20190914175516.patch text/plain 5151 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFiZjFmNjM1YzQ1Y2I1MDBm MTk0N2RmNzVhZTM0OTlkNDg5YjQ2OTQuLjA1ZTVlYTg3YjJlMGI0MDVkODFiNzk0ZmQ4MGE0Mjg2 MDkyMzNmYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDktMTMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCByZWxlYXNlIGxvZ2dpbmcg aW4gV2ViTG9hZGVyU3RyYXRlZ3kgdG8gY2hlY2sgdGhhdCBhIGxvYWQgaXMgZ29pbmcgdGhyb3Vn aCBzZXJ2aWNlIHdvcmtlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAxNzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAg ICAgICAgVGhpcyBhbGxvd3MgaWRlbnRpZnlpbmcgd2hldGhlciBhIGxvYWQgcmVtYWlucyBwZW5k aW5nIG9uIHRoZSBzZXJ2aWNlIHdvcmtlciBmZXRjaCBwYXRoLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi TG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlTG9hZCk6CisKIDIwMTktMDktMTIgIFJ5YW4gSGFkZGFk ICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjI0OTgwMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3Jr L1dlYkxvYWRlclN0cmF0ZWd5LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3Jr L1dlYkxvYWRlclN0cmF0ZWd5LmNwcAppbmRleCBiNTM5YmViNjc5NzRmNGZhMmFhMTBkN2Q5M2Jl MzZlYjVkODU2ODllLi41NWIzN2MyOTNjMTVkOWZhOTJiZDc1NGY5M2YzOWRmZTIzNDcyMDU4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJh dGVneS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVy U3RyYXRlZ3kuY3BwCkBAIC0yMTUsNiArMjE1LDggQEAgdm9pZCBXZWJMb2FkZXJTdHJhdGVneTo6 c2NoZWR1bGVMb2FkKFJlc291cmNlTG9hZGVyJiByZXNvdXJjZUxvYWRlciwgQ2FjaGVkUmVzb3UK ICNlbmRpZgogCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQorICAgIFJFTEVBU0VfTE9HX0lG X0FMTE9XRUQoISFyZXNvdXJjZUxvYWRlci5vcHRpb25zKCkuc2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbklkZW50aWZpZXIgJiYgcmVzb3VyY2VMb2FkZXIsICJzY2hlZHVsZUxvYWQ6IFVSTCB3aWxs IGJlIHNjaGVkdWxlZCB0aHJvdWdoIFNlcnZpY2VXb3JrZXIgb3IgTmV0d29yayBQcm9jZXNzIChm cmFtZSA9ICVwLCBwYWdlSUQgPSAlIiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCBy ZXNvdXJjZUlEID0gJSIgUFJJdTY0ICIpIiwgcmVzb3VyY2VMb2FkZXIuZnJhbWUoKSwgdHJhY2tp bmdQYXJhbWV0ZXJzLnBhZ2VJRC50b1VJbnQ2NCgpLCB0cmFja2luZ1BhcmFtZXRlcnMuZnJhbWVJ RC50b1VJbnQ2NCgpLCBpZGVudGlmaWVyKTsKKwogICAgIFdlYlNlcnZpY2VXb3JrZXJQcm92aWRl cjo6c2luZ2xldG9uKCkuaGFuZGxlRmV0Y2gocmVzb3VyY2VMb2FkZXIsIHNlc3Npb25JRCwgc2hv dWxkQ2xlYXJSZWZlcnJlck9uSFRUUFNUb0hUVFBSZWRpcmVjdCwgW3RoaXMsIHRyYWNraW5nUGFy YW1ldGVycywgaWRlbnRpZmllciwgc2Vzc2lvbklELCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQ U1RvSFRUUFJlZGlyZWN0LCBtYXhpbXVtQnVmZmVyaW5nVGltZSA9IG1heGltdW1CdWZmZXJpbmdU aW1lKHJlc291cmNlKSwgcmVzb3VyY2VMb2FkZXIgPSBtYWtlUmVmKHJlc291cmNlTG9hZGVyKV0g KFNlcnZpY2VXb3JrZXJDbGllbnRGZXRjaDo6UmVzdWx0IHJlc3VsdCkgbXV0YWJsZSB7CiAgICAg ICAgIGlmIChyZXN1bHQgIT0gU2VydmljZVdvcmtlckNsaWVudEZldGNoOjpSZXN1bHQ6OlVuaGFu ZGxlZCkgewogICAgICAgICAgICAgTE9HKE5ldHdvcmtTY2hlZHVsaW5nLCAiKFdlYlByb2Nlc3Mp IFdlYkxvYWRlclN0cmF0ZWd5OjpzY2hlZHVsZUxvYWQsIHVybCAnJXMnIHdpbGwgYmUgc2NoZWR1 bGVkIHRocm91Z2ggU2VydmljZVdvcmtlciBoYW5kbGUgZmV0Y2ggYWxnb3JpdGhtIiwgcmVzb3Vy Y2VMb2FkZXItPnVybCgpLnN0cmluZygpLmxhdGluMSgpLmRhdGEoKSk7CkBAIC0yMzEsMTYgKzIz MywyMSBAQCB2b2lkIFdlYkxvYWRlclN0cmF0ZWd5OjpzY2hlZHVsZUxvYWQoUmVzb3VyY2VMb2Fk ZXImIHJlc291cmNlTG9hZGVyLCBDYWNoZWRSZXNvdQogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9CiAKLSAgICAgICAgaWYgKCFXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS53ZWJMb2FkZXJT dHJhdGVneSgpLnRyeUxvYWRpbmdVc2luZ1VSTFNjaGVtZUhhbmRsZXIocmVzb3VyY2VMb2FkZXIp KQorICAgICAgICBpZiAoIVdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLndlYkxvYWRlclN0cmF0ZWd5 KCkudHJ5TG9hZGluZ1VzaW5nVVJMU2NoZW1lSGFuZGxlcihyZXNvdXJjZUxvYWRlcikpIHsKKyAg ICAgICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQocmVzb3VyY2VMb2FkZXIuZ2V0KCksICJz Y2hlZHVsZUxvYWQ6IFVSTCB3aWxsIGJlIHNjaGVkdWxlZCB3aXRoIHRoZSBOZXR3b3JrUHJvY2Vz cyAoZnJhbWUgPSAlcCwgcGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQg IiwgcmVzb3VyY2VJRCA9ICUiIFBSSXU2NCAiKSIsIHJlc291cmNlTG9hZGVyLT5mcmFtZSgpLCB0 cmFja2luZ1BhcmFtZXRlcnMucGFnZUlELnRvVUludDY0KCksIHRyYWNraW5nUGFyYW1ldGVycy5m cmFtZUlELnRvVUludDY0KCksIGlkZW50aWZpZXIpOwogICAgICAgICAgICAgV2ViUHJvY2Vzczo6 c2luZ2xldG9uKCkud2ViTG9hZGVyU3RyYXRlZ3koKS5zY2hlZHVsZUxvYWRGcm9tTmV0d29ya1By b2Nlc3MocmVzb3VyY2VMb2FkZXIuZ2V0KCksIHJlc291cmNlTG9hZGVyLT5yZXF1ZXN0KCksIHRy YWNraW5nUGFyYW1ldGVycywgc2Vzc2lvbklELCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1Rv SFRUUFJlZGlyZWN0LCBtYXhpbXVtQnVmZmVyaW5nVGltZSk7Ci0gICAgICAgIGVsc2UKLSAgICAg ICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQocmVzb3VyY2VMb2FkZXIuZ2V0KCksICJzY2hl ZHVsZUxvYWQ6IFVSTCBub3QgaGFuZGxlZCBieSBhbnkgaGFuZGxlcnMgKGZyYW1lID0gJXAsIHBh Z2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0ICIsIHJlc291cmNlSUQgPSAl IiBQUkl1NjQgIikiLCByZXNvdXJjZUxvYWRlci0+ZnJhbWUoKSwgdHJhY2tpbmdQYXJhbWV0ZXJz LnBhZ2VJRC50b1VJbnQ2NCgpLCB0cmFja2luZ1BhcmFtZXRlcnMuZnJhbWVJRC50b1VJbnQ2NCgp LCBpZGVudGlmaWVyKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAg IFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQocmVzb3VyY2VMb2FkZXIuZ2V0KCksICJzY2hlZHVsZUxv YWQ6IFVSTCBub3QgaGFuZGxlZCBieSBhbnkgaGFuZGxlcnMgKGZyYW1lID0gJXAsIHBhZ2VJRCA9 ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1 NjQgIikiLCByZXNvdXJjZUxvYWRlci0+ZnJhbWUoKSwgdHJhY2tpbmdQYXJhbWV0ZXJzLnBhZ2VJ RC50b1VJbnQ2NCgpLCB0cmFja2luZ1BhcmFtZXRlcnMuZnJhbWVJRC50b1VJbnQ2NCgpLCBpZGVu dGlmaWVyKTsKICAgICB9KTsKICNlbHNlCi0gICAgaWYgKCF0cnlMb2FkaW5nVXNpbmdVUkxTY2hl bWVIYW5kbGVyKHJlc291cmNlTG9hZGVyKSkKKyAgICBpZiAoIXRyeUxvYWRpbmdVc2luZ1VSTFNj aGVtZUhhbmRsZXIocmVzb3VyY2VMb2FkZXIpKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0lGX0FM TE9XRUQocmVzb3VyY2VMb2FkZXIsICJzY2hlZHVsZUxvYWQ6IFVSTCB3aWxsIGJlIHNjaGVkdWxl ZCB3aXRoIHRoZSBOZXR3b3JrUHJvY2VzcyAoZnJhbWUgPSAlcCwgcGFnZUlEID0gJSIgUFJJdTY0 ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3VyY2VJRCA9ICUiIFBSSXU2NCAiKSIsIHJl c291cmNlTG9hZGVyLmZyYW1lKCksIHRyYWNraW5nUGFyYW1ldGVycy5wYWdlSUQudG9VSW50NjQo KSwgdHJhY2tpbmdQYXJhbWV0ZXJzLmZyYW1lSUQudG9VSW50NjQoKSwgaWRlbnRpZmllcik7CiAg ICAgICAgIHNjaGVkdWxlTG9hZEZyb21OZXR3b3JrUHJvY2VzcyhyZXNvdXJjZUxvYWRlciwgcmVz b3VyY2VMb2FkZXIucmVxdWVzdCgpLCB0cmFja2luZ1BhcmFtZXRlcnMsIHNlc3Npb25JRCwgc2hv dWxkQ2xlYXJSZWZlcnJlck9uSFRUUFNUb0hUVFBSZWRpcmVjdCwgbWF4aW11bUJ1ZmZlcmluZ1Rp bWUocmVzb3VyY2UpKTsKLSAgICBlbHNlCi0gICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQo cmVzb3VyY2VMb2FkZXIsICJzY2hlZHVsZUxvYWQ6IFVSTCBub3QgaGFuZGxlZCBieSBhbnkgaGFu ZGxlcnMgKGZyYW1lID0gJXAsIHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJ dTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1NjQgIikiLCByZXNvdXJjZUxvYWRlci5mcmFtZSgp LCB0cmFja2luZ1BhcmFtZXRlcnMucGFnZUlELnRvVUludDY0KCksIHRyYWNraW5nUGFyYW1ldGVy cy5mcmFtZUlELnRvVUludDY0KCksIGlkZW50aWZpZXIpOworICAgICAgICByZXR1cm47CisgICAg fQorICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQocmVzb3VyY2VMb2FkZXIsICJzY2hlZHVsZUxv YWQ6IFVSTCBub3QgaGFuZGxlZCBieSBhbnkgaGFuZGxlcnMgKGZyYW1lID0gJXAsIHBhZ2VJRCA9 ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1 NjQgIikiLCByZXNvdXJjZUxvYWRlci5mcmFtZSgpLCB0cmFja2luZ1BhcmFtZXRlcnMucGFnZUlE LnRvVUludDY0KCksIHRyYWNraW5nUGFyYW1ldGVycy5mcmFtZUlELnRvVUludDY0KCksIGlkZW50 aWZpZXIpOwogI2VuZGlmCiB9CiAK