201751 2019-09-12 20:28:09 -0700 [WinCairo][Clang][ANGLE] global_state.cpp(39,1): error: static_assert failed due to requirement 'std::is_trivially_constructible<std::atomic<std::mutex *>>::value' "global mutex is not trivially constructible" 2019-10-01 20:41:16 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham commit-queue dino don.olmstead ews-watchlist graouts jdarpinian kondapallykalyan pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1570485 0 fujii 2019-09-12 20:28:09 -0700 [WinCairo][Clang][ANGLE] global_state.cpp(39,1): error: static_assert failed due to requirement 'std::is_trivially_constructible<std::atomic<std::mutex *>>::value' "global mutex is not trivially constructible" Since r249823, clang-cl can't compile WinCairo while MSVC can do. > [1811/5064] Building CXX object Source\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir\src\libGLESv2\global_state.cpp.obj > FAILED: Source/ThirdParty/ANGLE/CMakeFiles/GLESv2.dir/src/libGLESv2/global_state.cpp.obj > C:\PROGRA~1\LLVM\bin\clang-cl.exe /nologo -TP -DANGLE_ENABLE_D3D11 -DANGLE_ENABLE_D3D9 -DANGLE_ENABLE_ESSL -DANGLE_ENABLE_HLSL -DBUILDING_WITH_CMAKE=1 -DGLESv2_EXPORTS -DGL_API="" -DGL_APICALL="" -DHAVE_CONFIG_H=1 -DLIBGLESV2_IMPLEMENTATION -DNOMINMAX -DUNICODE -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WINDOWS -D_WINSOCKAPI_="" -I..\..\WebKitLibraries\win\include -I..\..\Source\ThirdParty\ANGLE\include -I..\..\Source\ThirdParty\ANGLE\include\KHR -I..\..\Source\ThirdParty\ANGLE\src -I..\..\Source\ThirdParty\ANGLE\src\common\third_party\base -ISource\ThirdParty\ANGLE\include /W4 -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-unknown-argument -Wno-nonportable-include-path -Wno-unknown-pragmas -Wno-macro-redefined -Wno-undef /DWIN32 /D_WINDOWS /GR- /EHsc- -fno-strict-aliasing /MD /O2 /Ob2 /DNDEBUG /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /utf-8 /validate-charset /Oy- -fmsc-version=1911 -std:c++17 /showIncludes /FoSource\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir\src\libGLESv2\global_state.cpp.obj /FdSource\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir\ -c ..\..\Source\ThirdParty\ANGLE\src\libGLESv2\global_state.cpp > ..\..\Source\ThirdParty\ANGLE\src\libGLESv2\global_state.cpp(39,1): error: static_assert failed due to requirement 'std::is_trivially_constructible<std::atomic<std::mutex *>>::value' "global mutex is not trivially constructible" > static_assert(std::is_trivially_constructible<decltype(g_Mutex)>::value, > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. 1570488 1 fujii 2019-09-12 20:39:29 -0700 Mozilla's bug report. 1579743 - Build fails after 13282d7a47a5 error: static_assert failed due to requirement 'std::is_trivially_constructible<std::atomic<std::mutex *>>::value' at gfx/angle/checkout/src/libGLESv2/global_state.cpp(39,1) https://bugzilla.mozilla.org/show_bug.cgi?id=1579743 1570542 2 fujii 2019-09-13 03:10:32 -0700 It seems that Chromium is using libc++'s atomic instead of MSVC's one. It compiles global_state.cpp with -I../../buildtools/third_party/libc++/trunk/include switch. 1573958 3 fujii 2019-09-24 23:42:10 -0700 ANGLE bug ticket: https://crbug.com/angleproject/3936 1575846 4 379985 fujii 2019-10-01 19:51:22 -0700 Created attachment 379985 Patch 1575848 5 ews-watchlist 2019-10-01 19:52:00 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1575865 6 379985 commit-queue 2019-10-01 20:40:34 -0700 Comment on attachment 379985 Patch Clearing flags on attachment: 379985 Committed r250592: <https://trac.webkit.org/changeset/250592> 1575866 7 commit-queue 2019-10-01 20:40:35 -0700 All reviewed patches have been landed. Closing bug. 1575867 8 webkit-bug-importer 2019-10-01 20:41:16 -0700 <rdar://problem/55899837> 379985 2019-10-01 19:51:22 -0700 2019-10-01 20:40:34 -0700 Patch bug-201751-20191002115121.patch text/plain 3113 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMjFkMDI2YWVlNDMzNDZmZjgzZDQ4M2U4MWE4M2U2OWRhNjk2MTQ4Mi4uYjRkODA1OWI1MTA2 YWI5N2ZjMGQ3OTNlODYzODc5NzU4MzFjMzQwMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTAxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb11bQ2xhbmddW0FOR0xFXSBnbG9i YWxfc3RhdGUuY3BwKDM5LDEpOiBlcnJvcjogc3RhdGljX2Fzc2VydCBmYWlsZWQgZHVlIHRvIHJl cXVpcmVtZW50ICdzdGQ6OmlzX3RyaXZpYWxseV9jb25zdHJ1Y3RpYmxlPHN0ZDo6YXRvbWljPHN0 ZDo6bXV0ZXggKj4+Ojp2YWx1ZScgImdsb2JhbCBtdXRleCBpcyBub3QgdHJpdmlhbGx5IGNvbnN0 cnVjdGlibGUiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDE3NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDbGFuZy1jbCBjb3VsZG4ndCBjb21waWxlIHRoZSBsYXRlc3QgQU5HTEUgd2l0aCBNUyBTVEwg b3dpbmcgdG8gYQorICAgICAgICBzdGF0aWNfYXNzZXJ0IGZhaWx1cmUuCisKKyAgICAgICAgRml4 IGl0IGJ5IGNoZXJyaS1waWNraW5nIHRoZSB1cHN0cmVhbSBmaXguCisgICAgICAgIDxodHRwczov L2Nocm9taXVtLmdvb2dsZXNvdXJjZS5jb20vYW5nbGUvYW5nbGUvKy83NTU0MTdkZDc5MDcxZDYx NDljODE0MThlMTQwNGIwYzYxZDE5NjcyPgorCisgICAgICAgICogQVVUSE9SUzoKKyAgICAgICAg KiBzcmMvY29tbW9uL2FuZ2xldXRpbHMuaDoKKyAgICAgICAgKiBzcmMvbGliR0xFU3YyL2dsb2Jh bF9zdGF0ZS5jcHA6CisKIDIwMTktMDktMjQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVy ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBTkdMRSdzIGVnbHBsYXRmb3JtLmggaXMg YnVpbGQgYnJva2VuIHdpdGggLURFTkFCTEVfWDExX1BMQVRGT1JNPU9GRgpkaWZmIC0tZ2l0IGEv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvQVVUSE9SUyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L0FVVEhPUlMKaW5kZXggYWIzOWVlMDFhNDdjMTVkYTU3YjUzMWQyYzcxMTY0OWYxNjg1MDkxYi4u N2EwZjNiMzJiMTAxYjM0MTk1YzU3NjM3YjIyNzA2MmQ5YjE3M2Q2YSAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvQVVUSE9SUworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9BVVRIT1JTCkBAIC01OCwzICs1OCw0IEBAIErDqXLDtG1lIER1dmFsCiBUaG9tYXMgTWlsbGVy CiBUaWxsIFJhdGhtYW5uCiBOaWNrIFNoYWZvcm9zdG92CitKYWltZSBCZXJuYXJkbwpkaWZmIC0t Z2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9hbmdsZXV0aWxzLmggYi9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL2FuZ2xldXRpbHMuaAppbmRleCBkNWQz Y2E4MzEyYTYxZTJkZWJmMzA0Y2FjMjFmMzUzNmVmNmNiNDcyLi4zYzkzZDFiZmRjYTIxYmFiMzMx NjhjMTQ0ZWE1ZmI2MDAyYmZmNWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9zcmMvY29tbW9uL2FuZ2xldXRpbHMuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9z cmMvY29tbW9uL2FuZ2xldXRpbHMuaApAQCAtMzMzLDQgKzMzMywxMCBAQCBzdGQ6OnN0cmluZyBU b1N0cmluZyhjb25zdCBUICZ2YWx1ZSkKICMgICAgZGVmaW5lIEFOR0xFX01BWUJFX1VOVVNFRAog I2VuZGlmICAvLyBfX2hhc19jcHBfYXR0cmlidXRlKG1heWJlX3VudXNlZCkKIAorI2lmIF9faGFz X2NwcF9hdHRyaWJ1dGUocmVxdWlyZV9jb25zdGFudF9pbml0aWFsaXphdGlvbikKKyMgICAgZGVm aW5lIEFOR0xFX1JFUVVJUkVfQ09OU1RBTlRfSU5JVCBbW3JlcXVpcmVfY29uc3RhbnRfaW5pdGlh bGl6YXRpb25dXQorI2Vsc2UKKyMgICAgZGVmaW5lIEFOR0xFX1JFUVVJUkVfQ09OU1RBTlRfSU5J VAorI2VuZGlmICAvLyBfX2hhc19jcHBfYXR0cmlidXRlKHJlcXVpcmVfY29uc3RhbnRfaW5pdGlh bGl6YXRpb24pCisKICNlbmRpZiAgLy8gQ09NTU9OX0FOR0xFVVRJTFNfSF8KZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJHTEVTdjIvZ2xvYmFsX3N0YXRlLmNwcCBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJHTEVTdjIvZ2xvYmFsX3N0YXRlLmNwcApp bmRleCA4ZWE5MTJlZWEwNDVjOTEyZWY2NGRmZWRjZmQ4ZjA3ZGI0MzM3YTlkLi5jOGM5YTczMmZi YWQ1Y2M1MGVkMmE3ZmM0YjUzODdhMzAyNzQ0MzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliR0xFU3YyL2dsb2JhbF9zdGF0ZS5jcHAKKysrIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2xpYkdMRVN2Mi9nbG9iYWxfc3RhdGUuY3BwCkBAIC0zNSw5ICsz NSw4IEBAIG5hbWVzcGFjZQogewogc3RhdGljIFRMU0luZGV4IHRocmVhZFRMUyA9IFRMU19JTlZB TElEX0lOREVYOwogRGVidWcgKmdfRGVidWcgICAgICAgICAgICA9IG51bGxwdHI7Ci1zdGQ6OmF0 b21pYzxzdGQ6Om11dGV4ICo+IGdfTXV0ZXg7Ci1zdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfdHJpdmlh bGx5X2NvbnN0cnVjdGlibGU8ZGVjbHR5cGUoZ19NdXRleCk+Ojp2YWx1ZSwKLSAgICAgICAgICAg ICAgImdsb2JhbCBtdXRleCBpcyBub3QgdHJpdmlhbGx5IGNvbnN0cnVjdGlibGUiKTsKKworQU5H TEVfUkVRVUlSRV9DT05TVEFOVF9JTklUIHN0ZDo6YXRvbWljPHN0ZDo6bXV0ZXggKj4gZ19NdXRl eChudWxscHRyKTsKIHN0YXRpY19hc3NlcnQoc3RkOjppc190cml2aWFsbHlfZGVzdHJ1Y3RpYmxl PGRlY2x0eXBlKGdfTXV0ZXgpPjo6dmFsdWUsCiAgICAgICAgICAgICAgICJnbG9iYWwgbXV0ZXgg aXMgbm90IHRyaXZpYWxseSBkZXN0cnVjdGlibGUiKTsKIAo=