201732 2019-09-12 12:19:38 -0700 REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data 2019-09-13 12:03:07 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1570322 0 joepeck 2019-09-12 12:19:38 -0700 Web Inspector: Layout Timeline View does not show popover for initiator data Steps to Reproduce: 1. Record a timeline with forced layouts 2. Show Detail Layout and Rendering timeline 3. Select a Forced Layout row => expected popover, but was none. Uncaught exception. 1570323 1 webkit-bug-importer 2019-09-12 12:20:05 -0700 <rdar://problem/55312339> 1570324 2 378666 joepeck 2019-09-12 12:20:44 -0700 Created attachment 378666 [PATCH] Proposed Fix 1570403 3 378666 hi 2019-09-12 15:30:56 -0700 Comment on attachment 378666 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378666&action=review r=me, this is another example of why UI tests would be awesome, as well as another reason why I don't like `WI.DataGrid` :( > Source/WebInspectorUI/ChangeLog:3 > + REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data I think this was r243301. 1570662 4 378666 commit-queue 2019-09-13 12:03:06 -0700 Comment on attachment 378666 [PATCH] Proposed Fix Clearing flags on attachment: 378666 Committed r249847: <https://trac.webkit.org/changeset/249847> 1570663 5 commit-queue 2019-09-13 12:03:07 -0700 All reviewed patches have been landed. Closing bug. 378666 2019-09-12 12:20:44 -0700 2019-09-13 12:03:06 -0700 [PATCH] Proposed Fix layout-1.patch text/plain 1681 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBlNmZmNDZiN2ExLi4wYzA1NjBlZGNjNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDktMTIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBX ZWIgSW5zcGVjdG9yOiBMYXlvdXQgVGltZWxpbmUgVmlldyBkb2VzIG5vdCBzaG93IHBvcG92ZXIg Zm9yIGluaXRpYXRvciBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDE3MzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1MzEyMzM5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFHcmlkLmpzOgorICAgICAgICAoV0kuTGF5b3V0 VGltZWxpbmVEYXRhR3JpZC5wcm90b3R5cGUuY2FsbEZyYW1lUG9wb3ZlckFuY2hvckVsZW1lbnQp OgorICAgICAgICAoV0kuTGF5b3V0VGltZWxpbmVEYXRhR3JpZC5wcm90b3R5cGUuc2hvdWxkU2hv d0NhbGxGcmFtZVBvcG92ZXIpOgorICAgICAgICBUaGUgY29sdW1uIG5hbWUgd2FzIGluY29ycmVj dC4KKwogMjAxOS0wOS0xMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtPdmVycmlkZXNdIENvbW1hbmQtWiBkb2Vzbid0IHVu ZG8gY2hhbmdlcyBhZnRlciBwYWdlIHJlbG9hZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lRGF0 YUdyaWQuanMKaW5kZXggNGYzZTA1MjlmZmIuLmM2Y2EwMDM3MmY2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFH cmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xh eW91dFRpbWVsaW5lRGF0YUdyaWQuanMKQEAgLTI5LDExICsyOSwxMSBAQCBXSS5MYXlvdXRUaW1l bGluZURhdGFHcmlkID0gY2xhc3MgTGF5b3V0VGltZWxpbmVEYXRhR3JpZCBleHRlbmRzIFdJLlRp bWVsaW5lRGF0YQogCiAgICAgY2FsbEZyYW1lUG9wb3ZlckFuY2hvckVsZW1lbnQoKQogICAgIHsK LSAgICAgICAgcmV0dXJuIHRoaXMuc2VsZWN0ZWROb2RlLmVsZW1lbnRXaXRoQ29sdW1uSWRlbnRp ZmllcigibG9jYXRpb24iKTsKKyAgICAgICAgcmV0dXJuIHRoaXMuc2VsZWN0ZWROb2RlLmVsZW1l bnRXaXRoQ29sdW1uSWRlbnRpZmllcigiaW5pdGlhdG9yIik7CiAgICAgfQogCiAgICAgc2hvdWxk U2hvd0NhbGxGcmFtZVBvcG92ZXIoKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuaXNDb2x1 bW5WaXNpYmxlKCJsb2NhdGlvbiIpOworICAgICAgICByZXR1cm4gdGhpcy5pc0NvbHVtblZpc2li bGUoImluaXRpYXRvciIpOwogICAgIH0KIH07Cg==