20173 2008-07-25 14:09:17 -0700 wx port does not show tooltips 2008-07-29 22:34:54 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kevinwatters kevino oldest_to_newest 86964 0 kevinwatters 2008-07-25 14:09:17 -0700 The wx port's ChromeClient didn't implement the setToolTip method. 86967 1 22481 kevinwatters 2008-07-25 14:12:27 -0700 Created attachment 22481 implement ChromeClientWx::setToolTip Implements ChromeClientWx::setToolTip and modifies wxWebView's mouse event handler to use EventHandler::mouseMoved instead of handleMouseMoveEvent. 87047 2 22481 eric 2008-07-26 22:52:31 -0700 Comment on attachment 22481 implement ChromeClientWx::setToolTip Looks fine except for the tabs. WebCore uses 4 spaces, not tabs. Also, which way is the easier conversion? + if (!tooltip || tooltip->GetTip() != wxString(tip)) + m_webView->SetToolTip(tip); From wxString to String or the other way? I'm surprised that you need the explicit wxString conversion there at all. Since you don't have the ability to commit your own patches (yet), please upload a new patch without tabs. Thanks! 87082 3 22508 kevinwatters 2008-07-27 13:10:40 -0700 Created attachment 22508 Revised tooltip support patch for the wx port. Removed all the tabs. Unfortunately, the explicit wxString conversion is necessary at the moment--the compiler complains about ambiguous overloads. Perhaps a future patch could resolve this. 87362 4 kevino 2008-07-29 22:34:54 -0700 Landed in r35437, thanks! :) 22481 2008-07-25 14:12:27 -0700 2008-07-27 13:10:40 -0700 implement ChromeClientWx::setToolTip WebKitTooltips.diff text/plain 1874 kevinwatters ZGlmZiAtLWdpdCBhL1dlYktpdC93eC9DaGFuZ2VMb2cgYi9XZWJLaXQvd3gvQ2hhbmdlTG9nCmlu ZGV4IGQxMzBiZDMuLmY4YTMwZGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3d4L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA4LTA3LTI1ICBLZXZp biBXYXR0ZXJzICA8a2V2aW53YXR0ZXJzQGdtYWlsLmNvbT4KKworICAgICAgICBUb29sdGlwIHN1 cHBvcnQgZm9yIHRoZSB3eCBwb3J0LgorCisgICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAg ICh3eFdlYlZpZXc6Ok9uTW91c2VFdmVudHMpOiB1c2UgbW91c2VNb3ZlZCBpbnN0ZWFkIG9mIGhh bmRsZU1vdXNlTW92ZUV2ZW50CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRX eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRXeDo6c2V0VG9vbFRpcCk6CisK IDIwMDgtMDctMjEgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAK ICAgICAgICAgd3ggYnVpbGQgZml4LiBGaXggcHRocmVhZCBsaW5rYWdlIHVuZGVyIExpbnV4Lgpk aWZmIC0tZ2l0IGEvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvQ2hyb21lQ2xpZW50V3guY3BwIGIv V2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvQ2hyb21lQ2xpZW50V3guY3BwCmluZGV4IGY1ZDQxNTQu LmIyODcwYWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9XZWJLaXRTdXBwb3J0L0Nocm9tZUNsaWVu dFd4LmNwcAorKysgYi9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRXeC5jcHAK QEAgLTM5LDYgKzM5LDcgQEAKICAgICAjaW5jbHVkZSA8d3gvd3guaD4KICNlbmRpZgogI2luY2x1 ZGUgPHd4L3RleHRkbGcuaD4KKyNpbmNsdWRlIDx3eC90b29sdGlwLmg+CiAKICNpbmNsdWRlICJX ZWJCcm93c2VyU2hlbGwuaCIKICNpbmNsdWRlICJXZWJWaWV3LmgiCkBAIC0zMDQsOSArMzA1LDEx IEBAIHZvaWQgQ2hyb21lQ2xpZW50V3g6Om1vdXNlRGlkTW92ZU92ZXJFbGVtZW50KGNvbnN0IEhp dFRlc3RSZXN1bHQmLCB1bnNpZ25lZCBtb2RpCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAot dm9pZCBDaHJvbWVDbGllbnRXeDo6c2V0VG9vbFRpcChjb25zdCBTdHJpbmcmKQordm9pZCBDaHJv bWVDbGllbnRXeDo6c2V0VG9vbFRpcChjb25zdCBTdHJpbmcmIHRpcCkKIHsKLSAgICBub3RJbXBs ZW1lbnRlZCgpOworCXd4VG9vbFRpcCogdG9vbHRpcCA9IG1fd2ViVmlldy0+R2V0VG9vbFRpcCgp OworCWlmICghdG9vbHRpcCB8fCB0b29sdGlwLT5HZXRUaXAoKSAhPSB3eFN0cmluZyh0aXApKQor CQltX3dlYlZpZXctPlNldFRvb2xUaXAodGlwKTsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnRXeDo6 cHJpbnQoRnJhbWUqKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3d4L1dlYlZpZXcuY3BwIGIvV2ViS2l0 L3d4L1dlYlZpZXcuY3BwCmluZGV4IGIxOTc1M2UuLmE1ZmVlOTkgMTAwNjQ0Ci0tLSBhL1dlYktp dC93eC9XZWJWaWV3LmNwcAorKysgYi9XZWJLaXQvd3gvV2ViVmlldy5jcHAKQEAgLTUzNyw3ICs1 MzcsNyBAQCB2b2lkIHd4V2ViVmlldzo6T25Nb3VzZUV2ZW50cyh3eE1vdXNlRXZlbnQmIGV2ZW50 KQogICAgICAgICBtX2ltcGwtPmZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VSZWxl YXNlRXZlbnQod2tFdmVudCk7CiAKICAgICBlbHNlIGlmICh0eXBlID09IHd4RVZUX01PVElPTikK LSAgICAgICAgbV9pbXBsLT5mcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlTW92ZUV2 ZW50KHdrRXZlbnQpOworICAgICAgICBtX2ltcGwtPmZyYW1lLT5ldmVudEhhbmRsZXIoKS0+bW91 c2VNb3ZlZCh3a0V2ZW50KTsKIH0KIAogYm9vbCB3eFdlYlZpZXc6OkNhbkNvcHkoKQo= 22508 2008-07-27 13:10:40 -0700 2008-07-29 10:29:24 -0700 Revised tooltip support patch for the wx port. wxToolTipRevised.diff text/plain 1929 kevinwatters ZGlmZiAtLWdpdCBhL1dlYktpdC93eC9DaGFuZ2VMb2cgYi9XZWJLaXQvd3gvQ2hhbmdlTG9nCmlu ZGV4IGQxMzBiZDMuLjdlMWE1YjEgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3d4L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA4LTA3LTI3ICBLZXZp biBXYXR0ZXJzICA8a2V2aW53YXR0ZXJzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdG9vbHRpcCBzdXBwb3J0IHRvIHRoZSB3 eCBwb3J0LgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRXeC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRXeDo6c2V0VG9vbFRpcCk6CisgICAgICAgICog V2ViVmlldy5jcHA6CisgICAgICAgICh3eFdlYlZpZXc6Ok9uTW91c2VFdmVudHMpOiBVc2UgbW91 c2VNb3ZlZCBpbnN0ZWFkIG9mIGhhbmRsZU1vdXNlTW92ZUV2ZW50LgorCiAyMDA4LTA3LTIxICBL ZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIHd4IGJ1 aWxkIGZpeC4gRml4IHB0aHJlYWQgbGlua2FnZSB1bmRlciBMaW51eC4KZGlmZiAtLWdpdCBhL1dl YktpdC93eC9XZWJLaXRTdXBwb3J0L0Nocm9tZUNsaWVudFd4LmNwcCBiL1dlYktpdC93eC9XZWJL aXRTdXBwb3J0L0Nocm9tZUNsaWVudFd4LmNwcAppbmRleCBmNWQ0MTU0Li4xMzI2YmE4IDEwMDY0 NAotLS0gYS9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRXeC5jcHAKKysrIGIv V2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvQ2hyb21lQ2xpZW50V3guY3BwCkBAIC0zOSw2ICszOSw3 IEBACiAgICAgI2luY2x1ZGUgPHd4L3d4Lmg+CiAjZW5kaWYKICNpbmNsdWRlIDx3eC90ZXh0ZGxn Lmg+CisjaW5jbHVkZSA8d3gvdG9vbHRpcC5oPgogCiAjaW5jbHVkZSAiV2ViQnJvd3NlclNoZWxs LmgiCiAjaW5jbHVkZSAiV2ViVmlldy5oIgpAQCAtMzA0LDkgKzMwNSwxMSBAQCB2b2lkIENocm9t ZUNsaWVudFd4Ojptb3VzZURpZE1vdmVPdmVyRWxlbWVudChjb25zdCBIaXRUZXN0UmVzdWx0Jiwg dW5zaWduZWQgbW9kaQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZvaWQgQ2hyb21lQ2xp ZW50V3g6OnNldFRvb2xUaXAoY29uc3QgU3RyaW5nJikKK3ZvaWQgQ2hyb21lQ2xpZW50V3g6OnNl dFRvb2xUaXAoY29uc3QgU3RyaW5nJiB0aXApCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAg ICB3eFRvb2xUaXAqIHRvb2x0aXAgPSBtX3dlYlZpZXctPkdldFRvb2xUaXAoKTsKKyAgICBpZiAo IXRvb2x0aXAgfHwgdG9vbHRpcC0+R2V0VGlwKCkgIT0gd3hTdHJpbmcodGlwKSkKKyAgICAgICAg bV93ZWJWaWV3LT5TZXRUb29sVGlwKHRpcCk7CiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50V3g6OnBy aW50KEZyYW1lKikKZGlmZiAtLWdpdCBhL1dlYktpdC93eC9XZWJWaWV3LmNwcCBiL1dlYktpdC93 eC9XZWJWaWV3LmNwcAppbmRleCBiMTk3NTNlLi5hNWZlZTk5IDEwMDY0NAotLS0gYS9XZWJLaXQv d3gvV2ViVmlldy5jcHAKKysrIGIvV2ViS2l0L3d4L1dlYlZpZXcuY3BwCkBAIC01MzcsNyArNTM3 LDcgQEAgdm9pZCB3eFdlYlZpZXc6Ok9uTW91c2VFdmVudHMod3hNb3VzZUV2ZW50JiBldmVudCkK ICAgICAgICAgbV9pbXBsLT5mcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlUmVsZWFz ZUV2ZW50KHdrRXZlbnQpOwogCiAgICAgZWxzZSBpZiAodHlwZSA9PSB3eEVWVF9NT1RJT04pCi0g ICAgICAgIG1faW1wbC0+ZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVNb3VzZU1vdmVFdmVu dCh3a0V2ZW50KTsKKyAgICAgICAgbV9pbXBsLT5mcmFtZS0+ZXZlbnRIYW5kbGVyKCktPm1vdXNl TW92ZWQod2tFdmVudCk7CiB9CiAKIGJvb2wgd3hXZWJWaWV3OjpDYW5Db3B5KCkK