201716 2019-09-12 00:01:25 -0700 Uncaught Exception: TypeError: null is not an object (evaluating 'selectedTreeElement.representedObject') 2019-09-12 00:50:26 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1570180 0 joepeck 2019-09-12 00:01:25 -0700 Uncaught Exception: TypeError: null is not an object (evaluating 'selectedTreeElement.representedObject') * STEPS TO REPRODUCE 1. Inspect any page 2. Set a breakpoint by clicking in the gutter 3. Delete the breakpoint by dragging it off the gutter => Exception * NOTES - The Breakpoint Tree Outline doesn't have any selected tree element and the breakpoint is getting removed. ------- Uncaught Exceptions: - TypeError: null is not an object (evaluating 'selectedTreeElement.representedObject') (at SourcesNavigationSidebarPanel.js:1763:36) _handleBreakpointElementAddedOrRemoved @ SourcesNavigationSidebarPanel.js:1763:36 dispatch @ Object.js:165:30 dispatchEventToListeners @ Object.js:172:17 removeChildAtIndex @ TreeOutline.js:392:49 removeChild @ TreeOutline.js:406:32 _removeDebuggerTreeElement @ SourcesNavigationSidebarPanel.js:1209:38 _removeBreakpoint @ SourcesNavigationSidebarPanel.js:1148:40 _handleDebuggerBreakpointRemoved @ SourcesNavigationSidebarPanel.js:1985:31 dispatch @ Object.js:165:30 dispatchEventToListeners @ Object.js:172:17 removeBreakpoint @ DebuggerManager.js:636:38 textEditorBreakpointRemoved @ SourceCodeTextEditor.js:1329:44 _documentMouseUp @ TextEditor.js:1598:63 _documentMouseUp @ [native code] ------- 1570181 1 webkit-bug-importer 2019-09-12 00:01:46 -0700 <rdar://problem/55292615> 1570182 2 378627 joepeck 2019-09-12 00:04:08 -0700 Created attachment 378627 [PATCH] Proposed Fix 1570183 3 378627 hi 2019-09-12 00:06:25 -0700 Comment on attachment 378627 [PATCH] Proposed Fix r=me, good catch! 1570189 4 378627 commit-queue 2019-09-12 00:50:24 -0700 Comment on attachment 378627 [PATCH] Proposed Fix Clearing flags on attachment: 378627 Committed r249800: <https://trac.webkit.org/changeset/249800> 1570190 5 commit-queue 2019-09-12 00:50:26 -0700 All reviewed patches have been landed. Closing bug. 378627 2019-09-12 00:04:08 -0700 2019-09-12 00:50:24 -0700 [PATCH] Proposed Fix breakpoint-1.patch text/plain 5220 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAyNmE4ZWEzZDMxLi5iZGZmNjUzZmUyMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDktMTIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBVbmNhdWdodCBFeGNl cHRpb246IFR5cGVFcnJvcjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdzZWxl Y3RlZFRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0JykKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTcxNgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTUyOTI2MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzOgorICAg ICAgICAoV0kuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9oYW5kbGVCcmVha3BvaW50 RWxlbWVudEFkZGVkT3JSZW1vdmVkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Nv dXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuU291cmNlc05hdmln YXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl9oYW5kbGVCcmVha3BvaW50RWxlbWVudEFkZGVk T3JSZW1vdmVkKToKKyAgICAgICAgSWYgYSBicmVha3BvaW50IHdhcyByZW1vdmVkIHdpdGhvdXQg YSBzZWxlY3Rpb24gaW4gdGhlIGJyZWFrcG9pbnQgdHJlZSBvdXRsaW5lCisgICAgICAgIHRoZW4g dGhlcmUgbWF5IGJlIG5vIHNlbGVjdGVkIHRyZWUgZWxlbWVudC4KKwogMjAxOS0wOS0xMSAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJFR1JFU1NJT046IEluc3BlY3RvciBUaW1lbGluZSBhbHdheXMgc3RhcnRzIGF0IGFib3V0 IDUwMG1zIG1hcmsgb24gYSByZWxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMK aW5kZXggMDllZmE2MmIwOTQuLjg2ZGJhNjhmZGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGVi YXJQYW5lbC5qcwpAQCAtMTU5NSwxNiArMTU5NSwxNyBAQCBXSS5EZWJ1Z2dlclNpZGViYXJQYW5l bCA9IGNsYXNzIERlYnVnZ2VyU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlvblNpZGVi YQogCiAgICAgICAgIGlmIChldmVudC50eXBlID09PSBXSS5UcmVlT3V0bGluZS5FdmVudC5FbGVt ZW50UmVtb3ZlZCkgewogICAgICAgICAgICAgbGV0IHNlbGVjdGVkVHJlZUVsZW1lbnQgPSB0aGlz Ll9icmVha3BvaW50c0NvbnRlbnRUcmVlT3V0bGluZS5zZWxlY3RlZFRyZWVFbGVtZW50OwotICAg ICAgICAgICAgY29uc29sZS5hc3NlcnQoc2VsZWN0ZWRUcmVlRWxlbWVudCk7Ci0gICAgICAgICAg ICBpZiAoc2VsZWN0ZWRUcmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCA9PT0gV0kuZGVidWdn ZXJNYW5hZ2VyLmFzc2VydGlvbkZhaWx1cmVzQnJlYWtwb2ludCB8fCAhV0kuZGVidWdnZXJNYW5h Z2VyLmlzQnJlYWtwb2ludFJlbW92YWJsZShzZWxlY3RlZFRyZWVFbGVtZW50LnJlcHJlc2VudGVk T2JqZWN0KSkgewotICAgICAgICAgICAgICAgIGNvbnN0IHNraXBVbnJldmVhbGVkID0gdHJ1ZTsK LSAgICAgICAgICAgICAgICBjb25zdCBkb250UG9wdWxhdGUgPSB0cnVlOwotICAgICAgICAgICAg ICAgIGxldCB0cmVlRWxlbWVudFRvU2VsZWN0ID0gc2VsZWN0ZWRUcmVlRWxlbWVudC50cmF2ZXJz ZU5leHRUcmVlRWxlbWVudChza2lwVW5yZXZlYWxlZCwgZG9udFBvcHVsYXRlKTsKLSAgICAgICAg ICAgICAgICBpZiAodHJlZUVsZW1lbnRUb1NlbGVjdCkgewotICAgICAgICAgICAgICAgICAgICBj b25zdCBvbWl0Rm9jdXMgPSB0cnVlOwotICAgICAgICAgICAgICAgICAgICBjb25zdCBzZWxlY3Rl ZEJ5VXNlciA9IHRydWU7Ci0gICAgICAgICAgICAgICAgICAgIHRyZWVFbGVtZW50VG9TZWxlY3Qu c2VsZWN0KG9taXRGb2N1cywgc2VsZWN0ZWRCeVVzZXIpOwotICAgICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIGlmIChzZWxlY3RlZFRyZWVFbGVtZW50KSB7CisgICAgICAgICAgICAgICAgaWYg KHNlbGVjdGVkVHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgPT09IFdJLmRlYnVnZ2VyTWFu YWdlci5hc3NlcnRpb25GYWlsdXJlc0JyZWFrcG9pbnQgfHwgIVdJLmRlYnVnZ2VyTWFuYWdlci5p c0JyZWFrcG9pbnRSZW1vdmFibGUoc2VsZWN0ZWRUcmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVj dCkpIHsKKyAgICAgICAgICAgICAgICAgICAgY29uc3Qgc2tpcFVucmV2ZWFsZWQgPSB0cnVlOwor ICAgICAgICAgICAgICAgICAgICBjb25zdCBkb250UG9wdWxhdGUgPSB0cnVlOworICAgICAgICAg ICAgICAgICAgICBsZXQgdHJlZUVsZW1lbnRUb1NlbGVjdCA9IHNlbGVjdGVkVHJlZUVsZW1lbnQu dHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQoc2tpcFVucmV2ZWFsZWQsIGRvbnRQb3B1bGF0ZSk7Cisg ICAgICAgICAgICAgICAgICAgIGlmICh0cmVlRWxlbWVudFRvU2VsZWN0KSB7CisgICAgICAgICAg ICAgICAgICAgICAgICBjb25zdCBvbWl0Rm9jdXMgPSB0cnVlOworICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3Qgc2VsZWN0ZWRCeVVzZXIgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICAg ICAgdHJlZUVsZW1lbnRUb1NlbGVjdC5zZWxlY3Qob21pdEZvY3VzLCBzZWxlY3RlZEJ5VXNlcik7 CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9ICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlc05hdmlnYXRpb25TaWRlYmFy UGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3Vy Y2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwppbmRleCBmZjE1MGEyOTFjOC4uYzdkZDNjNTg0 Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpz CkBAIC0xNzU5LDE1ICsxNzU5LDE2IEBAIFdJLlNvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVs ID0gY2xhc3MgU291cmNlc05hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXCiAKICAgICAg ICAgaWYgKGV2ZW50LnR5cGUgPT09IFdJLlRyZWVPdXRsaW5lLkV2ZW50LkVsZW1lbnRSZW1vdmVk KSB7CiAgICAgICAgICAgICBsZXQgc2VsZWN0ZWRUcmVlRWxlbWVudCA9IHRoaXMuX2JyZWFrcG9p bnRzVHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudDsKLSAgICAgICAgICAgIGNvbnNvbGUu YXNzZXJ0KHNlbGVjdGVkVHJlZUVsZW1lbnQpOwotICAgICAgICAgICAgaWYgKHNlbGVjdGVkVHJl ZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgPT09IFdJLmRlYnVnZ2VyTWFuYWdlci5hc3NlcnRp b25GYWlsdXJlc0JyZWFrcG9pbnQgfHwgIVdJLmRlYnVnZ2VyTWFuYWdlci5pc0JyZWFrcG9pbnRS ZW1vdmFibGUoc2VsZWN0ZWRUcmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCkpIHsKLSAgICAg ICAgICAgICAgICBjb25zdCBza2lwVW5yZXZlYWxlZCA9IHRydWU7Ci0gICAgICAgICAgICAgICAg Y29uc3QgZG9udFBvcHVsYXRlID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICBsZXQgdHJlZUVsZW1l bnRUb1NlbGVjdCA9IHNlbGVjdGVkVHJlZUVsZW1lbnQudHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQo c2tpcFVucmV2ZWFsZWQsIGRvbnRQb3B1bGF0ZSk7Ci0gICAgICAgICAgICAgICAgaWYgKHRyZWVF bGVtZW50VG9TZWxlY3QpIHsKLSAgICAgICAgICAgICAgICAgICAgY29uc3Qgb21pdEZvY3VzID0g dHJ1ZTsKLSAgICAgICAgICAgICAgICAgICAgY29uc3Qgc2VsZWN0ZWRCeVVzZXIgPSB0cnVlOwot ICAgICAgICAgICAgICAgICAgICB0cmVlRWxlbWVudFRvU2VsZWN0LnNlbGVjdChvbWl0Rm9jdXMs IHNlbGVjdGVkQnlVc2VyKTsKKyAgICAgICAgICAgIGlmIChzZWxlY3RlZFRyZWVFbGVtZW50KSB7 CisgICAgICAgICAgICAgICAgaWYgKHNlbGVjdGVkVHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmpl Y3QgPT09IFdJLmRlYnVnZ2VyTWFuYWdlci5hc3NlcnRpb25GYWlsdXJlc0JyZWFrcG9pbnQgfHwg IVdJLmRlYnVnZ2VyTWFuYWdlci5pc0JyZWFrcG9pbnRSZW1vdmFibGUoc2VsZWN0ZWRUcmVlRWxl bWVudC5yZXByZXNlbnRlZE9iamVjdCkpIHsKKyAgICAgICAgICAgICAgICAgICAgY29uc3Qgc2tp cFVucmV2ZWFsZWQgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICBjb25zdCBkb250UG9wdWxh dGUgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICBsZXQgdHJlZUVsZW1lbnRUb1NlbGVjdCA9 IHNlbGVjdGVkVHJlZUVsZW1lbnQudHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQoc2tpcFVucmV2ZWFs ZWQsIGRvbnRQb3B1bGF0ZSk7CisgICAgICAgICAgICAgICAgICAgIGlmICh0cmVlRWxlbWVudFRv U2VsZWN0KSB7CisgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBvbWl0Rm9jdXMgPSB0cnVl OworICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc2VsZWN0ZWRCeVVzZXIgPSB0cnVlOwor ICAgICAgICAgICAgICAgICAgICAgICAgdHJlZUVsZW1lbnRUb1NlbGVjdC5zZWxlY3Qob21pdEZv Y3VzLCBzZWxlY3RlZEJ5VXNlcik7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K