201708 2019-09-11 20:28:50 -0700 Web Inspector: Do not show override actions unless Sources tab is enabled 2019-09-11 22:48:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1570108 0 joepeck 2019-09-11 20:28:50 -0700 Do not show override actions unless Sources tab is enabled It is confusing because it appears to do nothing! 1570109 1 378615 joepeck 2019-09-11 20:29:25 -0700 Created attachment 378615 [PATCH] Proposed Fix 1570140 2 378615 hi 2019-09-11 21:57:04 -0700 Comment on attachment 378615 [PATCH] Proposed Fix r=me 1570165 3 378615 commit-queue 2019-09-11 22:47:32 -0700 Comment on attachment 378615 [PATCH] Proposed Fix Clearing flags on attachment: 378615 Committed r249796: <https://trac.webkit.org/changeset/249796> 1570166 4 commit-queue 2019-09-11 22:47:33 -0700 All reviewed patches have been landed. Closing bug. 1570167 5 webkit-bug-importer 2019-09-11 22:48:17 -0700 <rdar://problem/55291121> 378615 2019-09-11 20:29:25 -0700 2019-09-11 22:47:32 -0700 [PATCH] Proposed Fix override-1.patch text/plain 2052 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYwNjhhM2Y1Y2QzLi4xZWIwNzAwNWY4ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDktMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBEbyBub3Qgc2hvdyBvdmVycmlkZSBhY3Rpb25zIHVubGVzcyBTb3VyY2VzIHRhYiBpcyBlbmFi bGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE3 MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTmV0d29ya01hbmFnZXIuanM6CisgICAgICAgIChXSS5O ZXR3b3JrTWFuYWdlci5zdXBwb3J0c0xvY2FsUmVzb3VyY2VPdmVycmlkZXMpOgorCiAyMDE5LTA5 LTExICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IEVsZW1lbnRzOiBkb24ndCBzaG93IENoYW5nZXMgcGFuZWwgd2hlbiBzZWxl Y3RpbmcgdGV4dCBub2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9OZXR3b3JrTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL05ldHdvcmtNYW5hZ2VyLmpzCmluZGV4IGU0 MzJlNDBjY2ZiLi5kZmZlOThjODhlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTmV0d29ya01hbmFnZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTmV0d29ya01hbmFnZXIu anMKQEAgLTgzLDYgKzgzLDE0IEBAIFdJLk5ldHdvcmtNYW5hZ2VyID0gY2xhc3MgTmV0d29ya01h bmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgcmV0dXJuIEluc3BlY3RvckZyb250ZW5k SG9zdC5zdXBwb3J0c1Nob3dDZXJ0aWZpY2F0ZSAmJiB3aW5kb3cuTmV0d29ya0FnZW50ICYmIE5l dHdvcmtBZ2VudC5nZXRTZXJpYWxpemVkQ2VydGlmaWNhdGU7CiAgICAgfQogCisgICAgc3RhdGlj IHN1cHBvcnRzTG9jYWxSZXNvdXJjZU92ZXJyaWRlcygpCisgICAgeworICAgICAgICBpZiAoIVdJ LnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZVNvdXJjZXNUYWIudmFsdWUpCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgcmV0dXJuIHdpbmRvdy5OZXR3b3JrQWdlbnQgJiYg SW5zcGVjdG9yQmFja2VuZC5kb21haW5zLk5ldHdvcmsgJiYgSW5zcGVjdG9yQmFja2VuZC5kb21h aW5zLk5ldHdvcmsuc2V0SW50ZXJjZXB0aW9uRW5hYmxlZDsKKyAgICB9CisKICAgICBzdGF0aWMg c3ludGhlc2l6ZUltcG9ydEVycm9yKG1lc3NhZ2UpCiAgICAgewogICAgICAgICBtZXNzYWdlID0g V0kuVUlTdHJpbmcoIkhBUiBJbXBvcnQgRXJyb3I6ICVzIikuZm9ybWF0KG1lc3NhZ2UpOwpAQCAt OTgsMTEgKzEwNiw2IEBAIFdJLk5ldHdvcmtNYW5hZ2VyID0gY2xhc3MgTmV0d29ya01hbmFnZXIg ZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgV0kuY29uc29sZUxvZ1ZpZXdDb250cm9sbGVyLmFw cGVuZENvbnNvbGVNZXNzYWdlKGNvbnNvbGVNZXNzYWdlKTsKICAgICB9CiAKLSAgICBzdGF0aWMg c3VwcG9ydHNMb2NhbFJlc291cmNlT3ZlcnJpZGVzKCkKLSAgICB7Ci0gICAgICAgIHJldHVybiB3 aW5kb3cuTmV0d29ya0FnZW50ICYmIEluc3BlY3RvckJhY2tlbmQuZG9tYWlucy5OZXR3b3JrICYm IEluc3BlY3RvckJhY2tlbmQuZG9tYWlucy5OZXR3b3JrLnNldEludGVyY2VwdGlvbkVuYWJsZWQ7 Ci0gICAgfQotCiAgICAgLy8gVGFyZ2V0CiAKICAgICBpbml0aWFsaXplVGFyZ2V0KHRhcmdldCkK