201707 2019-09-11 19:27:10 -0700 Web Inspector: Crashes when intercept response continues with original content 2019-09-12 03:59:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck achristensen ap commit-queue ddkilzer inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1570093 0 joepeck 2019-09-11 19:27:10 -0700 Crashes when intercept response continues with original content Steps to Reproduce: 1. run-webkit-tests -g inspector/network/local-resource-override-continue-response.html => CRASH Notes: • didReceiveData that was deferred is no longer valid. Copy it when deferring avoids a crash. 1570094 1 joepeck 2019-09-11 19:27:36 -0700 <rdar://problem/55261857> 1570095 2 378612 joepeck 2019-09-11 19:28:42 -0700 Created attachment 378612 [PATCH] Proposed Fix 1570096 3 joepeck 2019-09-11 19:30:01 -0700 Not sure if there is any efficient way to keep the data around, but I noticed this pattern in other places and it seems straightforward. For intercepts the inspector should always provide data anyways. 1570219 4 378612 ddkilzer 2019-09-12 03:14:41 -0700 Comment on attachment 378612 [PATCH] Proposed Fix r=me 1570230 5 378612 commit-queue 2019-09-12 03:59:16 -0700 Comment on attachment 378612 [PATCH] Proposed Fix Clearing flags on attachment: 378612 Committed r249805: <https://trac.webkit.org/changeset/249805> 1570231 6 commit-queue 2019-09-12 03:59:17 -0700 All reviewed patches have been landed. Closing bug. 378612 2019-09-11 19:28:42 -0700 2019-09-12 03:59:16 -0700 [PATCH] Proposed Fix g-1.patch text/plain 1968 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNWZmZDRlNjMxNDguLmRhYTlmYWNmZjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTA5LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ3Jhc2hlcyB3aGVuIGludGVyY2VwdCByZXNwb25z ZSBjb250aW51ZXMgd2l0aCBvcmlnaW5hbCBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE3MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU1MjYxODU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhKToKKyAgICAgICAgQ29w eSB0aGUgZGF0YSBmb3IgdGhlIGNhbGxiYWNrIHNpbmNlIHRoZSBkZWZlcnJhbCBtYXkgcnVuIGl0 IG11Y2ggbGF0ZXIuCisKIDIwMTktMDktMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKDI0NTAwNik6IGNhbid0IHNjcm9sbCBpbiAicmVh ZCBtb3JlIiB2aWV3IGluIEV2ZW50YnJpdGUgYXBwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggOTU4Y2M5MjYz MDYuLmEzOTI0MWFjYTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0 d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0xODQsNyArMTg0LDkgQEAgdm9pZCBX ZWJSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZURhdGEoY29uc3QgSVBDOjpEYXRhUmVmZXJlbmNl JiBkYXRhLCBpbnQ2NF90IGUKICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKCFtX2lzUHJvY2Vzc2lu Z05ldHdvcmtSZXNwb25zZSwgIk5ldHdvcmsgcHJvY2VzcyBzaG91bGQgbm90IHNlbmQgZGF0YSB1 bnRpbCB3ZSd2ZSB2YWxpZGF0ZWQgdGhlIHJlc3BvbnNlIik7CiAKICAgICBpZiAoVU5MSUtFTFko bV9pbnRlcmNlcHRDb250cm9sbGVyLmlzSW50ZXJjZXB0aW5nKG1fY29yZUxvYWRlci0+aWRlbnRp ZmllcigpKSkpIHsKLSAgICAgICAgbV9pbnRlcmNlcHRDb250cm9sbGVyLmRlZmVyKG1fY29yZUxv YWRlci0+aWRlbnRpZmllcigpLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMp LCBkYXRhLCBlbmNvZGVkRGF0YUxlbmd0aF0oKSBtdXRhYmxlIHsKKyAgICAgICAgYXV0byBidWZm ZXIgPSBXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZShkYXRhLmRhdGEoKSwgZGF0YS5zaXpl KCkpOworICAgICAgICBtX2ludGVyY2VwdENvbnRyb2xsZXIuZGVmZXIobV9jb3JlTG9hZGVyLT5p ZGVudGlmaWVyKCksIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGJ1ZmZl ciA9IFdURk1vdmUoYnVmZmVyKSwgZW5jb2RlZERhdGFMZW5ndGhdKCkgbXV0YWJsZSB7CisgICAg ICAgICAgICBJUEM6OkRhdGFSZWZlcmVuY2UgZGF0YShyZWludGVycHJldF9jYXN0PGNvbnN0IHVp bnQ4X3QqPihidWZmZXItPmRhdGEoKSksIGJ1ZmZlci0+c2l6ZSgpKTsKICAgICAgICAgICAgIGlm IChtX2NvcmVMb2FkZXIpCiAgICAgICAgICAgICAgICAgZGlkUmVjZWl2ZURhdGEoZGF0YSwgZW5j b2RlZERhdGFMZW5ndGgpOwogICAgICAgICB9KTsK