20170 2008-07-25 06:50:02 -0700 [Qt] missing namespace defines in JavaScriptCore.pro 2008-07-31 08:01:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 loki webkit-unassigned hausmann oldest_to_newest 86938 0 loki 2008-07-25 06:50:02 -0700 With Qt-4.3.4 there is a build error. The QT_BEGIN_NAMESPACE and QT_END_NAMESPACE macros are never defined (rev. 35342). A similar patch is needed for JavaScriptCore.pro as http://trac.webkit.org/changeset/32306#file1 was. 87268 1 22538 ossy 2008-07-29 07:35:40 -0700 Created attachment 22538 proposed fix 87482 2 22538 hausmann 2008-07-31 06:00:01 -0700 Comment on attachment 22538 proposed fix Thanks for the fix! 87490 3 hausmann 2008-07-31 08:01:02 -0700 Landed in r35479 22538 2008-07-29 07:35:40 -0700 2008-07-31 06:00:01 -0700 proposed fix Qtbuild.patch text/plain 1035 ossy SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM1NDE4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDctMjkgIENzYWJhIE9z enRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMTcwOiBbUXRdIG1pc3NpbmcgbmFtZXNw YWNlIGRlZmluZXMgaW4gSmF2YVNjcmlwdENvcmUucHJvCisgICAgICAgIDxodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNzA+CisKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS5wcm86IEFkZGVkIG1pc3NpbmcgZGVmaW5lLgorCiAyMDA4LTA3LTI5ICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIg SHVudC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8JKHJldmlzaW9uIDM1NDE4KQor KysgSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC02 MywzICs2Myw3IEBAIGluY2x1ZGUoSmF2YVNjcmlwdENvcmUucHJpKQogUU1BS0VfRVhUUkFfVEFS R0VUUyArPSBnZW5lcmF0ZWRfZmlsZXMKIAogbGludXgtaWNjKjpRTUFLRV9DWFhGTEFHU19SRUxF QVNFIH49IHMvLU8yLy1PMC8KKworcXQtcG9ydDogbGVzc1RoYW4oUVRfTUlOT1JfVkVSU0lPTiwg NCkgeworICAgIERFRklORVMgKz0gUVRfQkVHSU5fTkFNRVNQQUNFPSIiIFFUX0VORF9OQU1FU1BB Q0U9IiIKK30K