201698 2019-09-11 14:28:39 -0700 Web Inspector: [Overrides] Command-Z doesn't undo changes after page reload 2019-09-13 01:16:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1569981 0 nvasilyev 2019-09-11 14:28:39 -0700 Command-Z only works until you reload the page. 1569982 1 webkit-bug-importer 2019-09-11 14:28:49 -0700 <rdar://problem/55276645> 1570307 2 joepeck 2019-09-12 11:14:55 -0700 The TextResourceContentView gets closed via SourcesNavigationSidebarPanel _updateMainFrameTreeElement closeAllContentViews(). Perhaps we can avoid closing these particular content views. 1570311 3 378662 joepeck 2019-09-12 11:26:51 -0700 Created attachment 378662 [PATCH] Proposed Fix 1570417 4 378662 hi 2019-09-12 15:59:38 -0700 Comment on attachment 378662 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378662&action=review r=me, it doesn't look like `WI.TextResourceContentView` (or any of it's superclasses) rely on the current main frame, so I think this is safe :) > Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:289 > + for (let i = 0; i < this._backForwardList.length; ++i) { `for (let entry of this._backForwardList)` 1570526 5 378662 commit-queue 2019-09-13 01:16:04 -0700 Comment on attachment 378662 [PATCH] Proposed Fix Clearing flags on attachment: 378662 Committed r249828: <https://trac.webkit.org/changeset/249828> 1570527 6 commit-queue 2019-09-13 01:16:05 -0700 All reviewed patches have been landed. Closing bug. 378662 2019-09-12 11:26:51 -0700 2019-09-13 01:16:04 -0700 [PATCH] Proposed Fix close-all-content-views-1.patch text/plain 3945 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg2YTMyNTdmN2UxLi4wZTZmZjQ2YjdhMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDktMTIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBbT3ZlcnJpZGVzXSBDb21tYW5kLVogZG9lc24ndCB1bmRvIGNoYW5nZXMgYWZ0ZXIgcGFnZSBy ZWxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MTY5OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTUyNzY2NDU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Nv bnRlbnRWaWV3Q29udGFpbmVyLmpzOgorICAgICAgICAoV0kuQ29udGVudFZpZXdDb250YWluZXIu cHJvdG90eXBlLmNsb3NlQWxsQ29udGVudFZpZXdzKToKKyAgICAgICAgUHJvdmlkZSBhIGZpbHRl ciB0byBvcHQgb3V0IG9mIGNsb3Npbmcgc29tZSBjb250ZW50IHZpZXdzLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qczoKKyAg ICAgICAgKFdJLlNvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fY2xvc2VD b250ZW50Vmlld3NGaWx0ZXIpOgorICAgICAgICAoV0kuU291cmNlc05hdmlnYXRpb25TaWRlYmFy UGFuZWwucHJvdG90eXBlLl91cGRhdGVNYWluRnJhbWVUcmVlRWxlbWVudCk6CisgICAgICAgIEF2 b2lkIGNsb3NpbmcgQ29udGVudFZpZXdzIGZvciBsb2NhbCByZXNvdXJjZSBvdmVycmlkZXMuIFRo aXMga2VlcHMgdGhlCisgICAgICAgIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGFyb3VuZCBhbmQgdGh1 cyBpdHMgdW5kby9yZWRvIHN0YWNrLgorCiAyMDE5LTA5LTA5ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRm9ybWF0dGVyOiBQ cmV0dHkgUHJpbnQgSFRNTCByZXNvdXJjZXMgKGluY2x1ZGluZyBpbmxpbmUgPHNjcmlwdD4vPHN0 eWxlPikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbnRlbnRWaWV3Q29udGFpbmVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29udGVudFZpZXdDb250YWluZXIuanMKaW5kZXggMzRmMDZmNWFmMTYu LjU5ODVkMmRkZTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db250ZW50Vmlld0NvbnRhaW5lci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlld0NvbnRhaW5lci5qcwpAQCAtMjc0 LDggKzI3NCwxMCBAQCBXSS5Db250ZW50Vmlld0NvbnRhaW5lciA9IGNsYXNzIENvbnRlbnRWaWV3 Q29udGFpbmVyIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB9CiAgICAgfQogCi0gICAgY2xvc2VB bGxDb250ZW50Vmlld3MoKQorICAgIGNsb3NlQWxsQ29udGVudFZpZXdzKGZpbHRlcikKICAgICB7 CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KCFmaWx0ZXIgfHwgdHlwZW9mIGZpbHRlciA9PT0gImZ1 bmN0aW9uIik7CisKICAgICAgICAgaWYgKCF0aGlzLl9iYWNrRm9yd2FyZExpc3QubGVuZ3RoKSB7 CiAgICAgICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9jdXJyZW50SW5kZXggPT09IC0xKTsK ICAgICAgICAgICAgIHJldHVybjsKQEAgLTI4NCwxMCArMjg2LDE0IEBAIFdJLkNvbnRlbnRWaWV3 Q29udGFpbmVyID0gY2xhc3MgQ29udGVudFZpZXdDb250YWluZXIgZXh0ZW5kcyBXSS5WaWV3CiAg ICAgICAgIHZhciB2aXNpYmxlQ29udGVudFZpZXcgPSB0aGlzLmN1cnJlbnRDb250ZW50VmlldzsK IAogICAgICAgICAvLyBIaWRlIGFuZCBkaXNhc3NvY2lhdGUgd2l0aCBhbGwgdGhlIGNvbnRlbnQg dmlld3MuCi0gICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fYmFja0ZvcndhcmRMaXN0 Lmxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICB2YXIgZW50cnkgPSB0aGlzLl9iYWNrRm9yd2Fy ZExpc3RbaV07CisgICAgICAgIGZvciAobGV0IGkgPSAwOyBpIDwgdGhpcy5fYmFja0ZvcndhcmRM aXN0Lmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICBsZXQgZW50cnkgPSB0aGlzLl9iYWNrRm9y d2FyZExpc3RbaV07CisgICAgICAgICAgICBpZiAoZmlsdGVyICYmICFmaWx0ZXIoZW50cnkuY29u dGVudFZpZXcpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgICAgICBpZiAo ZW50cnkuY29udGVudFZpZXcgPT09IHZpc2libGVDb250ZW50VmlldykKICAgICAgICAgICAgICAg ICB0aGlzLl9oaWRlRW50cnkoZW50cnkpOworCiAgICAgICAgICAgICB0aGlzLl9kaXNhc3NvY2lh dGVGcm9tQ29udGVudFZpZXcoZW50cnkuY29udGVudFZpZXcsIGVudHJ5LnRvbWJzdG9uZSk7CiAg ICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU291cmNlc05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQYW5l bC5qcwppbmRleCBjN2RkM2M1ODRjYy4uNzdiMDgzYjViMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJh clBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCkBAIC03MzcsMTAgKzczNywxOSBAQCBX SS5Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIFNvdXJjZXNOYXZpZ2F0aW9u U2lkZWJhclBhbmVsIGV4dGVuZHMgVwogICAgICAgICByZXR1cm4gYS5tYWluVGl0bGUuZXh0ZW5k ZWRMb2NhbGVDb21wYXJlKGIubWFpblRpdGxlKSB8fCBhLnN1YnRpdGxlLmV4dGVuZGVkTG9jYWxl Q29tcGFyZShiLnN1YnRpdGxlKTsKICAgICB9CiAKKyAgICBfY2xvc2VDb250ZW50Vmlld3NGaWx0 ZXIoY29udGVudFZpZXcpCisgICAgeworICAgICAgICAvLyBMb2NhbCBSZXNvdXJjZSBPdmVycmlk ZSBjb250ZW50IHZpZXdzIGRvIG5vdCBuZWVkIHRvIGJlIGNsb3NlZCBhY3Jvc3MgcGFnZSBuYXZp Z2F0aW9ucy4KKyAgICAgICAgaWYgKGNvbnRlbnRWaWV3LnJlcHJlc2VudGVkT2JqZWN0IGluc3Rh bmNlb2YgV0kuTG9jYWxSZXNvdXJjZSAmJiBjb250ZW50Vmlldy5yZXByZXNlbnRlZE9iamVjdC5p c0xvY2FsUmVzb3VyY2VPdmVycmlkZSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg ICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKICAgICBfdXBkYXRlTWFpbkZyYW1lVHJlZUVsZW1l bnQobWFpbkZyYW1lKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuZGlkSW5pdGlhbExheW91dCkK LSAgICAgICAgICAgIHRoaXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIuY2xv c2VBbGxDb250ZW50Vmlld3MoKTsKKyAgICAgICAgICAgIHRoaXMuY29udGVudEJyb3dzZXIuY29u dGVudFZpZXdDb250YWluZXIuY2xvc2VBbGxDb250ZW50Vmlld3ModGhpcy5fY2xvc2VDb250ZW50 Vmlld3NGaWx0ZXIpOwogCiAgICAgICAgIGxldCBvbGRNYWluRnJhbWVUcmVlRWxlbWVudCA9IHRo aXMuX21haW5GcmFtZVRyZWVFbGVtZW50OwogICAgICAgICBpZiAodGhpcy5fbWFpbkZyYW1lVHJl ZUVsZW1lbnQpIHsK