201669 2019-09-10 17:52:33 -0700 Web Inspector: Elements: don't show Changes panel when selecting text node 2019-09-12 12:27:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1569779 0 nvasilyev 2019-09-10 17:52:33 -0700 Currently... When "Show only for selected node" setting is enabled, Changes panel is NOT shown for text nodes. When the setting is disabled, Changes panel always shown. I suggest to never show Changes panel for text nodes, regardless of the setting. 1569783 1 378519 nvasilyev 2019-09-10 18:02:21 -0700 Created attachment 378519 Patch 1570068 2 378519 joepeck 2019-09-11 17:22:35 -0700 Comment on attachment 378519 Patch r=me 1570075 3 378519 commit-queue 2019-09-11 18:06:51 -0700 Comment on attachment 378519 Patch Clearing flags on attachment: 378519 Committed r249788: <https://trac.webkit.org/changeset/249788> 1570076 4 commit-queue 2019-09-11 18:06:53 -0700 All reviewed patches have been landed. Closing bug. 1570077 5 webkit-bug-importer 2019-09-11 18:07:17 -0700 <rdar://problem/55285036> 1570327 6 nvasilyev 2019-09-12 12:27:04 -0700 *** Bug 201039 has been marked as a duplicate of this bug. *** 378519 2019-09-10 18:02:21 -0700 2019-09-11 18:06:51 -0700 Patch patch.txt text/plain 1984 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc3OTczZWM2NDVkLi5jOTdjMTliM2JiNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDktMTAgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogRWxlbWVudHM6IGRvbid0IHNob3cgQ2hhbmdlcyBwYW5lbCB3aGVuIHNlbGVjdGluZyB0ZXh0 IG5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MTY2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNo b3cgQ2hhbmdlcyBwYW5lbCBvbmx5IGZvciBlbGVtZW50cyByZWdhcmRsZXNzIG9mICJTaG93IG9u bHkgZm9yIHNlbGVjdGVkIG5vZGUiIHNldHRpbmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0NoYW5nZXNEZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuQ2hhbmdl c0RldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLnN1cHBvcnRzRE9NTm9kZSk6CisgICAgICAg IChXSS5DaGFuZ2VzRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuaW5zcGVjdCk6IERlbGV0 ZWQuCisKIDIwMTktMDktMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEYXJrIE1vZGU6IE92ZXJ2aWV3IFRpbWVsaW5lIFZp ZXcgaGFzIGphcnJpbmcgd2hpdGUgYm94LXNoYWRvd3MgaW4gZGFyayBtb2RlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DaGFuZ2VzRGV0YWls c1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NoYW5nZXNEZXRhaWxzU2lkZWJhclBhbmVsLmpzCmluZGV4IGFkMGY2YWY4NGQzLi5jMzQ2 Y2VlNzQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQ2hhbmdlc0RldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2hhbmdlc0RldGFpbHNTaWRlYmFyUGFuZWwuanMK QEAgLTM1LDI0ICszNSw5IEBAIFdJLkNoYW5nZXNEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3Mg Q2hhbmdlc0RldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5ET01ECiAKICAgICAvLyBQdWJs aWMKIAotICAgIGluc3BlY3Qob2JqZWN0cykKLSAgICB7Ci0gICAgICAgIGxldCBpbnNwZWN0YWJs ZSA9IHN1cGVyLmluc3BlY3Qob2JqZWN0cyk7Ci0KLSAgICAgICAgaWYgKFdJLnNldHRpbmdzLmNz c0NoYW5nZXNQZXJOb2RlLnZhbHVlKQotICAgICAgICAgICAgcmV0dXJuIGluc3BlY3RhYmxlOwot Ci0gICAgICAgIC8vIERpc3BsYXkgQ2hhbmdlcyBwYW5lbCByZWdhcmRsZXNzIG9mIHRoZSBzZWxl Y3RlZCBET00gbm9kZS4KLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotCiAgICAgc3VwcG9y dHNET01Ob2RlKG5vZGVUb0luc3BlY3QpCiAgICAgewotICAgICAgICBpZiAoV0kuc2V0dGluZ3Mu Y3NzQ2hhbmdlc1Blck5vZGUudmFsdWUpCi0gICAgICAgICAgICByZXR1cm4gbm9kZVRvSW5zcGVj dC5ub2RlVHlwZSgpID09PSBOb2RlLkVMRU1FTlRfTk9ERTsKLQotICAgICAgICAvLyBEaXNwbGF5 IENoYW5nZXMgcGFuZWwgcmVnYXJkbGVzcyBvZiB0aGUgc2VsZWN0ZWQgRE9NIG5vZGUuCi0gICAg ICAgIHJldHVybiB0cnVlOworICAgICAgICByZXR1cm4gbm9kZVRvSW5zcGVjdC5ub2RlVHlwZSgp ID09PSBOb2RlLkVMRU1FTlRfTk9ERTsKICAgICB9CiAKICAgICBzaG93bigpCg==