201658 2019-09-10 14:40:18 -0700 setup-git-clone is using http not https 2021-03-11 09:40:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino alancoon.bugzilla commit-queue ews-watchlist glenn kocsen_chung sam webkit-bug-importer oldest_to_newest 1569673 0 dino 2019-09-10 14:40:18 -0700 setup-git-clone is using http not https 1569676 1 378496 dino 2019-09-10 14:41:49 -0700 Created attachment 378496 Patch 1569823 2 378496 commit-queue 2019-09-10 21:16:02 -0700 Comment on attachment 378496 Patch Clearing flags on attachment: 378496 Committed r249752: <https://trac.webkit.org/changeset/249752> 1569824 3 commit-queue 2019-09-10 21:16:04 -0700 All reviewed patches have been landed. Closing bug. 1569825 4 webkit-bug-importer 2019-09-10 21:17:19 -0700 <rdar://problem/55248896> 1578471 5 kocsen_chung 2019-10-09 17:27:18 -0700 This is not right. We can only do this if the git clone was also done from the HTTPS git-svn mirror. The longer explanation is that each commit message on a git-svn mirror has the annotation of the URL for the SVN commit. You may have seen this as "git-svn-id: https://svn.webkit.org/repository/webkit/trunk@r1234". Since this is embedded in the commit message and the commit message takes part in creating the hash, this makes it so that the git-svn hash of a particular revision <r1> have different hashes on the HTTP git repo, vs the HTTPS git repo. Long winded way of saying this change is currently broken given the current docs, which have us clone the http version of the git repo. 1579542 6 sam 2019-10-13 17:03:12 -0700 (In reply to Kocsen Chung from comment #5) > This is not right. We can only do this if the git clone was also done from > the HTTPS git-svn mirror. > > > The longer explanation is that each commit message on a git-svn mirror has > the annotation of the URL for the SVN commit. You may have seen this as > "git-svn-id: https://svn.webkit.org/repository/webkit/trunk@r1234". Since > this is embedded in the commit message and the commit message takes part in > creating the hash, this makes it so that the git-svn hash of a particular > revision <r1> have different hashes on the HTTP git repo, vs the HTTPS git > repo. > > Long winded way of saying this change is currently broken given the current > docs, which have us clone the http version of the git repo. Which doc is that? Can we update the doc to clone the https version of the git repo too? 1581890 7 kocsen_chung 2019-10-21 10:58:43 -0700 Currently the docs that outline this are: - https://webkit.org/getting-the-code/ - https://trac.webkit.org/wiki/UsingGitWithWebKit I'll look into editing those instead of reverting this change. 1581903 8 kocsen_chung 2019-10-21 11:15:43 -0700 Requested change for #1. Changed #2 here: https://trac.webkit.org/wiki/UsingGitWithWebKit?action=diff&version=95 1738489 9 alancoon 2021-03-11 09:40:26 -0800 *** Bug 201206 has been marked as a duplicate of this bug. *** 378496 2019-09-10 14:41:49 -0700 2019-09-10 21:16:02 -0700 Patch bug-201658-20190911074148.patch text/plain 1506 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWYwNGM1ZWVjNDc0NTQ2OGIwYWM5M2EwMjY3MWYzYWVm NjIxNzM0Zi4uZDIxNGYzZWYyNTc5YWM5ODJhMTc3NDQ1N2MxYWMyZjhkNGNmOWQ5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA5LTEwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAg ICBzZXR1cC1naXQtY2xvbmUgaXMgdXNpbmcgaHR0cCBub3QgaHR0cHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTY1OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3NldHVwZ2l0Y2xvbmUucHk6CisgICAgICAgIChTZXR1cEdpdENsb25lLmV4ZWN1 dGUpOgorCiAyMDE5LTA5LTA2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgRGVwcmVjYXRlIGFsbCBXS0Nvb2tpZU1hbmFnZXJSZWYgZnVuY3Rp b25zCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2V0 dXBnaXRjbG9uZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zZXR1 cGdpdGNsb25lLnB5CmluZGV4IDgxYmI0OThiZjYwMTU1NDZlYTU0Y2YyM2Y3Yjg2YTM4YzNhNjEx OTguLmNlOTdkZGUzMzE3NWE1YTM2YTY4ZjZlNDQ4MTY3NjkwY2QyMGJhNjYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zZXR1cGdpdGNsb25lLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zZXR1cGdpdGNsb25lLnB5 CkBAIC00OSw3ICs0OSw3IEBAIGNsYXNzIFNldHVwR2l0Q2xvbmUoQ29tbWFuZCk6CiAgICAgICAg ICMgRklYTUU6IFdlIHNob3VsZG4ndCBiZSB1c2luZyBhIHByaXZhdGUgbWV0aG9kLgogICAgICAg ICBydW5fZ2l0ID0gdG9vbC5zY20oKS5fcnVuX2dpdAogICAgICAgICBydW5fZ2l0KFsicHVsbCJd KQotICAgICAgICBydW5fZ2l0KFsic3ZuIiwgImluaXQiLCAiLS1wcmVmaXg9b3JpZ2luLyIsICIt VCIsICJ0cnVuayIsICJodHRwOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93ZWJraXQiXSkK KyAgICAgICAgcnVuX2dpdChbInN2biIsICJpbml0IiwgIi0tcHJlZml4PW9yaWdpbi8iLCAiLVQi LCAidHJ1bmsiLCAiaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdCJdKQog ICAgICAgICBydW5fZ2l0KFsiY29uZmlnIiwgIi0tcmVwbGFjZSIsICJzdm4tcmVtb3RlLnN2bi5m ZXRjaCIsICJ0cnVuazpyZWZzL3JlbW90ZXMvb3JpZ2luL21hc3RlciJdKQogICAgICAgICBydW5f Z2l0KFsic3ZuIiwgImZldGNoIl0pCiAK