<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>201653</bug_id>
          
          <creation_ts>2019-09-10 13:28:09 -0700</creation_ts>
          <short_desc>Add missing origin check for Service-Worker-Allowed header</short_desc>
          <delta_ts>2019-09-10 14:44:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1569633</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-09-10 13:28:09 -0700</bug_when>
    <thetext>Add missing origin check for Service-Worker-Allowed header:
- https://w3c.github.io/ServiceWorker/#update-algorithm (step 15. 2.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569635</commentid>
    <comment_count>1</comment_count>
      <attachid>378479</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-09-10 13:29:36 -0700</bug_when>
    <thetext>Created attachment 378479
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569647</commentid>
    <comment_count>2</comment_count>
      <attachid>378479</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2019-09-10 13:44:26 -0700</bug_when>
    <thetext>Comment on attachment 378479
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569677</commentid>
    <comment_count>3</comment_count>
      <attachid>378479</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-10 14:43:47 -0700</bug_when>
    <thetext>Comment on attachment 378479
Patch

Clearing flags on attachment: 378479

Committed r249733: &lt;https://trac.webkit.org/changeset/249733&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569678</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-10 14:43:48 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569679</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-10 14:44:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/55237830&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>378479</attachid>
            <date>2019-09-10 13:29:36 -0700</date>
            <delta_ts>2019-09-10 14:43:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201653-20190910132936.patch</filename>
            <type>text/plain</type>
            <size>3981</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGJlMWFjMDE0MzhjMDM3
ODI5MDNlOWQ0ODQ1YWRjZjBmM2U4YjdlOC4uZTFjYjM5MmI2NjhmOWQ2MmNhM2NlMjk3ZTY0Nzg3
NjQ3NjUzNGQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTEwICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIG1pc3Npbmcgb3JpZ2lu
IGNoZWNrIGZvciBTZXJ2aWNlLVdvcmtlci1BbGxvd2VkIGhlYWRlcgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNjUzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3Npbmcgb3JpZ2luIGNoZWNr
IGZvciBTZXJ2aWNlLVdvcmtlci1BbGxvd2VkIGhlYWRlcjoKKyAgICAgICAgLSBodHRwczovL3cz
Yy5naXRodWIuaW8vU2VydmljZVdvcmtlci8jdXBkYXRlLWFsZ29yaXRobSAoc3RlcCAxNS4gMi4p
CisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckpvYi5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpTZXJ2aWNlV29ya2VySm9iOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAy
MDE5LTA5LTEwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBS
VENQZWVyQ29ubmVjdGlvbiBjYW4gb25seSBiZSBpbnN0YW50aWF0ZWQgaW4gZG9jdW1lbnRzCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckpv
Yi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckpvYi5j
cHAKaW5kZXggYWYyZGFlYzQ4NzcxOGRkNWUzNjM1Mzk2YmRjNDI2ZDE2MzZmMGU0Ni4uYjNkYzU4
ZjIzZjMxYzY5MWY1MWYxNjA5MjNhMDJmNjg4YTc5ZjJmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJKb2IuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VySm9iLmNwcApAQCAtMTM0LDcgKzEz
NCw4IEBAIHZvaWQgU2VydmljZVdvcmtlckpvYjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKHVuc2lnbmVk
IGxvbmcsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmCiAgICAgICAgIG1heFNjb3BlU3RyaW5nID0g
cGF0aC5zdWJzdHJpbmcoMCwgcGF0aC5yZXZlcnNlRmluZCgnLycpICsgMSk7CiAgICAgfSBlbHNl
IHsKICAgICAgICAgYXV0byBtYXhTY29wZSA9IFVSTChtX2pvYkRhdGEuc2NyaXB0VVJMLCBzZXJ2
aWNlV29ya2VyQWxsb3dlZCk7Ci0gICAgICAgIG1heFNjb3BlU3RyaW5nID0gbWF4U2NvcGUucGF0
aCgpOworICAgICAgICBpZiAoU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShtYXhTY29wZSktPmlzU2Ft
ZU9yaWdpbkFzKFNlY3VyaXR5T3JpZ2luOjpjcmVhdGUobV9qb2JEYXRhLnNjcmlwdFVSTCkpKQor
ICAgICAgICAgICAgbWF4U2NvcGVTdHJpbmcgPSBtYXhTY29wZS5wYXRoKCk7CiAgICAgfQogCiAg
ICAgU3RyaW5nIHNjb3BlU3RyaW5nID0gbV9qb2JEYXRhLnNjb3BlVVJMLnBhdGgoKTsKZGlmZiAt
LWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9p
bXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGRjODIxMDgyZjQ5ODBmYjk0MWI1MGE3OTY0ODNj
N2ZlODdhYzg5Y2EuLmQ2Y2FlNWUyNzM1NTQzN2E3ZTVlZGIzMTg2YjYwNWViNzA2Yzk4NmIgMTAw
NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0
VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA5LTEw
ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIG1pc3Npbmcg
b3JpZ2luIGNoZWNrIGZvciBTZXJ2aWNlLVdvcmtlci1BbGxvd2VkIGhlYWRlcgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNjUzCisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXUFQgdGVz
dCB0aGF0IGlzIG5vdyBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3Nl
cnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9TZXJ2aWNlLVdvcmtlci1BbGxvd2VkLWhlYWRl
ci5odHRwcy1leHBlY3RlZC50eHQ6CisKIDIwMTktMDktMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6
QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQ5NzI0Lgpk
aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9z
ZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvU2VydmljZS1Xb3JrZXItQWxsb3dlZC1oZWFk
ZXIuaHR0cHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0
Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvU2VydmljZS1Xb3JrZXIt
QWxsb3dlZC1oZWFkZXIuaHR0cHMtZXhwZWN0ZWQudHh0CmluZGV4IDYxOGI5MmQ5ZWFkMjA3NWRk
MzgzMjVhZTY2NjM1ZTNmNTFhYjQ3NjkuLmUxNzU5ZTA4M2QzMTU1MTViZTA3MWMxYjE4NDIzYjBi
MjAwZWE5YTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv
cm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL1NlcnZpY2UtV29ya2VyLUFs
bG93ZWQtaGVhZGVyLmh0dHBzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRl
ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9T
ZXJ2aWNlLVdvcmtlci1BbGxvd2VkLWhlYWRlci5odHRwcy1leHBlY3RlZC50eHQKQEAgLTQsNyAr
NCw3IEBAIFBBU1MgUmVnaXN0ZXJpbmcgd2l0aGluIFNlcnZpY2UtV29ya2VyLUFsbG93ZWQgcGF0
aCAoYWJzb2x1dGUgVVJMKQogUEFTUyBSZWdpc3RlcmluZyB3aXRoaW4gU2VydmljZS1Xb3JrZXIt
QWxsb3dlZCBwYXRoIHdpdGggcGFyZW50IHJlZmVyZW5jZSAKIFBBU1MgUmVnaXN0ZXJpbmcgb3V0
c2lkZSBTZXJ2aWNlLVdvcmtlci1BbGxvd2VkIHBhdGggCiBQQVNTIFJlZ2lzdGVyaW5nIG91dHNp
ZGUgU2VydmljZS1Xb3JrZXItQWxsb3dlZCBwYXRoIHdpdGggcGFyZW50IHJlZmVyZW5jZSAKLUZB
SUwgU2VydmljZS1Xb3JrZXItQWxsb3dlZCBpcyBjcm9zcy1vcmlnaW4gdG8gc2NyaXB0LCByZWdp
c3RlcmluZyBvbiBhIG5vcm1hbGx5IGFsbG93ZWQgc2NvcGUgYXNzZXJ0X3VucmVhY2hlZDogU2hv
dWxkIGhhdmUgcmVqZWN0ZWQ6IHVuZGVmaW5lZCBSZWFjaGVkIHVucmVhY2hhYmxlIGNvZGUKLUZB
SUwgU2VydmljZS1Xb3JrZXItQWxsb3dlZCBpcyBjcm9zcy1vcmlnaW4gdG8gc2NyaXB0LCByZWdp
c3RlcmluZyBvbiBhIG5vcm1hbGx5IGRpc2FsbG93ZWQgc2NvcGUgYXNzZXJ0X3VucmVhY2hlZDog
U2hvdWxkIGhhdmUgcmVqZWN0ZWQ6IHVuZGVmaW5lZCBSZWFjaGVkIHVucmVhY2hhYmxlIGNvZGUK
K1BBU1MgU2VydmljZS1Xb3JrZXItQWxsb3dlZCBpcyBjcm9zcy1vcmlnaW4gdG8gc2NyaXB0LCBy
ZWdpc3RlcmluZyBvbiBhIG5vcm1hbGx5IGFsbG93ZWQgc2NvcGUgCitQQVNTIFNlcnZpY2UtV29y
a2VyLUFsbG93ZWQgaXMgY3Jvc3Mtb3JpZ2luIHRvIHNjcmlwdCwgcmVnaXN0ZXJpbmcgb24gYSBu
b3JtYWxseSBkaXNhbGxvd2VkIHNjb3BlIAogUEFTUyBTZXJ2aWNlLVdvcmtlci1BbGxvd2VkIGlz
IGNyb3NzLW9yaWdpbiB0byBwYWdlLCBzYW1lLW9yaWdpbiB0byBzY3JpcHQgCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>