201632 2019-09-09 22:22:12 -0700 [Win][WK2] Pressing space key on text input form scrolls the page 2020-01-21 17:57:12 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead pvollan ross.kirsling stephan.szabo webkit-bug-importer oldest_to_newest 1569453 0 378442 fujii 2019-09-09 22:22:12 -0700 Created attachment 378442 test case [Win][WK2] Pressing space key sometimes inputs space character, but scrolling the page otherwise 1. Start Windows WK2 MiniBrowser 2. Open test page 3. Hitting space key repeatedly Expected: space characters should be input consistently Actual: Sometimes page scrolling happens. 1569454 1 fujii 2019-09-09 22:26:13 -0700 It seems that the current implementation of WebPage::performDefaultBehaviorForKeyEvent is wrong. Current implementation: https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp?rev=244932#L70 Original implementation: https://trac.webkit.org/browser/webkit/trunk/Source/WebKit2/WebProcess/WebPage/win/WebPageWin.cpp?rev=138331#L201 1569810 2 378532 fujii 2019-09-10 19:47:44 -0700 Created attachment 378532 test case 1569811 3 fujii 2019-09-10 19:48:41 -0700 scrolling happens every time. 1569848 4 fujii 2019-09-10 23:15:43 -0700 In Windows, key events are mapped as following: WM_KEYDOWN → WebEvent::RawKeyDown WM_KEYUP → WebEvent::KeyUp WM_CHAR → WebEvent::Char On the other hand, other ports are using only two types: WebEvent::KeyDown WebEvent::KeyUp 1569850 5 fujii 2019-09-10 23:19:44 -0700 In GTK port, WebEvent::KeyDown are converted to keydown and keypress DOM events. And, keypress event are comsumed in WebEditorClient::handleKeyboardEvent. Then, WebPage::performDefaultBehaviorForKeyEvent is not called because it is consumed. 1569866 6 fujii 2019-09-11 01:01:19 -0700 See also: Bug 56612 – Web page shouldn't swallow alt-key combinations on Windows Bug 43665 – Delete key doesn't go Back in WebKit2 windows 1608925 7 fujii 2020-01-20 21:02:57 -0800 After I implemented the logic preventing keypress event if the preceding keydown event is canceled, space characters can't be input anymore in WinCairo WK2. Bug 204694 – [Win] Retrieve all following WM_CHAR events at the beginning of processing WM_KEYDOWN event 1608933 8 388280 fujii 2020-01-20 22:29:46 -0800 Created attachment 388280 Patch 1609413 9 fujii 2020-01-21 17:56:22 -0800 Committed r254897: <https://trac.webkit.org/changeset/254897> 1609414 10 webkit-bug-importer 2020-01-21 17:57:12 -0800 <rdar://problem/58781952> 378442 2019-09-09 22:22:12 -0700 2019-09-10 19:47:44 -0700 test case a.html text/html 107 fujii PHN0eWxlPgogIGJvZHkgewogICAgICBoZWlnaHQ6IDEwMDAwcHg7CiAgICAgIGJhY2tncm91bmQ6 IHBpbms7CiAgfSAgCjwvc3R5bGU+CjxpbnB1dCB0eXBlPXRleHQgYXV0b2ZvY3VzPgo= 378532 2019-09-10 19:47:44 -0700 2019-09-10 19:47:44 -0700 test case a.html text/html 130 fujii PHN0eWxlPgogIGRpdiB7CiAgICAgIGhlaWdodDogMTAwMDBweDsKICAgICAgYmFja2dyb3VuZDog cGluazsKICB9ICAKPC9zdHlsZT4KPGRpdj48L2Rpdj4KPGlucHV0IHR5cGU9dGV4dCBhdXRvZm9j dXM+CjxkaXY+PC9kaXY+Cg== 388280 2020-01-20 22:29:46 -0800 2020-01-21 09:30:59 -0800 Patch bug-201632-20200121152945.patch text/plain 2321 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlNGY2MjVhMjJlMGUzOThm YWI3MDJjMWZmMzEwNzkyMzk5MGIyZTkuLmZkNzMwMTA1NzBmMTgyOGU4MDkzMTA3Y2YzZmMxYTA1 ODBkOTcwMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjAtMDEtMjAgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bV0syXSBQ cmVzc2luZyBzcGFjZSBrZXkgb24gdGV4dCBpbnB1dCBmb3JtIHNjcm9sbHMgdGhlIHBhZ2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTYzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyMjMyNjIgd2Fz IGFkZCBXZWJQYWdlOjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9yRm9yS2V5RXZlbnQgZm9yCisgICAg ICAgIFdpbmRvd3MgcG9ydCBieSBjb3B5aW5nIEdUSyBwb3J0J3MgaW1wbGVtZW50YXRpb24uIEJ1 dCwgV2luZG93cworICAgICAgICBwb3J0IGlzIHVzaW5nIHVuaXF1ZSBrZXkgZXZlbnQgcHJvY2Vz c2luZy4gSXQgZGlzcGF0Y2hlcworICAgICAgICBXZWJFdmVudDo6UmF3S2V5RG93biBhbmQgV2Vi RXZlbnQ6OktleVVwIHNlcGFyYXRlbHkgZXZlbiB0aG91Z2gKKyAgICAgICAgb3RoZXIgcG9ydHMg ZGlzcGF0Y2ggb25seSBXZWJFdmVudDo6S2V5RG93biBieSB1bmlmeWluZyB0aGVtLgorCisgICAg ICAgIEJlY2F1c2UgV2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50IGhh bmRsZWQKKyAgICAgICAgV2ViRXZlbnQ6OlJhd0tleURvd24gb2Ygc3BhY2Uga2V5IHRvIHNjcm9s bCBwYWdlLCBhbmQgY29uc3VtZWQgdGhlCisgICAgICAgIGV2ZW50LCB0aGUga2V5cHJlc3MgZXZl bnQgb2Ygc3BhY2Uga2V5IHdhc24ndCBkaXNwYXRjaGVkLgorCisgICAgICAgIFRoZSBrZXlwcmVz cyBldmVudCBvZiBhIHNwYWNlIGtleSBpcyBoYW5kbGVkIGluCisgICAgICAgIEV2ZW50SGFuZGxl cjo6ZGVmYXVsdFNwYWNlRXZlbnRIYW5kbGVyLgorICAgICAgICBwZXJmb3JtRGVmYXVsdEJlaGF2 aW9yRm9yS2V5RXZlbnQgZG9uJ3QgbmVlZCB0byBkbyBpdC4KKworICAgICAgICBUZXN0czogQ292 ZXJ0ZWQgYnkgZmFzdC9ldmVudHMvc3BhY2Utc2Nyb2xsLWV2ZW50Lmh0bWwKKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2U6OnBlcmZvcm1EZWZhdWx0QmVoYXZpb3JGb3JLZXlFdmVudCk6IERvbid0IGhhbmRs ZSBWS19TUEFDRS4KKwogMjAyMC0wMS0yMCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEZpeCBtaXNzaW5nIGhlYWRlciBndWFyZHMgYW5kIGNsZWFuIHVwIGVt cHR5IGZpbGVzIGluIFdlYkNvcmUsIFdlYktpdExlZ2FjeSwgV2ViS2l0LCBUb29scwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwCmlu ZGV4IGM5NGJkMDVjOTI0NTU3Yjk0ODNlNjEzZGQ5OWE4OGRlYjA5NzE0NGIuLjYyNGY0ZDExMjY2 YTI3ZGEzN2Q3ZDlmZjAyMTZjZjI2NWVhMmRjNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdlV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHAKQEAgLTczLDkgKzczLDYgQEAg Ym9vbCBXZWJQYWdlOjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9yRm9yS2V5RXZlbnQoY29uc3QgV2Vi S2V5Ym9hcmRFdmVudCYga2V5Ym9hcmQKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgc3dp dGNoIChrZXlib2FyZEV2ZW50LndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpKSB7Ci0gICAgY2FzZSBW S19TUEFDRToKLSAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwga2V5Ym9hcmRFdmVudC5zaGlm dEtleSgpID8gU2Nyb2xsVXAgOiBTY3JvbGxEb3duLCBTY3JvbGxCeVBhZ2UpOwotICAgICAgICBi cmVhazsKICAgICBjYXNlIFZLX0xFRlQ6CiAgICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNj cm9sbExlZnQsIFNjcm9sbEJ5TGluZSk7CiAgICAgICAgIGJyZWFrOwo=