201616 2019-09-09 15:33:13 -0700 WebKitTestRunner: Many tests timeout on macOS Catalina 2019-10-01 18:50:33 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard achristensen ap beidson benjamin cdumez cmarcelo commit-queue dbates ews-watchlist jbedard jlewis3 katherine_cheney pvollan webkit-bug-importer wilander youennf oldest_to_newest 1569313 0 jbedard 2019-09-09 15:33:13 -0700 When I try to run tests on macOS Catalina, hundreds of tests are timing out, mostly http tests. Many of the tests I'm seeing timeout involve ResourceLoadStatistics, although it's possible other features are also effected. In http/tests/cache, the following tests are timing out: http/tests/cache/link-prefetch-main-resource-iframe.html [ Timeout ] http/tests/cache/link-prefetch-main-resource.html [ Timeout ] http/tests/cache/partitioned-cache-iframe.html [ Timeout ] http/tests/cache/partitioned-cache.html [ Timeout ] http/tests/cache/xhr-vary-header.html [ Timeout ] 1569314 1 webkit-bug-importer 2019-09-09 15:33:37 -0700 <rdar://problem/55200897> 1574728 2 jbedard 2019-09-26 21:49:48 -0700 I originally thought this was because of where we were saving files, but testing today indicates that it has to do with hanging on https. 1575565 3 jbedard 2019-10-01 09:27:35 -0700 I have a pretty basic reproduction case, which took me awhile to figure out because I am still not clear on how this would happen. In short, with http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html, the test runner is never even attempting to retrieve the other resources. This will completely break many http tests in various different ways. It doesn't seem to be apache, because I can retrieve these files fine via curl, and this test even works if I run it in the browser while the http server is running. So this would seem to be a problem in the test runner. 1575609 4 jbedard 2019-10-01 11:21:27 -0700 This is an entitlement problem: "com.apple.WebKit(####) does not hold the necessary entitlement to delegate network traffic for other processes by pid" 1575756 5 379953 jbedard 2019-10-01 15:04:34 -0700 Created attachment 379953 Patch 1575757 6 jbedard 2019-10-01 15:05:26 -0700 (In reply to Jonathan Bedard from comment #5) > Created attachment 379953 [details] > Patch This fixes the problem...doing some additional testing, but I wanted to put the patch up for review. 1575758 7 379953 achristensen 2019-10-01 15:08:27 -0700 Comment on attachment 379953 Patch Let's keep it on for all IOS_FAMILY builds but only turn it off for open source Catalina builds. 1575767 8 379954 jbedard 2019-10-01 15:22:19 -0700 Created attachment 379954 Patch 1575770 9 jbedard 2019-10-01 15:26:28 -0700 (In reply to Alex Christensen from comment #7) > Comment on attachment 379953 [details] > Patch > > Let's keep it on for all IOS_FAMILY builds but only turn it off for open > source Catalina builds. Fair point. 1575797 10 379954 ap 2019-10-01 16:43:07 -0700 Comment on attachment 379954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379954&action=review > Source/WTF/wtf/Platform.h:1387 > +#if (PLATFORM(MAC) && defined USE_APPLE_INTERNAL_SDK && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || PLATFORM(IOS_FAMILY) This should be USE(APPLE_INTERNAL_SDK), not USE_APPLE_INTERNAL_SDK. 1575808 11 379968 jbedard 2019-10-01 16:54:59 -0700 Created attachment 379968 Patch 1575833 12 379968 commit-queue 2019-10-01 18:50:31 -0700 Comment on attachment 379968 Patch Clearing flags on attachment: 379968 Committed r250590: <https://trac.webkit.org/changeset/250590> 1575834 13 commit-queue 2019-10-01 18:50:33 -0700 All reviewed patches have been landed. Closing bug. 379953 2019-10-01 15:04:34 -0700 2019-10-01 15:22:17 -0700 Patch bug-201616-20191001150432.patch text/plain 1252 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTA1ODIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEwLTAxICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyOiBNYW55IHRlc3Rz IHRpbWVvdXQgb24gbWFjT1MgQ2F0YWxpbmEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMTYxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTUyMDA4 OTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvUGxhdGZvcm0uaDogVVNFX1NPVVJDRV9BUFBMSUNBVElPTl9BVURJVF9EQVRBIHNob3VsZCBv bmx5IGJlIGVuYWJsZWQgb24KKyAgICAgICAgYnVpbGRzIHdoaWNoIGFsbG93IHJlc3RyaWN0ZWQg ZW50aXRsZW1lbnRzLgorCiAyMDE5LTEwLTAxICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgc29tZSBzdXBwb3J0IGZvciA8IGlPUyAxMwpJbmRleDog U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCShyZXZpc2lvbiAyNTA1MjMpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xMzg1LDcgKzEzODUsNyBAQAogI2VuZGlmCiAKICNpZiAoUExB VEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTUwMCkg fHwgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSNkZWZpbmUgVVNFX1NPVVJDRV9BUFBMSUNBVElPTl9B VURJVF9EQVRBIDEKKyNkZWZpbmUgVVNFX1NPVVJDRV9BUFBMSUNBVElPTl9BVURJVF9EQVRBIFVT RV9BUFBMRV9JTlRFUk5BTF9TREsKICNlbmRpZgogCiAjaWYgKFBMQVRGT1JNKE1BQykgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8IChQTEFURk9STShJT1Nf RkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDApCg== 379954 2019-10-01 15:22:19 -0700 2019-10-01 16:54:57 -0700 Patch bug-201616-20191001152217.patch text/plain 1196 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTA1ODIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEwLTAxICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyOiBNYW55IHRlc3Rz IHRpbWVvdXQgb24gbWFjT1MgQ2F0YWxpbmEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMTYxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTUyMDA4 OTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvUGxhdGZvcm0uaDogVVNFX1NPVVJDRV9BUFBMSUNBVElPTl9BVURJVF9EQVRBIHNob3VsZCBv bmx5IGJlIGVuYWJsZWQgb24KKyAgICAgICAgYnVpbGRzIHdoaWNoIGFsbG93IHJlc3RyaWN0ZWQg ZW50aXRsZW1lbnRzLgorCiAyMDE5LTEwLTAxICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgc29tZSBzdXBwb3J0IGZvciA8IGlPUyAxMwpJbmRleDog U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCShyZXZpc2lvbiAyNTA1ODIpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xMzg0LDcgKzEzODQsNyBAQAogI2RlZmluZSBIQVZFX1JTQV9Q U1MgMQogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05f TUlOX1JFUVVJUkVEID49IDEwMTUwMCkgfHwgUExBVEZPUk0oSU9TX0ZBTUlMWSkKKyNpZiAoUExB VEZPUk0oTUFDKSAmJiBkZWZpbmVkIFVTRV9BUFBMRV9JTlRFUk5BTF9TREsgJiYgX19NQUNfT1Nf WF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8IFBMQVRGT1JNKElPU19GQU1JTFkp CiAjZGVmaW5lIFVTRV9TT1VSQ0VfQVBQTElDQVRJT05fQVVESVRfREFUQSAxCiAjZW5kaWYKIAo= 379968 2019-10-01 16:54:59 -0700 2019-10-01 18:50:31 -0700 Patch bug-201616-20191001165457.patch text/plain 1194 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTA1ODIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEwLTAxICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyOiBNYW55IHRlc3Rz IHRpbWVvdXQgb24gbWFjT1MgQ2F0YWxpbmEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMTYxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTUyMDA4 OTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAg ICAqIHd0Zi9QbGF0Zm9ybS5oOiBVU0VfU09VUkNFX0FQUExJQ0FUSU9OX0FVRElUX0RBVEEgc2hv dWxkIG9ubHkgYmUgZW5hYmxlZCBvbgorICAgICAgICBidWlsZHMgd2hpY2ggYWxsb3cgcmVzdHJp Y3RlZCBlbnRpdGxlbWVudHMuCisKIDIwMTktMTAtMDEgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBzb21lIHN1cHBvcnQgZm9yIDwgaU9TIDEzCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYv d3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDI1MDU4MikKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRm b3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTEzODQsNyArMTM4NCw3IEBACiAjZGVmaW5lIEhBVkVf UlNBX1BTUyAxCiAjZW5kaWYKIAotI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwKSB8fCBQTEFURk9STShJT1NfRkFNSUxZKQorI2lm IChQTEFURk9STShNQUMpICYmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwKSB8fCBQTEFURk9STShJT1NfRkFNSUxZKQog I2RlZmluZSBVU0VfU09VUkNFX0FQUExJQ0FUSU9OX0FVRElUX0RBVEEgMQogI2VuZGlmCiAK