201579 2019-09-07 03:10:25 -0700 The jsc shell should allow disabling of the Gigacage for testing purposes. 2019-09-07 07:57:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201570 InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist fpizlo keith_miller msaboff rmorisset ryanhaddad saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1568863 0 mark.lam 2019-09-07 03:10:25 -0700 ... 1568864 1 mark.lam 2019-09-07 03:14:33 -0700 The relevant tests were previously skipped in r249611: <http://trac.webkit.org/r249611>. 1568867 2 378289 mark.lam 2019-09-07 03:26:02 -0700 Created attachment 378289 proposed patch. 1568876 3 378289 msaboff 2019-09-07 06:58:27 -0700 Comment on attachment 378289 proposed patch. r=me 1568882 4 mark.lam 2019-09-07 07:56:02 -0700 Thanks for the review. Landed in r249612: <http://trac.webkit.org/r249612>. 1568883 5 webkit-bug-importer 2019-09-07 07:57:16 -0700 <rdar://problem/55145646> 378289 2019-09-07 03:26:02 -0700 2019-09-07 07:35:11 -0700 proposed patch. bug-201579.patch text/plain 3895 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDk2MTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUaGUganNjIHNoZWxsIHNob3VsZCBhbGxvdyBkaXNhYmxpbmcgb2YgdGhl IEdpZ2FjYWdlIGZvciB0ZXN0aW5nIHB1cnBvc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHRoZSB0ZXN0cyBub3cuCisKKyAgICAgICAg KiBzdHJlc3MvZGlzYWJsZS1naWdhY2FnZS1hcnJheXMuanM6CisgICAgICAgICogc3RyZXNzL2Rp c2FibGUtZ2lnYWNhZ2Utc3RyaW5ncy5qczoKKyAgICAgICAgKiBzdHJlc3MvZGlzYWJsZS1naWdh Y2FnZS10eXBlZC1hcnJheXMuanM6CisKIDIwMTktMDktMDcgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIEdhcmRlbmluZzogdGVtcG9yYXJpbHkgc2tpcHBpbmcgdGhl c2UgdGVzdHMgdW50aWwgdGhlIGZpeCBjYW4gYmUgcmV2aWV3ZWQgYW5kIGxhbmRlZC4KSW5kZXg6 IEpTVGVzdHMvc3RyZXNzL2Rpc2FibGUtZ2lnYWNhZ2UtYXJyYXlzLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEpTVGVzdHMvc3RyZXNzL2Rpc2FibGUtZ2lnYWNhZ2UtYXJyYXlzLmpzCShyZXZpc2lvbiAyNDk2 MTEpCisrKyBKU1Rlc3RzL3N0cmVzcy9kaXNhYmxlLWdpZ2FjYWdlLWFycmF5cy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMSw1ICsxLDQgQEAKLS8vQCBza2lwCi0vLyB0ZW1wb3JhcmlseSBkaXNhYmxl LCBwcmV2aW91cyBvcHRpb25zOiBydW5Ob2lzeVRlc3RXaXRoRW52ICJkaXNhYmxlLWdpZ2FjYWdl IiwgIkdJR0FDQUdFX0VOQUJMRUQ9MCIKKy8vQCBydW5Ob2lzeVRlc3RXaXRoRW52ICJkaXNhYmxl LWdpZ2FjYWdlIiwgIkdJR0FDQUdFX0VOQUJMRUQ9MCIKIAogKGZ1bmN0aW9uKCkgewogICAgIGZ1 bmN0aW9uIGZvbyhhcnJheSwgaSkKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2Rpc2FibGUtZ2lnYWNh Z2Utc3RyaW5ncy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kaXNhYmxlLWdpZ2Fj YWdlLXN0cmluZ3MuanMJKHJldmlzaW9uIDI0OTYxMSkKKysrIEpTVGVzdHMvc3RyZXNzL2Rpc2Fi bGUtZ2lnYWNhZ2Utc3RyaW5ncy5qcwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDQgQEAKLS8v QCBza2lwCi0vLyB0ZW1wb3JhcmlseSBkaXNhYmxlLCBwcmV2aW91cyBvcHRpb25zOiBydW5Ob2lz eVRlc3RXaXRoRW52ICJkaXNhYmxlLWdpZ2FjYWdlIiwgIkdJR0FDQUdFX0VOQUJMRUQ9MCIKKy8v QCBydW5Ob2lzeVRlc3RXaXRoRW52ICJkaXNhYmxlLWdpZ2FjYWdlIiwgIkdJR0FDQUdFX0VOQUJM RUQ9MCIKIAogKGZ1bmN0aW9uKCkgewogICAgIGZ1bmN0aW9uIGZvbyhhcnJheSwgaSkKSW5kZXg6 IEpTVGVzdHMvc3RyZXNzL2Rpc2FibGUtZ2lnYWNhZ2UtdHlwZWQtYXJyYXlzLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2Rpc2FibGUtZ2lnYWNhZ2UtdHlwZWQtYXJyYXlzLmpzCShy ZXZpc2lvbiAyNDk2MTEpCisrKyBKU1Rlc3RzL3N0cmVzcy9kaXNhYmxlLWdpZ2FjYWdlLXR5cGVk LWFycmF5cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDQgQEAKLS8vQCBza2lwCi0vLyB0 ZW1wb3JhcmlseSBkaXNhYmxlLCBwcmV2aW91cyBvcHRpb25zOiBydW5Ob2lzeVRlc3RXaXRoRW52 ICJkaXNhYmxlLWdpZ2FjYWdlIiwgIkdJR0FDQUdFX0VOQUJMRUQ9MCIKKy8vQCBydW5Ob2lzeVRl c3RXaXRoRW52ICJkaXNhYmxlLWdpZ2FjYWdlIiwgIkdJR0FDQUdFX0VOQUJMRUQ9MCIKIAogKGZ1 bmN0aW9uKCkgewogICAgIGZ1bmN0aW9uIGZvbyhhcnJheSwgaSkKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwkocmV2aXNpb24gMjQ5NjA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA5LTA3ICBNYXJr IExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUganNjIHNoZWxsIHNob3Vs ZCBhbGxvdyBkaXNhYmxpbmcgb2YgdGhlIEdpZ2FjYWdlIGZvciB0ZXN0aW5nIHB1cnBvc2VzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNTc5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgZm9y IHRoZSBzYW1lIEdJR0FDQUdFX0VOQUJMRUQgZW52IHZhciB0aGF0IGlzIGNoZWNrZWQgYnkgR2ln YWNhZ2UgY29kZS4gIElmCisgICAgICAgIHRoaXMgZW52IHZhciBpcyBwcmVzZW50IGFuZCBpdCBo YXMgYSBmYWxzeSB2YWx1ZSwgdGhlbiBkbyBub3QKKyAgICAgICAgZm9yYmlkRGlzYWJsaW5nUHJp bWl0aXZlR2lnYWNhZ2UoKSBpbiB0aGUganNjIHNoZWxsLgorCisgICAgICAgICoganNjLmNwcDoK KyAgICAgICAgKGpzY21haW4pOgorCiAyMDE5LTA5LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBIYXJkZW4gcHJvdGVjdGlvbiBvZiB0aGUgR2lnYWNhZ2UgQ29u ZmlnIHBhcmFtZXRlcnMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gMjQ5NjA5 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMw ODYsNyArMzA4NiwxNCBAQCBpbnQganNjbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAjaWYg RU5BQkxFKFdFQkFTU0VNQkxZKQogICAgIEpTQzo6V2FzbTo6ZW5hYmxlRmFzdE1lbW9yeSgpOwog I2VuZGlmCi0gICAgR2lnYWNhZ2U6OmZvcmJpZERpc2FibGluZ1ByaW1pdGl2ZUdpZ2FjYWdlKCk7 CisKKyAgICBib29sIGdpZ2FjYWdlRGlzYWJsZVJlcXVlc3RlZCA9IGZhbHNlOworICAgIGlmIChj aGFyKiBnaWdhY2FnZUVuYWJsZWQgPSBnZXRlbnYoIkdJR0FDQUdFX0VOQUJMRUQiKSkgeworICAg ICAgICBpZiAoIXN0cmNhc2VjbXAoZ2lnYWNhZ2VFbmFibGVkLCAibm8iKSB8fCAhc3RyY2FzZWNt cChnaWdhY2FnZUVuYWJsZWQsICJmYWxzZSIpIHx8ICFzdHJjYXNlY21wKGdpZ2FjYWdlRW5hYmxl ZCwgIjAiKSkKKyAgICAgICAgICAgIGdpZ2FjYWdlRGlzYWJsZVJlcXVlc3RlZCA9IHRydWU7Cisg ICAgfQorICAgIGlmICghZ2lnYWNhZ2VEaXNhYmxlUmVxdWVzdGVkKQorICAgICAgICBHaWdhY2Fn ZTo6Zm9yYmlkRGlzYWJsaW5nUHJpbWl0aXZlR2lnYWNhZ2UoKTsKIAogI2lmIFBMQVRGT1JNKENP Q09BKQogICAgIGF1dG8mIG1lbW9yeVByZXNzdXJlSGFuZGxlciA9IE1lbW9yeVByZXNzdXJlSGFu ZGxlcjo6c2luZ2xldG9uKCk7Cg==