201572 2019-09-06 20:17:36 -0700 [FTW] Minor cleanups to avoid crashes during web browsing 2019-09-06 23:01:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue dino don.olmstead fujii pvollan webkit-bug-importer oldest_to_newest 1568816 0 bfulgham 2019-09-06 20:17:36 -0700 This patch addresses two crashes seen when doing general web browsing on Amazon.com and Apple.com using the FTW build of WebKit: 1. ImageBuffer::sinkIntoImage was attempting to use a render target after WTFMoving it elsewhere. 2. ImageBuffer::copyNativeImage was not properly checking the type of the render target to make sure it was suitable for Bitmap operations. 3. BackingStoreBackendDirect2DImpl::scroll would crash if the scroll offset was outside the bounds of the current view. In that case, it would attempt to allocate a texture of zero size, which triggered a crash. 1568817 1 378268 bfulgham 2019-09-06 20:22:59 -0700 Created attachment 378268 Patch 1568837 2 bfulgham 2019-09-06 22:17:30 -0700 Thank you for the review, ap! 1568845 3 378268 commit-queue 2019-09-06 22:59:45 -0700 Comment on attachment 378268 Patch Clearing flags on attachment: 378268 Committed r249609: <https://trac.webkit.org/changeset/249609> 1568846 4 commit-queue 2019-09-06 22:59:46 -0700 All reviewed patches have been landed. Closing bug. 1568847 5 webkit-bug-importer 2019-09-06 23:01:04 -0700 <rdar://problem/55140532> 378268 2019-09-06 20:22:59 -0700 2019-09-06 22:59:45 -0700 Patch bug-201572-20190906202258.patch text/plain 4156 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTYwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE5LTA5LTA2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtGVFddIE1pbm9yIGNsZWFu dXBzIHRvIGF2b2lkIGNyYXNoZXMgZHVyaW5nIHdlYiBicm93c2luZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNTcyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRyZXNzZXMgYSBm ZXcgY3Jhc2hlcyBzZWVuIHdoZW4gZG9pbmcgZ2VuZXJhbCB3ZWIgYnJvd3NpbmcgdXNpbmcKKyAg ICAgICAgdGhlIEZUVyBidWlsZCBvZiBXZWJLaXQ6CisKKyAgICAgICAgMS4gSW1hZ2VCdWZmZXI6 OnNpbmtJbnRvSW1hZ2Ugd2FzIGF0dGVtcHRpbmcgdG8gdXNlIGEgcmVuZGVyIHRhcmdldCBhZnRl ciBXVEZNb3ZpbmcgaXQgZWxzZXdoZXJlLgorICAgICAgICAyLiBJbWFnZUJ1ZmZlcjo6Y29weU5h dGl2ZUltYWdlIHdhcyBub3QgcHJvcGVybHkgY2hlY2tpbmcgdGhlIHR5cGUgb2YgdGhlIHJlbmRl cgorICAgICAgICAgICB0YXJnZXQgdG8gbWFrZSBzdXJlIGl0IHdhcyBzdWl0YWJsZSBmb3IgQml0 bWFwIG9wZXJhdGlvbnMuCisgICAgICAgIDMuIEJhY2tpbmdTdG9yZUJhY2tlbmREaXJlY3QyRElt cGw6OnNjcm9sbCB3b3VsZCBjcmFzaCBpZiB0aGUgc2Nyb2xsIG9mZnNldCB3YXMKKyAgICAgICAg ICAgb3V0c2lkZSB0aGUgYm91bmRzIG9mIHRoZSBjdXJyZW50IHZpZXcuIEluIHRoYXQgY2FzZSwg aXQgd291bGQgYXR0ZW1wdCB0byBhbGxvY2F0ZQorICAgICAgICAgICBhIHplcm8tc2l6ZSB0ZXh0 dXJlLCB3aGljaCB0cmlnZ2VyZWQgYSBjcmFzaC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3dpbi9CYWNraW5nU3RvcmVCYWNrZW5kRGlyZWN0MkRJbXBsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkJhY2tpbmdTdG9yZUJhY2tlbmREaXJlY3QyREltcGw6OnNjcm9sbCk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ltYWdlQnVmZmVyRGlyZWN0MkQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnNpbmtJbnRvSW1hZ2UpOgorICAgICAgICAoV2ViQ29y ZTo6SW1hZ2VCdWZmZXI6OmNvcHlOYXRpdmVJbWFnZSBjb25zdCk6CisKIDIwMTktMDktMDYgIFdl bnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgSW5jb3JyZWN0 IHNlbGVjdGlvbiByZWN0IHJldmVhbGVkIGFmdGVyIHBhc3RpbmcgaW1hZ2VzIGluIGEgY29udGVu dGVkaXRhYmxlIGVsZW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dpbi9CYWNraW5nU3RvcmVCYWNrZW5kRGlyZWN0MkRJbXBsLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vQmFja2luZ1N0b3JlQmFja2VuZERp cmVjdDJESW1wbC5jcHAJKHJldmlzaW9uIDI0OTYwNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9CYWNraW5nU3RvcmVCYWNrZW5kRGlyZWN0MkRJbXBsLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjksNiArNjksOSBAQCB2b2lkIEJhY2tpbmdTdG9yZUJhY2tlbmREaXJl Y3QyREltcGw6OnNjCiAgICAgc291cmNlUmVjdC5tb3ZlKC1zY3JvbGxPZmZzZXQpOwogICAgIHNv dXJjZVJlY3QuaW50ZXJzZWN0KHNjcm9sbFJlY3QpOwogCisgICAgaWYgKHNvdXJjZVJlY3QuaXNF bXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBpZiAoIW1fc2Nyb2xsU3VyZmFjZSB8fCBz Y3JvbGxSZWN0LnNpemUoKSAhPSBtX3Njcm9sbFN1cmZhY2VTaXplKSB7CiAjaWZuZGVmIF9OREVC VUcKICAgICAgICAgQVNTRVJUKG1fc2l6ZS53aWR0aCgpID49IHNjcm9sbFJlY3Quc2l6ZSgpLndp ZHRoKCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ltYWdl QnVmZmVyRGlyZWN0MkQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3dpbi9JbWFnZUJ1ZmZlckRpcmVjdDJELmNwcAkocmV2aXNpb24gMjQ5NjA1KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ltYWdlQnVmZmVyRGlyZWN0 MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTQsOCArMTk0LDEyIEBAIFJlZlB0cjxJbWFnZT4g SW1hZ2VCdWZmZXI6OnNpbmtJbnRvSW1hZ2UKICAgICBJbnRTaXplIGJhY2tpbmdTdG9yZVNpemUg PSBpbWFnZUJ1ZmZlci0+bV9kYXRhLmJhY2tpbmdTdG9yZVNpemU7CiAgICAgZmxvYXQgcmVzb2x1 dGlvblNjYWxlID0gaW1hZ2VCdWZmZXItPm1fcmVzb2x1dGlvblNjYWxlOwogCi0gICAgYXV0byBi aXRtYXBUYXJnZXQgPSByZWludGVycHJldF9jYXN0PElEMkQxQml0bWFwUmVuZGVyVGFyZ2V0Kj4o aW1hZ2VCdWZmZXItPmNvbnRleHQoKS5wbGF0Zm9ybUNvbnRleHQoKS0+cmVuZGVyVGFyZ2V0KCkp OwotICAgIHJldHVybiBjcmVhdGVCaXRtYXBJbWFnZUFmdGVyU2NhbGluZ0lmTmVlZGVkKGJpdG1h cFRhcmdldCwgc2lua0ludG9OYXRpdmVJbWFnZShXVEZNb3ZlKGltYWdlQnVmZmVyKSksIGludGVy bmFsU2l6ZSwgbG9naWNhbFNpemUsIGJhY2tpbmdTdG9yZVNpemUsIHJlc29sdXRpb25TY2FsZSwg cHJlc2VydmVSZXNvbHV0aW9uKTsKKyAgICBDT01QdHI8SUQyRDFCaXRtYXBSZW5kZXJUYXJnZXQ+ IGJpdG1hcFRhcmdldDsKKyAgICBIUkVTVUxUIGhyID0gaW1hZ2VCdWZmZXItPmNvbnRleHQoKS5w bGF0Zm9ybUNvbnRleHQoKS0+cmVuZGVyVGFyZ2V0KCktPlF1ZXJ5SW50ZXJmYWNlKCZiaXRtYXBU YXJnZXQpOworICAgIGlmICghU1VDQ0VFREVEKGhyKSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7 CisKKyAgICByZXR1cm4gY3JlYXRlQml0bWFwSW1hZ2VBZnRlclNjYWxpbmdJZk5lZWRlZChiaXRt YXBUYXJnZXQuZ2V0KCksIHNpbmtJbnRvTmF0aXZlSW1hZ2UoV1RGTW92ZShpbWFnZUJ1ZmZlcikp LCBpbnRlcm5hbFNpemUsIGxvZ2ljYWxTaXplLCBiYWNraW5nU3RvcmVTaXplLCByZXNvbHV0aW9u U2NhbGUsIHByZXNlcnZlUmVzb2x1dGlvbik7CiB9CiAKIEJhY2tpbmdTdG9yZUNvcHkgSW1hZ2VC dWZmZXI6OmZhc3RDb3B5SW1hZ2VNb2RlKCkKQEAgLTIxMSwxMCArMjE1LDEzIEBAIENPTVB0cjxJ RDJEMUJpdG1hcD4gSW1hZ2VCdWZmZXI6OnNpbmtJbnQKIAogQ09NUHRyPElEMkQxQml0bWFwPiBJ bWFnZUJ1ZmZlcjo6Y29weU5hdGl2ZUltYWdlKEJhY2tpbmdTdG9yZUNvcHkgY29weUJlaGF2aW9y KSBjb25zdAogewotICAgIGF1dG8gYml0bWFwVGFyZ2V0ID0gcmVpbnRlcnByZXRfY2FzdDxJRDJE MUJpdG1hcFJlbmRlclRhcmdldCo+KGNvbnRleHQoKS5wbGF0Zm9ybUNvbnRleHQoKSk7CisgICAg Q09NUHRyPElEMkQxQml0bWFwUmVuZGVyVGFyZ2V0PiBiaXRtYXBUYXJnZXQ7CisgICAgSFJFU1VM VCBociA9IGNvbnRleHQoKS5wbGF0Zm9ybUNvbnRleHQoKS0+cmVuZGVyVGFyZ2V0KCktPlF1ZXJ5 SW50ZXJmYWNlKCZiaXRtYXBUYXJnZXQpOworICAgIGlmICghU1VDQ0VFREVEKGhyKSkKKyAgICAg ICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICBDT01QdHI8SUQyRDFCaXRtYXA+IGltYWdlOwotICAg IEhSRVNVTFQgaHIgPSBiaXRtYXBUYXJnZXQtPkdldEJpdG1hcCgmaW1hZ2UpOworICAgIGhyID0g Yml0bWFwVGFyZ2V0LT5HZXRCaXRtYXAoJmltYWdlKTsKICAgICBBU1NFUlQoU1VDQ0VFREVEKGhy KSk7CiAKICAgICAvLyBGSVhNRTogbV9kYXRhLmRhdGEgaXMgbnVsbHB0ciBldmVuIHdoZW4gYXNr aW5nIHRvIGNvcHkgYmFja2luZyBzdG9yZSBsZWFkaW5nIHRvIHRlc3QgZmFpbHVyZXMuCg==