201548 2019-09-06 10:29:14 -0700 IndexedDB: cache prepared SQLiteStatement in SQLiteIDBCursor 2019-09-10 12:43:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen alecflett beidson commit-queue ews-watchlist ggaren jsbell webkit-bug-importer oldest_to_newest 1568573 0 sihui_liu 2019-09-06 10:29:14 -0700 ... so we don't need to create and compile the statement every time we use it. 1568576 1 378204 sihui_liu 2019-09-06 10:40:00 -0700 Created attachment 378204 Patch 1569278 2 sihui_liu 2019-09-09 13:43:49 -0700 This change does not make an improvement on test benchmark; but there is a small improvement on the execution time of SQLiteIDBCursor::internalFetchNextRecord when running tests like PerformanceTests/IndexedDB/basic/index-cursor-advance.html (using MonotonicTime to check the execution time). 1569616 3 378204 commit-queue 2019-09-10 12:42:36 -0700 Comment on attachment 378204 Patch Clearing flags on attachment: 378204 Committed r249729: <https://trac.webkit.org/changeset/249729> 1569617 4 commit-queue 2019-09-10 12:42:38 -0700 All reviewed patches have been landed. Closing bug. 1569618 5 webkit-bug-importer 2019-09-10 12:43:20 -0700 <rdar://problem/55232336> 1569619 6 webkit-bug-importer 2019-09-10 12:43:20 -0700 <rdar://problem/55232337> 378204 2019-09-06 10:40:00 -0700 2019-09-10 12:42:36 -0700 Patch bug-201548-20190906103959.patch text/plain 3954 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBjNGMwNjI5ZjZkNjdi YzUyMDUyMzc4ZjlmMmYzYWNjZWI2OWQ5NC4uZDgwYjFjZTM2MTBlNDFkOGUzODg3NTBlNjA4ZjE1 OTI2YTQzOWNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA5LTA2ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEluZGV4ZWREQjogY2FjaGUg cHJlcGFyZWQgU1FMaXRlU3RhdGVtZW50IGluIFNRTGl0ZUlEQkN1cnNvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNTQ4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzaG91bGQgYmUgYSBwZXJm b3JtYW5jZSBpbXByb3ZlbWVudCBhcyB3ZSBkb24ndCBjb21waWxlIHRoZSBzYW1lIFNRTGl0ZVN0 YXRlbWVudCBldmVyeXRpbWUgaXQgaXMgdXNlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5v IGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9T UUxpdGVJREJDdXJzb3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVyOjpTUUxpdGVJ REJDdXJzb3I6OmludGVybmFsRmV0Y2hOZXh0UmVjb3JkKToKKyAgICAgICAgKiBNb2R1bGVzL2lu ZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQ3Vyc29yLmg6CisKIDIwMTktMDktMDUgIEp1c3RpbiBG YW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViR1BVXSBJbXBsZW1lbnQg R1BVVW5jYXB0dXJlZEVycm9yRXZlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJDdXJzb3IuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkN1cnNvci5jcHAKaW5kZXggYzZiM2Zk OTUzYTBkNTNhYzE1NjhlMjg0OGNiYzc4YTEyZjE5NTc1NC4uZDQ5OGQxY2JkMmIyOWU3YjIyYzU4 ZGQ2N2ZjZGNhMmI2M2MyZWFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkN1cnNvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkN1cnNvci5jcHAKQEAgLTQ3MiwyMCAr NDcyLDI0IEBAIFNRTGl0ZUlEQkN1cnNvcjo6RmV0Y2hSZXN1bHQgU1FMaXRlSURCQ3Vyc29yOjpp bnRlcm5hbEZldGNoTmV4dFJlY29yZChTUUxpdGVDdXJzCiAgICAgICAgICAgICByZXR1cm4gRmV0 Y2hSZXN1bHQ6OkZhaWx1cmU7CiAgICAgICAgIH0KIAotICAgICAgICBTUUxpdGVTdGF0ZW1lbnQg b2JqZWN0U3RvcmVTdGF0ZW1lbnQobV9zdGF0ZW1lbnQtPmRhdGFiYXNlKCksICJTRUxFQ1QgdmFs dWUgRlJPTSBSZWNvcmRzIFdIRVJFIGtleSA9IENBU1QoPyBBUyBURVhUKSBhbmQgb2JqZWN0U3Rv cmVJRCA9ID87Iik7CisgICAgICAgIGlmICghbV9jYWNoZWRPYmplY3RTdG9yZVN0YXRlbWVudCB8 fCBtX2NhY2hlZE9iamVjdFN0b3JlU3RhdGVtZW50LT5yZXNldCgpICE9IFNRTElURV9PSykgewor ICAgICAgICAgICAgbV9jYWNoZWRPYmplY3RTdG9yZVN0YXRlbWVudCA9IG1ha2VVbmlxdWU8U1FM aXRlU3RhdGVtZW50PihtX3N0YXRlbWVudC0+ZGF0YWJhc2UoKSwgIlNFTEVDVCB2YWx1ZSBGUk9N IFJlY29yZHMgV0hFUkUga2V5ID0gQ0FTVCg/IEFTIFRFWFQpIGFuZCBvYmplY3RTdG9yZUlEID0g PzsiKTsKKyAgICAgICAgICAgIGlmIChtX2NhY2hlZE9iamVjdFN0b3JlU3RhdGVtZW50LT5wcmVw YXJlKCkgIT0gU1FMSVRFX09LKQorICAgICAgICAgICAgICAgIG1fY2FjaGVkT2JqZWN0U3RvcmVT dGF0ZW1lbnQgPSBudWxscHRyOworICAgICAgICB9CiAKLSAgICAgICAgaWYgKG9iamVjdFN0b3Jl U3RhdGVtZW50LnByZXBhcmUoKSAhPSBTUUxJVEVfT0sKLSAgICAgICAgICAgIHx8IG9iamVjdFN0 b3JlU3RhdGVtZW50LmJpbmRCbG9iKDEsIGtleURhdGEuZGF0YSgpLCBrZXlEYXRhLnNpemUoKSkg IT0gU1FMSVRFX09LCi0gICAgICAgICAgICB8fCBvYmplY3RTdG9yZVN0YXRlbWVudC5iaW5kSW50 NjQoMiwgbV9vYmplY3RTdG9yZUlEKSAhPSBTUUxJVEVfT0spIHsKKyAgICAgICAgaWYgKCFtX2Nh Y2hlZE9iamVjdFN0b3JlU3RhdGVtZW50CisgICAgICAgICAgICB8fCBtX2NhY2hlZE9iamVjdFN0 b3JlU3RhdGVtZW50LT5iaW5kQmxvYigxLCBrZXlEYXRhLmRhdGEoKSwga2V5RGF0YS5zaXplKCkp ICE9IFNRTElURV9PSworICAgICAgICAgICAgfHwgbV9jYWNoZWRPYmplY3RTdG9yZVN0YXRlbWVu dC0+YmluZEludDY0KDIsIG1fb2JqZWN0U3RvcmVJRCkgIT0gU1FMSVRFX09LKSB7CiAgICAgICAg ICAgICBMT0dfRVJST1IoIkNvdWxkIG5vdCBjcmVhdGUgaW5kZXggY3Vyc29yIHN0YXRlbWVudCBp bnRvIG9iamVjdCBzdG9yZSByZWNvcmRzICglaSkgJyVzJyIsIG1fc3RhdGVtZW50LT5kYXRhYmFz ZSgpLmxhc3RFcnJvcigpLCBtX3N0YXRlbWVudC0+ZGF0YWJhc2UoKS5sYXN0RXJyb3JNc2coKSk7 CiAgICAgICAgICAgICBtYXJrQXNFcnJvcmVkKHJlY29yZCk7CiAgICAgICAgICAgICByZXR1cm4g RmV0Y2hSZXN1bHQ6OkZhaWx1cmU7CiAgICAgICAgIH0KIAotICAgICAgICBpbnQgcmVzdWx0ID0g b2JqZWN0U3RvcmVTdGF0ZW1lbnQuc3RlcCgpOworICAgICAgICBpbnQgcmVzdWx0ID0gbV9jYWNo ZWRPYmplY3RTdG9yZVN0YXRlbWVudC0+c3RlcCgpOwogCiAgICAgICAgIGlmIChyZXN1bHQgPT0g U1FMSVRFX1JPVykgewotICAgICAgICAgICAgb2JqZWN0U3RvcmVTdGF0ZW1lbnQuZ2V0Q29sdW1u QmxvYkFzVmVjdG9yKDAsIGtleURhdGEpOworICAgICAgICAgICAgbV9jYWNoZWRPYmplY3RTdG9y ZVN0YXRlbWVudC0+Z2V0Q29sdW1uQmxvYkFzVmVjdG9yKDAsIGtleURhdGEpOwogICAgICAgICAg ICAgcmVjb3JkLnJlY29yZC52YWx1ZSA9IG1ha2VVbmlxdWU8SURCVmFsdWU+KFRocmVhZFNhZmVE YXRhQnVmZmVyOjpjcmVhdGUoV1RGTW92ZShrZXlEYXRhKSkpOwogICAgICAgICB9IGVsc2UgaWYg KHJlc3VsdCA9PSBTUUxJVEVfRE9ORSkgewogICAgICAgICAgICAgLy8gVGhpcyBpbmRpY2F0ZXMg dGhhdCB0aGUgcmVjb3JkIHdlJ3JlIHRyeWluZyB0byByZXRyaWV2ZSBoYXMgYmVlbiByZW1vdmVk IGZyb20gdGhlIG9iamVjdCBzdG9yZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJDdXJzb3IuaCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJDdXJzb3IuaAppbmRleCA4Y2MyYWI5MzE4 ZTE2MmI1MjY3ZDNhOGMzMDM5ZWJmOWVhOTRjZjM0Li4zNzM3MjZlZWNiOGQ3N2NkZTBkYjc4M2Yy YTJiNzk2NmZjMTE1Nzc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQ3Vyc29yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkN1cnNvci5oCkBAIC0xMjMsNiArMTIzLDggQEAg cHJpdmF0ZToKICAgICBJREJLZXlEYXRhIG1fY3VycmVudEtleUZvclVuaXF1ZW5lc3M7CiAKICAg ICBzdGQ6OnVuaXF1ZV9wdHI8U1FMaXRlU3RhdGVtZW50PiBtX3N0YXRlbWVudDsKKyAgICBzdGQ6 OnVuaXF1ZV9wdHI8U1FMaXRlU3RhdGVtZW50PiBtX2NhY2hlZE9iamVjdFN0b3JlU3RhdGVtZW50 OworCiAgICAgYm9vbCBtX3N0YXRlbWVudE5lZWRzUmVzZXQgeyB0cnVlIH07CiAgICAgaW50NjRf dCBtX2JvdW5kSUQgeyAwIH07CiAK