201523 2019-09-05 15:40:41 -0700 Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in plugins/private-browsing-mode.html 2019-09-05 21:38:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=112646 InRadar P2 Normal --- 201475 1 cdumez cdumez achristensen commit-queue webkit-bug-importer oldest_to_newest 1568293 0 cdumez 2019-09-05 15:40:41 -0700 Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in plugins/private-browsing-mode.html as it does not do the right thing for WebKit2. 1568295 1 378131 cdumez 2019-09-05 15:46:47 -0700 Created attachment 378131 Patch 1568385 2 378131 commit-queue 2019-09-05 21:37:16 -0700 Comment on attachment 378131 Patch Clearing flags on attachment: 378131 Committed r249561: <https://trac.webkit.org/changeset/249561> 1568386 3 commit-queue 2019-09-05 21:37:18 -0700 All reviewed patches have been landed. Closing bug. 1568387 4 webkit-bug-importer 2019-09-05 21:38:18 -0700 <rdar://problem/55099311> 378131 2019-09-05 15:46:47 -0700 2019-09-05 21:37:16 -0700 Patch bug-201523-20190905154647.patch text/plain 7300 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmNhYWQ5MDkxYWE4ZmJjOTQ2ZWMw MGQ2ZDRjNGRlNTA2YTMyMTU0MC4uYTI5ZWYyMjcwODAyYTgxOTgyZTYzM2MxZjUzZWM0N2U3ZTIz MWRiMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA5LTA1ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyB0ZXN0UnVubmVyLnNldFByaXZh dGVCcm93c2luZ0VuYWJsZWRfREVQUkVDQVRFRCgpIGluIHBsdWdpbnMvcHJpdmF0ZS1icm93c2lu Zy1tb2RlLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwMTUyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFN0b3AgdXNpbmcgdGVzdFJ1bm5lci5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkX0RFUFJF Q0FURUQoKSBpbiBwbHVnaW5zL3ByaXZhdGUtYnJvd3NpbmctbW9kZS5odG1sCisgICAgICAgIHNp bmNlIGl0IGRvZXMgbm90IGRvIHRoZSByaWdodCB0aGluZyBmb3IgV2ViS2l0Mi4gSW5zdGVhZCwg dXNlIHRoZSBuZXcgdXNlRXBoZW1lcmFsU2Vzc2lvbgorICAgICAgICBXS1RSIGZsYWcuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGx1Z2lucy9ub24tcHJpdmF0 ZS1icm93c2luZy1tb2RlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGx1Z2lucy9u b24tcHJpdmF0ZS1icm93c2luZy1tb2RlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsdWdpbnMv cHJpdmF0ZS1icm93c2luZy1tb2RlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbHVnaW5zL3By aXZhdGUtYnJvd3NpbmctbW9kZS5odG1sOgorCiAyMDE5LTA5LTA1ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCB1c2luZyB0ZXN0UnVubmVyLnNldFByaXZh dGVCcm93c2luZ0VuYWJsZWRfREVQUkVDQVRFRCgpIGluIGpzLXRlc3QuanMKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxNWFjYmI2YmY4OWMz NTM5NzNhODE0Mzg2NzAwYzUxYWJjMjExMDQxLi4xODJlNmVhMmI4NWRlMTVmMTM1NzgwMTBkMjA1 MGJiNDg5NWE0Y2RmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhw ZWN0YXRpb25zCkBAIC00ODcsNyArNDg3LDYgQEAgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1v cmlnaW4tcGx1Z2luLXByaXZhdGUtYnJvd3NpbmctdG9nZ2xlZC5odG1sIFsgU2tpcCBdCiBodHRw L3Rlc3RzL3NlY3VyaXR5L3N0b3JhZ2UtYmxvY2tpbmctbG9vc2VuZWQtcHJpdmF0ZS1icm93c2lu Zy1wbHVnaW4uaHRtbCBbIFNraXAgXQogaHR0cC90ZXN0cy9zZWN1cml0eS9zdG9yYWdlLWJsb2Nr aW5nLXN0cmVuZ3RoZW5lZC1wcml2YXRlLWJyb3dzaW5nLXBsdWdpbi5odG1sIFsgU2tpcCBdCiBw bHVnaW5zL3ByaXZhdGUtYnJvd3NpbmctbW9kZS0yLmh0bWwgWyBTa2lwIF0KLXBsdWdpbnMvcHJp dmF0ZS1icm93c2luZy1tb2RlLmh0bWwgWyBTa2lwIF0KIHN0b3JhZ2Uvd2Vic3FsL3ByaXZhdGUt YnJvd3Npbmctbm9yZWFkLW5vd3JpdGUuaHRtbCBbIFNraXAgXQogCiAjIFRoZXJlIGlzIG5vIG5l dHdvcmsgbG9hZCBzY2hlZHVsaW5nIG9yIHByaW9yaXRpemF0aW9uIHdpdGggTmV0d29ya1Byb2Nl c3MuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGNiYmM1 YTU0OWUwOWU1YjJhZmRhMjZiOWVjMDgyNzY5NWExZTMzYjEuLjU0NzhiOTdmYTQ1MTFlNGEwZTZj NTJiNjIxN2NiMDkyN2U3YjgyMDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCkBAIC00NjcsNyArNDY3LDYgQEAgd2Via2l0Lm9yZy9iLzU3Njg4IGZhc3QvdGV4 dC9pbnRlcm5hdGlvbmFsL2JpZGktQU4tYWZ0ZXItZW1wdHktcnVuLmh0bWwgWyBGYWlsdXIKIHdl YmtpdC5vcmcvYi81NzY4OCBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC9iaWRpLUNTLWFmdGVyLUFO Lmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzU3Njg4IGZhc3QvdGV4dC9pbnRl cm5hdGlvbmFsL3RoYWktbGluZS1icmVha3MuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiAKLXdlYmtp dC5vcmcvYi8xMTI2NDYgcGx1Z2lucy9wcml2YXRlLWJyb3dzaW5nLW1vZGUuaHRtbCBbIEZhaWx1 cmUgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTEyNjE2IHBsdWdpbnMvcGx1Z2luLWNsaXAtc3ViZnJh bWUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiAKICMgRmxha2V5IHBsdWdpbiB0ZXN0cwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9ub24tcHJpdmF0ZS1icm93c2luZy1tb2RlLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL3BsdWdpbnMvbm9uLXByaXZhdGUtYnJvd3NpbmctbW9kZS1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTU1ZGUwNDNiMmRlMWY0ZDBmZTY4NGUyOGMzMDJlYmMz NDU5ZDY4NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsdWdpbnMvbm9uLXByaXZh dGUtYnJvd3NpbmctbW9kZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGVzdHMgdGhh dCB0aGUgcHJpdmF0ZSBicm93c2luZyBBUEkgaW1wbGVtZW50YXRpb24gd29ya3MgYXMgZXhwZWN0 ZWQKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgcGx1Z2luLnByaXZhdGVC cm93c2luZ0VuYWJsZWQgaXMgZmFsc2UKK1BBU1MgcGx1Z2luLmNhY2hlZFByaXZhdGVCcm93c2lu Z0VuYWJsZWQgaXMgZmFsc2UKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT VCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5zL25vbi1wcml2YXRl LWJyb3dzaW5nLW1vZGUuaHRtbCBiL0xheW91dFRlc3RzL3BsdWdpbnMvbm9uLXByaXZhdGUtYnJv d3NpbmctbW9kZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNlMDhlNDA3ODJiYmQ3NzZhZWE0MjI5NTY2MTAz NjZlM2U0ZTQ0MDcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL25vbi1w cml2YXRlLWJyb3dzaW5nLW1vZGUuaHRtbApAQCAtMCwwICsxLDI3IEBACis8aGVhZD4KKzxzY3Jp cHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8c2NyaXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpIAorewor ICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgZGVidWcoIlRoaXMgdGVzdCBj YW4gb25seSBydW4gZnJvbSB3aXRoaW4gRHVtcFJlbmRlclRyZWUgYmVjYXVzZSBpdCByZXF1aXJl cyBUZXN0TmV0c2NhcGVQbHVnaW4uXG4iKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICAK KyAgICBwbHVnaW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJlbWJlZCIpOworICAgIHBsdWdp bi50eXBlID0gImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3QtbmV0c2NhcGUiOworICAgIHBsdWdp bi5zZXRBdHRyaWJ1dGUoJ3Rlc3QnLCAncHJpdmF0ZS1icm93c2luZycpOworICAgIGRvY3VtZW50 LmJvZHkuYXBwZW5kQ2hpbGQocGx1Z2luKTsKKyAgICAKKyAgICBzaG91bGRCZSgicGx1Z2luLnBy aXZhdGVCcm93c2luZ0VuYWJsZWQiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZSgicGx1Z2luLmNh Y2hlZFByaXZhdGVCcm93c2luZ0VuYWJsZWQiLCAiZmFsc2UiKTsKK30KKzwvc2NyaXB0PgorCis8 c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgdGhlIHByaXZhdGUgYnJvd3NpbmcgQVBJ IGltcGxlbWVudGF0aW9uIHdvcmtzIGFzIGV4cGVjdGVkIik7CisKKworPC9zY3JpcHQ+CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5zL3ByaXZhdGUtYnJvd3NpbmctbW9kZS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL3ByaXZhdGUtYnJvd3NpbmctbW9kZS1leHBlY3Rl ZC50eHQKaW5kZXggNzhhMjkzY2Y4YThlYjFiZDE0NWNmNjgyNjk3YzVhOTA5MmFhMmRjMi4uNDNm MWQ2ZWZlYmUxYjAyODkzYWY0Y2VkNjM1YzEzYWMxMzY5ODk0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGx1Z2lucy9wcml2YXRlLWJyb3dzaW5nLW1vZGUtZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL3BsdWdpbnMvcHJpdmF0ZS1icm93c2luZy1tb2RlLWV4cGVjdGVkLnR4dApAQCAt MywxMCArMyw5IEBAIFRlc3RzIHRoYXQgdGhlIHByaXZhdGUgYnJvd3NpbmcgQVBJIGltcGxlbWVu dGF0aW9uIHdvcmtzIGFzIGV4cGVjdGVkCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAot UEFTUyBwbHVnaW4xLnByaXZhdGVCcm93c2luZ0VuYWJsZWQgaXMgZmFsc2UKLVBBU1MgcGx1Z2lu MS5jYWNoZWRQcml2YXRlQnJvd3NpbmdFbmFibGVkIGlzIGZhbHNlCi1QQVNTIHBsdWdpbjEucHJp dmF0ZUJyb3dzaW5nRW5hYmxlZCBpcyB0cnVlCi1QQVNTIHBsdWdpbjEuY2FjaGVkUHJpdmF0ZUJy b3dzaW5nRW5hYmxlZCBpcyB0cnVlCi1QQVNTIHBsdWdpbjIucHJpdmF0ZUJyb3dzaW5nRW5hYmxl ZCBpcyB0cnVlCi1QQVNTIHBsdWdpbjIuY2FjaGVkUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCBpcyB0 cnVlCitQQVNTIHBsdWdpbi5wcml2YXRlQnJvd3NpbmdFbmFibGVkIGlzIHRydWUKK1BBU1MgcGx1 Z2luLmNhY2hlZFByaXZhdGVCcm93c2luZ0VuYWJsZWQgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsdWdpbnMvcHJpdmF0ZS1icm93c2luZy1tb2RlLmh0bWwgYi9MYXlvdXRUZXN0cy9wbHVn aW5zL3ByaXZhdGUtYnJvd3NpbmctbW9kZS5odG1sCmluZGV4IGY2ZWI5NjQyMmUyYTI5MDdkYjZj M2FiYjhhN2E3NmVmNGFjN2QzMzMuLjk4MGE2NTc1MzI1MmI2NzgxZWJkOTU1NWFjY2FjOTEyYTc4 YWVhODcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsdWdpbnMvcHJpdmF0ZS1icm93c2luZy1t b2RlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9wcml2YXRlLWJyb3dzaW5nLW1vZGUu aHRtbApAQCAtMSw5ICsxLDggQEAKKzwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgdXNlRXBoZW1l cmFsU2Vzc2lvbj10cnVlIF0gLS0+CiA8aGVhZD4KLTxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10 ZXN0LmpzIj48L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KLTxw IGlkPSJkZXNjcmlwdGlvbiI+PC9wPgotPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiA8c2NyaXB0 PgogZnVuY3Rpb24gcnVuVGVzdCgpIAogewpAQCAtMTIsMjcgKzExLDEzIEBAIGZ1bmN0aW9uIHJ1 blRlc3QoKQogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIAotICAgIHBsdWdpbjEgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJlbWJlZCIpOwotICAgIHBsdWdpbjEudHlwZSA9ICJhcHBsaWNh dGlvbi94LXdlYmtpdC10ZXN0LW5ldHNjYXBlIjsKLSAgICBwbHVnaW4xLnNldEF0dHJpYnV0ZSgn dGVzdCcsICdwcml2YXRlLWJyb3dzaW5nJyk7Ci0gICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGls ZChwbHVnaW4xKTsKKyAgICBwbHVnaW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJlbWJlZCIp OworICAgIHBsdWdpbi50eXBlID0gImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3QtbmV0c2NhcGUi OworICAgIHBsdWdpbi5zZXRBdHRyaWJ1dGUoJ3Rlc3QnLCAncHJpdmF0ZS1icm93c2luZycpOwor ICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQocGx1Z2luKTsKICAgICAKLSAgICBzaG91bGRC ZSgicGx1Z2luMS5wcml2YXRlQnJvd3NpbmdFbmFibGVkIiwgImZhbHNlIik7Ci0gICAgc2hvdWxk QmUoInBsdWdpbjEuY2FjaGVkUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCIsICJmYWxzZSIpOwotCi0g ICAgLy8gTm93IGVuYWJsZSBwcml2YXRlIGJyb3dzaW5nCi0gICAgdGVzdFJ1bm5lci5zZXRQcml2 YXRlQnJvd3NpbmdFbmFibGVkX0RFUFJFQ0FURUQodHJ1ZSk7Ci0KLSAgICBzaG91bGRCZSgicGx1 Z2luMS5wcml2YXRlQnJvd3NpbmdFbmFibGVkIiwgInRydWUiKTsKLSAgICBzaG91bGRCZSgicGx1 Z2luMS5jYWNoZWRQcml2YXRlQnJvd3NpbmdFbmFibGVkIiwgInRydWUiKTsKLSAgICAKLSAgICBw bHVnaW4yID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZW1iZWQiKTsKLSAgICBwbHVnaW4yLnR5 cGUgPSAiYXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRzY2FwZSI7Ci0gICAgcGx1Z2luMi5z ZXRBdHRyaWJ1dGUoJ3Rlc3QnLCAncHJpdmF0ZS1icm93c2luZycpOwotICAgIGRvY3VtZW50LmJv ZHkuYXBwZW5kQ2hpbGQocGx1Z2luMik7Ci0gICAgCi0gICAgc2hvdWxkQmUoInBsdWdpbjIucHJp dmF0ZUJyb3dzaW5nRW5hYmxlZCIsICJ0cnVlIik7Ci0gICAgc2hvdWxkQmUoInBsdWdpbjIuY2Fj aGVkUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCIsICJ0cnVlIik7CisgICAgc2hvdWxkQmUoInBsdWdp bi5wcml2YXRlQnJvd3NpbmdFbmFibGVkIiwgInRydWUiKTsKKyAgICBzaG91bGRCZSgicGx1Z2lu LmNhY2hlZFByaXZhdGVCcm93c2luZ0VuYWJsZWQiLCAidHJ1ZSIpOwogICAgIAogfQogPC9zY3Jp cHQ+Cg==