201519 2019-09-05 15:07:22 -0700 Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing 2019-09-05 22:58:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201475 1 cdumez cdumez achristensen beidson commit-queue ggaren koivisto webkit-bug-importer youennf oldest_to_newest 1568277 0 cdumez 2019-09-05 15:07:22 -0700 Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing. 1568282 1 378127 cdumez 2019-09-05 15:09:36 -0700 Created attachment 378127 Patch 1568369 2 378127 achristensen 2019-09-05 20:15:46 -0700 Comment on attachment 378127 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378127&action=review > Tools/WebKitTestRunner/TestOptions.cpp:61 > + return pathContains(pathOrURL, "w3c/IndexedDB-private-browsing") || pathContains(pathOrURL, "w3c\\IndexedDB-private-browsing"); Maybe pathContains should be made to replace '\\' with '/' before doing the comparison so we don't need both of these for all call sites. 1568398 3 378127 commit-queue 2019-09-05 22:57:29 -0700 Comment on attachment 378127 Patch Clearing flags on attachment: 378127 Committed r249564: <https://trac.webkit.org/changeset/249564> 1568399 4 commit-queue 2019-09-05 22:57:31 -0700 All reviewed patches have been landed. Closing bug. 1568400 5 webkit-bug-importer 2019-09-05 22:58:18 -0700 <rdar://problem/55101171> 378127 2019-09-05 15:09:36 -0700 2019-09-05 22:57:29 -0700 Patch bug-201519-20190905150935.patch text/plain 4888 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGVlNzJmMGJhMzk5MjViYmZmNTQ0OTFjNjZlNmFiNThm N2IxYTZiMy4uZjJmNmI3MGEwZjA3NjllMTViYzNmY2MyMWU3NDNkNzJjM2FmY2NmZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE5LTA5LTA1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgU3RvcCB1c2luZyB0ZXN0UnVubmVyLnNldFByaXZhdGVCcm93c2luZ0VuYWJsZWRfREVQUkVD QVRFRCgpIGluIGltcG9ydGVkL3czYy9JbmRleGVkREItcHJpdmF0ZS1icm93c2luZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNTE5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1c2luZyB0ZXN0 UnVubmVyLnNldFByaXZhdGVCcm93c2luZ0VuYWJsZWRfREVQUkVDQVRFRCgpIGluIGltcG9ydGVk L3czYy9JbmRleGVkREItcHJpdmF0ZS1icm93c2luZworICAgICAgICBhcyBpdCBkb2VzIG5vdCB0 cnVseSBlbmFibGUgcHJpdmF0ZSBicm93c2luZyBmb3IgV2ViS2l0Mi4gSW5zdGVhZCwgaGF2ZSBX S1RSIC8gRFJUIHNldCB0aGUKKyAgICAgICAgVGVzdE9wdGlvbjo6dXNlRXBoZW1lcmFsU2Vzc2lv biBmbGFnIGJhc2VkIG9uIHRoZSB0ZXN0IGZvbGRlci4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAgKHNob3VsZFVzZUVwaGVtZXJhbFNl c3Npb24pOgorICAgICAgICAocnVuVGVzdCk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9U ZXN0T3B0aW9ucy5jcHA6CisgICAgICAgIChXVFI6OnNob3VsZFVzZUVwaGVtZXJhbFNlc3Npb24p OgorICAgICAgICAoV1RSOjpUZXN0T3B0aW9uczo6VGVzdE9wdGlvbnMpOgorCiAyMDE5LTA5LTA1 ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gQWRkIHBy b3BlciBsYXlvdXQgdGVzdCBzdXBwb3J0IGZvciBlcGhlbWVyYWwgc2Vzc2lvbnMKZGlmZiAtLWdp dCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbSBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQppbmRleCBiNGI2NTMwNTY2NWU2Yzc5 YTlhOTg2OWMxZjE0NGFiMmI3NzczODM2Li5mZWVkNmJlNzg3YjFkZjYwZDNmNDA2MjVmMmM2NTZi NzIxN2I1ZTg5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRl clRyZWUubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1t CkBAIC0xODM0LDYgKzE4MzQsMTEgQEAgc3RhdGljIGJvb2wgc2hvdWxkTWFrZVZpZXdwb3J0Rmxl eGlibGUoY29uc3QgY2hhciogcGF0aE9yVVJMKQogfQogI2VuZGlmCiAKK3N0YXRpYyBib29sIHNo b3VsZFVzZUVwaGVtZXJhbFNlc3Npb24oY29uc3QgY2hhciogcGF0aE9yVVJMKQoreworICAgIHJl dHVybiBzdHJzdHIocGF0aE9yVVJMLCAidzNjL0luZGV4ZWREQi1wcml2YXRlLWJyb3dzaW5nIik7 Cit9CisKIHN0YXRpYyB2b2lkIHNldEpTQ09wdGlvbnMoY29uc3QgVGVzdE9wdGlvbnMmIG9wdGlv bnMpCiB7CiAgICAgc3RhdGljIFdURjo6U3RyaW5nQnVpbGRlciBzYXZlZE9wdGlvbnM7CkBAIC0y MDY1LDYgKzIwNzAsOSBAQCBzdGF0aWMgdm9pZCBydW5UZXN0KGNvbnN0IHN0cmluZyYgaW5wdXRM aW5lKQogICAgICAgICBhZGp1c3RXZWJEb2N1bWVudEZvckZsZXhpYmxlVmlld3BvcnQoZ1dlYkJy b3dzZXJWaWV3LCBnV2ViU2Nyb2xsVmlldyk7CiAjZW5kaWYKIAorICAgIGlmIChzaG91bGRVc2VF cGhlbWVyYWxTZXNzaW9uKHBhdGhPclVSTC5jX3N0cigpKSkKKyAgICAgICAgW1tbbWFpbkZyYW1l IHdlYlZpZXddIHByZWZlcmVuY2VzXSBzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkOllFU107CisK ICAgICBpZiAoW1dlYkhpc3Rvcnkgb3B0aW9uYWxTaGFyZWRIaXN0b3J5XSkKICAgICAgICAgW1dl Ykhpc3Rvcnkgc2V0T3B0aW9uYWxTaGFyZWRIaXN0b3J5Om5pbF07CiAKZGlmZiAtLWdpdCBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdE9wdGlvbnMuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9UZXN0T3B0aW9ucy5jcHAKaW5kZXggZDZlOGFiMjM4Mjc4NTU1Mjc2NWNhOGI0YmFjYzRk MmY0ZWIxMzU1Yy4uMTI0MWVlZWMyOTAwZDJjMWUxOGM0MmU4Zjk0ODdmYTkwYmE2NzFmNiAxMDA2 NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0T3B0aW9ucy5jcHAKKysrIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0T3B0aW9ucy5jcHAKQEAgLTU2LDYgKzU2LDExIEBAIHN0 YXRpYyBib29sIGlzU1ZHVGVzdFBhdGgoY29uc3Qgc3RkOjpzdHJpbmcmIHBhdGhPclVSTCkKICAg ICByZXR1cm4gcGF0aENvbnRhaW5zKHBhdGhPclVSTCwgInN2Zy9XM0MtU1ZHLTEuMSIpIHx8IHBh dGhDb250YWlucyhwYXRoT3JVUkwsICJzdmdcXFczQy1TVkctMS4xIik7CiB9CiAKK3N0YXRpYyBi b29sIHNob3VsZFVzZUVwaGVtZXJhbFNlc3Npb24oY29uc3Qgc3RkOjpzdHJpbmcmIHBhdGhPclVS TCkKK3sKKyAgICByZXR1cm4gcGF0aENvbnRhaW5zKHBhdGhPclVSTCwgInczYy9JbmRleGVkREIt cHJpdmF0ZS1icm93c2luZyIpIHx8IHBhdGhDb250YWlucyhwYXRoT3JVUkwsICJ3M2NcXEluZGV4 ZWREQi1wcml2YXRlLWJyb3dzaW5nIik7Cit9CisKIHN0YXRpYyBmbG9hdCBkZXZpY2VTY2FsZUZh Y3RvckZvclRlc3QoY29uc3Qgc3RkOjpzdHJpbmcmIHBhdGhPclVSTCkKIHsKICAgICBpZiAocGF0 aENvbnRhaW5zKHBhdGhPclVSTCwgIi9oaWRwaS0zeC0iKSkKQEAgLTY5LDYgKzc0LDcgQEAgVGVz dE9wdGlvbnM6OlRlc3RPcHRpb25zKGNvbnN0IHN0ZDo6c3RyaW5nJiBwYXRoT3JVUkwpCiAgICAg OiB1c2VGbGV4aWJsZVZpZXdwb3J0KHNob3VsZE1ha2VWaWV3cG9ydEZsZXhpYmxlKHBhdGhPclVS TCkpCiAgICAgLCB1c2VGaXhlZExheW91dChzaG91bGRVc2VGaXhlZExheW91dChwYXRoT3JVUkwp KQogICAgICwgaXNTVkdUZXN0KGlzU1ZHVGVzdFBhdGgocGF0aE9yVVJMKSkKKyAgICAsIHVzZUVw aGVtZXJhbFNlc3Npb24oc2hvdWxkVXNlRXBoZW1lcmFsU2Vzc2lvbihwYXRoT3JVUkwpKQogICAg ICwgZGV2aWNlU2NhbGVGYWN0b3IoZGV2aWNlU2NhbGVGYWN0b3JGb3JUZXN0KHBhdGhPclVSTCkp CiB7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA3NzU1ZTg2ODE4ZGI4OGFl OGM2ODlhZjFhNmRiYWVjOTM5YzNiMzUzLi5kODFmOTBhNDk3MTU1MmFmYTNmNjFkNmQxYTFkZjhi MDFkZmI5YzhiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxOS0wOS0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAg IFN0b3AgdXNpbmcgdGVzdFJ1bm5lci5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkX0RFUFJFQ0FU RUQoKSBpbiBpbXBvcnRlZC93M2MvSW5kZXhlZERCLXByaXZhdGUtYnJvd3NpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTUxOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgV2Via2l0LXNwZWNp ZmljIGNoYW5nZXMgdG8gV1BUIHRlc3RzLgorCisgICAgICAgICogSW5kZXhlZERCLXByaXZhdGUt YnJvd3Npbmcvc3VwcG9ydC5qczoKKwogMjAxOS0wOS0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIEFkZCBwcm9wZXIgbGF5b3V0IHRlc3Qgc3VwcG9y dCBmb3IgZXBoZW1lcmFsIHNlc3Npb25zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2MvSW5kZXhlZERCLXByaXZhdGUtYnJvd3Npbmcvc3VwcG9ydC5qcyBiL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy9JbmRleGVkREItcHJpdmF0ZS1icm93c2luZy9zdXBwb3J0LmpzCmluZGV4 IDBmOGRlZTlmNzQzODQwNTQ0OWI5YjEyMWY3M2E2MDFlOTNiOGI2MzYuLjJlZWNhNGYxZjUzODVj NmJhMjIwMTVhMGM5MTJkYzI3YjA2M2JkMjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy9JbmRleGVkREItcHJpdmF0ZS1icm93c2luZy9zdXBwb3J0LmpzCisrKyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy9JbmRleGVkREItcHJpdmF0ZS1icm93c2luZy9zdXBwb3J0Lmpz CkBAIC0xLDEwICsxLDMgQEAKLS8vIFdlYktpdCBjaGFuZ2VzOiB0aGlzIGZpbGUgaXMgdGhlIHNh bWUgYXMgIkluZGV4ZWREQi9zdXBwb3J0LmpzIiBmb3VuZCBpbiBXM0Mgd2ViLXBsYXRmb3JtLXRl c3RzIHJlcG8sCi0vLyBleGNlcHQgZm9yIHRoZSBmb2xsb3dpbmcgbGluZXMgdGhhdCBhY3RpdmF0 ZSBwcml2YXRlIGJyb3dzaW5nCi0vLyBGSVhNRTogVXBkYXRlIFdLVFIgLyBEUlQgdG8gZW5hYmxl IHByaXZhdGUgYnJvd3NpbmcgZm9yIHRoaXMgZm9sZGVyIGluc3RlYWQuCi1pZiAod2luZG93LnRl c3RSdW5uZXIpCi0gICAgdGVzdFJ1bm5lci5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkX0RFUFJF Q0FURUQodHJ1ZSk7Ci0vL0VuZCBvZiBXZWJLaXQgY2hhbmdlcwotCiB2YXIgZGF0YWJhc2VOYW1l ID0gImRhdGFiYXNlIjsKIHZhciBkYXRhYmFzZVZlcnNpb24gPSAxOwogCg==