201518 2019-09-05 14:40:29 -0700 AccessibilityRenderObject::setSelectedTextRange fails to set the selection passed an empty line. 2019-09-06 00:06:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 webkit-unassigned cfleizach commit-queue rniwa oldest_to_newest 1568264 0 andresg_22 2019-09-05 14:40:29 -0700 AccessibilityRenderObject::setSelectedTextRange fails to set the selection passed an empty line. 1568273 1 378126 andresg_22 2019-09-05 14:57:28 -0700 Created attachment 378126 Patch 1568328 2 andresg_22 2019-09-05 17:14:01 -0700 <rdar://problem/54835122> VoiceOver: When navigating text using characters rotor, VO gets stuck at end of first line and does not jump to subsequent lines of text as expected 1568411 3 378126 commit-queue 2019-09-06 00:06:15 -0700 Comment on attachment 378126 Patch Clearing flags on attachment: 378126 Committed r249565: <https://trac.webkit.org/changeset/249565> 1568412 4 commit-queue 2019-09-06 00:06:16 -0700 All reviewed patches have been landed. Closing bug. 378126 2019-09-05 14:57:28 -0700 2019-09-06 00:06:15 -0700 Patch bug-201518-20190905175727.patch text/plain 5939 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRlZjRjNjk3Y2VlMmQz MjBmZjE5NDZmZDEwNWI1ZTlmNjUyOGUxZC4uOWNlNTk4YmI0ZDI3NGUwZjY4ZTE1NmFlMGFlZGVl YmZkNmZkYTliYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA5LTA1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0OjpzZXRTZWxlY3RlZFRleHRSYW5nZSBmYWlscyB0byBzZXQgdGhlIHNl bGVjdGlvbiBwYXNzZWQgYW4gZW1wdHkgbGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTUxOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ4 MzUxMjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVzdDogYWNjZXNzaWJpbGl0eS9zZXQtc2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRlci1uZXdsaW5l Lmh0bWwKKworICAgICAgICBJbiB0aGUgY2FzZSBvZiBhbiBlbXB0eSBsaW5lLCB0aGUgQ2hhcmFj dGVySXRlcmF0b3IgcmFuZ2Ugc3RhcnQgYW5kIGVuZAorICAgICAgICB3ZXJlIG5vdCBlcXVhbCwg dGh1cyB3ZSB3ZXJlIG5vdCBhZHZhbmNpbmcgdGhlIGl0ZXJhdG9yIGFuZCByZXR1cm5pbmcKKyAg ICAgICAgdGhlIGl0ZXJhdG9yIHJhbmdlIGVuZCwgd2hpY2ggaXMgbm90IGNvcnJlY3QuIFdpdGgg dGhpcyBjaGFuZ2Ugd2UgYXJlCisgICAgICAgIGFsd2F5cyBhZHZhbmNpbmcgdGhlIGl0ZXJhdG9y IGlmIGl0cyB0ZXh0IGlzIGp1c3QgJ1xuJy4gVGhpcyBjb3ZlcnMgYWxsCisgICAgICAgIHRoZSBj YXNlcyB3ZSBmaXhlZCBiZWZvcmUgcGx1cyBlbXB0eSBsaW5lcy4KKworICAgICAgICAqIGVkaXRp bmcvRWRpdGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2aXNpYmxlUG9zaXRpb25Gb3JJbmRl eFVzaW5nQ2hhcmFjdGVySXRlcmF0b3IpOgorCiAyMDE5LTA4LTI5ICBaYW4gRG9iZXJzZWsgIDx6 ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTmljb3NpYV0gTmljb3NpYTo6QW5pbWF0 aW9uIGlzIG1pc3NpbmcgdGhlIGNvcHkgYXNzaWdubWVudCBvcGVyYXRvcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRWRpdGluZy5jcHAKaW5kZXggNjk5OTljOTMwY2Q2YTQyOTY0ZmE2ZTlmYTRjYTJhZmUwYThl ZDFiNC4uZmYyZGY4MjBmZWVkMDRlYWQwYWU5OGQ1M2U2N2I3NzNlMTQ0YTJiYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0VkaXRpbmcuY3BwCkBAIC0xMTIyLDE0ICsxMTIyLDExIEBAIFZpc2libGVQb3Np dGlvbiB2aXNpYmxlUG9zaXRpb25Gb3JJbmRleFVzaW5nQ2hhcmFjdGVySXRlcmF0b3IoTm9kZSYg bm9kZSwgaW50IGluCiAgICAgQ2hhcmFjdGVySXRlcmF0b3IgaXQocmFuZ2UuZ2V0KCkpOwogICAg IGl0LmFkdmFuY2UoaW5kZXggLSAxKTsKIAotICAgIGlmICghaXQuYXRFbmQoKSAmJiBpdC50ZXh0 KClbMF0gPT0gJ1xuJykgeworICAgIGlmICghaXQuYXRFbmQoKSAmJiBpdC50ZXh0KCkubGVuZ3Ro KCkgPT0gMSAmJiBpdC50ZXh0KClbMF0gPT0gJ1xuJykgewogICAgICAgICAvLyBGSVhNRTogd29y a2Fyb3VuZCBmb3IgY29sbGFwc2VkIHJhbmdlICh3aGVyZSBvbmx5IHN0YXJ0IHBvc2l0aW9uIGlz IGNvcnJlY3QpIGVtaXR0ZWQgZm9yIHNvbWUgZW1pdHRlZCBuZXdsaW5lcy4KLSAgICAgICAgYXV0 byBpdGVyYXRvclJhbmdlID0gaXQucmFuZ2UoKTsKLSAgICAgICAgaWYgKGl0ZXJhdG9yUmFuZ2Ut PnN0YXJ0UG9zaXRpb24oKSA9PSBpdGVyYXRvclJhbmdlLT5lbmRQb3NpdGlvbigpKSB7Ci0gICAg ICAgICAgICBpdC5hZHZhbmNlKDEpOwotICAgICAgICAgICAgaWYgKCFpdC5hdEVuZCgpKQotICAg ICAgICAgICAgICAgIHJldHVybiBWaXNpYmxlUG9zaXRpb24oaXQucmFuZ2UoKS0+c3RhcnRQb3Np dGlvbigpKTsKLSAgICAgICAgfQorICAgICAgICBpdC5hZHZhbmNlKDEpOworICAgICAgICBpZiAo IWl0LmF0RW5kKCkpCisgICAgICAgICAgICByZXR1cm4gVmlzaWJsZVBvc2l0aW9uKGl0LnJhbmdl KCktPnN0YXJ0UG9zaXRpb24oKSk7CiAgICAgfQogCiAgICAgcmV0dXJuIHsgaXQuYXRFbmQoKSA/ IHJhbmdlLT5lbmRQb3NpdGlvbigpIDogaXQucmFuZ2UoKS0+ZW5kUG9zaXRpb24oKSwgVVBTVFJF QU0gfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCA0ZWE1MDQ2NTMxYTBjMjc3ZDUyNWM5Y2QyMzI5MzY2OTEyNmQzMTdlLi5m NjUzNTBiZGUxMzI2MTA3ZGI0ODNjZWNmODI2M2QzZTk5NWYyNmUzIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTktMDktMDUgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29t PgorCisgICAgICAgIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnNldFNlbGVjdGVkVGV4dFJh bmdlIGZhaWxzIHRvIHNldCB0aGUgc2VsZWN0aW9uIHBhc3NlZCBhbiBlbXB0eSBsaW5lLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNTE4CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81NDgzNTEyMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFeHRlbmRlZCB0aGlzIHRlc3QgdG8gc2V0IHRoZSBzZWxl Y3Rpb24gcmFuZ2UgcGFzc2VkIGFuIGVtcHR5IGxpbmUuCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9zZXQtc2VsZWN0ZWQtdGV4dC1yYW5nZS1hZnRlci1uZXdsaW5lLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L3NldC1zZWxlY3RlZC10ZXh0LXJhbmdlLWFmdGVyLW5ld2xp bmUuaHRtbDoKKwogMjAxOS0wOC0yOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBNYWtlIHRhYkluZGV4IElETCBhdHRyaWJ1dGUgcmVmbGVjdCBpdHMgY29udGVu dCBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvc2V0LXNl bGVjdGVkLXRleHQtcmFuZ2UtYWZ0ZXItbmV3bGluZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L3NldC1zZWxlY3RlZC10ZXh0LXJhbmdlLWFmdGVyLW5ld2xpbmUtZXhw ZWN0ZWQudHh0CmluZGV4IDEwZDQ1Mjc5OThlMzk1NDMwYmRkM2RkMGRiOGQxNTY3YzcxMzZlNWQu LjEzMGY0YjQ3MTdhMzVhNzI5ODliNmM4YThmZGFkN2ZhNTEzNmQ2MmQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvc2V0LXNlbGVjdGVkLXRleHQtcmFuZ2UtYWZ0ZXItbmV3 bGluZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9zZXQtc2Vs ZWN0ZWQtdGV4dC1yYW5nZS1hZnRlci1uZXdsaW5lLWV4cGVjdGVkLnR4dApAQCAtMSw4ICsxLDEx IEBACiBoZWxsbworCiB3b3JsZAogUEFTUyB0ZXh0LnNlbGVjdGVkVGV4dFJhbmdlIGJlY2FtZSAn ezUsIDB9JwogVGhlcmUgbXVzdCBiZSBvbmx5IG9uZSBbbmV3bGluZV0gYmV0d2VlbiBoZWxsbyBh bmQgd29ybGQ6IGhlbGxvW25ld2xpbmVdd29ybGQKIFBBU1MgdGV4dC5zZWxlY3RlZFRleHRSYW5n ZSBiZWNhbWUgJ3s2LCAwfScKK1RoZXJlIG11c3QgYmUgdHdvIFtuZXdsaW5lXSBiZXR3ZWVuIGhl bGxvIGFuZCB3b3JsZDogaGVsbG9bbmV3bGluZV1bbmV3bGluZV13b3JsZAorUEFTUyB0ZXh0LnNl bGVjdGVkVGV4dFJhbmdlIGJlY2FtZSAnezcsIDB9JwogVGhlIHRleHQgYWZ0ZXIgdGhlIG5ld2xp bmUgc2hvdWxkIGJlIHdvcmxkOiB3b3JsZAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3NldC1zZWxlY3RlZC10 ZXh0LXJhbmdlLWFmdGVyLW5ld2xpbmUuaHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv c2V0LXNlbGVjdGVkLXRleHQtcmFuZ2UtYWZ0ZXItbmV3bGluZS5odG1sCmluZGV4IDRmZmMyZTNi Mzg2MTg0MDdhZGRhMjUxNmM5NTE1NWRlNWNmMmEwZDQuLmJkYjQyY2JhMjAwMmQxM2RkODZmMzVl ZDA2ODZkZGY2ZWFlODg0ZjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv c2V0LXNlbGVjdGVkLXRleHQtcmFuZ2UtYWZ0ZXItbmV3bGluZS5odG1sCisrKyBiL0xheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvc2V0LXNlbGVjdGVkLXRleHQtcmFuZ2UtYWZ0ZXItbmV3bGluZS5o dG1sCkBAIC0xOCw2ICsxOCw3IEBACiAgICAgICAgIHZhciB0ZXh0ID0gYWNjZXNzaWJpbGl0eUNv bnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CiAgICAgICAgIHRleHQuc2V0U2VsZWN0ZWRUZXh0UmFu Z2UoNSwgMCk7CiAgICAgICAgIHNob3VsZEJlY29tZUVxdWFsKCJ0ZXh0LnNlbGVjdGVkVGV4dFJh bmdlIiwgIid7NSwgMH0nIiwgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAvLyBJbnNlcnQgYSBs aW5lYnJlYWsgYmV0d2VlbiAiaGVsbG8iIGFuZCAid29ybGQiLgogICAgICAgICAgICAgdGV4dC5y ZXBsYWNlVGV4dEluUmFuZ2UoIlxuIiwgNSwgMCk7CiAKICAgICAgICAgICAgIHZhciB0ID0gdGV4 dC5zdHJpbmdGb3JSYW5nZSgwLCAxMSk7CkBAIC0yNiwxMSArMjcsMjEgQEAKIAogICAgICAgICAg ICAgdGV4dC5zZXRTZWxlY3RlZFRleHRSYW5nZSg2LCAwKTsKICAgICAgICAgICAgIHNob3VsZEJl Y29tZUVxdWFsKCJ0ZXh0LnNlbGVjdGVkVGV4dFJhbmdlIiwgIid7NiwgMH0nIiwgZnVuY3Rpb24o KSB7Ci0gICAgICAgICAgICAgICAgdmFyIHQgPSB0ZXh0LnN0cmluZ0ZvclJhbmdlKDYsIDUpOwor ICAgICAgICAgICAgICAgIC8vIEluc2VydCBhbm90aGVyIGxpbmVicmVhayBiZWZvcmUgIndvcmxk Ii4KKyAgICAgICAgICAgICAgICB0ZXh0LnJlcGxhY2VUZXh0SW5SYW5nZSgiXG4iLCA2LCAwKTsK KworICAgICAgICAgICAgICAgIHZhciB0ID0gdGV4dC5zdHJpbmdGb3JSYW5nZSgwLCAxMik7CiAg ICAgICAgICAgICAgICAgdCA9IHQucmVwbGFjZSgvKD86XHJcbnxccnxcbikvZywgJ1tuZXdsaW5l XScpOwotICAgICAgICAgICAgICAgIGRlYnVnKCJUaGUgdGV4dCBhZnRlciB0aGUgbmV3bGluZSBz aG91bGQgYmUgd29ybGQ6ICIgKyB0KTsKKyAgICAgICAgICAgICAgICBkZWJ1ZygiVGhlcmUgbXVz dCBiZSB0d28gW25ld2xpbmVdIGJldHdlZW4gaGVsbG8gYW5kIHdvcmxkOiAiICsgdCk7CisKKyAg ICAgICAgICAgICAgICB0ZXh0LnNldFNlbGVjdGVkVGV4dFJhbmdlKDcsIDApOworICAgICAgICAg ICAgICAgIHNob3VsZEJlY29tZUVxdWFsKCJ0ZXh0LnNlbGVjdGVkVGV4dFJhbmdlIiwgIid7Nywg MH0nIiwgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgICAgIHZhciB0ID0gdGV4dC5zdHJp bmdGb3JSYW5nZSg3LCA1KTsKKyAgICAgICAgICAgICAgICAgICAgdCA9IHQucmVwbGFjZSgvKD86 XHJcbnxccnxcbikvZywgJ1tuZXdsaW5lXScpOworICAgICAgICAgICAgICAgICAgICBkZWJ1Zygi VGhlIHRleHQgYWZ0ZXIgdGhlIG5ld2xpbmUgc2hvdWxkIGJlIHdvcmxkOiAiICsgdCk7CiAKLSAg ICAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgICAgICAgICAgICAgZmluaXNo SlNUZXN0KCk7CisgICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICB9KTsKICAgICAgICAg fSk7CiAgICAgfQo=