201512 2019-09-05 12:42:16 -0700 results.webkit.org: Fix prepending search result on empty list 2019-09-05 16:04:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue webkit-bug-importer oldest_to_newest 1568207 0 jbedard 2019-09-05 12:42:16 -0700 If we try and add a new result when the search page is empty, we can't because there is nothing to prepend to. We need to add the result if no existing results are present. 1568210 1 378105 jbedard 2019-09-05 12:49:45 -0700 Created attachment 378105 Patch 1568301 2 378105 commit-queue 2019-09-05 16:03:38 -0700 Comment on attachment 378105 Patch Clearing flags on attachment: 378105 Committed r249549: <https://trac.webkit.org/changeset/249549> 1568302 3 commit-queue 2019-09-05 16:03:39 -0700 All reviewed patches have been landed. Closing bug. 1568303 4 webkit-bug-importer 2019-09-05 16:04:20 -0700 <rdar://problem/55089070> 378105 2019-09-05 12:49:45 -0700 2019-09-05 16:03:38 -0700 Patch bug-201512-20190905124944.patch text/plain 1555 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0OTUzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA5LTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEZpeCBwcmVwZW5kaW5nIHNlYXJjaCBy ZXN1bHQgb24gZW1wdHkgbGlzdCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMTUxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy90ZW1wbGF0ZXMvc2Vh cmNoLmh0bWw6CisKIDIwMTktMDktMDUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUkVHUkVTU0lPTiAoaU9TIDEzKTogQnVsbGV0ZWQgbGlzdCBjb3BpZWQgZnJv bSBOb3RlcyB0byBNYWlsIHJlc3VsdHMgaW4gVGltZXMgTmV3IFJvbWFuCkluZGV4OiBUb29scy9y ZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9zZWFyY2guaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9zZWFy Y2guaHRtbAkocmV2aXNpb24gMjQ5NTI5KQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2Ri cHkvdmlldy90ZW1wbGF0ZXMvc2VhcmNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEzMSw3ICsx MzEsMTAgQEAgY2xhc3MgU2VhcmNoVmlldyB7CiAgICAgICAgICAgICAgICAgICAgIERPTS5pbmpl Y3QoZWxlbWVudCwgZGlmZi5jaGlsZHJlbi5tYXAocmVuZGVyQ2hpbGQpLmpvaW4oJycpKTsKICAg ICAgICAgICAgICAgICBpZiAoZGlmZi5wcmVwZW5kaW5nKSB7CiAgICAgICAgICAgICAgICAgICAg IGRpZmYucHJlcGVuZGluZy5mb3JFYWNoKGNoaWxkID0+IHsKLSAgICAgICAgICAgICAgICAgICAg ICAgIERPTS5hZnRlcihlbGVtZW50LmZpcnN0RWxlbWVudENoaWxkLCByZW5kZXJDaGlsZChjaGls ZCkpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQuZmlyc3RFbGVtZW50Q2hp bGQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgRE9NLmFmdGVyKGVsZW1lbnQuZmlyc3RF bGVtZW50Q2hpbGQsIHJlbmRlckNoaWxkKGNoaWxkKSk7CisgICAgICAgICAgICAgICAgICAgICAg ICBlbHNlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgRE9NLmluamVjdChlbGVtZW50LCBy ZW5kZXJDaGlsZChjaGlsZCkpOwogICAgICAgICAgICAgICAgICAgICAgICAgdGhpcy5yZWYuc3Rh dGUuY2hpbGRyZW4udW5zaGlmdChjaGlsZCk7CiAgICAgICAgICAgICAgICAgICAgIH0pOwogICAg ICAgICAgICAgICAgIH0gCg==