201510 2019-09-05 11:31:16 -0700 results.webkit.org: Assign notifyRerender before calling 2019-09-05 16:38:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer zhifei_fang oldest_to_newest 1568190 0 jbedard 2019-09-05 11:31:16 -0700 This bug doesn't have much of an effect, but it pollutes our console log. 1568192 1 378102 jbedard 2019-09-05 11:33:32 -0700 Created attachment 378102 Patch 1568279 2 378102 aakash_jain 2019-09-05 15:09:17 -0700 Comment on attachment 378102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378102&action=review > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:515 > + // notify inside of the provider that we may changed the layout size because of expanded / unexpanded. Nit: notify => Notify 1568315 3 jbedard 2019-09-05 16:37:18 -0700 Committed r249554: <https://trac.webkit.org/changeset/249554> 1568317 4 webkit-bug-importer 2019-09-05 16:38:19 -0700 <rdar://problem/55090537> 378102 2019-09-05 11:33:32 -0700 2019-09-05 15:09:17 -0700 Patch bug-201510-20190905113332.patch text/plain 6121 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0OTUzNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE5LTA5LTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEFzc2lnbiBub3RpZnlSZXJlbmRlciBi ZWZvcmUgY2FsbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAxNTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGltZWxpbmVzIHNob3VsZCBkZWZpbmUgbm90aWZ5UmVyZW5kZXIgdG8gYW4gZW1wdHkg ZnVuY3Rpb24sCisgICAgICAgIHJlbmFtZSBub3RpZml5UmVyZW5kZXIgdG8gbm90aWZ5UmVyZW5k ZXIuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy90 aW1lbGluZS5qczoKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRp Yy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvVGltZWxpbmVDb21wb25lbnRzLmpzOgorICAgICAgICAq IHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvdGVtcGxhdGVzL3NlYXJjaC5odG1sOgorICAg ICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvdGVtcGxhdGVzL3N1aXRlX3Jlc3Vs dHMuaHRtbDoKKwogMjAxOS0wOS0wNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBSRUdSRVNTSU9OIChpT1MgMTMpOiBCdWxsZXRlZCBsaXN0IGNvcGllZCBmcm9t IE5vdGVzIHRvIE1haWwgcmVzdWx0cyBpbiBUaW1lcyBOZXcgUm9tYW4KSW5kZXg6IFRvb2xzL3Jl c3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL3RpbWVsaW5lLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL3RpbWVs aW5lLmpzCShyZXZpc2lvbiAyNDk1MjkpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJw eS92aWV3L3N0YXRpYy9qcy90aW1lbGluZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMzgwLDYgKzM4 MCw3IEBAIGNsYXNzIFRpbWVsaW5lRnJvbUVuZHBvaW50IHsKICAgICAgICAgdGhpcy51cGRhdGVz ID0gW107CiAgICAgICAgIHRoaXMueGF4aXNVcGRhdGVzID0gW107CiAgICAgICAgIHRoaXMudGlt ZWxpbmVVcGRhdGUgPSBudWxsOworICAgICAgICB0aGlzLm5vdGlmeVJlcmVuZGVyID0gKCkgPT4g e307CiAgICAgICAgIHRoaXMucmVwb3NpdG9yaWVzID0gW107CiAKICAgICAgICAgY29uc3Qgc2Vs ZiA9IHRoaXM7CkBAIC03NjYsNyArNzY3LDcgQEAgY2xhc3MgVGltZWxpbmVGcm9tRW5kcG9pbnQg ewogICAgICAgICAgICAgdG9wID0gZmFsc2U7CiAgICAgICAgIH0pOwogCi0gICAgICAgIGNvbnN0 IGNvbXBvc2VyID0gRlAuY29tcG9zZXIoRlAuY3VycnlpbmcoKHVwZGF0ZVRpbWVsaW5lLCBub3Rp Zml5UmVyZW5kZXIpID0+IHsKKyAgICAgICAgY29uc3QgY29tcG9zZXIgPSBGUC5jb21wb3NlcihG UC5jdXJyeWluZygodXBkYXRlVGltZWxpbmUsIG5vdGlmeVJlcmVuZGVyKSA9PiB7CiAgICAgICAg ICAgICBzZWxmLnRpbWVsaW5lVXBkYXRlID0gKHhBeGlzZXMpID0+IHsKICAgICAgICAgICAgICAg ICBjaGlsZHJlbi5zcGxpY2UoMCwgMSk7CiAgICAgICAgICAgICAgICAgaWYgKHNlbGYucmVwb3Np dG9yaWVzLmxlbmd0aCA+IDEpCkBAIC03ODIsNyArNzgzLDcgQEAgY2xhc3MgVGltZWxpbmVGcm9t RW5kcG9pbnQgewogICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgICAgIHVwZGF0ZVRp bWVsaW5lKGNoaWxkcmVuKTsKICAgICAgICAgICAgIH07Ci0gICAgICAgICAgICBzZWxmLm5vdGlm aXlSZXJlbmRlciA9IG5vdGlmaXlSZXJlbmRlcjsKKyAgICAgICAgICAgIHNlbGYubm90aWZ5UmVy ZW5kZXIgPSBub3RpZnlSZXJlbmRlcjsKICAgICAgICAgfSkpOwogICAgICAgICByZXR1cm4gVGlt ZWxpbmUuQ2FudmFzQ29udGFpbmVyKGNvbXBvc2VyLCAuLi5jaGlsZHJlbik7CiAgICAgfQpJbmRl eDogVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9j b21wb25lbnRzL1RpbWVsaW5lQ29tcG9uZW50cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1 bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvVGlt ZWxpbmVDb21wb25lbnRzLmpzCShyZXZpc2lvbiAyNDk1MjkpCisrKyBUb29scy9yZXN1bHRzZGJw eS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvVGltZWxpbmVD b21wb25lbnRzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsNyArMTU3LDcgQEAgZnVuY3Rpb24g WFNjcm9sbGFibGVDYW52YXNQcm92aWRlcihleHBvcgogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzY3JvbGxFdmVudFN0cmVhbS5yZXBsYXlMYXN0KCk7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKioKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAqIE5vdGlmaXkgUmUtcmVuZGVyCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKiBOb3RpZnkgUmUtcmVuZGVyCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKiBAcGFyYW0gd2lkdGgge251bWJlcn0gciBpZiB1bmRlZmluZWQsIGl0IHdpbGwgYXV0byBk ZXRhY3QgdGhlIHdpZHRoIGNoYW5nZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICovCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZHRoKSA9PiB7CkBAIC01MTIsNyArNTEyLDcg QEAgVGltZWxpbmUuRXhwYW5kYWJsZVNlcmllc0NvbXBvbmVudCA9IChtYQogICAgICAgICAgICAg ICAgIGVsZW1lbnQuY2hpbGRyZW5bMV0uc3R5bGUuZGlzcGxheSA9ICdub25lJzsKICAgICAgICAg ICAgICAgICBlbGVtZW50LmNoaWxkcmVuWzJdLnN0eWxlLmRpc3BsYXkgPSAnYmxvY2snOwogICAg ICAgICAgICAgfQotICAgICAgICAgICAgLy8gTm90aWZpeSBpbnNpZGUgb2YgdGhlIHByb3ZpZGVy IHRoYXQgd2UgbWF5IGNoYW5nZWQgdGhlIGxheW91dCBzaXplIGJlY2F1c2Ugb2YgZXhwYW5kZWQg LyB1bmV4cGFuZGVkLgorICAgICAgICAgICAgLy8gbm90aWZ5IGluc2lkZSBvZiB0aGUgcHJvdmlk ZXIgdGhhdCB3ZSBtYXkgY2hhbmdlZCB0aGUgbGF5b3V0IHNpemUgYmVjYXVzZSBvZiBleHBhbmRl ZCAvIHVuZXhwYW5kZWQuCiAgICAgICAgICAgICBsYXlvdXRTaXplTWF5Q2hhbmdlRXZlbnQuYWRk KCk7CiAgICAgICAgIH0KICAgICB9KTsKQEAgLTg5NywxMyArODk3LDEzIEBAIFRpbWVsaW5lLkNh bnZhc0NvbnRhaW5lciA9IChleHBvcnRlciwgLi4KICAgICAgICAgcmV0dXJuIHtoZWFkZXJzLCBz ZXJpZXNlc307CiAgICAgfTsKICAgICBjb25zdCB7aGVhZGVycywgc2VyaWVzZXN9ID0gdXBhY2tD aGlsZHJlbihjaGlsZHJlbik7Ci0gICAgbGV0IGNvbXBvc2VyID0gRlAuY29tcG9zZXIoRlAuY3Vy cnlpbmcoKHVwZGF0ZUhlYWRlcnMsIHVwZGF0ZVNlcmllc2VzLCBub3RpZml5UmVyZW5kZXIpID0+ IHsKKyAgICBsZXQgY29tcG9zZXIgPSBGUC5jb21wb3NlcihGUC5jdXJyeWluZygodXBkYXRlSGVh ZGVycywgdXBkYXRlU2VyaWVzZXMsIG5vdGlmeVJlcmVuZGVyKSA9PiB7CiAgICAgICAgIGlmIChl eHBvcnRlcikKICAgICAgICAgICAgIGV4cG9ydGVyKChuZXdDaGlsZHJlbikgPT4gewogICAgICAg ICAgICAgICAgIGNvbnN0IHtoZWFkZXJzLCBzZXJpZXNlc30gPSB1cGFja0NoaWxkcmVuKG5ld0No aWxkcmVuKTsKICAgICAgICAgICAgICAgICB1cGRhdGVIZWFkZXJzKGhlYWRlcnMpOwogICAgICAg ICAgICAgICAgIHVwZGF0ZVNlcmllc2VzKHNlcmllc2VzKTsKLSAgICAgICAgICAgIH0sIG5vdGlm aXlSZXJlbmRlcik7CisgICAgICAgICAgICB9LCBub3RpZnlSZXJlbmRlcik7CiAgICAgfSkpOwog ICAgIHJldHVybiAoCiAgICAgICAgIGA8ZGl2IGNsYXNzPSJ0aW1lbGluZSI+CkluZGV4OiBUb29s cy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9zZWFyY2guaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9z ZWFyY2guaHRtbAkocmV2aXNpb24gMjQ5NTI5KQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0 c2RicHkvdmlldy90ZW1wbGF0ZXMvc2VhcmNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTIwMyw5 ICsyMDMsOSBAQCBjbGFzcyBTZWFyY2hWaWV3IHsKICAgICB0b1N0cmluZygpIHsKICAgICAgICAg cmV0dXJuIGA8ZGl2IHJlZj0iJHt0aGlzLnJlZn0iPjwvZGl2PmA7CiAgICAgfQotICAgIG5vdGlm aXlUaW1lbGluZXNSZW5kZXIoKSB7CisgICAgbm90aWZ5VGltZWxpbmVzUmVuZGVyKCkgewogICAg ICAgICB0aGlzLnJlZi5zdGF0ZS5jaGlsZHJlbi5mb3JFYWNoKGNoaWxkID0+IHsKLSAgICAgICAg ICAgIGNoaWxkLnRpbWVsaW5lLm5vdGlmaXlSZXJlbmRlcigpOworICAgICAgICAgICAgY2hpbGQu dGltZWxpbmUubm90aWZ5UmVyZW5kZXIoKTsKICAgICAgICAgfSk7CiAgICAgfQogfQpAQCAtMjEz LDcgKzIxMyw3IEBAIGNsYXNzIFNlYXJjaFZpZXcgewogbGV0IHZpZXcgPSBuZXcgU2VhcmNoVmll dygpOwogY29uc3Qgb25MYXlvdXRDaGFuZ2UgPSBuZXcgRXZlbnRTdHJlYW0oKTsKIG9uTGF5b3V0 Q2hhbmdlLmFjdGlvbigoKSA9PiB7Ci0gICAgdmlldy5ub3RpZml5VGltZWxpbmVzUmVuZGVyKCk7 CisgICAgdmlldy5ub3RpZnlUaW1lbGluZXNSZW5kZXIoKTsKIH0pOwogd2luZG93Lm9ucG9wc3Rh dGUgPSBldmVudCA9PiB7dmlldy5yZWxvYWQoKTt9Owogd2luZG93Lm9ucHVzaHN0YXRlID0gZXZl bnQgPT4ge3ZpZXcucmVsb2FkKCk7fTsKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNk YnB5L3ZpZXcvdGVtcGxhdGVzL3N1aXRlX3Jlc3VsdHMuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9zdWl0ZV9yZXN1bHRzLmh0 bWwJKHJldmlzaW9uIDI0OTUyOSkKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3Zp ZXcvdGVtcGxhdGVzL3N1aXRlX3Jlc3VsdHMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTUyLDkg KzE1Miw5IEBAIGNsYXNzIE1haW5WaWV3IHsKICAgICAgICAgICAgICAgICA8L2Rpdj48YnI+YDsK ICAgICAgICAgfSkuam9pbignJyk7CiAgICAgfQotICAgIG5vdGlmaXlUaW1lbGluZXNSZW5kZXIo KSB7CisgICAgbm90aWZ5VGltZWxpbmVzUmVuZGVyKCkgewogICAgICAgICBmb3IgKGxldCBzdWl0 ZSBpbiB0aGlzLmNoaWxkcmVuKSB7Ci0gICAgICAgICAgICB0aGlzLmNoaWxkcmVuW3N1aXRlXS5u b3RpZml5UmVyZW5kZXIoKTsKKyAgICAgICAgICAgIHRoaXMuY2hpbGRyZW5bc3VpdGVdLm5vdGlm eVJlcmVuZGVyKCk7CiAgICAgICAgIH0KICAgICB9CiB9CkBAIC0xNjIsNyArMTYyLDcgQEAgY2xh c3MgTWFpblZpZXcgewogbGV0IHZpZXcgPSBuZXcgTWFpblZpZXcoKTsKIGNvbnN0IG9uTGF5b3V0 Q2hhbmdlID0gbmV3IEV2ZW50U3RyZWFtKCk7CiBvbkxheW91dENoYW5nZS5hY3Rpb24oKCkgPT4g ewotICAgIHZpZXcubm90aWZpeVRpbWVsaW5lc1JlbmRlcigpOworICAgIHZpZXcubm90aWZ5VGlt ZWxpbmVzUmVuZGVyKCk7CiB9KTsKIAogRE9NLmluamVjdChkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnYXBwJyksIGAke1Rvb2xUaXB9Cg==