201508 2019-09-05 08:56:29 -0700 Don't call PlatformMediaSessionManager methods when neither VIDEO nor WEB_AUDIO is enabled 2019-09-05 09:57:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen commit-queue eric.carlson jer.noble webkit-bug-importer youennf oldest_to_newest 1568135 0 annulen 2019-09-05 08:56:29 -0700 Definitions of these methods are guarded with #if ENABLE(VIDEO) || ENABLE(WEB_AUDIO), so calling them causes linking errors. 1568137 1 378087 annulen 2019-09-05 08:57:45 -0700 Created attachment 378087 Patch 1568150 2 378087 commit-queue 2019-09-05 09:56:31 -0700 Comment on attachment 378087 Patch Clearing flags on attachment: 378087 Committed r249531: <https://trac.webkit.org/changeset/249531> 1568151 3 commit-queue 2019-09-05 09:56:33 -0700 All reviewed patches have been landed. Closing bug. 1568152 4 webkit-bug-importer 2019-09-05 09:57:17 -0700 <rdar://problem/55071488> 378087 2019-09-05 08:57:45 -0700 2019-09-05 09:56:31 -0700 Patch bug-201508-20190905185744.patch text/plain 5074 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE2Mjk3M2EzYzk3ZDA1 OGE2YWU3ZWMwODlhMTdlYjBlNjU2YTdhMS4uNjNmNGUzNzdlMWNiYzY4OWYyOTMyYjM2MGZhNmQ1 ZWY3MzQ5MmZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA5LTA1ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEb24ndCBjYWxs IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciBtZXRob2RzIHdoZW4gbmVpdGhlciBWSURFTyBu b3IgV0VCX0FVRElPIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMTUwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERlZmluaXRpb25zIG9mIHRoZXNlIG1ldGhvZHMgYXJlIGd1YXJkZWQg d2l0aCAjaWYgRU5BQkxFKFZJREVPKSB8fCBFTkFCTEUoV0VCX0FVRElPKSwKKyAgICAgICAgc28g Y2FsbGluZyB0aGVtIGNhdXNlcyBsaW5raW5nIGVycm9ycy4KKworICAgICAgICAqIHRlc3Rpbmcv SW50ZXJuYWxTZXR0aW5ncy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbFNldHRpbmdz OjpCYWNrdXA6OkJhY2t1cCk6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbFNldHRpbmdzOjpC YWNrdXA6OnJlc3RvcmVUbyk6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbFNldHRpbmdzOjpz ZXRTaG91bGREZWFjdGl2YXRlQXVkaW9TZXNzaW9uKToKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVy bmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OnJlc2V0VG9Db25zaXN0ZW50 U3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxzOjpwcm9jZXNzV2lsbFN1c3BlbmQp OgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxzOjpwcm9jZXNzRGlkUmVzdW1lKToKKyAgICAg ICAgKFdlYkNvcmU6OkludGVybmFsczo6c2V0SXNQbGF5aW5nVG9BdXRvbW90aXZlSGVhZFVuaXQp OgorCiAyMDE5LTA5LTA1ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggaW1wbGljaXQgY29udmVyc2lvbiB0aGF0IGxvc2VzIHByZWNpc2lvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKaW5kZXggMTkyNmNiNTkxODI3 YWQ1ZTVhNWNkMzc3N2RmYmFjMmNjOGE0NDdjYy4uZDZkN2RkNDhiYThmZDY4ZThjMDJjOGViMTM4 OTFlNjQyYzY4MDBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGlu Z3MuY3BwCkBAIC0xMDIsNyArMTAyLDkgQEAgSW50ZXJuYWxTZXR0aW5nczo6QmFja3VwOjpCYWNr dXAoU2V0dGluZ3MmIHNldHRpbmdzKQogICAgICwgbV9pbmNvbXBsZXRlSW1hZ2VCb3JkZXJFbmFi bGVkKHNldHRpbmdzLmluY29tcGxldGVJbWFnZUJvcmRlckVuYWJsZWQoKSkKICAgICAsIG1fc2hv dWxkRGlzcGF0Y2hTeW50aGV0aWNNb3VzZUV2ZW50c1doZW5Nb2RpZnlpbmdTZWxlY3Rpb24oc2V0 dGluZ3Muc2hvdWxkRGlzcGF0Y2hTeW50aGV0aWNNb3VzZUV2ZW50c1doZW5Nb2RpZnlpbmdTZWxl Y3Rpb24oKSkKICAgICAsIG1fc2hvdWxkRGlzcGF0Y2hTeW50aGV0aWNNb3VzZU91dEFmdGVyU3lu dGhldGljQ2xpY2soc2V0dGluZ3Muc2hvdWxkRGlzcGF0Y2hTeW50aGV0aWNNb3VzZU91dEFmdGVy U3ludGhldGljQ2xpY2soKSkKKyNpZiBFTkFCTEUoVklERU8pIHx8IEVOQUJMRShXRUJfQVVESU8p CiAgICAgLCBtX3Nob3VsZERlYWN0aXZhdGVBdWRpb1Nlc3Npb24oUGxhdGZvcm1NZWRpYVNlc3Np b25NYW5hZ2VyOjpzaG91bGREZWFjdGl2YXRlQXVkaW9TZXNzaW9uKCkpCisjZW5kaWYKICAgICAs IG1fYW5pbWF0ZWRJbWFnZURlYnVnQ2FudmFzRHJhd2luZ0VuYWJsZWQoc2V0dGluZ3MuYW5pbWF0 ZWRJbWFnZURlYnVnQ2FudmFzRHJhd2luZ0VuYWJsZWQoKSkKICAgICAsIG1fdXNlckludGVyZmFj ZURpcmVjdGlvblBvbGljeShzZXR0aW5ncy51c2VySW50ZXJmYWNlRGlyZWN0aW9uUG9saWN5KCkp CiAgICAgLCBtX3N5c3RlbUxheW91dERpcmVjdGlvbihzZXR0aW5ncy5zeXN0ZW1MYXlvdXREaXJl Y3Rpb24oKSkKQEAgLTIxMiw3ICsyMTQsOSBAQCB2b2lkIEludGVybmFsU2V0dGluZ3M6OkJhY2t1 cDo6cmVzdG9yZVRvKFNldHRpbmdzJiBzZXR0aW5ncykKICAgICBzZXR0aW5ncy5zZXRJbmNvbXBs ZXRlSW1hZ2VCb3JkZXJFbmFibGVkKG1faW5jb21wbGV0ZUltYWdlQm9yZGVyRW5hYmxlZCk7CiAg ICAgc2V0dGluZ3Muc2V0U2hvdWxkRGlzcGF0Y2hTeW50aGV0aWNNb3VzZUV2ZW50c1doZW5Nb2Rp ZnlpbmdTZWxlY3Rpb24obV9zaG91bGREaXNwYXRjaFN5bnRoZXRpY01vdXNlRXZlbnRzV2hlbk1v ZGlmeWluZ1NlbGVjdGlvbik7CiAgICAgc2V0dGluZ3Muc2V0U2hvdWxkRGlzcGF0Y2hTeW50aGV0 aWNNb3VzZU91dEFmdGVyU3ludGhldGljQ2xpY2sobV9zaG91bGREaXNwYXRjaFN5bnRoZXRpY01v dXNlT3V0QWZ0ZXJTeW50aGV0aWNDbGljayk7CisjaWYgRU5BQkxFKFZJREVPKSB8fCBFTkFCTEUo V0VCX0FVRElPKQogICAgIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2V0U2hvdWxkRGVh Y3RpdmF0ZUF1ZGlvU2Vzc2lvbihtX3Nob3VsZERlYWN0aXZhdGVBdWRpb1Nlc3Npb24pOworI2Vu ZGlmCiAgICAgc2V0dGluZ3Muc2V0QW5pbWF0ZWRJbWFnZURlYnVnQ2FudmFzRHJhd2luZ0VuYWJs ZWQobV9hbmltYXRlZEltYWdlRGVidWdDYW52YXNEcmF3aW5nRW5hYmxlZCk7CiAKICNpZiBFTkFC TEUoSU5ERVhFRF9EQVRBQkFTRV9JTl9XT1JLRVJTKQpAQCAtMTAyNCw3ICsxMDI4LDkgQEAgYm9v bCBJbnRlcm5hbFNldHRpbmdzOjp3ZWJBbmltYXRpb25zQ1NTSW50ZWdyYXRpb25FbmFibGVkKCkK IAogdm9pZCBJbnRlcm5hbFNldHRpbmdzOjpzZXRTaG91bGREZWFjdGl2YXRlQXVkaW9TZXNzaW9u KGJvb2wgc2hvdWxkKQogeworI2lmIEVOQUJMRShWSURFTykgfHwgRU5BQkxFKFdFQl9BVURJTykK ICAgICBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNldFNob3VsZERlYWN0aXZhdGVBdWRp b1Nlc3Npb24oc2hvdWxkKTsKKyNlbmRpZgogfQogCiAvLyBJZiB5b3UgYWRkIHRvIHRoaXMgY2xh c3MsIG1ha2Ugc3VyZSB0aGF0IHlvdSB1cGRhdGUgdGhlIEJhY2t1cCBjbGFzcyBmb3IgdGVzdCBy ZXByb2R1Y2FiaWxpdHkhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggYmE0 MzFjNzM1N2U3M2UzNzQxNTRkNGY5MmNlNmEzYzhiMzQ1MjllOS4uY2IwMjRjNTUwMDRkMzQ0YjIx NDk3ZGI1MzQ4NTA3NzEwY2U1ODJlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNw cApAQCAtNDg1LDcgKzQ4NSw5IEBAIHZvaWQgSW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0 YXRlKFBhZ2UmIHBhZ2UpCiAgICAgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRN YW5hZ2VyKCkucmVzZXRSZXN0cmljdGlvbnMoKTsKICAgICBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1h bmFnZXI6OnNoYXJlZE1hbmFnZXIoKS5zZXRXaWxsSWdub3JlU3lzdGVtSW50ZXJydXB0aW9ucyh0 cnVlKTsKICNlbmRpZgorI2lmIEVOQUJMRShWSURFTykgfHwgRU5BQkxFKFdFQl9BVURJTykKICAg ICBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXIoKS5zZXRJc1BsYXlp bmdUb0F1dG9tb3RpdmVIZWFkVW5pdChmYWxzZSk7CisjZW5kaWYKICNpZiBFTkFCTEUoQUNDRVNT SUJJTElUWSkKICAgICBBWE9iamVjdENhY2hlOjpzZXRFbmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nl c3NpYmlsaXR5KGZhbHNlKTsKICAgICBBWE9iamVjdENhY2hlOjpkaXNhYmxlQWNjZXNzaWJpbGl0 eSgpOwpAQCAtNTEwNCwxMiArNTEwNiwxNiBAQCB2b2lkIEludGVybmFsczo6c2V0QWx3YXlzQWxs b3dMb2NhbFdlYmFyY2hpdmUoYm9vbCBhbHdheXNBbGxvd0xvY2FsV2ViYXJjaGl2ZSkKIAogdm9p ZCBJbnRlcm5hbHM6OnByb2Nlc3NXaWxsU3VzcGVuZCgpCiB7CisjaWYgRU5BQkxFKFZJREVPKSB8 fCBFTkFCTEUoV0VCX0FVRElPKQogICAgIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hh cmVkTWFuYWdlcigpLnByb2Nlc3NXaWxsU3VzcGVuZCgpOworI2VuZGlmCiB9CiAKIHZvaWQgSW50 ZXJuYWxzOjpwcm9jZXNzRGlkUmVzdW1lKCkKIHsKKyNpZiBFTkFCTEUoVklERU8pIHx8IEVOQUJM RShXRUJfQVVESU8pCiAgICAgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5h Z2VyKCkucHJvY2Vzc0RpZFJlc3VtZSgpOworI2VuZGlmCiB9CiAKIHZvaWQgSW50ZXJuYWxzOjp0 ZXN0RGljdGlvbmFyeUxvZ2dpbmcoKQpAQCAtNTEzOSw3ICs1MTQ1LDkgQEAgdm9pZCBJbnRlcm5h bHM6OnNldFhIUk1heGltdW1JbnRlcnZhbEZvclVzZXJHZXN0dXJlRm9yd2FyZGluZyhYTUxIdHRw UmVxdWVzdCYgcmUKIAogdm9pZCBJbnRlcm5hbHM6OnNldElzUGxheWluZ1RvQXV0b21vdGl2ZUhl YWRVbml0KGJvb2wgaXNQbGF5aW5nKQogeworI2lmIEVOQUJMRShWSURFTykgfHwgRU5BQkxFKFdF Ql9BVURJTykKICAgICBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXIo KS5zZXRJc1BsYXlpbmdUb0F1dG9tb3RpdmVIZWFkVW5pdChpc1BsYXlpbmcpOworI2VuZGlmCiB9 CiAgICAgCiBJbnRlcm5hbHM6OlRleHRJbmRpY2F0b3JJbmZvOjpUZXh0SW5kaWNhdG9ySW5mbygp Cg==