<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>201503</bug_id>
          
          <creation_ts>2019-09-05 02:07:49 -0700</creation_ts>
          <short_desc>Build failure after r249501 for ports with SERVICE_WORKER set OFF</short_desc>
          <delta_ts>2019-09-05 07:22:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pablo Saavedra">psaavedra</reporter>
          <assigned_to name="Pablo Saavedra">psaavedra</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>hi</cc>
    
    <cc>joepeck</cc>
    
    <cc>koivisto</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1568071</commentid>
    <comment_count>0</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-09-05 02:07:49 -0700</bug_when>
    <thetext>Error:

../../Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:163:17: error: ‘ServiceWorkerFrameLoaderClient’ was not declared in this scope
     else if (is&lt;ServiceWorkerFrameLoaderClient&gt;(frameLoaderClient))</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568072</commentid>
    <comment_count>1</comment_count>
      <attachid>378065</attachid>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-09-05 02:09:23 -0700</bug_when>
    <thetext>Created attachment 378065
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568115</commentid>
    <comment_count>2</comment_count>
      <attachid>378065</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-05 07:21:37 -0700</bug_when>
    <thetext>Comment on attachment 378065
patch

Clearing flags on attachment: 378065

Committed r249528: &lt;https://trac.webkit.org/changeset/249528&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568116</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-05 07:21:39 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568117</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-05 07:22:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/55066477&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568118</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-05 07:22:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/55066479&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>378065</attachid>
            <date>2019-09-05 02:09:23 -0700</date>
            <delta_ts>2019-09-05 07:21:37 -0700</delta_ts>
            <desc>patch</desc>
            <filename>bug-201503-20190905110921.patch</filename>
            <type>text/plain</type>
            <size>1918</size>
            <attacher name="Pablo Saavedra">psaavedra</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlNjgzMjIxNjAxNzFiZjg3
NWRiNjYxZTQzZGQ2NzRiOGRmZTZjNmIuLjFiZGUxMjk1MjBkMWFlYzgwNTQwM2Q1MTY4Njk3MWRm
MjhjNTdjYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDktMDUgIFBhYmxvIFNh
YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgQnVpbGQgZmFpbHVyZSBh
ZnRlciByMjQ5NTAxIGZvciBwb3J0cyB3aXRoIFNFUlZJQ0VfV09SS0VSIHNldCBPRkYKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTUwMworCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9O
ZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVy
U3RyYXRlZ3k6OnNjaGVkdWxlTG9hZCk6CisKIDIwMTktMDktMDQgIFdlbnNvbiBIc2llaCAgPHdl
bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgTW9iaWxlU2FmYXJpIG1heSBjcmFzaCB3
aGVuIGludm9raW5nIHRoZSBDKysgbGFtYmRhIGluIC1bV0tDb250ZW50VmlldyBfc2hhcmVGb3JX
ZWJWaWV3Ol0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dl
YkxvYWRlclN0cmF0ZWd5LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dl
YkxvYWRlclN0cmF0ZWd5LmNwcAppbmRleCAwMzRhNjYzZGMwZDBlZDY0NWY4NWNkMDBmOWI5YmI0
NjExNmIxMzFiLi5iNTM5YmViNjc5NzRmNGZhMmFhMTBkN2Q5M2JlMzZlYjVkODU2ODllIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVn
eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3Ry
YXRlZ3kuY3BwCkBAIC0xNjAsOCArMTYwLDEwIEBAIHZvaWQgV2ViTG9hZGVyU3RyYXRlZ3k6OnNj
aGVkdWxlTG9hZChSZXNvdXJjZUxvYWRlciYgcmVzb3VyY2VMb2FkZXIsIENhY2hlZFJlc291CiAg
ICAgV2ViUmVzb3VyY2VMb2FkZXI6OlRyYWNraW5nUGFyYW1ldGVycyB0cmFja2luZ1BhcmFtZXRl
cnM7CiAgICAgaWYgKGF1dG8qIHdlYkZyYW1lTG9hZGVyQ2xpZW50ID0gdG9XZWJGcmFtZUxvYWRl
ckNsaWVudChmcmFtZUxvYWRlckNsaWVudCkpCiAgICAgICAgIHRyYWNraW5nUGFyYW1ldGVycy53
ZWJQYWdlUHJveHlJRCA9IHdlYkZyYW1lTG9hZGVyQ2xpZW50LT53ZWJQYWdlUHJveHlJRCgpLnZh
bHVlT3IoV2ViUGFnZVByb3h5SWRlbnRpZmllciB7IH0pOworI2lmIEVOQUJMRShTRVJWSUNFX1dP
UktFUikKICAgICBlbHNlIGlmIChpczxTZXJ2aWNlV29ya2VyRnJhbWVMb2FkZXJDbGllbnQ+KGZy
YW1lTG9hZGVyQ2xpZW50KSkKICAgICAgICAgdHJhY2tpbmdQYXJhbWV0ZXJzLndlYlBhZ2VQcm94
eUlEID0gZG93bmNhc3Q8U2VydmljZVdvcmtlckZyYW1lTG9hZGVyQ2xpZW50PihmcmFtZUxvYWRl
ckNsaWVudCkud2ViUGFnZVByb3h5SUQoKTsKKyNlbmRpZgogICAgIHRyYWNraW5nUGFyYW1ldGVy
cy5wYWdlSUQgPSBmcmFtZUxvYWRlckNsaWVudC5wYWdlSUQoKS52YWx1ZU9yKFBhZ2VJZGVudGlm
aWVyIHsgfSk7CiAgICAgdHJhY2tpbmdQYXJhbWV0ZXJzLmZyYW1lSUQgPSBmcmFtZUxvYWRlckNs
aWVudC5mcmFtZUlEKCkudmFsdWVPcihGcmFtZUlkZW50aWZpZXIgeyB9KTsKICAgICB0cmFja2lu
Z1BhcmFtZXRlcnMucmVzb3VyY2VJRCA9IGlkZW50aWZpZXI7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>