201495 2019-09-04 23:56:19 -0700 [JSC] Do not use FTLOutput::weakPointer directly 2019-09-05 16:21:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1568027 0 ysuzuki 2019-09-04 23:56:19 -0700 [JSC] Do not use FTLOutput::weakPointer directly 1568029 1 378051 ysuzuki 2019-09-05 00:00:23 -0700 Created attachment 378051 Patch 1568030 2 378051 ysuzuki 2019-09-05 00:01:21 -0700 Comment on attachment 378051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378051&action=review > Source/JavaScriptCore/ChangeLog:12 > + For FrozenValue, we should use frozenPointer helper function. Note that DFG implementation of CreatePromise/NewPromise are using DFGSpeculativeJIT::TrustedImmPtr::weakPointer correctly. And I checked NewPromise and it was OK. 1568031 3 ysuzuki 2019-09-05 00:02:15 -0700 <rdar://problem/55055463> 1568035 4 ysuzuki 2019-09-05 00:09:40 -0700 Ensures this patch fixes the debug assertion in jsc-stress-tests. https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/3589 1568122 5 378051 fpizlo 2019-09-05 08:08:15 -0700 Comment on attachment 378051 Patch Can you do a follow-up that renames FTL::Output::weakPointer so that folks don't make the same mistake? Maybe Output::alreadyRegisteredWeakPointer or something that makes it clear what the assumptions are. 1568132 6 378051 commit-queue 2019-09-05 08:51:53 -0700 Comment on attachment 378051 Patch Clearing flags on attachment: 378051 Committed r249530: <https://trac.webkit.org/changeset/249530> 1568133 7 commit-queue 2019-09-05 08:51:54 -0700 All reviewed patches have been landed. Closing bug. 1568182 8 ysuzuki 2019-09-05 11:14:44 -0700 (In reply to Filip Pizlo from comment #5) > Comment on attachment 378051 [details] > Patch > > Can you do a follow-up that renames FTL::Output::weakPointer so that folks > don't make the same mistake? Maybe Output::alreadyRegisteredWeakPointer or > something that makes it clear what the assumptions are. Sounds nice! I'll change this. 1568308 9 ysuzuki 2019-09-05 16:21:27 -0700 Committed r249552: <https://trac.webkit.org/changeset/249552> 378051 2019-09-05 00:00:23 -0700 2019-09-05 08:51:53 -0700 Patch bug-201495-20190905000022.patch text/plain 4526 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MjMxNjQyZjY2M2ZjMzViZTdiZWQzMmYzOWFlODRkMzk1NGRkOTJhLi43ZWY2NDcxY2ZhYjNhMmI3 MGFmNzgzOTAzZWMyOTg0N2VmMTRkNTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wOS0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERvIG5vdCB1c2UgRlRMT3V0cHV0Ojp3ZWFrUG9pbnRlciBkaXJl Y3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAx NDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRlRM T3V0cHV0Ojp3ZWFrUG9pbnRlciBkb2VzIG5vdCByZWdpc3RlciB0aGUgY2VsbCBhcyBhIHdlYWsg cG9pbnRlci4KKyAgICAgICAgQ3JlYXRlUHJvbWlzZSdzIGltcGxlbWVudGF0aW9uIGlzIGFjY2lk ZW50YWxseSB1c2luZyBtX291dC53ZWFrUG9pbnRlciBhbmQgaGl0cyB0aGUgZGVidWcgYXNzZXJ0 aW9uLgorICAgICAgICBXaGlsZSB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBpcyBub3QgcG9z aW5nIGNvcnJlY3RuZXNzIGlzc3VlIHNpbmNlIHRoZXNlIGNlbGxzIGFyZSBsaXZlIHNvIGxvbmcg YXMgSlNHbG9iYWxPYmplY3QgaXMgbGl2ZSwKKyAgICAgICAgYW5kIHdlIHJlZ2lzdGVyIEpTR2xv YmFsT2JqZWN0IGFzIGEgd2Vha1BvaW50ZXIsIHdlIHNob3VsZCBhbHdheXMgdXNlIEZUTExvd2Vy REZHVG9CMydzIGhlbHBlciBmdW5jdGlvbi4KKyAgICAgICAgRm9yIEZyb3plblZhbHVlLCB3ZSBz aG91bGQgdXNlIGZyb3plblBvaW50ZXIgaGVscGVyIGZ1bmN0aW9uLgorCisgICAgICAgICogZnRs L0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1Rv QjM6OmNvbXBpbGVDcmVhdGVQcm9taXNlKToKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2Vy REZHVG9CMzo6Y29tcGlsZU5ld0FycmF5QnVmZmVyKToKKwogMjAxOS0wOS0wNCAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHBhcnRpYWwg cm9sbCBvdXQgcjI0OTM3MiBkdWUgdG8gSmV0U3RyZWFtMi9CYXNpYyB+MTAlIHJlZ3Jlc3Npb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAppbmRleCBh YmU2NTE4NTUyNmYyNDNmYTcxZjNjMjNhNmVhMGRlNGJkN2U4ZTdhLi42NzU2ODYzOGFkY2U5MzE0 ZmZmZWZhNWVlYWY3ZGM5YjM3NDA5YjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExMb3dlckRGR1RvQjMuY3BwCkBAIC02MzAwLDcgKzYzMDAsNyBAQCBjbGFzcyBMb3dlckRG R1RvQjMgewogICAgICAgICBMQmFzaWNCbG9jayBjb250aW51YXRpb24gPSBtX291dC5uZXdCbG9j aygpOwogCiAgICAgICAgIFZhbHVlRnJvbUJsb2NrIHByb21pc2VTdHJ1Y3R1cmUgPSBtX291dC5h bmNob3Iod2Vha1N0cnVjdHVyZShtX2dyYXBoLnJlZ2lzdGVyU3RydWN0dXJlKG1fbm9kZS0+aXNJ bnRlcm5hbFByb21pc2UoKSA/IGdsb2JhbE9iamVjdC0+aW50ZXJuYWxQcm9taXNlU3RydWN0dXJl KCkgOiBnbG9iYWxPYmplY3QtPnByb21pc2VTdHJ1Y3R1cmUoKSkpKTsKLSAgICAgICAgbV9vdXQu YnJhbmNoKG1fb3V0LmVxdWFsKGNhbGxlZSwgbV9vdXQud2Vha1BvaW50ZXIobV9ncmFwaCwgbV9u b2RlLT5pc0ludGVybmFsUHJvbWlzZSgpID8gZ2xvYmFsT2JqZWN0LT5pbnRlcm5hbFByb21pc2VD b25zdHJ1Y3RvcigpIDogZ2xvYmFsT2JqZWN0LT5wcm9taXNlQ29uc3RydWN0b3IoKSkpLCB1bnN1 cmUoZmFzdEFsbG9jYXRpb25DYXNlKSwgdW5zdXJlKGRlcml2ZWRDYXNlKSk7CisgICAgICAgIG1f b3V0LmJyYW5jaChtX291dC5lcXVhbChjYWxsZWUsIHdlYWtQb2ludGVyKG1fbm9kZS0+aXNJbnRl cm5hbFByb21pc2UoKSA/IGdsb2JhbE9iamVjdC0+aW50ZXJuYWxQcm9taXNlQ29uc3RydWN0b3Io KSA6IGdsb2JhbE9iamVjdC0+cHJvbWlzZUNvbnN0cnVjdG9yKCkpKSwgdW5zdXJlKGZhc3RBbGxv Y2F0aW9uQ2FzZSksIHVuc3VyZShkZXJpdmVkQ2FzZSkpOwogCiAgICAgICAgIExCYXNpY0Jsb2Nr IGxhc3ROZXh0ID0gbV9vdXQuYXBwZW5kVG8oZGVyaXZlZENhc2UsIGlzRnVuY3Rpb25CbG9jayk7 CiAgICAgICAgIG1fb3V0LmJyYW5jaChpc0Z1bmN0aW9uKGNhbGxlZSwgcHJvdmVuVHlwZShtX25v ZGUtPmNoaWxkMSgpKSksIHVzdWFsbHkoaXNGdW5jdGlvbkJsb2NrKSwgcmFyZWx5KHNsb3dDYXNl KSk7CkBAIC02NTMwLDcgKzY1MzAsNyBAQCBjbGFzcyBMb3dlckRGR1RvQjMgewogICAgICAgICAg ICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOwogCiAgICAgICAgICAgICBtX291dC5hcHBlbmRU byhzbG93UGF0aCwgY29udGludWF0aW9uKTsKLSAgICAgICAgICAgIExWYWx1ZSBzbG93QXJyYXkg PSB2bUNhbGwoSW50NjQsIG1fb3V0Lm9wZXJhdGlvbihvcGVyYXRpb25OZXdBcnJheUJ1ZmZlciks IG1fY2FsbEZyYW1lLCB3ZWFrU3RydWN0dXJlKHN0cnVjdHVyZSksIG1fb3V0LndlYWtQb2ludGVy KG1fbm9kZS0+Y2VsbE9wZXJhbmQoKSkpOworICAgICAgICAgICAgTFZhbHVlIHNsb3dBcnJheSA9 IHZtQ2FsbChJbnQ2NCwgbV9vdXQub3BlcmF0aW9uKG9wZXJhdGlvbk5ld0FycmF5QnVmZmVyKSwg bV9jYWxsRnJhbWUsIHdlYWtTdHJ1Y3R1cmUoc3RydWN0dXJlKSwgZnJvemVuUG9pbnRlcihtX25v ZGUtPmNlbGxPcGVyYW5kKCkpKTsKICAgICAgICAgICAgIFZhbHVlRnJvbUJsb2NrIHNsb3dSZXN1 bHQgPSBtX291dC5hbmNob3Ioc2xvd0FycmF5KTsKICAgICAgICAgICAgIG1fb3V0Lmp1bXAoY29u dGludWF0aW9uKTsKIApAQCAtNjU0Myw3ICs2NTQzLDcgQEAgY2xhc3MgTG93ZXJERkdUb0IzIHsK ICAgICAgICAgCiAgICAgICAgIHNldEpTVmFsdWUodm1DYWxsKAogICAgICAgICAgICAgSW50NjQs IG1fb3V0Lm9wZXJhdGlvbihvcGVyYXRpb25OZXdBcnJheUJ1ZmZlciksIG1fY2FsbEZyYW1lLAot ICAgICAgICAgICAgd2Vha1N0cnVjdHVyZShzdHJ1Y3R1cmUpLCBtX291dC53ZWFrUG9pbnRlciht X25vZGUtPmNlbGxPcGVyYW5kKCkpKSk7CisgICAgICAgICAgICB3ZWFrU3RydWN0dXJlKHN0cnVj dHVyZSksIGZyb3plblBvaW50ZXIobV9ub2RlLT5jZWxsT3BlcmFuZCgpKSkpOwogICAgIH0KIAog ICAgIHZvaWQgY29tcGlsZU5ld0FycmF5V2l0aFNpemUoKQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9D aGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCAzNzQ2YTM4MTFiNDM0YzM0OWEyYTQ2 ZGRjYjU4ZmNiZmI1MGZjYTk4Li5jYTFhN2JiYjE3OWVjMjdmYjMwNzY0YzhhZTk4ZWMwNzRlOWU3 NDM2IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA5LTA0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBh cHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gRG8gbm90IHVzZSBGVExPdXRwdXQ6OndlYWtQb2lu dGVyIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDE0OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHN0cmVzcy9jcmVhdGUtcHJvbWlzZS13ZWFrLXBvaW50ZXIuanM6IEFkZGVkLgorICAg ICAgICAoZm9vKToKKwogMjAxOS0wOS0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUu Y29tPgogCiAgICAgICAgIFtKU0NdIE1ha2UgUHJvbWlzZSBpbXBsZW1lbnRhdGlvbiBmYXN0ZXIK ZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2NyZWF0ZS1wcm9taXNlLXdlYWstcG9pbnRlci5q cyBiL0pTVGVzdHMvc3RyZXNzL2NyZWF0ZS1wcm9taXNlLXdlYWstcG9pbnRlci5qcwpuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4yOWQ5YjhjNGMxYWE4OWNkZTFmMzJkNjkyZTNiNGQ4MWJmYzQwMzM0Ci0tLSAvZGV2L251 bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvY3JlYXRlLXByb21pc2Utd2Vhay1wb2ludGVyLmpzCkBA IC0wLDAgKzEsNyBAQAorY29uc3QgeCA9IG5ldyBQcm94eShQcm9taXNlLCB7fSk7CitmdW5jdGlv biBmb28oKSB7CisgICAgbmV3IHgoKCk9Pnt9KTsKK30KK2ZvciAobGV0IGk9MDsgaTwxMDAwMDA7 IGkrKykgeworICAgIGZvbygpOworfQo=