201486 2019-09-04 19:32:45 -0700 [GTK][WPE] Do not enable the sandbox in Snap 2019-09-14 03:41:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 201793 1 pgriffis pgriffis bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1567959 0 pgriffis 2019-09-04 19:32:45 -0700 [GTK][WPE] Do not enable the sandbox in Snap 1567961 1 378039 pgriffis 2019-09-04 19:34:51 -0700 Created attachment 378039 Patch 1568061 2 378039 cgarcia 2019-09-05 01:32:59 -0700 Comment on attachment 378039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378039&action=review > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:65 > + static int ret = -1; Use Optional<bool> instead. > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:69 > + ret = g_getenv("SNAP") != nullptr; Do not compare to nullptr. 1568107 3 378039 mcatanzaro 2019-09-05 05:35:27 -0700 Comment on attachment 378039 Patch And now we have a secret little envvar we can use to disable the sandbox for testing, that nobody else will likely be tempted to use. Cool. 1568228 4 378111 pgriffis 2019-09-05 13:29:39 -0700 Created attachment 378111 Patch 1568229 5 pgriffis 2019-09-05 13:30:42 -0700 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 378039 [details] > Patch > > And now we have a secret little envvar we can use to disable the sandbox for > testing, that nobody else will likely be tempted to use. Cool. WEBKIT_FORCE_SANDBOX=0 was already a thing. 1568426 6 cgarcia 2019-09-06 01:15:31 -0700 (In reply to Patrick Griffis from comment #5) > (In reply to Michael Catanzaro from comment #3) > > Comment on attachment 378039 [details] > > Patch > > > > And now we have a secret little envvar we can use to disable the sandbox for > > testing, that nobody else will likely be tempted to use. Cool. > > WEBKIT_FORCE_SANDBOX=0 was already a thing. I'm not sure that's checked at the right place, though. WebProcesdsPool::sandboxEnabled() will still return true. 1568451 7 378111 commit-queue 2019-09-06 02:00:11 -0700 Comment on attachment 378111 Patch Clearing flags on attachment: 378111 Committed r249569: <https://trac.webkit.org/changeset/249569> 1568452 8 commit-queue 2019-09-06 02:00:12 -0700 All reviewed patches have been landed. Closing bug. 378039 2019-09-04 19:34:51 -0700 2019-09-05 13:29:38 -0700 Patch bug-201486-20190904193450.patch text/plain 2041 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5Mzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBlNjg3YTk5ZWU3MTE5MWQx Y2VlMmY1NzFiNjk3NWRhZWUxMGU2NzIuLjZlZWNlMzdlYTQxYTFjMTE5NWJlYTA0MzcxYzE5YTcw MWYyYzJmOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDktMDQgIFBhdHJpY2sg R3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBEbyBu b3QgZW5hYmxlIHRoZSBzYW5kYm94IGluIFNuYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJ1bm5pbmcgaW5zaWRlIG9mIFNuYXAgYWRkcyBpdHMgb3du IGNvbXBsaWNhdGlvbnMgYW5kIGlzIHNpbXBseQorICAgICAgICBub3Qgc3VwcG9ydGVkIGZvciBu b3cuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9Qcm9jZXNzTGF1bmNoZXJH TGliLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aXNJbnNpZGVTbmFwKToKKyAgICAgICAgKFdlYktp dDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKToKKwogMjAxOS0wOS0wNCAgUGF0cmlj ayBHcmlmZmlzICA8cGdyaWZmaXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIEZp eCBzYW5kYm94IHBhcnNpbmcgRElTUExBWSBvbiBYMTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL1Byb2Nlc3NMYXVuY2hlckdMaWIuY3Bw CmluZGV4IDA4NDE3MDM3NWY5NWQ1ZGM4MGVkNGY5NzY4Y2ViNTRkYzc5NmIwZTYuLmZhMTM2MzQ0 Nzc0YTc3MjVkZDg4NTE3NTE2MGVlNGFmYzYyNDNjNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGli LmNwcApAQCAtNTksNiArNTksMTYgQEAgc3RhdGljIGJvb2wgaXNJbnNpZGVGbGF0cGFrKCkKICAg ICByZXQgPSBnX2ZpbGVfdGVzdCgiLy5mbGF0cGFrLWluZm8iLCBHX0ZJTEVfVEVTVF9FWElTVFMp OwogICAgIHJldHVybiByZXQ7CiB9CisKK3N0YXRpYyBib29sIGlzSW5zaWRlU25hcCgpCit7Cisg ICAgc3RhdGljIGludCByZXQgPSAtMTsKKyAgICBpZiAocmV0ICE9IC0xKQorICAgICAgICByZXR1 cm4gcmV0OworCisgICAgcmV0ID0gZ19nZXRlbnYoIlNOQVAiKSAhPSBudWxscHRyOworICAgIHJl dHVybiByZXQ7Cit9CiAjZW5kaWYKIAogdm9pZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nl c3MoKQpAQCAtMTM3LDcgKzE0Nyw4IEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9j ZXNzKCkKICAgICAgICAgc2FuZGJveEVuYWJsZWQgPSAhc3RyY21wKHNhbmRib3hFbnYsICIxIik7 CiAKICAgICAvLyBZb3UgY2Fubm90IHVzZSBidWJibGV3cmFwIHdpdGhpbiBGbGF0cGFrIHNvIGxl dHMgZW5zdXJlIGl0IG5ldmVyIGhhcHBlbnMuCi0gICAgaWYgKHNhbmRib3hFbmFibGVkICYmICFp c0luc2lkZUZsYXRwYWsoKSkKKyAgICAvLyBTbmFwIGNhbiBhbGxvdyBpdCBidXQgaGFzIGl0cyBv d24gbGltaXRhdGlvbnMgdGhhdCByZXF1aXJlIHdvcmthcm91bmRzLgorICAgIGlmIChzYW5kYm94 RW5hYmxlZCAmJiAhaXNJbnNpZGVGbGF0cGFrKCkgJiYgIWlzSW5zaWRlU25hcCgpKQogICAgICAg ICBwcm9jZXNzID0gYnViYmxld3JhcFNwYXduKGxhdW5jaGVyLmdldCgpLCBtX2xhdW5jaE9wdGlv bnMsIGFyZ3YsICZlcnJvci5vdXRQdHIoKSk7CiAgICAgZWxzZQogI2VuZGlmCg== 378111 2019-09-05 13:29:39 -0700 2019-09-06 02:00:11 -0700 Patch bug-201486-20190905132938.patch text/plain 2329 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5Mzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBlNjg3YTk5ZWU3MTE5MWQx Y2VlMmY1NzFiNjk3NWRhZWUxMGU2NzIuLjU1ZmM3NzkyNTA1M2YxYTViYzM5NTk2MWJmYTBmZTcz ZTE4ZDViMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDktMDQgIFBhdHJpY2sg R3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBEbyBu b3QgZW5hYmxlIHRoZSBzYW5kYm94IGluIFNuYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJ1bm5pbmcgaW5zaWRlIG9mIFNuYXAgYWRkcyBpdHMgb3du IGNvbXBsaWNhdGlvbnMgYW5kIGlzIHNpbXBseQorICAgICAgICBub3Qgc3VwcG9ydGVkIGZvciBu b3cuCisKKyAgICAgICAgQWxzbyB1cGRhdGUgaXNJbnNpZGVGbGF0cGFrKCkgZm9yIGNvbnNpc3Rl bmN5LgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVy R0xpYi5jcHA6CisgICAgICAgIChXZWJLaXQ6OmlzSW5zaWRlRmxhdHBhayk6CisgICAgICAgIChX ZWJLaXQ6OmlzSW5zaWRlU25hcCk6CisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6 bGF1bmNoUHJvY2Vzcyk6CisKIDIwMTktMDktMDQgIFBhdHJpY2sgR3JpZmZpcyAgPHBncmlmZmlz QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV1bR1RLXSBGaXggc2FuZGJveCBwYXJzaW5nIERJ U1BMQVkgb24gWDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hl ci9nbGliL1Byb2Nlc3NMYXVuY2hlckdMaWIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv TGF1bmNoZXIvZ2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcAppbmRleCAwODQxNzAzNzVmOTVk NWRjODBlZDRmOTc2OGNlYjU0ZGM3OTZiMGU2Li44ZGUxYjIxYmZlYjI4MDNkY2ZjMGY0YmIyOTNl YTc4M2FkOGQwN2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hl ci9nbGliL1Byb2Nlc3NMYXVuY2hlckdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0xhdW5jaGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHAKQEAgLTUyLDEyICs1Miwy MiBAQCBzdGF0aWMgdm9pZCBjaGlsZFNldHVwRnVuY3Rpb24oZ3BvaW50ZXIgdXNlckRhdGEpCiAj aWYgRU5BQkxFKEJVQkJMRVdSQVBfU0FOREJPWCkKIHN0YXRpYyBib29sIGlzSW5zaWRlRmxhdHBh aygpCiB7Ci0gICAgc3RhdGljIGludCByZXQgPSAtMTsKLSAgICBpZiAocmV0ICE9IC0xKQotICAg ICAgICByZXR1cm4gcmV0OworICAgIHN0YXRpYyBPcHRpb25hbDxib29sPiByZXQ7CisgICAgaWYg KHJldCkKKyAgICAgICAgcmV0dXJuICpyZXQ7CiAKICAgICByZXQgPSBnX2ZpbGVfdGVzdCgiLy5m bGF0cGFrLWluZm8iLCBHX0ZJTEVfVEVTVF9FWElTVFMpOwotICAgIHJldHVybiByZXQ7CisgICAg cmV0dXJuICpyZXQ7Cit9CisKK3N0YXRpYyBib29sIGlzSW5zaWRlU25hcCgpCit7CisgICAgc3Rh dGljIE9wdGlvbmFsPGJvb2w+IHJldDsKKyAgICBpZiAocmV0KQorICAgICAgICByZXR1cm4gKnJl dDsKKworICAgIHJldCA9IGdfZ2V0ZW52KCJTTkFQIik7CisgICAgcmV0dXJuICpyZXQ7CiB9CiAj ZW5kaWYKIApAQCAtMTM3LDcgKzE0Nyw4IEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQ cm9jZXNzKCkKICAgICAgICAgc2FuZGJveEVuYWJsZWQgPSAhc3RyY21wKHNhbmRib3hFbnYsICIx Iik7CiAKICAgICAvLyBZb3UgY2Fubm90IHVzZSBidWJibGV3cmFwIHdpdGhpbiBGbGF0cGFrIHNv IGxldHMgZW5zdXJlIGl0IG5ldmVyIGhhcHBlbnMuCi0gICAgaWYgKHNhbmRib3hFbmFibGVkICYm ICFpc0luc2lkZUZsYXRwYWsoKSkKKyAgICAvLyBTbmFwIGNhbiBhbGxvdyBpdCBidXQgaGFzIGl0 cyBvd24gbGltaXRhdGlvbnMgdGhhdCByZXF1aXJlIHdvcmthcm91bmRzLgorICAgIGlmIChzYW5k Ym94RW5hYmxlZCAmJiAhaXNJbnNpZGVGbGF0cGFrKCkgJiYgIWlzSW5zaWRlU25hcCgpKQogICAg ICAgICBwcm9jZXNzID0gYnViYmxld3JhcFNwYXduKGxhdW5jaGVyLmdldCgpLCBtX2xhdW5jaE9w dGlvbnMsIGFyZ3YsICZlcnJvci5vdXRQdHIoKSk7CiAgICAgZWxzZQogI2VuZGlmCg==