201485 2019-09-04 19:11:15 -0700 [JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen 2019-09-04 19:52:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1567944 0 ysuzuki 2019-09-04 19:11:15 -0700 [JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen 1567951 1 378036 ysuzuki 2019-09-04 19:17:12 -0700 Created attachment 378036 Patch 1567952 2 webkit-bug-importer 2019-09-04 19:17:43 -0700 <rdar://problem/55050943> 1567953 3 ysuzuki 2019-09-04 19:18:07 -0700 This is the cause of occasional crashes in testapi. e.g. https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/16693/steps/webkit-jsc-cloop-test/logs/stdio 1567955 4 378036 tzagallo 2019-09-04 19:27:25 -0700 Comment on attachment 378036 Patch r=me 1567971 5 ysuzuki 2019-09-04 19:52:54 -0700 Committed r249518: <https://trac.webkit.org/changeset/249518> 378036 2019-09-04 19:17:12 -0700 2019-09-04 19:27:25 -0700 Patch bug-201485-20190904191711.patch text/plain 4726 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YzYxNmZiYjQ1ZjcwODc2NzczYTllMjUwMzU0ZjQ4MjBiMWVhZmMzLi4yMDgwOTRmOGU0NDEyNDk1 MzY2OWZiZTAyMmRmZGQ4NGQyM2E1ZGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxOS0wOS0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEZ1bmN0aW9uT3ZlcnJpZGVzIHNob3VsZCBoYXZlIGEgbG9jayB0 byBlbnN1cmUgY29uY3VycmVudCBhY2Nlc3MgdG8gaGFzaCB0YWJsZSBkb2VzIG5vdCBoYXBwZW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTQ4NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZ1bmN0aW9u T3ZlcnJpZGVzIGlzIGEgcGVyLXByb2Nlc3Mgc2luZ2xldG9uIGZvciByZWdpc3RlcmluZyBvdmVy cmlkZXMgaW5mb3JtYXRpb24uIEJ1dCB3ZSBhcmUgYWNjZXNzaW5nCisgICAgICAgIGl0IHdpdGhv dXQgdGFraW5nIGEgbG9jay4gSWYgbXVsdGlwbGUgdGhyZWFkcyB3aXRoIG11bHRpcGxlIFZNcyBh cmUgYWNjZXNzaW5nIHRoaXMgY29uY3VycmVudGx5LCB3ZSBoYXZlCisgICAgICAgIGEgcmFjZSBp c3N1ZSBsaWtlLAorCisgICAgICAgIDEuIFdoaWxlIG9uZSB0aHJlYWQgaXMgYWRkaW5nIG92ZXJy aWRlcyBpbmZvcm1hdGlvbiwKKyAgICAgICAgMi4gQW5vdGhlciB0aHJlYWQgaXMgYWNjZXNzaW5n IHRoaXMgaGFzaCB0YWJsZS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBsb2NrIHRvIG1h a2Ugc3VyZSB0aGF0IG9ubHkgb25lIHRocmVhZCBjYW4gYWNjZXNzIHRoaXMgcmVnaXN0cnkuCisK KyAgICAgICAgKiB0b29scy9GdW5jdGlvbk92ZXJyaWRlcy5jcHA6CisgICAgICAgIChKU0M6OkZ1 bmN0aW9uT3ZlcnJpZGVzOjpGdW5jdGlvbk92ZXJyaWRlcyk6CisgICAgICAgIChKU0M6OkZ1bmN0 aW9uT3ZlcnJpZGVzOjpyZWluc3RhbGxPdmVycmlkZXMpOgorICAgICAgICAoSlNDOjpGdW5jdGlv bk92ZXJyaWRlczo6aW5pdGlhbGl6ZU92ZXJyaWRlRm9yKToKKyAgICAgICAgKEpTQzo6RnVuY3Rp b25PdmVycmlkZXM6OnBhcnNlT3ZlcnJpZGVzSW5GaWxlKToKKyAgICAgICAgKiB0b29scy9GdW5j dGlvbk92ZXJyaWRlcy5oOgorICAgICAgICAoSlNDOjpGdW5jdGlvbk92ZXJyaWRlczo6Y2xlYXIp OgorCiAyMDE5LTA5LTA0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAg ICAgICAgW0pTQ10gTWFrZSBQcm9taXNlIGltcGxlbWVudGF0aW9uIGZhc3RlcgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0Z1bmN0aW9uT3ZlcnJpZGVzLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9GdW5jdGlvbk92ZXJyaWRlcy5jcHAKaW5kZXggYzEx NTRmNTdkZmVmNzYzNjRlMDM0YmFkNDQyMTNlODhlOWFmZmVmZS4uZmZmYTRhMWJjMDY3MjhkODQy OTNjMzAyMTQ3YWNmMmYzM2NhYmQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rvb2xzL0Z1bmN0aW9uT3ZlcnJpZGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv dG9vbHMvRnVuY3Rpb25PdmVycmlkZXMuY3BwCkBAIC0xMDIsMTUgKzEwMiwxNiBAQCBGdW5jdGlv bk92ZXJyaWRlcyYgRnVuY3Rpb25PdmVycmlkZXM6Om92ZXJyaWRlcygpCiAgICAgCiBGdW5jdGlv bk92ZXJyaWRlczo6RnVuY3Rpb25PdmVycmlkZXMoY29uc3QgY2hhciogb3ZlcnJpZGVzRmlsZU5h bWUpCiB7Ci0gICAgcGFyc2VPdmVycmlkZXNJbkZpbGUob3ZlcnJpZGVzRmlsZU5hbWUpOworICAg IHBhcnNlT3ZlcnJpZGVzSW5GaWxlKGhvbGRMb2NrKG1fbG9jayksIG92ZXJyaWRlc0ZpbGVOYW1l KTsKIH0KIAogdm9pZCBGdW5jdGlvbk92ZXJyaWRlczo6cmVpbnN0YWxsT3ZlcnJpZGVzKCkKIHsK ICAgICBGdW5jdGlvbk92ZXJyaWRlcyYgb3ZlcnJpZGVzID0gRnVuY3Rpb25PdmVycmlkZXM6Om92 ZXJyaWRlcygpOworICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sob3ZlcnJpZGVzLm1fbG9jayk7 CiAgICAgY29uc3QgY2hhciogb3ZlcnJpZGVzRmlsZU5hbWUgPSBPcHRpb25zOjpmdW5jdGlvbk92 ZXJyaWRlcygpOwotICAgIG92ZXJyaWRlcy5jbGVhcigpOwotICAgIG92ZXJyaWRlcy5wYXJzZU92 ZXJyaWRlc0luRmlsZShvdmVycmlkZXNGaWxlTmFtZSk7CisgICAgb3ZlcnJpZGVzLmNsZWFyKGxv Y2tlcik7CisgICAgb3ZlcnJpZGVzLnBhcnNlT3ZlcnJpZGVzSW5GaWxlKGxvY2tlciwgb3ZlcnJp ZGVzRmlsZU5hbWUpOwogfQogCiBzdGF0aWMgdm9pZCBpbml0aWFsaXplT3ZlcnJpZGVJbmZvKGNv bnN0IFNvdXJjZUNvZGUmIG9yaWdDb2RlLCBjb25zdCBTdHJpbmcmIG5ld0JvZHksIEZ1bmN0aW9u T3ZlcnJpZGVzOjpPdmVycmlkZUluZm8mIGluZm8pCkBAIC0xNTEsMTEgKzE1MiwxNiBAQCBib29s IEZ1bmN0aW9uT3ZlcnJpZGVzOjppbml0aWFsaXplT3ZlcnJpZGVGb3IoY29uc3QgU291cmNlQ29k ZSYgb3JpZ0NvZGUsIEZ1bmN0aQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgU3RyaW5nIHNv dXJjZUJvZHlTdHJpbmcgPSBzb3VyY2VTdHJpbmcuc3Vic3RyaW5nKHNvdXJjZUJvZHlTdGFydCk7 CiAKLSAgICBhdXRvIGl0ID0gb3ZlcnJpZGVzLm1fZW50cmllcy5maW5kKHNvdXJjZUJvZHlTdHJp bmcpOwotICAgIGlmIChpdCA9PSBvdmVycmlkZXMubV9lbnRyaWVzLmVuZCgpKQotICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgU3RyaW5nIG5ld0JvZHk7CisgICAgeworICAgICAgICBhdXRvIGxv Y2tlciA9IGhvbGRMb2NrKG92ZXJyaWRlcy5tX2xvY2spOworICAgICAgICBhdXRvIGl0ID0gb3Zl cnJpZGVzLm1fZW50cmllcy5maW5kKHNvdXJjZUJvZHlTdHJpbmcuaXNvbGF0ZWRDb3B5KCkpOwor ICAgICAgICBpZiAoaXQgPT0gb3ZlcnJpZGVzLm1fZW50cmllcy5lbmQoKSkKKyAgICAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICAgICAgbmV3Qm9keSA9IGl0LT52YWx1ZS5pc29sYXRlZENvcHko KTsKKyAgICB9CiAKLSAgICBpbml0aWFsaXplT3ZlcnJpZGVJbmZvKG9yaWdDb2RlLCBpdC0+dmFs dWUsIHJlc3VsdCk7CisgICAgaW5pdGlhbGl6ZU92ZXJyaWRlSW5mbyhvcmlnQ29kZSwgbmV3Qm9k eSwgcmVzdWx0KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMjI3LDcgKzIzMyw3IEBAIHN0 YXRpYyBTdHJpbmcgcGFyc2VDbGF1c2UoY29uc3QgY2hhcioga2V5d29yZCwgc2l6ZV90IGtleXdv cmRMZW5ndGgsIEZJTEUqIGZpbGUsCiAgICAgRkFJTF9XSVRIX0VSUk9SKFNZTlRBWF9FUlJPUiwg KCInIiwga2V5d29yZCwgIicgY2xhdXNlIGVuZCBkZWxpbWl0ZXIgJyIsIGRlbGltaXRlciwgIicg bm90IGZvdW5kOlxuIiwgYnVpbGRlci50b1N0cmluZygpLCAiXG4iLCAiQXJlIHlvdSBtaXNzaW5n IGEgJ30nIGJlZm9yZSB0aGUgZGVsaW1pdGVyP1xuIikpOwogfQogCi12b2lkIEZ1bmN0aW9uT3Zl cnJpZGVzOjpwYXJzZU92ZXJyaWRlc0luRmlsZShjb25zdCBjaGFyKiBmaWxlTmFtZSkKK3ZvaWQg RnVuY3Rpb25PdmVycmlkZXM6OnBhcnNlT3ZlcnJpZGVzSW5GaWxlKGNvbnN0IEFic3RyYWN0TG9j a2VyJiwgY29uc3QgY2hhciogZmlsZU5hbWUpCiB7CiAgICAgaWYgKCFmaWxlTmFtZSkKICAgICAg ICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0Z1bmN0 aW9uT3ZlcnJpZGVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvRnVuY3Rpb25PdmVy cmlkZXMuaAppbmRleCA0YTQyYmJjMWYyNWE5ZDAxZGRmYjJkODlhZDIxY2ZjMGFiMjY4ODYxLi44 ODI5NjcwMDczZGRmOWQ2ZDQ5Y2VlZjIwOGI2MzhjNzEzZjRlZDY5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvRnVuY3Rpb25PdmVycmlkZXMuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvdG9vbHMvRnVuY3Rpb25PdmVycmlkZXMuaApAQCAtMjcsNiArMjcsNyBA QAogCiAjaW5jbHVkZSAiU291cmNlQ29kZS5oIgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+Cisj aW5jbHVkZSA8d3RmL0xvY2suaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAog bmFtZXNwYWNlIEpTQyB7CkBAIC01NiwxMCArNTcsMTEgQEAgY2xhc3MgRnVuY3Rpb25PdmVycmlk ZXMgewogICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyB2b2lkIHJlaW5zdGFsbE92ZXJyaWRl cygpOwogCiBwcml2YXRlOgotICAgIHZvaWQgcGFyc2VPdmVycmlkZXNJbkZpbGUoY29uc3QgY2hh ciogZmlsZU5hbWUpOwotICAgIHZvaWQgY2xlYXIoKSB7IG1fZW50cmllcy5jbGVhcigpOyB9Cisg ICAgdm9pZCBwYXJzZU92ZXJyaWRlc0luRmlsZShjb25zdCBBYnN0cmFjdExvY2tlciYsIGNvbnN0 IGNoYXIqIGZpbGVOYW1lKTsKKyAgICB2b2lkIGNsZWFyKGNvbnN0IEFic3RyYWN0TG9ja2VyJikg eyBtX2VudHJpZXMuY2xlYXIoKTsgfQogCiAgICAgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4gbV9l bnRyaWVzOworICAgIExvY2sgbV9sb2NrOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==