201477 2019-09-04 16:07:04 -0700 Replace defaultCustomPasteboardDataEnabled by an equivalent macro 2019-09-04 19:12:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1567900 0 rniwa 2019-09-04 16:07:04 -0700 https://trac.webkit.org/changeset/227282 introduced defaultCustomPasteboardDataEnabled() to disable the custom pasteboard data on iOS and macOS apps linked against old SDKs. However, this had a bug that the check inside WebContent would always return true. Because WebPreferences values aren't propagated from UI process to WebContent process unless there is a value change, it meant that custom pasteboard data is always enabled. Replace this function with a simple macro which always enables the custom pasteboard data on iOS and macOS. 1567901 1 378024 rniwa 2019-09-04 16:11:11 -0700 Created attachment 378024 Cleanup 1567945 2 rniwa 2019-09-04 19:11:24 -0700 Committed r249512: <https://trac.webkit.org/changeset/249512> 1567946 3 webkit-bug-importer 2019-09-04 19:12:17 -0700 <rdar://problem/55050818> 378024 2019-09-04 16:11:11 -0700 2019-09-04 17:06:01 -0700 Cleanup bug-201477-20190904161110.patch text/plain 3704 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDk1MDEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA5LTA0ICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlcGxhY2UgZGVmYXVsdEN1c3RvbVBh c3RlYm9hcmREYXRhRW5hYmxlZCBieSBhbiBlcXVpdmFsZW50IG1hY3JvCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE0NzcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjI3MjgyIGludHJvZHVjZWQgZGVm YXVsdEN1c3RvbVBhc3RlYm9hcmREYXRhRW5hYmxlZCgpIHRvIGRpc2FibGUgdGhlIGN1c3RvbSBw YXN0ZWJvYXJkIGRhdGEgb24KKyAgICAgICAgYXBwcyBsaW5rZWQgYWdhaW5zdCBvbGQgU0RLcy4g SG93ZXZlciwgdGhpcyBoYWQgYSBidWcgdGhhdCB0aGUgY2hlY2sgaW5zaWRlIFdlYkNvbnRlbnQg cHJvY2VzcworICAgICAgICB3b3VsZCBhbHdheXMgcmV0dXJuIHRydWUgYmVjYXVzZSBXZWJDb250 ZW50IHByb2Nlc3MgaXMgYWx3YXlzIGxpbmtlZCBhZ2FpbnN0IHRoZSBsYXRlc3QgU0RLcy4KKyAg ICAgICAgQmVjYXVzZSBXZWJQcmVmZXJlbmNlcyB2YWx1ZXMgYXJlbid0IHByb3BhZ2F0ZWQgZnJv bSBVSSBwcm9jZXNzIHRvIFdlYkNvbnRlbnQgcHJvY2VzcyB1bmxlc3MKKyAgICAgICAgdGhlcmUg aXMgYSB2YWx1ZSBjaGFuZ2UsIGl0IG1lYW50IHRoYXQgY3VzdG9tIHBhc3RlYm9hcmQgZGF0YSBp cyBhbHdheXMgZW5hYmxlZC4KKworICAgICAgICBUaGlzIHBhdGNoIHJlcGxhY2VzIHRoaXMgZnVu Y3Rpb24gd2l0aCBhIHNpbXBsZSBtYWNybyB3aGljaCBhbHdheXMgZW5hYmxlcyB0aGUgY3VzdG9t IHBhc3RlYm9hcmQKKyAgICAgICAgZGF0YSBvbiBpT1MgZmFtaWx5IGFuZCBtYWNPUyBhcyBpdCBo YXMgYWx3YXlzIGJlZW4gdGhlIGNhc2UgYmVmb3JlIGFuZCBhZnRlciByMjI3MjgyLgorCisgICAg ICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWw6CisgICAgICAgICogU2hhcmVkL1dlYlBy ZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmRlZmF1bHRDdXN0 b21QYXN0ZWJvYXJkRGF0YUVuYWJsZWQpOiBEZWxldGVkLgorICAgICAgICAqIFNoYXJlZC9XZWJQ cmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaDoKKwogMjAxOS0wOS0wNCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSBXZWJQYWdlUHJveHkgaWRlbnRpZmll ciB0byB0aGUgTmV0d29yayBQcm9jZXNzCkluZGV4OiBTb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQ cmVmZXJlbmNlcy55YW1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzLnlhbWwJKHJldmlzaW9uIDI0OTUwMCkKKysrIFNvdXJjZS9XZWJLaXQvU2hhcmVk L1dlYlByZWZlcmVuY2VzLnlhbWwJKHdvcmtpbmcgY29weSkKQEAgLTg0Niw3ICs4NDYsNyBAQCBE YXRhVHJhbnNmZXJJdGVtc0VuYWJsZWQ6CiAKIEN1c3RvbVBhc3RlYm9hcmREYXRhRW5hYmxlZDoK ICAgdHlwZTogYm9vbAotICBkZWZhdWx0VmFsdWU6IGRlZmF1bHRDdXN0b21QYXN0ZWJvYXJkRGF0 YUVuYWJsZWQoKQorICBkZWZhdWx0VmFsdWU6IERFRkFVTFRfQ1VTVE9NX1BBU1RFQk9BUkRfREFU QV9FTkFCTEVECiAgIGh1bWFuUmVhZGFibGVOYW1lOiAiQ3VzdG9tIHBhc3RlYm9hcmQgZGF0YSIK ICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5hYmxlIGN1c3RvbSBjbGlwYm9hcmQgdHlw ZXMgYW5kIGJldHRlciBzZWN1cml0eSBtb2RlbCBmb3IgY2xpcGJvYXJkIEFQSS4iCiAgIHdlYmNv cmVCaW5kaW5nOiBSdW50aW1lRW5hYmxlZEZlYXR1cmVzCkluZGV4OiBTb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5jcHAJKHJldmlzaW9u IDI0OTUwMCkKKysrIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZh bHVlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDE5ICs0Niw2IEBAIGJvb2wgZGVmYXVsdFBh c3NpdmVUb3VjaExpc3RlbmVyc0FzRGVmYXUKICNlbmRpZgogfQogCi1ib29sIGRlZmF1bHRDdXN0 b21QYXN0ZWJvYXJkRGF0YUVuYWJsZWQoKQotewotI2lmIFBMQVRGT1JNKE1BQ0NBVEFMWVNUKQot ICAgIHJldHVybiB0cnVlOwotI2VsaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICByZXR1cm4g V2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzTW9iaWxlU2FmYXJpKCkgfHwgZHlsZF9nZXRfcHJv Z3JhbV9zZGtfdmVyc2lvbigpID49IERZTERfSU9TX1ZFUlNJT05fMTFfMzsKLSNlbGlmIFBMQVRG T1JNKE1BQykKLSAgICByZXR1cm4gV2ViQ29yZTo6TWFjQXBwbGljYXRpb246OmlzU2FmYXJpKCkg fHwgZHlsZF9nZXRfcHJvZ3JhbV9zZGtfdmVyc2lvbigpID4gRFlMRF9NQUNPU1hfVkVSU0lPTl8x MF8xMzsKLSNlbHNlCi0gICAgcmV0dXJuIGZhbHNlOwotI2VuZGlmCi19Ci0KIGJvb2wgZGVmYXVs dENTU09NVmlld1Njcm9sbGluZ0FQSUVuYWJsZWQoKQogewogI2lmIFBMQVRGT1JNKElPU19GQU1J TFkpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1 ZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0Rl ZmF1bHRWYWx1ZXMuaAkocmV2aXNpb24gMjQ5NTAwKQorKysgU291cmNlL1dlYktpdC9TaGFyZWQv V2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI1MCw2ICsy NTAsMTIgQEAKICNkZWZpbmUgREVGQVVMVF9EQVRBTElTVF9FTEVNRU5UX0VOQUJMRUQgdHJ1ZQog I2VuZGlmCiAKKyNpZiBQTEFURk9STShDT0NPQSkKKyNkZWZpbmUgREVGQVVMVF9DVVNUT01fUEFT VEVCT0FSRF9EQVRBX0VOQUJMRUQgdHJ1ZQorI2Vsc2UKKyNkZWZpbmUgREVGQVVMVF9DVVNUT01f UEFTVEVCT0FSRF9EQVRBX0VOQUJMRUQgZmFsc2UKKyNlbmRpZgorCiAjaWYgUExBVEZPUk0oSU9T KQogI2RlZmluZSBERUZBVUxUX0RPTV9QQVNURV9BQ0NFU1NfUkVRVUVTVFNfRU5BQkxFRCB0cnVl CiAjZWxzZQpAQCAtMjczLDcgKzI3OSw2IEBACiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogYm9vbCBk ZWZhdWx0UGFzc2l2ZVRvdWNoTGlzdGVuZXJzQXNEZWZhdWx0T25Eb2N1bWVudCgpOwotYm9vbCBk ZWZhdWx0Q3VzdG9tUGFzdGVib2FyZERhdGFFbmFibGVkKCk7CiBib29sIGRlZmF1bHRDU1NPTVZp ZXdTY3JvbGxpbmdBUElFbmFibGVkKCk7CiAKICNpZiBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKQo=