201476 2019-09-04 16:01:56 -0700 Fix implicit conversion that loses precision 2019-09-06 10:16:49 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen commit-queue webkit-bug-importer youennf oldest_to_newest 1567897 0 krollin 2019-09-04 16:01:56 -0700 Building for watchOS results in the following error: .../Source/WebCore/fileapi/NetworkSendQueue.cpp:66:42: error: implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int' [-Werror,-Wshorten-64-to-32] enqueue(JSC::ArrayBuffer::create(byteLength, 1), 0, 0); Fix this with an ASSERT(isInBounds()) and a static_cast. 1567898 1 webkit-bug-importer 2019-09-04 16:02:09 -0700 <rdar://problem/55043129> 1567899 2 378023 krollin 2019-09-04 16:05:49 -0700 Created attachment 378023 Patch 1567938 3 378023 achristensen 2019-09-04 18:39:39 -0700 Comment on attachment 378023 Patch WebKit style prefers "unsigned" over "unsigned int" I think it would look nicer if we instead changed the line before this: unsigned byteLength = blob.size(); 1568012 4 378023 youennf 2019-09-04 23:04:02 -0700 Comment on attachment 378023 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378023&action=review > Source/WebCore/fileapi/NetworkSendQueue.cpp:68 > + enqueue(JSC::ArrayBuffer::create(static_cast<unsigned int>(byteLength), 1), 0, 0); The ASSERT is unneeded, since byteLength is equal to 0. We could write it as: enqueue(JSC::ArrayBuffer::create(0, 1), 0, 0); But then the compiler will not know which ArrayBuffer::create to use. I guess typing 0 as unsigned will make things clearer. 1568081 5 krollin 2019-09-05 02:43:08 -0700 Youenn, I think you're saying to use the following? JSC::ArrayBuffer::create(0U, 1) I'm taking this route rather than Alex's suggestion, since his will still require a static_cast<>() at the point where byteLength is assigned. I also removed the ASSERT(). 1568082 6 378070 krollin 2019-09-05 02:44:02 -0700 Created attachment 378070 Patch 1568093 7 378070 commit-queue 2019-09-05 03:53:42 -0700 Comment on attachment 378070 Patch Clearing flags on attachment: 378070 Committed r249527: <https://trac.webkit.org/changeset/249527> 1568094 8 commit-queue 2019-09-05 03:53:43 -0700 All reviewed patches have been landed. Closing bug. 1568569 9 378070 achristensen 2019-09-06 10:16:49 -0700 Comment on attachment 378070 Patch Wow, this change is much better. 378023 2019-09-04 16:05:49 -0700 2019-09-05 02:44:00 -0700 Patch bug-201476-20190904160548.patch text/plain 2054 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBhM2Y3OTcyOTUzOWEz YjY5NWZlOGZjNTIyYjgxOThjODk0MGQ3Mi4uNjVjMTM4N2Y2OTA4ZmI2Y2E4ZjhmZDZlNDI5MmI3 YjViZGMxNTdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA5LTA0ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW1wbGljaXQgY29u dmVyc2lvbiB0aGF0IGxvc2VzIHByZWNpc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNDc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTA0 MzEyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dWlsZGluZyBmb3Igd2F0Y2hPUyByZXN1bHRzIGluIHRoZSBmb2xsb3dpbmcgZXJyb3I6CisKKyAg ICAgICAgLi4uL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvTmV0d29ya1NlbmRRdWV1ZS5jcHA6NjY6 NDI6IGVycm9yOiBpbXBsaWNpdCBjb252ZXJzaW9uIGxvc2VzIGludGVnZXIgcHJlY2lzaW9uOiAn dW5zaWduZWQgbG9uZyBsb25nJyB0byAndW5zaWduZWQgaW50JyBbLVdlcnJvciwtV3Nob3J0ZW4t NjQtdG8tMzJdCisgICAgICAgICAgICAgICAgZW5xdWV1ZShKU0M6OkFycmF5QnVmZmVyOjpjcmVh dGUoYnl0ZUxlbmd0aCwgMSksIDAsIDApOworCisgICAgICAgIEZpeCB0aGlzIHdpdGggYW4gQVNT RVJUKGlzSW5Cb3VuZHMoKSkgYW5kIGEgc3RhdGljX2Nhc3QuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIC0tIG5vIG5ldyBvciBjaGFuZ2VkIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBmaWxl YXBpL05ldHdvcmtTZW5kUXVldWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya1NlbmRR dWV1ZTo6ZW5xdWV1ZSk6CisKIDIwMTktMDktMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIFNQSSB0aGF0IGFjY2Vz c2VzIE1lbW9yeUNhY2hlIGRpcmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9maWxl YXBpL05ldHdvcmtTZW5kUXVldWUuY3BwIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9OZXR3b3Jr U2VuZFF1ZXVlLmNwcAppbmRleCA3OWJlYzU4NzAwNzA3ZTg5OWJhMmYyZTE2MTAwZDk5ZTYyMTI5 MmY1Li4xMDFlYjhiNmI0ZWZlNDBkZjIwZTFkOGVjMDE3MGVhYTg4MWJlZWRlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL05ldHdvcmtTZW5kUXVldWUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2ZpbGVhcGkvTmV0d29ya1NlbmRRdWV1ZS5jcHAKQEAgLTI3LDYgKzI3LDcgQEAK ICNpbmNsdWRlICJOZXR3b3JrU2VuZFF1ZXVlLmgiCiAKICNpbmNsdWRlICJCbG9iTG9hZGVyLmgi CisjaW5jbHVkZSA8d3RmL0NoZWNrZWRBcml0aG1ldGljLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIApAQCAtNjMsNyArNjQsOCBAQCB2b2lkIE5ldHdvcmtTZW5kUXVldWU6OmVucXVldWUoV2Vi Q29yZTo6QmxvYiYgYmxvYikKIHsKICAgICBhdXRvIGJ5dGVMZW5ndGggPSBibG9iLnNpemUoKTsK ICAgICBpZiAoIWJ5dGVMZW5ndGgpIHsKLSAgICAgICAgZW5xdWV1ZShKU0M6OkFycmF5QnVmZmVy OjpjcmVhdGUoYnl0ZUxlbmd0aCwgMSksIDAsIDApOworICAgICAgICBBU1NFUlQoV1RGOjppc0lu Qm91bmRzPHVuc2lnbmVkIGludD4oYnl0ZUxlbmd0aCkpOworICAgICAgICBlbnF1ZXVlKEpTQzo6 QXJyYXlCdWZmZXI6OmNyZWF0ZShzdGF0aWNfY2FzdDx1bnNpZ25lZCBpbnQ+KGJ5dGVMZW5ndGgp LCAxKSwgMCwgMCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgbV9xdWV1ZS5hcHBlbmQo bWFrZVVuaXF1ZVJlZjxCbG9iTG9hZGVyPihtX2RvY3VtZW50LmdldCgpLCBibG9iLCBbdGhpc10g ewo= 378070 2019-09-05 02:44:02 -0700 2019-09-05 03:53:42 -0700 Patch bug-201476-20190905024401.patch text/plain 2084 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWYxMzQ3MGVlYjk3Yzg3 YzkyOTAxNWZhNDNjYjcyMTBjYjExNmU5Zi4uNDMwZTUxYjI4NTk1NGIxNDg2OTdjNmRmMGExYjk3 MzBhNDJmYmM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA5LTA1ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW1wbGljaXQgY29u dmVyc2lvbiB0aGF0IGxvc2VzIHByZWNpc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNDc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTA0 MzEyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LCBBbGV4IENocmlzdGVu c2VuLgorCisgICAgICAgIEJ1aWxkaW5nIGZvciB3YXRjaE9TIHJlc3VsdHMgaW4gdGhlIGZvbGxv d2luZyBlcnJvcjoKKworICAgICAgICAgICAgLi4uL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvTmV0 d29ya1NlbmRRdWV1ZS5jcHA6NjY6NDI6IGVycm9yOiBpbXBsaWNpdCBjb252ZXJzaW9uIGxvc2Vz IGludGVnZXIgcHJlY2lzaW9uOiAndW5zaWduZWQgbG9uZyBsb25nJyB0byAndW5zaWduZWQgaW50 JyBbLVdlcnJvciwtV3Nob3J0ZW4tNjQtdG8tMzJdCisgICAgICAgICAgICAgICAgICAgIGVucXVl dWUoSlNDOjpBcnJheUJ1ZmZlcjo6Y3JlYXRlKGJ5dGVMZW5ndGgsIDEpLCAwLCAwKTsKKworICAg ICAgICBGaXggdGhpcyBieSByZXBsYWNpbmcgYnl0ZUxlbmd0aCAod2hpY2ggaXMga25vd24gdG8g YmUgemVybyBhdCB0aGlzCisgICAgICAgIHBvaW50KSB3aXRoIDBVLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyAtLSBubyBuZXcgb3IgY2hhbmdlZCBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICog ZmlsZWFwaS9OZXR3b3JrU2VuZFF1ZXVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtT ZW5kUXVldWU6OmVucXVldWUpOgorCiAyMDE5LTA5LTA0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9u b3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5dW0NsYW5nXSBJbnNwZWN0b3JOZXR3 b3JrQWdlbnQuY3BwKDExMjIsMjApOiBlcnJvcjogY2Fubm90IGRlY29tcG9zZSB0aGlzIHR5cGU7 ICdzdGQ6OnR1cGxlX3NpemU8Y29uc3QgV1RGOjpLZXlWYWx1ZVBhaXI8V1RGOjpTdHJpbmcsIFdU Rjo6UmVmUHRyPFdURjo6SlNPTkltcGw6OlZhbHVlLCBXVEY6OkR1bWJQdHJUcmFpdHM8V1RGOjpK U09OSW1wbDo6VmFsdWU+ID4gPj46OnZhbHVlJyBpcyBub3QgYSB2YWxpZCBpbnRlZ3JhbCBjb25z dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9OZXR3b3JrU2VuZFF1ZXVlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvTmV0d29ya1NlbmRRdWV1ZS5jcHAKaW5kZXggNzli ZWM1ODcwMDcwN2U4OTliYTJmMmUxNjEwMGQ5OWU2MjEyOTJmNS4uZGI3MTIxOTkyN2Y3NTdjYTU4 YjkyNzQ3YmVmYzMyNzE2NjA1MDQ3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmlsZWFw aS9OZXR3b3JrU2VuZFF1ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL05ldHdv cmtTZW5kUXVldWUuY3BwCkBAIC02Myw3ICs2Myw3IEBAIHZvaWQgTmV0d29ya1NlbmRRdWV1ZTo6 ZW5xdWV1ZShXZWJDb3JlOjpCbG9iJiBibG9iKQogewogICAgIGF1dG8gYnl0ZUxlbmd0aCA9IGJs b2Iuc2l6ZSgpOwogICAgIGlmICghYnl0ZUxlbmd0aCkgewotICAgICAgICBlbnF1ZXVlKEpTQzo6 QXJyYXlCdWZmZXI6OmNyZWF0ZShieXRlTGVuZ3RoLCAxKSwgMCwgMCk7CisgICAgICAgIGVucXVl dWUoSlNDOjpBcnJheUJ1ZmZlcjo6Y3JlYXRlKDBVLCAxKSwgMCwgMCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAgICAgbV9xdWV1ZS5hcHBlbmQobWFrZVVuaXF1ZVJlZjxCbG9iTG9hZGVyPiht X2RvY3VtZW50LmdldCgpLCBibG9iLCBbdGhpc10gewo=